<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23024] trunk/launchd/src/launchd_core_logic.c</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.macosforge.org/projects/launchd/changeset/23024">23024</a></dd>
<dt>Author</dt> <dd>zarzycki@apple.com</dd>
<dt>Date</dt> <dd>2007-01-26 15:45:13 -0800 (Fri, 26 Jan 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>PIDs shouldn't be running around without user records to back the UIDs assigned to the process.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunklaunchdsrclaunchd_core_logicc">trunk/launchd/src/launchd_core_logic.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunklaunchdsrclaunchd_core_logicc"></a>
<div class="modfile"><h4>Modified: trunk/launchd/src/launchd_core_logic.c (23023 => 23024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/launchd/src/launchd_core_logic.c 2007-01-25 21:46:03 UTC (rev 23023)
+++ trunk/launchd/src/launchd_core_logic.c 2007-01-26 23:45:13 UTC (rev 23024)
</span><span class="lines">@@ -404,7 +404,7 @@
</span><span class="cx"> job_stop(job_t j)
</span><span class="cx"> {
</span><span class="cx"> if (j->p) {
</span><del>- kill(j->p, SIGTERM);
</del><ins>+ job_assumes(j, kill(j->p, SIGTERM) != -1);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1975,13 +1975,17 @@
</span><span class="cx"> uid_t i_euid = kp[i].kp_eproc.e_ucred.cr_uid;
</span><span class="cx"> uid_t i_uid = kp[i].kp_eproc.e_pcred.p_ruid;
</span><span class="cx"> uid_t i_svuid = kp[i].kp_eproc.e_pcred.p_svuid;
</span><ins>+ pid_t i_pid = kp[i].kp_proc.p_pid;
</ins><span class="cx">
</span><span class="cx"> if (i_euid != u && i_uid != u && i_svuid != u) {
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> job_log(j, LOG_ERR, "PID %u \"%s\" has no account to back it! Real/effective/saved UIDs: %u/%u/%u",
</span><del>- kp[i].kp_proc.p_pid, kp[i].kp_proc.p_comm, i_uid, i_euid, i_svuid);
</del><ins>+ i_pid, kp[i].kp_proc.p_comm, i_uid, i_euid, i_svuid);
+
+ /* Ask the accountless process to exit. */
+ job_assumes(j, kill(i_pid, SIGTERM) != -1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> out:
</span></span></pre>
</div>
</div>
</body>
</html>