
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--

#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }

#msg ul, pre { overflow: auto; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<title>[23273] trunk/launchd/src/launchctl.c</title>

</head>

<body>


<div id="msg">

<dl>

<dt>Revision</dt> <dd><a href="http://trac.macosforge.org/projects/launchd/changeset/23273">23273</a></dd>

<dt>Author</dt> <dd>zarzycki@apple.com</dd>

<dt>Date</dt> <dd>2007-06-06 09:04:51 -0700 (Wed, 06 Jun 2007)</dd>

</dl>


<h3>Log Message</h3>

<pre>&lt;rdar://problem/5253449&gt; launchctl:do_sysversion_sysctl() does not have any safety checks</pre>


<h3>Modified Paths</h3>

<ul>

<li><a href="#trunklaunchdsrclaunchctlc">trunk/launchd/src/launchctl.c</a></li>

</ul>


</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunklaunchdsrclaunchctlc"></a>

<div class="modfile"><h4>Modified: trunk/launchd/src/launchctl.c (23272 => 23273)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/launchd/src/launchctl.c        2007-06-04 18:26:07 UTC (rev 23272)

+++ trunk/launchd/src/launchctl.c        2007-06-06 16:04:51 UTC (rev 23273)

</span><span class="lines">@@ -2887,12 +2887,14 @@

</span><span class="cx">                 return;

</span><span class="cx">         }

</span><span class="cx"> 

</span><del>-        versdict = _CFCopySystemVersionDictionary();

-        buildvers = CFDictionaryGetValue(versdict, _kCFSystemVersionBuildVersionKey);

-        CFStringGetCString(buildvers, buf, sizeof(buf), kCFStringEncodingUTF8);

</del><ins>+        if (!assumes((versdict = _CFCopySystemVersionDictionary()))) {

+                return;

+        }

</ins><span class="cx"> 

</span><del>-        if (sysctl(mib, 2, NULL, 0, buf, strlen(buf) + 1) == -1) {

-                fprintf(stderr, &quot;sysctl(): %s\n&quot;, strerror(errno));

</del><ins>+        if (assumes((buildvers = CFDictionaryGetValue(versdict, _kCFSystemVersionBuildVersionKey)))) {

+                CFStringGetCString(buildvers, buf, sizeof(buf), kCFStringEncodingUTF8);

+

+                assumes(sysctl(mib, 2, NULL, 0, buf, strlen(buf) + 1) != -1);

</ins><span class="cx">         }

</span><span class="cx"> 

</span><span class="cx">         CFRelease(versdict);

</span></span></pre>

</div>

</div>


</body>

</html>