<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23559] trunk/launchd/src/launchproxy.c</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.macosforge.org/projects/launchd/changeset/23559">23559</a></dd>
<dt>Author</dt> <dd>zarzycki@apple.com</dd>
<dt>Date</dt> <dd>2008-03-19 13:36:52 -0700 (Wed, 19 Mar 2008)</dd>
</dl>
<h3>Log Message</h3>
<pre>getnameinfo() only supports IPv4 and IPv6 right now.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunklaunchdsrclaunchproxyc">trunk/launchd/src/launchproxy.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunklaunchdsrclaunchproxyc"></a>
<div class="modfile"><h4>Modified: trunk/launchd/src/launchproxy.c (23558 => 23559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/launchd/src/launchproxy.c 2008-03-18 21:32:54 UTC (rev 23558)
+++ trunk/launchd/src/launchproxy.c 2008-03-19 20:36:52 UTC (rev 23559)
</span><span class="lines">@@ -159,19 +159,23 @@
</span><span class="cx"> syslog(LOG_DEBUG, "accept(): %m");
</span><span class="cx"> goto out;
</span><span class="cx"> } else {
</span><del>- char fromhost[NI_MAXHOST];
- char fromport[NI_MAXSERV];
- int gni_r;
</del><ins>+ if (ss.ss_family == AF_INET || ss.ss_family == AF_INET6) {
+ char fromhost[NI_MAXHOST];
+ char fromport[NI_MAXSERV];
+ int gni_r;
</ins><span class="cx">
</span><del>- gni_r = getnameinfo((struct sockaddr *)&ss, slen,
- fromhost, sizeof(fromhost),
- fromport, sizeof(fromport),
- NI_NUMERICHOST | NI_NUMERICSERV);
</del><ins>+ gni_r = getnameinfo((struct sockaddr *)&ss, slen,
+ fromhost, sizeof(fromhost),
+ fromport, sizeof(fromport),
+ NI_NUMERICHOST | NI_NUMERICSERV);
</ins><span class="cx">
</span><del>- if (gni_r) {
- syslog(LOG_WARNING, "%s: getnameinfo(): %s", prog, gai_strerror(gni_r));
</del><ins>+ if (gni_r) {
+ syslog(LOG_WARNING, "%s: getnameinfo(): %s", prog, gai_strerror(gni_r));
+ } else {
+ syslog(LOG_INFO, "%s: Connection from: %s on port: %s", prog, fromhost, fromport);
+ }
</ins><span class="cx"> } else {
</span><del>- syslog(LOG_INFO, "%s: Connection from: %s on port: %s", prog, fromhost, fromport);
</del><ins>+ syslog(LOG_WARNING, "%s: getnameinfo() only supports IPv4/IPv6. Connection from address family: %u", prog, ss.ss_family);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> switch (fork()) {
</span></span></pre>
</div>
</div>
</body>
</html>