<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23620] trunk/launchd/src/launchd_core_logic.c</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.macosforge.org/projects/launchd/changeset/23620">23620</a></dd>
<dt>Author</dt> <dd>zarzycki@apple.com</dd>
<dt>Date</dt> <dd>2008-05-05 13:23:42 -0700 (Mon, 05 May 2008)</dd>
</dl>
<h3>Log Message</h3>
<pre><rdar://problem/5804075> launchd fork/exec log message is incorrect</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunklaunchdsrclaunchd_core_logicc">trunk/launchd/src/launchd_core_logic.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunklaunchdsrclaunchd_core_logicc"></a>
<div class="modfile"><h4>Modified: trunk/launchd/src/launchd_core_logic.c (23619 => 23620)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/launchd/src/launchd_core_logic.c 2008-05-02 23:19:42 UTC (rev 23619)
+++ trunk/launchd/src/launchd_core_logic.c 2008-05-05 20:23:42 UTC (rev 23620)
</span><span class="lines">@@ -475,7 +475,7 @@
</span><span class="cx"> static void job_callback_timer(job_t j, void *ident);
</span><span class="cx"> static void job_callback_read(job_t j, int ident);
</span><span class="cx"> static void job_log_stray_pg(job_t j);
</span><del>-static void job_log_chidren_without_exec(job_t j);
</del><ins>+static void job_log_children_without_exec(job_t j);
</ins><span class="cx"> static job_t job_new_anonymous(jobmgr_t jm, pid_t anonpid) __attribute__((malloc, nonnull, warn_unused_result));
</span><span class="cx"> static job_t job_new(jobmgr_t jm, const char *label, const char *prog, const char *const *argv) __attribute__((malloc, nonnull(1,2), warn_unused_result));
</span><span class="cx"> static job_t job_new_via_mach_init(job_t j, const char *cmd, uid_t uid, bool ond) __attribute__((malloc, nonnull, warn_unused_result));
</span><span class="lines">@@ -2564,7 +2564,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void
</span><del>-job_log_chidren_without_exec(job_t j)
</del><ins>+job_log_children_without_exec(job_t j)
</ins><span class="cx"> {
</span><span class="cx"> /* <rdar://problem/5701343> ER: Add a KERN_PROC_PPID sysctl */
</span><span class="cx"> #ifdef KERN_PROC_PPID
</span><span class="lines">@@ -2599,7 +2599,7 @@
</span><span class="cx"> continue;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- job_log(j, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn(). Child PID %u",
</del><ins>+ job_log(j, LOG_APPLEONLY, "Called *fork(). Please switch to posix_spawn*(), pthreads or launchd. Child PID %u",
</ins><span class="cx"> kp[i].kp_proc.p_pid);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2641,7 +2641,7 @@
</span><span class="cx">
</span><span class="cx"> if (fflags & NOTE_FORK) {
</span><span class="cx"> job_log(j, LOG_DEBUG, "fork()ed%s", program_changed ? ". For this message only: We don't know whether this event happened before or after execve()." : "");
</span><del>- job_log_chidren_without_exec(j);
</del><ins>+ job_log_children_without_exec(j);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (fflags & NOTE_EXIT) {
</span></span></pre>
</div>
</div>
</body>
</html>