<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[19926] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/19926">19926</a></dd>
<dt>Author</dt> <dd>ap</dd>
<dt>Date</dt> <dd>2007-03-01 09:08:24 -0800 (Thu, 01 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=12801
Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
Test: editing/pasteboard/createMarkup-assert.xml
* editing/markup.cpp:
(WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreeditingmarkupcpp">trunk/WebCore/editing/markup.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingpasteboardcreateMarkupassertexpectedtxt">trunk/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingpasteboardcreateMarkupassertxml">trunk/LayoutTests/editing/pasteboard/createMarkup-assert.xml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (19925 => 19926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-03-01 07:43:27 UTC (rev 19925)
+++ trunk/LayoutTests/ChangeLog 2007-03-01 17:08:24 UTC (rev 19926)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2007-03-01 Mitz Pettel <mitz@webkit.org>
+
+ Reviewed by Maciej.
+
+ - test for http://bugs.webkit.org/show_bug.cgi?id=12801
+ Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
+
+ * editing/pasteboard/createMarkup-assert-expected.txt: Added.
+ * editing/pasteboard/createMarkup-assert.xml: Added.
+
</ins><span class="cx"> 2007-02-28 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Bradeee Eidson.
</span></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcreateMarkupassertexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt (0 => 19926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt 2007-03-01 17:08:24 UTC (rev 19926)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+Test for <http://bugs.webkit.org/show_bug.cgi?id=12801> Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document.
</ins><span class="cx">Property changes on: trunk/LayoutTests/editing/pasteboard/createMarkup-assert-expected.txt
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + text/plain
</span><span class="cx">Name: svn:eol-style
</span><span class="cx"> + native
</span></span></pre></div>
<a id="trunkLayoutTestseditingpasteboardcreateMarkupassertxml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/pasteboard/createMarkup-assert.xml (0 => 19926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/pasteboard/createMarkup-assert.xml (rev 0)
+++ trunk/LayoutTests/editing/pasteboard/createMarkup-assert.xml 2007-03-01 17:08:24 UTC (rev 19926)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<root>
+<text>Test for &lt;http://bugs.webkit.org/show_bug.cgi?id=12801> Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document.</text>
+<script xmlns="http://www.w3.org/1999/xhtml" type="text/javascript">
+ if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+
+ document.execCommand("selectall");
+ document.execCommand("copy");
+</script>
+</root>
</ins><span class="cx">Property changes on: trunk/LayoutTests/editing/pasteboard/createMarkup-assert.xml
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + text/xml
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (19925 => 19926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-03-01 07:43:27 UTC (rev 19925)
+++ trunk/WebCore/ChangeLog 2007-03-01 17:08:24 UTC (rev 19926)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-03-01 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Maciej.
+
+ http://bugs.webkit.org/show_bug.cgi?id=12801
+ Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document
+
+ Test: editing/pasteboard/createMarkup-assert.xml
+
+ * editing/markup.cpp:
+ (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.
+
</ins><span class="cx"> 2007-02-28 Adam Roben <aroben@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Oliver and Hyatt.
</span></span></pre></div>
<a id="trunkWebCoreeditingmarkupcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/editing/markup.cpp (19925 => 19926)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/editing/markup.cpp 2007-03-01 07:43:27 UTC (rev 19925)
+++ trunk/WebCore/editing/markup.cpp 2007-03-01 17:08:24 UTC (rev 19926)
</span><span class="lines">@@ -394,7 +394,6 @@
</span><span class="cx"> root = range->startPosition().node();
</span><span class="cx"> while (root && !root->hasTagName(bodyTag))
</span><span class="cx"> root = root->parentNode();
</span><del>- ASSERT(root);
</del><span class="cx"> if (!root)
</span><span class="cx"> root = doc->documentElement();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>