<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[19941] trunk/WebCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/19941">19941</a></dd>
<dt>Author</dt> <dd>antti</dd>
<dt>Date</dt> <dd>2007-03-02 00:22:45 -0800 (Fri, 02 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Maciej.
Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
REGRESSION: imagemap: pointer cursor is shown everywhere
<rdar://problem/5028163>
Image with imagemap should never itself be URLElement in hit test results.
No layout test, cursor state can't be captured.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorerenderingRenderLayercpp">trunk/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (19940 => 19941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-03-02 07:59:15 UTC (rev 19940)
+++ trunk/WebCore/ChangeLog 2007-03-02 08:22:45 UTC (rev 19941)
</span><span class="lines">@@ -1,6 +1,21 @@
</span><span class="cx"> 2007-03-01 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Maciej.
</span><ins>+
+ Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
+ REGRESSION: imagemap: pointer cursor is shown everywhere
+ <rdar://problem/5028163>
+
+ Image with imagemap should never itself be URLElement in hit test results.
+
+ No layout test, cursor state can't be captured.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::hitTest):
+
+2007-03-01 Antti Koivisto <antti@apple.com>
+
+ Reviewed by Maciej.
</ins><span class="cx">
</span><span class="cx"> Fix http://bugs.webkit.org/show_bug.cgi?id=12690
</span><span class="cx"> REGRESSION: can not log in to bank of america with TOT webkit
</span></span></pre></div>
<a id="trunkWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/RenderLayer.cpp (19940 => 19941)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/RenderLayer.cpp 2007-03-02 07:59:15 UTC (rev 19940)
+++ trunk/WebCore/rendering/RenderLayer.cpp 2007-03-02 08:22:45 UTC (rev 19941)
</span><span class="lines">@@ -1528,7 +1528,8 @@
</span><span class="cx"> // it already set URLElement and only use the innermost.
</span><span class="cx"> Node* node = result.innerNode();
</span><span class="cx"> while (node) {
</span><del>- if (node->isLink() && !result.URLElement())
</del><ins>+ // for imagemaps, URLElement is the associated area element not the image itself
+ if (node->isLink() && !result.URLElement() && !node->hasTagName(imgTag))
</ins><span class="cx"> result.setURLElement(static_cast<Element*>(node));
</span><span class="cx"> node = node->parentNode();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>