<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[19960] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/19960">19960</a></dd>
<dt>Author</dt> <dd>rwlbuis</dd>
<dt>Date</dt> <dd>2007-03-05 01:07:41 -0800 (Mon, 05 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12868
parts of the CSS classes in this simple SVG example are not applied
Make sure the xml stylesheets are parsed in strict mode.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoredomProcessingInstructioncpp">trunk/WebCore/dom/ProcessingInstruction.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgcustomxmlstylesheetexpectedchecksum">trunk/LayoutTests/svg/custom/xml-stylesheet-expected.checksum</a></li>
<li><a href="#trunkLayoutTestssvgcustomxmlstylesheetexpectedpng">trunk/LayoutTests/svg/custom/xml-stylesheet-expected.png</a></li>
<li><a href="#trunkLayoutTestssvgcustomxmlstylesheetexpectedtxt">trunk/LayoutTests/svg/custom/xml-stylesheet-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgcustomxmlstylesheetcss">trunk/LayoutTests/svg/custom/xml-stylesheet.css</a></li>
<li><a href="#trunkLayoutTestssvgcustomxmlstylesheetsvg">trunk/LayoutTests/svg/custom/xml-stylesheet.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (19959 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-03-05 06:18:37 UTC (rev 19959)
+++ trunk/LayoutTests/ChangeLog 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2007-03-05 Rob Buis <buis@kde.org>
+
+ Reviewed by Darin.
+
+ Add test for:
+ http://bugs.webkit.org/show_bug.cgi?id=12868
+ parts of the CSS classes in this simple SVG example are not applied
+
+ * svg/custom/xml-stylesheet-expected.checksum: Added.
+ * svg/custom/xml-stylesheet-expected.png: Added.
+ * svg/custom/xml-stylesheet-expected.txt: Added.
+ * svg/custom/xml-stylesheet.css: Added.
+ * svg/custom/xml-stylesheet.svg: Added.
+
</ins><span class="cx"> 2007-03-04 Alexey Proskuryakov <ap@webkit.org>
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin.
</span></span></pre></div>
<a id="trunkLayoutTestssvgcustomxmlstylesheetexpectedchecksum"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/xml-stylesheet-expected.checksum (0 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/xml-stylesheet-expected.checksum (rev 0)
+++ trunk/LayoutTests/svg/custom/xml-stylesheet-expected.checksum 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+76bdc02f9e5c8554aebc20f37d11fae7
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvgcustomxmlstylesheetexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/svg/custom/xml-stylesheet-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/svg/custom/xml-stylesheet-expected.png
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + application/octet-stream
</span><a id="trunkLayoutTestssvgcustomxmlstylesheetexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/xml-stylesheet-expected.txt (0 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/xml-stylesheet-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/xml-stylesheet-expected.txt 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+ RenderSVGContainer {svg} at (0,0) size 300x300
+ RenderPath {rect} at (0,0) size 300x300 [fill={[type=SOLID] [color=#008000]}] [data="M0.00,0.00L300.00,0.00L300.00,300.00L0.00,300.00"]
</ins></span></pre></div>
<a id="trunkLayoutTestssvgcustomxmlstylesheetcss"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/xml-stylesheet.css (0 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/xml-stylesheet.css (rev 0)
+++ trunk/LayoutTests/svg/custom/xml-stylesheet.css 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+.svgClass { fill: green; }
</ins></span></pre></div>
<a id="trunkLayoutTestssvgcustomxmlstylesheetsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/xml-stylesheet.svg (0 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/xml-stylesheet.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/xml-stylesheet.svg 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -0,0 +1,6 @@
</span><ins>+<?xml version="1.0" encoding="UTF-8"?>
+<?xml-stylesheet href="xml-stylesheet.css" type="text/css"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" [ ]>
+<svg xmlns="http://www.w3.org/2000/svg">
+<rect fill="red" x="0" y="0" width="300" height="300" class="svgClass"/>
+</svg>
</ins></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (19959 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-03-05 06:18:37 UTC (rev 19959)
+++ trunk/WebCore/ChangeLog 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-03-05 Rob Buis <buis@kde.org>
+
+ Reviewed by Darin.
+
+ http://bugs.webkit.org/show_bug.cgi?id=12868
+ parts of the CSS classes in this simple SVG example are not applied
+
+ Make sure the xml stylesheets are parsed in strict mode.
+
+ * dom/ProcessingInstruction.cpp:
+ (WebCore::ProcessingInstruction::parseStyleSheet):
+
</ins><span class="cx"> 2007-03-04 Adele Peterson <adele@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin.
</span></span></pre></div>
<a id="trunkWebCoredomProcessingInstructioncpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/dom/ProcessingInstruction.cpp (19959 => 19960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/dom/ProcessingInstruction.cpp 2007-03-05 06:18:37 UTC (rev 19959)
+++ trunk/WebCore/dom/ProcessingInstruction.cpp 2007-03-05 09:07:41 UTC (rev 19960)
</span><span class="lines">@@ -217,7 +217,7 @@
</span><span class="cx">
</span><span class="cx"> void ProcessingInstruction::parseStyleSheet(const String& sheet)
</span><span class="cx"> {
</span><del>- m_sheet->parseString(sheet);
</del><ins>+ m_sheet->parseString(sheet, true);
</ins><span class="cx"> if (m_cachedSheet)
</span><span class="cx"> m_cachedSheet->deref(this);
</span><span class="cx"> m_cachedSheet = 0;
</span></span></pre>
</div>
</div>
</body>
</html>