<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20024] trunk/WebKitSite</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20024">20024</a></dd>
<dt>Author</dt> <dd>beidson</dd>
<dt>Date</dt> <dd>2007-03-07 11:09:15 -0800 (Wed, 07 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Anders
Explicitly mention the prepare-Changelog step for contributing patches
* coding/contributing.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitSiteChangeLog">trunk/WebKitSite/ChangeLog</a></li>
<li><a href="#trunkWebKitSitecodingcontributinghtml">trunk/WebKitSite/coding/contributing.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitSiteChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKitSite/ChangeLog (20023 => 20024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitSite/ChangeLog 2007-03-07 19:07:40 UTC (rev 20023)
+++ trunk/WebKitSite/ChangeLog 2007-03-07 19:09:15 UTC (rev 20024)
</span><span class="lines">@@ -1,3 +1,11 @@
</span><ins>+2007-03-07 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Anders
+
+ Explicitly mention the prepare-Changelog step for contributing patches
+
+ * coding/contributing.html:
+
</ins><span class="cx"> 2007-02-25 Anders Carlsson <acarlsson@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Maciej.
</span></span></pre></div>
<a id="trunkWebKitSitecodingcontributinghtml"></a>
<div class="modfile"><h4>Modified: trunk/WebKitSite/coding/contributing.html (20023 => 20024)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitSite/coding/contributing.html 2007-03-07 19:07:40 UTC (rev 20023)
+++ trunk/WebKitSite/coding/contributing.html 2007-03-07 19:09:15 UTC (rev 20024)
</span><span class="lines">@@ -19,16 +19,19 @@
</span><span class="cx"> <p>The <tt>svn-apply</tt> and <tt>svn-unapply</tt> scripts are handy for applying patches to a tree, and rolling patches out of a tree.
</span><span class="cx"> They go beyond the capabilities of the <tt>patch</tt> tool by handling files added and removed from the repository.</p>
</span><span class="cx">
</span><ins>+<p>Before you create your patch, you should make sure it has a Changelog entry by using the <tt>prepare-Changelog</tt> script. It sets up a
+template for all of the Changelog entries you will have to fill in for your patch based on everything you've changed.</p>
+
+<p>Make sure that your patch meets the
+<a href="../coding/coding-style.html">coding style guidelines</a> and has received sufficient testing.
+Bug fixes should include a <a href="../quality/testing.html">new WebKit or JavaScriptCore test</a>.</p>
+
</ins><span class="cx"> <p>Once you have a patch file, it must be reviewed by one of the approved WebKit reviewers.
</span><span class="cx"> To request a review, attach the patch to the bug report, and mark the patch with the flag <tt>review:?</tt>. This will automatically
</span><span class="cx"> send mail to <a href="http://lists.webkit.org/mailman/listinfo/webkit-reviews">webkit-reviews@lists.webkit.org</a> on your behalf. The
</span><span class="cx"> <a href="../quality/lifecycle.html">WebKit Bug Life Cycle</a> page
</span><span class="cx"> has more information about the stages of a WebKit Bugzilla bug.</p>
</span><span class="cx">
</span><del>-<p>Make sure that your patch includes a ChangeLog entry, meets the
-<a href="../coding/coding-style.html">coding style guidelines</a>, and has received sufficient testing.
-Bug fixes should include a <a href="../quality/testing.html">new WebKit or JavaScriptCore test</a>.</p>
-
</del><span class="cx"> <p>The reviewer will typically either approve the patch (by responding with an <tt>r=me</tt> in the bug report or in e-mail
</span><span class="cx"> and marking the patch <tt>review:+</tt>)
</span><span class="cx"> or request revisions to the patch (and mark the patch <tt>review:-</tt>).
</span></span></pre>
</div>
</div>
</body>
</html>