<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20040] trunk/WebKit</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20040">20040</a></dd>
<dt>Author</dt> <dd>andersca</dd>
<dt>Date</dt> <dd>2007-03-07 17:16:19 -0800 (Wed, 07 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Darin.
Use HardRetain/HardRelease.
* WebView/WebDocumentLoaderMac.mm:
(WebDocumentLoaderMac::setDataSource):
(WebDocumentLoaderMac::attachToFrame):
(WebDocumentLoaderMac::detachFromFrame):
(WebDocumentLoaderMac::increaseLoadCount):
(WebDocumentLoaderMac::decreaseLoadCount):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitChangeLog">trunk/WebKit/ChangeLog</a></li>
<li><a href="#trunkWebKitWebViewWebDocumentLoaderMacmm">trunk/WebKit/WebView/WebDocumentLoaderMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/ChangeLog (20039 => 20040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/ChangeLog 2007-03-08 01:09:50 UTC (rev 20039)
+++ trunk/WebKit/ChangeLog 2007-03-08 01:16:19 UTC (rev 20040)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2007-03-07 Anders Carlsson <acarlsson@apple.com>
</span><span class="cx">
</span><ins>+ Reviewed by Darin.
+
+ Use HardRetain/HardRelease.
+
+ * WebView/WebDocumentLoaderMac.mm:
+ (WebDocumentLoaderMac::setDataSource):
+ (WebDocumentLoaderMac::attachToFrame):
+ (WebDocumentLoaderMac::detachFromFrame):
+ (WebDocumentLoaderMac::increaseLoadCount):
+ (WebDocumentLoaderMac::decreaseLoadCount):
+
+2007-03-07 Anders Carlsson <acarlsson@apple.com>
+
</ins><span class="cx"> Reviewed by Maciej.
</span><span class="cx">
</span><span class="cx"> <rdar://problem/4961259>
</span></span></pre></div>
<a id="trunkWebKitWebViewWebDocumentLoaderMacmm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/WebView/WebDocumentLoaderMac.mm (20039 => 20040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/WebView/WebDocumentLoaderMac.mm 2007-03-08 01:09:50 UTC (rev 20039)
+++ trunk/WebKit/WebView/WebDocumentLoaderMac.mm 2007-03-08 01:16:19 UTC (rev 20040)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx">
</span><span class="cx"> #import <JavaScriptCore/Assertions.h>
</span><span class="cx"> #import <WebCore/SubstituteData.h>
</span><ins>+#import <WebCore/FoundationExtras.h>
</ins><span class="cx">
</span><span class="cx"> using namespace WebCore;
</span><span class="cx">
</span><span class="lines">@@ -44,7 +45,7 @@
</span><span class="cx"> void WebDocumentLoaderMac::setDataSource(WebDataSource *dataSource)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_dataSource);
</span><del>- [dataSource retain];
</del><ins>+ HardRetain(dataSource);
</ins><span class="cx"> m_dataSource = dataSource;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -59,7 +60,7 @@
</span><span class="cx"> ASSERT(m_loadCount == 0);
</span><span class="cx">
</span><span class="cx"> if (m_hasEverBeenDetached)
</span><del>- [m_dataSource retain];
</del><ins>+ HardRetain(m_dataSource);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebDocumentLoaderMac::detachFromFrame()
</span><span class="lines">@@ -67,7 +68,7 @@
</span><span class="cx"> DocumentLoader::detachFromFrame();
</span><span class="cx">
</span><span class="cx"> m_hasEverBeenDetached = true;
</span><del>- [m_dataSource release];
</del><ins>+ HardRelease(m_dataSource);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebDocumentLoaderMac::increaseLoadCount()
</span><span class="lines">@@ -75,7 +76,7 @@
</span><span class="cx"> ASSERT(m_dataSource);
</span><span class="cx">
</span><span class="cx"> if (m_loadCount == 0)
</span><del>- [m_dataSource retain];
</del><ins>+ HardRetain(m_dataSource);
</ins><span class="cx">
</span><span class="cx"> m_loadCount++;
</span><span class="cx"> }
</span><span class="lines">@@ -87,5 +88,5 @@
</span><span class="cx"> m_loadCount--;
</span><span class="cx">
</span><span class="cx"> if (m_loadCount == 0)
</span><del>- [m_dataSource release];
</del><ins>+ HardRelease(m_dataSource);
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>