<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20041] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20041">20041</a></dd>
<dt>Author</dt> <dd>bdash</dd>
<dt>Date</dt> <dd>2007-03-07 17:29:17 -0800 (Wed, 07 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>2007-03-07 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13002
Incomplete repaint of inset outlines
Test: fast/repaint/outline-inset.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2007-03-07 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=13002
Incomplete repaint of inset outlines
* fast/repaint/outline-inset-expected.checksum: Added.
* fast/repaint/outline-inset-expected.png: Added.
* fast/repaint/outline-inset-expected.txt: Added.
* fast/repaint/outline-inset.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorerenderingRenderObjectcpp">trunk/WebCore/rendering/RenderObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintoutlineinsetexpectedchecksum">trunk/LayoutTests/fast/repaint/outline-inset-expected.checksum</a></li>
<li><a href="#trunkLayoutTestsfastrepaintoutlineinsetexpectedpng">trunk/LayoutTests/fast/repaint/outline-inset-expected.png</a></li>
<li><a href="#trunkLayoutTestsfastrepaintoutlineinsetexpectedtxt">trunk/LayoutTests/fast/repaint/outline-inset-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintoutlineinsethtml">trunk/LayoutTests/fast/repaint/outline-inset.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (20040 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-03-08 01:16:19 UTC (rev 20040)
+++ trunk/LayoutTests/ChangeLog 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-03-07 Mitz Pettel <mitz@webkit.org>
+
+ Reviewed by Darin.
+
+ - repaint test for http://bugs.webkit.org/show_bug.cgi?id=13002
+ Incomplete repaint of inset outlines
+
+ * fast/repaint/outline-inset-expected.checksum: Added.
+ * fast/repaint/outline-inset-expected.png: Added.
+ * fast/repaint/outline-inset-expected.txt: Added.
+ * fast/repaint/outline-inset.html: Added.
+
</ins><span class="cx"> 2007-03-07 Rob Buis <buis@kde.org>
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin.
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoutlineinsetexpectedchecksum"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/outline-inset-expected.checksum (0 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/outline-inset-expected.checksum (rev 0)
+++ trunk/LayoutTests/fast/repaint/outline-inset-expected.checksum 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+3b8b6f6d6f2d760bcae3168c989dbd76
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoutlineinsetexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/fast/repaint/outline-inset-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/fast/repaint/outline-inset-expected.png
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + application/octet-stream
</span><a id="trunkLayoutTestsfastrepaintoutlineinsetexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/outline-inset-expected.txt (0 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/outline-inset-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/repaint/outline-inset-expected.txt 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x318
+ RenderBlock {HTML} at (0,0) size 800x318
+ RenderBody {BODY} at (8,8) size 784x302
+ RenderBlock {DIV} at (0,0) size 222x142 [border: (1px solid #0000FF)]
+ RenderBlock {DIV} at (11,21) size 200x40 [bgcolor=#008080]
+ RenderBlock {DIV} at (10,0) size 180x40 [bgcolor=#C0C0C0]
+ RenderBlock (anonymous) at (0,142) size 784x18
+ RenderBR {BR} at (0,0) size 0x18
+ RenderBlock {DIV} at (0,160) size 222x142 [border: (1px solid #0000FF)]
+ RenderBlock {DIV} at (11,21) size 200x60 [bgcolor=#008080]
+ RenderBlock {DIV} at (10,0) size 180x60 [bgcolor=#C0C0C0]
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintoutlineinsethtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/outline-inset.html (0 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/outline-inset.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/outline-inset.html 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
+ "http://www.w3.org/TR/html4/strict.dtd">
+<html lang="en">
+<head>
+<style type="text/css">
+ div.test { width: 200px; height: 120px; border: 1px solid blue; padding: 10px; }
+</style>
+ <script src="repaint.js" type="text/javascript"></script>
+ <script type="text/javascript">
+ function repaintTest()
+ {
+ document.getElementById('a').style.height = '40px';
+ document.getElementById('b').style.height = '60px';
+ }
+ </script>
+</head>
+<body onload="runRepaintTest();">
+<div class="test">
+ <div style="background: teal; padding: 0; outline: solid red 4px; outline-offset: -5px;">
+ <div id="a" style="height: 60px; margin: 10px; background:silver;"></div>
+ </div>
+</div>
+<br>
+<div class="test">
+ <div style="background: teal; padding: 0; outline: solid red 4px; outline-offset: -5px;">
+ <div id="b" style="height: 40px; margin: 10px; background:silver;"></div>
+ </div>
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (20040 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-03-08 01:16:19 UTC (rev 20040)
+++ trunk/WebCore/ChangeLog 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-03-07 Mitz Pettel <mitz@webkit.org>
+
+ Reviewed by Darin.
+
+ - fix http://bugs.webkit.org/show_bug.cgi?id=13002
+ Incomplete repaint of inset outlines
+
+ Test: fast/repaint/outline-inset.html
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
+
</ins><span class="cx"> 2007-03-07 Oliver Hunt <oliver@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Antti.
</span></span></pre></div>
<a id="trunkWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/RenderObject.cpp (20040 => 20041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/RenderObject.cpp 2007-03-08 01:16:19 UTC (rev 20040)
+++ trunk/WebCore/rendering/RenderObject.cpp 2007-03-08 01:29:17 UTC (rev 20041)
</span><span class="lines">@@ -1791,7 +1791,7 @@
</span><span class="cx"> int ow = style() ? style()->outlineSize() : 0;
</span><span class="cx"> int width = abs(newOutlineBox.width() - oldOutlineBox.width());
</span><span class="cx"> if (width) {
</span><del>- int borderWidth = max(borderRight(), max(style()->borderTopRightRadius().width(), style()->borderBottomRightRadius().width())) + ow;
</del><ins>+ int borderWidth = max(-style()->outlineOffset(), max(borderRight(), max(style()->borderTopRightRadius().width(), style()->borderBottomRightRadius().width()))) + ow;
</ins><span class="cx"> IntRect rightRect(newOutlineBox.x() + min(newOutlineBox.width(), oldOutlineBox.width()) - borderWidth,
</span><span class="cx"> newOutlineBox.y(),
</span><span class="cx"> width + borderWidth,
</span><span class="lines">@@ -1804,7 +1804,7 @@
</span><span class="cx"> }
</span><span class="cx"> int height = abs(newOutlineBox.height() - oldOutlineBox.height());
</span><span class="cx"> if (height) {
</span><del>- int borderHeight = max(borderBottom(), max(style()->borderBottomLeftRadius().height(), style()->borderBottomRightRadius().height())) + ow;
</del><ins>+ int borderHeight = max(-style()->outlineOffset(), max(borderBottom(), max(style()->borderBottomLeftRadius().height(), style()->borderBottomRightRadius().height()))) + ow;
</ins><span class="cx"> IntRect bottomRect(newOutlineBox.x(),
</span><span class="cx"> min(newOutlineBox.bottom(), oldOutlineBox.bottom()) - borderHeight,
</span><span class="cx"> max(newOutlineBox.width(), oldOutlineBox.width()),
</span></span></pre>
</div>
</div>
</body>
</html>