<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20043] trunk/JavaScriptCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20043">20043</a></dd>
<dt>Author</dt> <dd>bdash</dd>
<dt>Date</dt> <dd>2007-03-07 17:42:39 -0800 (Wed, 07 Mar 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>2007-03-07 Anrong Hu <huanr@yahoo.com>
Reviewed by Maciej.
Fix http://bugs.webkit.org/show_bug.cgi?id=12535
Bug 12535: Stack-optimizing compilers can trick GC into freeing in-use objects
* kjs/internal.cpp:
(KJS::StringImp::toObject): Copy val onto the stack so it is not subject to garbage collection.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorekjsinternalcpp">trunk/JavaScriptCore/kjs/internal.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (20042 => 20043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog 2007-03-08 01:34:23 UTC (rev 20042)
+++ trunk/JavaScriptCore/ChangeLog 2007-03-08 01:42:39 UTC (rev 20043)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2007-03-07 Anrong Hu <huanr@yahoo.com>
+
+ Reviewed by Maciej.
+
+ Fix http://bugs.webkit.org/show_bug.cgi?id=12535
+ Bug 12535: Stack-optimizing compilers can trick GC into freeing in-use objects
+
+ * kjs/internal.cpp:
+ (KJS::StringImp::toObject): Copy val onto the stack so it is not subject to garbage collection.
+
</ins><span class="cx"> 2007-03-07 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> Build fix for non-multiple-thread folks.
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsinternalcpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/internal.cpp (20042 => 20043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/internal.cpp 2007-03-08 01:34:23 UTC (rev 20042)
+++ trunk/JavaScriptCore/kjs/internal.cpp 2007-03-08 01:42:39 UTC (rev 20043)
</span><span class="lines">@@ -78,7 +78,11 @@
</span><span class="cx">
</span><span class="cx"> JSObject *StringImp::toObject(ExecState *exec) const
</span><span class="cx"> {
</span><del>- return new StringInstance(exec->lexicalInterpreter()->builtinStringPrototype(), val);
</del><ins>+ // Put the reference onto the stack so it is not subject to garbage collection.
+ // <http://bugs.webkit.org/show_bug.cgi?id=12535>
+ UString valCopy = val;
+
+ return new StringInstance(exec->lexicalInterpreter()->builtinStringPrototype(), valCopy);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // ------------------------------ NumberImp ------------------------------------
</span></span></pre>
</div>
</div>
</body>
</html>