<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20714] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20714">20714</a></dd>
<dt>Author</dt> <dd>ap</dd>
<dt>Date</dt> <dd>2007-04-04 21:40:03 -0700 (Wed, 04 Apr 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=13278
REGRESSION: cannot change SELECT option
Test: fast/forms/option-change-single-selected.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed,
be sure to deselect the previous option.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorehtmlHTMLSelectElementcpp">trunk/WebCore/html/HTMLSelectElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformsoptionchangesingleselectedexpectedtxt">trunk/LayoutTests/fast/forms/option-change-single-selected-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsoptionchangesingleselectedhtml">trunk/LayoutTests/fast/forms/option-change-single-selected.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (20713 => 20714)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-04-05 04:39:06 UTC (rev 20713)
+++ trunk/LayoutTests/ChangeLog 2007-04-05 04:40:03 UTC (rev 20714)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2007-04-04 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin.
+
+ http://bugs.webkit.org/show_bug.cgi?id=13278
+ REGRESSION: cannot change SELECT option
+
+ * fast/forms/option-change-single-selected-expected.txt: Added.
+ * fast/forms/option-change-single-selected.html: Added.
+
</ins><span class="cx"> 2007-04-03 Justin Garcia <justin.garcia@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by darin
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsoptionchangesingleselectedexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/option-change-single-selected-expected.txt (0 => 20714)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/option-change-single-selected-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/option-change-single-selected-expected.txt 2007-04-05 04:40:03 UTC (rev 20714)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+Test for bug 13278: REGRESSION: cannot change SELECT option.
+
+
+SUCCESS
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/forms/option-change-single-selected-expected.txt
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + text/plain
</span><span class="cx">Name: svn:eol-style
</span><span class="cx"> + native
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsoptionchangesingleselectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/option-change-single-selected.html (0 => 20714)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/option-change-single-selected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/option-change-single-selected.html 2007-04-05 04:40:03 UTC (rev 20714)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+<body>
+<p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=13278">bug 13278</a>: REGRESSION: cannot change SELECT option.</p>
+<form>
+<select size="1">
+ <option>FAILURE: script didn't run</option>
+ <option>FAILURE</option>
+ <option>SUCCESS</option>
+</select>
+<select size="3">
+ <option>FAILURE: script didn't run</option>
+ <option>FAILURE</option>
+ <option>SUCCESS</option>
+</select>
+</form>
+<div id=result></div>
+<script>
+
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+
+document.forms[0].elements[0].options[1].selected = true;
+document.forms[0].elements[1].options[1].selected = true;
+
+document.forms[0].elements[0].options[2].selected = true;
+document.forms[0].elements[1].options[2].selected = true;
+if (document.forms[0].elements[0].value != "SUCCESS" || document.forms[0].elements[1].options[1].selected)
+ document.getElementById("result").innerHTML = "FAILURE";
+ else
+ document.getElementById("result").innerHTML = "SUCCESS";
+</script>
+</body>
</ins><span class="cx">Property changes on: trunk/LayoutTests/fast/forms/option-change-single-selected.html
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + text/html
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (20713 => 20714)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-04-05 04:39:06 UTC (rev 20713)
+++ trunk/WebCore/ChangeLog 2007-04-05 04:40:03 UTC (rev 20714)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2007-04-04 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by Darin.
+
+ http://bugs.webkit.org/show_bug.cgi?id=13278
+ REGRESSION: cannot change SELECT option
+
+ Test: fast/forms/option-change-single-selected.html
+
+ * html/HTMLSelectElement.cpp:
+ (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed,
+ be sure to deselect the previous option.
+
</ins><span class="cx"> 2007-04-04 Adele Peterson <adele@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Oliver.
</span></span></pre></div>
<a id="trunkWebCorehtmlHTMLSelectElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/html/HTMLSelectElement.cpp (20713 => 20714)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/html/HTMLSelectElement.cpp 2007-04-05 04:39:06 UTC (rev 20713)
+++ trunk/WebCore/html/HTMLSelectElement.cpp 2007-04-05 04:40:03 UTC (rev 20714)
</span><span class="lines">@@ -174,6 +174,9 @@
</span><span class="cx"> int listIndex = optionToListIndex(optionIndex);
</span><span class="cx"> HTMLOptionElement* element = 0;
</span><span class="cx">
</span><ins>+ if (!multiple())
+ deselect = true;
+
</ins><span class="cx"> if (listIndex >= 0) {
</span><span class="cx"> if (m_activeSelectionAnchorIndex < 0 || deselect)
</span><span class="cx"> setActiveSelectionAnchorIndex(listIndex);
</span></span></pre>
</div>
</div>
</body>
</html>