<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[20737] trunk/JavaScriptCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/20737">20737</a></dd>
<dt>Author</dt> <dd>kjk</dd>
<dt>Date</dt> <dd>2007-04-05 15:50:02 -0700 (Thu, 05 Apr 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by darin.
Coverity fix. Coverity says:
"Event check_after_deref: Pointer "re" dereferenced before NULL check"
* pcre/pcre_study.c:
(pcre_study):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorepcrepcre_studyc">trunk/JavaScriptCore/pcre/pcre_study.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (20736 => 20737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog 2007-04-05 22:45:24 UTC (rev 20736)
+++ trunk/JavaScriptCore/ChangeLog 2007-04-05 22:50:02 UTC (rev 20737)
</span><span class="lines">@@ -2,6 +2,16 @@
</span><span class="cx">
</span><span class="cx"> Reviewed by darin.
</span><span class="cx">
</span><ins>+ Coverity fix. Coverity says:
+ "Event check_after_deref: Pointer "re" dereferenced before NULL check"
+
+ * pcre/pcre_study.c:
+ (pcre_study):
+
+2007-04-05 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
+
+ Reviewed by darin.
+
</ins><span class="cx"> Coverity fixes. Coverity says:
</span><span class="cx"> "Event leaked_storage: Returned without freeing storage "buffer""
</span><span class="cx"> and:
</span></span></pre></div>
<a id="trunkJavaScriptCorepcrepcre_studyc"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/pcre/pcre_study.c (20736 => 20737)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/pcre/pcre_study.c 2007-04-05 22:45:24 UTC (rev 20736)
+++ trunk/JavaScriptCore/pcre/pcre_study.c 2007-04-05 22:50:02 UTC (rev 20737)
</span><span class="lines">@@ -409,8 +409,7 @@
</span><span class="cx"> pcre_study_data *study;
</span><span class="cx"> const uschar *tables;
</span><span class="cx"> const real_pcre *re = (const real_pcre *)external_re;
</span><del>-uschar *code = (uschar *)re + re->name_table_offset +
- (re->name_count * re->name_entry_size);
</del><ins>+uschar *code;
</ins><span class="cx"> compile_data compile_block;
</span><span class="cx">
</span><span class="cx"> *errorptr = NULL;
</span><span class="lines">@@ -421,6 +420,9 @@
</span><span class="cx"> return NULL;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+code = (uschar *)re + re->name_table_offset +
+ (re->name_count * re->name_entry_size);
+
</ins><span class="cx"> if ((options & ~PUBLIC_STUDY_OPTIONS) != 0)
</span><span class="cx"> {
</span><span class="cx"> *errorptr = "unknown or incorrect option bit(s) set";
</span></span></pre>
</div>
</div>
</body>
</html>