<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--

#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }

#msg ul, pre { overflow: auto; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<title>[23916] trunk</title>

</head>

<body>

<div id="msg">

<dl>

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23916">23916</a></dd>

<dt>Author</dt> <dd>weinig</dd>

<dt>Date</dt> <dd>2007-07-01 10:38:29 -0700 (Sun, 01 Jul 2007)</dd>

</dl>

<h3>Log Message</h3>

<pre>LayoutTests:

        Reviewed by Oliver.

        Third round of implicit 64-32 bit conversion errors fixes.

        &lt;rdar://problem/5292262&gt;

        getFloatValue() used to return a double and now returns a float for a small

        loss of precision.

        * fast/css/getFloatValueForUnit-expected.checksum:

        * fast/css/getFloatValueForUnit-expected.png:

        * fast/css/getFloatValueForUnit-expected.txt:

        * fast/css/getFloatValueForUnit.html:

WebCore:

        Reviewed by Oliver.

        Third round of implicit 64-32 bit conversion errors fixes.

        &lt;rdar://problem/5292262&gt;

        - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()

          methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.

        * css/CSSPrimitiveValue.cpp:

        (WebCore::CSSPrimitiveValue::computeLengthInt):

        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):

        (WebCore::CSSPrimitiveValue::computeLengthShort):

        (WebCore::CSSPrimitiveValue::computeLengthFloat):

        (WebCore::CSSPrimitiveValue::computeLengthDouble):

        (WebCore::CSSPrimitiveValue::getDoubleValue):

        * css/CSSPrimitiveValue.h:

        (WebCore::CSSPrimitiveValue::getDoubleValue):

        (WebCore::CSSPrimitiveValue::getFloatValue):

        (WebCore::CSSPrimitiveValue::getIntValue):

        * css/Counter.h:

        (WebCore::Counter::listStyleNumber):

        * css/MediaQueryEvaluator.cpp:

        (WebCore::parseAspectRatio):

        * css/cssparser.cpp:

        (WebCore::BorderImageParseContext::commitBorderImage):

        * css/cssstyleselector.cpp:

        (WebCore::convertToLength):

        (WebCore::applyCounterList):

        (WebCore::CSSStyleSelector::applyProperty):

        (WebCore::CSSStyleSelector::mapBackgroundSize):

        (WebCore::CSSStyleSelector::mapBackgroundXPosition):

        (WebCore::CSSStyleSelector::mapBackgroundYPosition):

        * html/HTMLTableElement.cpp:

        (WebCore::HTMLTableElement::parseMappedAttribute):

        * ksvg2/css/SVGCSSStyleSelector.cpp:

        (WebCore::CSSStyleSelector::applySVGProperty):

        * ksvg2/misc/KCanvasRenderingStyle.cpp:

        (WebCore::KSVGPainterFactory::cssPrimitiveToLength):

        (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>

<li><a href="#trunkLayoutTestsfastcssgetFloatValueForUnitexpectedchecksum">trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.checksum</a></li>

<li><a href="#trunkLayoutTestsfastcssgetFloatValueForUnitexpectedpng">trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.png</a></li>

<li><a href="#trunkLayoutTestsfastcssgetFloatValueForUnitexpectedtxt">trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.txt</a></li>

<li><a href="#trunkLayoutTestsfastcssgetFloatValueForUnithtml">trunk/LayoutTests/fast/css/getFloatValueForUnit.html</a></li>

<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>

<li><a href="#trunkWebCorecssCSSPrimitiveValuecpp">trunk/WebCore/css/CSSPrimitiveValue.cpp</a></li>

<li><a href="#trunkWebCorecssCSSPrimitiveValueh">trunk/WebCore/css/CSSPrimitiveValue.h</a></li>

<li><a href="#trunkWebCorecssCounterh">trunk/WebCore/css/Counter.h</a></li>

<li><a href="#trunkWebCorecssMediaQueryEvaluatorcpp">trunk/WebCore/css/MediaQueryEvaluator.cpp</a></li>

<li><a href="#trunkWebCorecsscssparsercpp">trunk/WebCore/css/cssparser.cpp</a></li>

<li><a href="#trunkWebCorecsscssstyleselectorcpp">trunk/WebCore/css/cssstyleselector.cpp</a></li>

<li><a href="#trunkWebCorehtmlHTMLTableElementcpp">trunk/WebCore/html/HTMLTableElement.cpp</a></li>

<li><a href="#trunkWebCoreksvg2cssSVGCSSStyleSelectorcpp">trunk/WebCore/ksvg2/css/SVGCSSStyleSelector.cpp</a></li>

<li><a href="#trunkWebCoreksvg2miscKCanvasRenderingStylecpp">trunk/WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkLayoutTestsChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/ChangeLog        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/LayoutTests/ChangeLog        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -1,3 +1,18 @@

</span><ins>+2007-07-01  Sam Weinig  &lt;sam@webkit.org&gt;

+

+        Reviewed by Oliver.

+

+        Third round of implicit 64-32 bit conversion errors fixes.

+        &lt;rdar://problem/5292262&gt;

+

+        getFloatValue() used to return a double and now returns a float for a small

+        loss of precision.

+

+        * fast/css/getFloatValueForUnit-expected.checksum:

+        * fast/css/getFloatValueForUnit-expected.png:

+        * fast/css/getFloatValueForUnit-expected.txt:

+        * fast/css/getFloatValueForUnit.html:

+

</ins><span class="cx"> 2007-07-01  Darin Adler  &lt;darin@apple.com&gt;

</span><span class="cx"> 

<span class="cx">         Fixed a no-SVG test failure by moving a test that requires SVG into the svg directory.

</span></span></pre></div>

<a id="trunkLayoutTestsfastcssgetFloatValueForUnitexpectedchecksum"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.checksum (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.checksum        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.checksum        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -1 +1 @@

</span><del>-aac74cf551377e05faf81bcc7dab978f

</del><span class="cx">\ No newline at end of file

</span><ins>+f6e55658bfaf1ba0196a3a8c48c01020

</ins><span class="cx">\ No newline at end of file

</span></span></pre></div>

<a id="trunkLayoutTestsfastcssgetFloatValueForUnitexpectedpng"></a>

<div class="binary"><h4>Modified: trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.png</h4>

<pre class="diff"><span>

<span class="cx">(Binary files differ)

</span></span></pre></div>

<a id="trunkLayoutTestsfastcssgetFloatValueForUnitexpectedtxt"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.txt (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.txt        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.txt        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -8,4 +8,5 @@

</span><span class="cx">         RenderText {#text} at (0,0) size 45x18

</span><span class="cx">           text run at (0,0) width 45: &quot;10pt = &quot;

</span><span class="cx">         RenderText {#text} at (45,0) size 383x18

</span><del>-          text run at (45,0) width 383: &quot;3.4395833333333328mm (should be 3.4395833333333328)&quot;

</del><ins>+          text run at (45,0) width 383: &quot;3.4395833015441895mm (should be 3.4395833015441895)&quot;

+        RenderText {#text} at (0,0) size 0x0

</ins></span></pre></div>

<a id="trunkLayoutTestsfastcssgetFloatValueForUnithtml"></a>

<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/css/getFloatValueForUnit.html (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/LayoutTests/fast/css/getFloatValueForUnit.html        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/LayoutTests/fast/css/getFloatValueForUnit.html        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -4,6 +4,6 @@

</span><span class="cx"> &lt;script&gt;

</span><span class="cx"> //CSSPrimitiveValue.CSS_MM

</span><span class="cx"> document.write(document.defaultView.getComputedStyle(document.getElementById('d'), '').getPropertyCSSValue('font-size').getFloatValue(7));

</span><del>-document.write(&quot;mm (should be 3.4395833333333328)&quot;);

</del><ins>+document.write(&quot;mm (should be 3.4395833015441895)&quot;);

</ins><span class="cx"> &lt;/script&gt;

</span><del>-&lt;/body&gt;

</del><span class="cx">\ No newline at end of file

</span><ins>+&lt;/body&gt;

</ins></span></pre></div>

<a id="trunkWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/WebCore/ChangeLog        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/WebCore/ChangeLog        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -1,3 +1,45 @@

</span><ins>+2007-07-01  Sam Weinig  &lt;sam@webkit.org&gt;

+

+        Reviewed by Oliver.

+

+        Third round of implicit 64-32 bit conversion errors fixes.

+        &lt;rdar://problem/5292262&gt;

+

+        - Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue()

+          methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.

+

+        * css/CSSPrimitiveValue.cpp:

+        (WebCore::CSSPrimitiveValue::computeLengthInt):

+        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):

+        (WebCore::CSSPrimitiveValue::computeLengthShort):

+        (WebCore::CSSPrimitiveValue::computeLengthFloat):

+        (WebCore::CSSPrimitiveValue::computeLengthDouble):

+        (WebCore::CSSPrimitiveValue::getDoubleValue):

+        * css/CSSPrimitiveValue.h:

+        (WebCore::CSSPrimitiveValue::getDoubleValue):

+        (WebCore::CSSPrimitiveValue::getFloatValue):

+        (WebCore::CSSPrimitiveValue::getIntValue):

+        * css/Counter.h:

+        (WebCore::Counter::listStyleNumber):

+        * css/MediaQueryEvaluator.cpp:

+        (WebCore::parseAspectRatio):

+        * css/cssparser.cpp:

+        (WebCore::BorderImageParseContext::commitBorderImage):

+        * css/cssstyleselector.cpp:

+        (WebCore::convertToLength):

+        (WebCore::applyCounterList):

+        (WebCore::CSSStyleSelector::applyProperty):

+        (WebCore::CSSStyleSelector::mapBackgroundSize):

+        (WebCore::CSSStyleSelector::mapBackgroundXPosition):

+        (WebCore::CSSStyleSelector::mapBackgroundYPosition):

+        * html/HTMLTableElement.cpp:

+        (WebCore::HTMLTableElement::parseMappedAttribute):

+        * ksvg2/css/SVGCSSStyleSelector.cpp:

+        (WebCore::CSSStyleSelector::applySVGProperty):

+        * ksvg2/misc/KCanvasRenderingStyle.cpp:

+        (WebCore::KSVGPainterFactory::cssPrimitiveToLength):

+        (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):

+

</ins><span class="cx"> 2007-07-01  Pamela Greene  &lt;pamg.bugs@gmail.com&gt;

</span><span class="cx"> 

<span class="cx">         Reviewed by Darin.

</span></span></pre></div>

<a id="trunkWebCorecssCSSPrimitiveValuecpp"></a>

<div class="modfile"><h4>Modified: trunk/WebCore/css/CSSPrimitiveValue.cpp (23915 => 23916)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/WebCore/css/CSSPrimitiveValue.cpp        2007-07-01 17:23:29 UTC (rev 23915)

+++ trunk/WebCore/css/CSSPrimitiveValue.cpp        2007-07-01 17:38:29 UTC (rev 23916)

</span><span class="lines">@@ -197,7 +197,7 @@

</span><span class="cx"> 

</span><span class="cx"> int CSSPrimitiveValue::computeLengthInt(RenderStyle* style)

</span><span class="cx"> {

</span><del>-    double result = computeLengthFloat(style);

</del><ins>+    double result = computeLengthDouble(style);

</ins><span class="cx"> 

</span><span class="cx">     // This conversion is imprecise, often resulting in values of, e.g., 44.99998.  We