<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23922] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23922">23922</a></dd>
<dt>Author</dt> <dd>darin</dd>
<dt>Date</dt> <dd>2007-07-01 19:26:49 -0700 (Sun, 01 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> * css/tokenizer.flex: Rolled out the fix for 14453.
The layout test wasn't passing. We'll try again.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorecsstokenizerflex">trunk/WebCore/css/tokenizer.flex</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss21hexcolorregressionexpectedchecksum">trunk/LayoutTests/css2.1/hex-color-regression-expected.checksum</a></li>
<li><a href="#trunkLayoutTestscss21hexcolorregressionexpectedpng">trunk/LayoutTests/css2.1/hex-color-regression-expected.png</a></li>
<li><a href="#trunkLayoutTestscss21hexcolorregressionexpectedtxt">trunk/LayoutTests/css2.1/hex-color-regression-expected.txt</a></li>
<li><a href="#trunkLayoutTestscss21hexcolorregressionhtml">trunk/LayoutTests/css2.1/hex-color-regression.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/LayoutTests/ChangeLog 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -1,16 +1,3 @@
</span><del>-2007-07-01 Rob Buis <buis@kde.org>
-
- Reviewed by Darin.
-
- Regression test for:
- http://bugs.webkit.org/show_bug.cgi?id=14453
- REGRESSION: www.nzherald.co.nz almost all the formating is gone
-
- * css2.1/hex-color-regression-expected.checksum: Added.
- * css2.1/hex-color-regression-expected.png: Added.
- * css2.1/hex-color-regression-expected.txt: Added.
- * css2.1/hex-color-regression.html: Added.
-
</del><span class="cx"> 2007-07-01 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><span class="cx"> Fixed a no-SVG test failure by removing a node that was affecting the test results differently
</span></span></pre></div>
<a id="trunkLayoutTestscss21hexcolorregressionexpectedchecksum"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/css2.1/hex-color-regression-expected.checksum (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css2.1/hex-color-regression-expected.checksum 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/LayoutTests/css2.1/hex-color-regression-expected.checksum 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -1 +0,0 @@
</span><del>-18f1f64eab31dfb69467a497de9442d7
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestscss21hexcolorregressionexpectedpng"></a>
<div class="binary"><h4>Deleted: trunk/LayoutTests/css2.1/hex-color-regression-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkLayoutTestscss21hexcolorregressionexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/css2.1/hex-color-regression-expected.txt (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css2.1/hex-color-regression-expected.txt 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/LayoutTests/css2.1/hex-color-regression-expected.txt 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
</del></span></pre></div>
<a id="trunkLayoutTestscss21hexcolorregressionhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/css2.1/hex-color-regression.html (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css2.1/hex-color-regression.html 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/LayoutTests/css2.1/hex-color-regression.html 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -1,5 +0,0 @@
</span><del>-<style>
- span { color: #f0; }
- div { background-color: green; width: 100px; height: 100px; }
-</style>
-<div></div>
</del></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/WebCore/ChangeLog 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -1,3 +1,8 @@
</span><ins>+2007-07-01 Darin Adler <darin@apple.com>
+
+ * css/tokenizer.flex: Rolled out the fix for 14453.
+ The layout test wasn't passing. We'll try again.
+
</ins><span class="cx"> 2007-07-01 Adam Roben <aroben@apple.com>
</span><span class="cx">
</span><span class="cx"> Fix a crash in ~PluginViewWin()
</span></span></pre></div>
<a id="trunkWebCorecsstokenizerflex"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/css/tokenizer.flex (23921 => 23922)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/css/tokenizer.flex 2007-07-02 00:51:22 UTC (rev 23921)
+++ trunk/WebCore/css/tokenizer.flex 2007-07-02 02:26:49 UTC (rev 23922)
</span><span class="lines">@@ -12,7 +12,7 @@
</span><span class="cx"> nmchar [_a-zA-Z0-9-]|{nonascii}|{escape}
</span><span class="cx"> string1 \"([\t !#$%&(-~]|\\{nl}|\'|{nonascii}|{escape})*\"
</span><span class="cx"> string2 \'([\t !#$%&(-~]|\\{nl}|\"|{nonascii}|{escape})*\'
</span><del>-hexcolor {h}{2,6}
</del><ins>+hexcolor {h}{3}|{h}{6}
</ins><span class="cx">
</span><span class="cx"> ident -?{nmstart}{nmchar}*
</span><span class="cx"> name {nmchar}+
</span></span></pre>
</div>
</div>
</body>
</html>