<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23912] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23912">23912</a></dd>
<dt>Author</dt> <dd>bdash</dd>
<dt>Date</dt> <dd>2007-07-01 07:26:02 -0700 (Sun, 01 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>2007-07-01 Pamela Greene <pamg.bugs@gmail.com>
Reviewed by Darin.
Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>
Use std::stable_sort() instead of qsort() to sort gradient stops.
Adjust the comparison function accordingly.
* html/CanvasGradient.cpp:
(WebCore::compareStops):
(WebCore::CanvasGradient::findStop):
2007-07-01 Pamela Greene <pamg.bugs@gmail.com>
Reviewed by Darin.
Tests for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>
Add tests for various combinations of stops, including multiple stops at
the same offsets, sorted and unsorted. Update results accordingly.
* fast/canvas/fillrect_gradient-expected.checksum:
* fast/canvas/fillrect_gradient-expected.png:
* fast/canvas/fillrect_gradient-expected.txt:
* fast/canvas/fillrect_gradient.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastcanvasfillrect_gradientexpectedchecksum">trunk/LayoutTests/fast/canvas/fillrect_gradient-expected.checksum</a></li>
<li><a href="#trunkLayoutTestsfastcanvasfillrect_gradientexpectedpng">trunk/LayoutTests/fast/canvas/fillrect_gradient-expected.png</a></li>
<li><a href="#trunkLayoutTestsfastcanvasfillrect_gradientexpectedtxt">trunk/LayoutTests/fast/canvas/fillrect_gradient-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastcanvasfillrect_gradienthtml">trunk/LayoutTests/fast/canvas/fillrect_gradient.html</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorehtmlCanvasGradientcpp">trunk/WebCore/html/CanvasGradient.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (23911 => 23912)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-07-01 14:20:13 UTC (rev 23911)
+++ trunk/LayoutTests/ChangeLog 2007-07-01 14:26:02 UTC (rev 23912)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2007-07-01 Pamela Greene <pamg.bugs@gmail.com>
+
+ Reviewed by Darin.
+
+ Tests for <http://bugs.webkit.org/show_bug.cgi?id=14320>
+ Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
+ <rdar://problem/5290084>
+
+ Add tests for various combinations of stops, including multiple stops at
+ the same offsets, sorted and unsorted. Update results accordingly.
+
+ * fast/canvas/fillrect_gradient-expected.checksum:
+ * fast/canvas/fillrect_gradient-expected.png:
+ * fast/canvas/fillrect_gradient-expected.txt:
+ * fast/canvas/fillrect_gradient.html:
+
</ins><span class="cx"> 2007-07-01 MorganL <morganl.webkit@yahoo.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin.
</span></span></pre></div>
<a id="trunkLayoutTestsfastcanvasfillrect_gradientexpectedchecksum"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/canvas/fillrect_gradient-expected.checksum ( => )</h4>
<pre class="diff"><span>
<span class="info">
</span></span></pre>
</div>
</div>
</body>
</html>