<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23934] branches/wx-port-alpha/trunk</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23934">23934</a></dd>
<dt>Author</dt> <dd>kevino</dd>
<dt>Date</dt> <dd>2007-07-02 16:05:50 -0700 (Mon, 02 Jul 2007)</dd>
</dl>

<h3>Log Message</h3>
<pre>Enable RTTI and exceptions for now, fix a linking issue with libjpeg on Win, and improve support for building with Python versions other than 2.5.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#brancheswxportalphatrunkJavaScriptCorejscorebkl">branches/wx-port-alpha/trunk/JavaScriptCore/jscore.bkl</a></li>
<li><a href="#brancheswxportalphatrunkWebCoreProjectswxwebcorewxbkl">branches/wx-port-alpha/trunk/WebCore/Projects/wx/webcore-wx.bkl</a></li>
<li><a href="#brancheswxportalphatrunkWebKitwxWebViewcpp">branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp</a></li>
<li><a href="#brancheswxportalphatrunkWebKitwxbindingspythonwxwebkitpybkl">branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/wxwebkit-py.bkl</a></li>
<li><a href="#brancheswxportalphatrunkWebKitwxwxwebkitbkl">branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl</a></li>
<li><a href="#brancheswxportalphatrunkWebKitToolsScriptsbuildwxwebkit">branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="brancheswxportalphatrunkJavaScriptCorejscorebkl"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/JavaScriptCore/jscore.bkl (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/JavaScriptCore/jscore.bkl        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/JavaScriptCore/jscore.bkl        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -50,8 +50,8 @@
</span><span class="cx">         &lt;!-- &lt;pre-build-target&gt;DerivedSources&lt;/pre-build-target&gt; --&gt;
</span><span class="cx">         &lt;dirname&gt;$(WKOUTPUTDIR)&lt;/dirname&gt;
</span><span class="cx">         &lt;warnings&gt;default&lt;/warnings&gt;
</span><del>-        &lt;cxx-rtti&gt;off&lt;/cxx-rtti&gt;
-        &lt;cxx-exceptions&gt;off&lt;/cxx-exceptions&gt;
</del><ins>+        &lt;cxx-rtti&gt;on&lt;/cxx-rtti&gt;
+        &lt;cxx-exceptions&gt;on&lt;/cxx-exceptions&gt;
</ins><span class="cx">         &lt;debug-info&gt;on&lt;/debug-info&gt;
</span><span class="cx">         &lt;if cond=&quot;FORMAT in ['msvc', 'msvs2005prj']&quot;&gt;
</span><span class="cx">             &lt;set var=&quot;DEBUG_RUNTIME&quot;&gt;
</span></span></pre></div>
<a id="brancheswxportalphatrunkWebCoreProjectswxwebcorewxbkl"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/WebCore/Projects/wx/webcore-wx.bkl (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/WebCore/Projects/wx/webcore-wx.bkl        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/WebCore/Projects/wx/webcore-wx.bkl        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -1,4 +1,4 @@
</span><del>-&lt;?xml version=&quot;1.0&quot; ?&gt;
</del><ins>+&lt;?xml version=&quot;1.0&quot; ?&gt;
</ins><span class="cx"> &lt;!-- 
</span><span class="cx"> Copyright (C) 2007 Kevin Ollivier &lt;kevino@theolliviers.com&gt;
</span><span class="cx"> 
</span><span class="lines">@@ -51,8 +51,8 @@
</span><span class="cx">     &lt;/action&gt;
</span><span class="cx">       
</span><span class="cx">     &lt;template id=&quot;webcore-wx&quot; template=&quot;webcore_base,curl,gtk,pthreads&quot;&gt;
</span><del>-        &lt;cxx-rtti&gt;off&lt;/cxx-rtti&gt;
-        &lt;cxx-exceptions&gt;off&lt;/cxx-exceptions&gt;
</del><ins>+        &lt;cxx-rtti&gt;on&lt;/cxx-rtti&gt;
+        &lt;cxx-exceptions&gt;on&lt;/cxx-exceptions&gt;
</ins><span class="cx">         &lt;pic&gt;on&lt;/pic&gt;
</span><span class="cx">         &lt;threading&gt;multi&lt;/threading&gt;
</span><span class="cx">         &lt;debug-info&gt;on&lt;/debug-info&gt;
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx">         &lt;define&gt;BUILDING_WX__=1&lt;/define&gt;
</span><span class="cx">                 &lt;define&gt;WTF_USE_ICU_UNICODE=1&lt;/define&gt;
</span><span class="cx">         &lt;define&gt;UNICODE=1&lt;/define&gt;
</span><del>-        
</del><ins>+
</ins><span class="cx">         &lt;if cond=&quot;PLATFORM_WIN32=='0'&quot;&gt;
</span><span class="cx">             &lt;ldlibs&gt;`$(WX_CONFIG) --libs`&lt;/ldlibs&gt;
</span><span class="cx">         &lt;/if&gt;
</span></span></pre></div>
<a id="brancheswxportalphatrunkWebKitwxWebViewcpp"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -168,9 +168,14 @@
</span><span class="cx">     WebCore::InitializeLoggingChannelsIfNecessary();    
</span><span class="cx">     WebCore::HTMLFrameOwnerElement* parentFrame = 0;
</span><span class="cx">     WebCore::Page* page = 0;
</span><del>-    wxWebView* parentWebView = dynamic_cast&lt;wxWebView*&gt;(parent);
</del><ins>+
+    // FIXME: This cast is obviously not as safe as a dynamic
+    // cast, but this allows us to get around requiring RTTI
+    // support for the moment. This is only used for subframes
+    // in any case, which aren't currently supported.
+    wxWebView* parentWebView = static_cast&lt;wxWebView*&gt;(parent);
</ins><span class="cx">     
</span><del>-    if ( parentWebView )
</del><ins>+    if ( data )
</ins><span class="cx">     {
</span><span class="cx">         parentFrame = data-&gt;ownerElement;
</span><span class="cx">         page = parentWebView-&gt;m_impl-&gt;frame-&gt;page();
</span></span></pre></div>
<a id="brancheswxportalphatrunkWebKitwxbindingspythonwxwebkitpybkl"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/wxwebkit-py.bkl (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/wxwebkit-py.bkl        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/wxwebkit-py.bkl        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -14,7 +14,8 @@
</span><span class="cx">     &lt;/if&gt;
</span><span class="cx">     
</span><span class="cx">     &lt;if cond=&quot;not isdefined('PYTHON_VERSION')&quot;&gt;
</span><del>-        &lt;option name=&quot;PYTHON_VERSION&quot; category=&quot;path&quot;&gt;
</del><ins>+        &lt;option name=&quot;PYTHON_VERSION&quot;&gt;
+            &lt;values&gt;24,25&lt;/values&gt;
</ins><span class="cx">             &lt;default-value&gt;25&lt;/default-value&gt;
</span><span class="cx">             &lt;description&gt;
</span><span class="cx">                 Python version we're building against. 
</span><span class="lines">@@ -32,6 +33,8 @@
</span><span class="cx">     &lt;/if&gt;
</span><span class="cx">     
</span><span class="cx">     &lt;module id=&quot;wxwebkit-python&quot; template=&quot;wx,webcore,xml2,iconv,xslt,icu,jscore,curl,sqlite3,gtk,pthreads&quot;&gt;
</span><ins>+        &lt;cxx-rtti&gt;on&lt;/cxx-rtti&gt;
+        &lt;cxx-exceptions&gt;on&lt;/cxx-exceptions&gt;
</ins><span class="cx">         &lt;debug-info&gt;on&lt;/debug-info&gt;
</span><span class="cx">         &lt;if cond=&quot;FORMAT in ['msvc', 'msvs2005prj']&quot;&gt;
</span><span class="cx">             &lt;!-- it's very unlikely someone will build a debug python, wxPython, etc.
</span><span class="lines">@@ -75,8 +78,16 @@
</span><span class="cx">             &lt;ldflags&gt;$(MAC_FLAGS) -undefined dynamic_lookup&lt;/ldflags&gt;
</span><span class="cx">         &lt;/if&gt;
</span><span class="cx">         &lt;if cond=&quot;FORMAT in ['msvc','msvs2005prj']&quot;&gt;
</span><ins>+            &lt;set var=&quot;PY_LIBNAME&quot;&gt;
+                &lt;if cond=&quot;PYTHON_VERSION=='24'&quot;&gt;
+                    python24
+                &lt;/if&gt;
+                &lt;if cond=&quot;PYTHON_VERSION=='25'&quot;&gt;
+                    python25
+                &lt;/if&gt;
+            &lt;/set&gt;
</ins><span class="cx">             &lt;sys-lib&gt;libpng&lt;/sys-lib&gt;
</span><del>-            &lt;sys-lib&gt;python$(PYTHON_VERSION)&lt;/sys-lib&gt;
</del><ins>+            &lt;sys-lib&gt;$(PY_LIBNAME)&lt;/sys-lib&gt;
</ins><span class="cx">             &lt;lib-path&gt;$(WK_ROOT)/libpng&lt;/lib-path&gt;
</span><span class="cx">             &lt;lib-path&gt;$(PYTHON_LIBDIR)&lt;/lib-path&gt;
</span><span class="cx">         &lt;/if&gt;
</span></span></pre></div>
<a id="brancheswxportalphatrunkWebKitwxwxwebkitbkl"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/WebKit/wx/wxwebkit.bkl        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -14,7 +14,9 @@
</span><span class="cx">     &lt;/if&gt;
</span><span class="cx">     
</span><span class="cx">     &lt;dll id=&quot;wxwebkit-dynamic&quot; template=&quot;wx,webcore,xml2,iconv,xslt,icu,jscore,curl,sqlite3,gtk,pthreads&quot;&gt;
</span><del>-        &lt;debug-info&gt;on&lt;/debug-info&gt;
</del><ins>+       &lt;cxx-rtti&gt;on&lt;/cxx-rtti&gt;
+       &lt;cxx-exceptions&gt;on&lt;/cxx-exceptions&gt;
+       &lt;debug-info&gt;on&lt;/debug-info&gt;
</ins><span class="cx">         &lt;if cond=&quot;FORMAT in ['msvc', 'msvs2005prj']&quot;&gt;
</span><span class="cx">             &lt;set var=&quot;DEBUG_RUNTIME&quot;&gt;
</span><span class="cx">                 &lt;if cond=&quot;WX_PYTHON=='1' and WX_DEBUG=='0'&quot;&gt;off&lt;/if&gt;
</span><span class="lines">@@ -40,9 +42,6 @@
</span><span class="cx">         &lt;dllname&gt;wxwebkit&lt;/dllname&gt;
</span><span class="cx">         &lt;libname&gt;wxwebkit&lt;/libname&gt;
</span><span class="cx">         
</span><del>-        &lt;wx-lib&gt;core&lt;/wx-lib&gt;
-        &lt;wx-lib&gt;base&lt;/wx-lib&gt;
-        
</del><span class="cx">         &lt;if cond=&quot;FORMAT=='gnu'&quot;&gt;
</span><span class="cx">             &lt;ldflags&gt;$(WKOUTPUTDIR)/libjscore.a&lt;/ldflags&gt;
</span><span class="cx">         &lt;/if&gt;
</span><span class="lines">@@ -71,10 +70,14 @@
</span><span class="cx">         &lt;if cond=&quot;FORMAT in ['msvc','msvs2005prj']&quot;&gt;
</span><span class="cx">             &lt;sys-lib&gt;webcore-wx&lt;/sys-lib&gt;
</span><span class="cx">             &lt;sys-lib&gt;libpng&lt;/sys-lib&gt;
</span><ins>+            &lt;sys-lib&gt;libjpeg&lt;/sys-lib&gt;
</ins><span class="cx">             &lt;lib-path&gt;$(WKOUTPUTDIR)&lt;/lib-path&gt;
</span><span class="cx">             &lt;lib-path&gt;$(WK_ROOT)/libpng&lt;/lib-path&gt;
</span><ins>+            &lt;lib-path&gt;$(WK_ROOT)/libjpeg&lt;/lib-path&gt;
</ins><span class="cx">         &lt;/if&gt;
</span><span class="cx">         
</span><ins>+        &lt;wx-lib&gt;core&lt;/wx-lib&gt;
+        &lt;wx-lib&gt;base&lt;/wx-lib&gt;
</ins><span class="cx">         &lt;define&gt;BUILDING_WX__=1&lt;/define&gt;
</span><span class="cx">         
</span><span class="cx">         &lt;sources&gt;
</span></span></pre></div>
<a id="brancheswxportalphatrunkWebKitToolsScriptsbuildwxwebkit"></a>
<div class="modfile"><h4>Modified: branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit (23933 => 23934)</h4>
<pre class="diff"><span>
<span class="info">--- branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit        2007-07-02 22:14:35 UTC (rev 23933)
+++ branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit        2007-07-02 23:05:50 UTC (rev 23934)
</span><span class="lines">@@ -247,7 +247,7 @@
</span><span class="cx">             
</span><span class="cx">             PY_INCLUDE=`python -c &quot;import distutils.sysconfig; print distutils.sysconfig.get_python_inc()&quot;`
</span><span class="cx">             PY_VERSION=`python -c &quot;import sys;  print str(sys.version_info[0]) + str(sys.version_info[1])&quot;`
</span><del>-            PY_LIBDIR=`python -c &quot;import distutils.sysconfig; print distutils.sysconfig.PREFIX&quot;`
</del><ins>+            PY_LIBDIR=`python -c &quot;import distutils.sysconfig; import sys; sys.stdout.write(distutils.sysconfig.PREFIX)&quot;`
</ins><span class="cx">             
</span><span class="cx">             if [ &quot;${OSTYPE:0:6}&quot; == &quot;cygwin&quot; ]; then
</span><span class="cx">                 PY_LIBDIR=&quot;$PY_LIBDIR\\Libs&quot;
</span></span></pre>
</div>
</div>

</body>
</html>