<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23959] tags/Safari-5522.10/WebCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23959">23959</a></dd>
<dt>Author</dt> <dd>thatcher</dd>
<dt>Date</dt> <dd>2007-07-03 15:11:06 -0700 (Tue, 03 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge r23894.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#tagsSafari552210WebCoreChangeLog">tags/Safari-5522.10/WebCore/ChangeLog</a></li>
<li><a href="#tagsSafari552210WebCoreeditingDeleteSelectionCommandcpp">tags/Safari-5522.10/WebCore/editing/DeleteSelectionCommand.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="tagsSafari552210WebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: tags/Safari-5522.10/WebCore/ChangeLog (23958 => 23959)</h4>
<pre class="diff"><span>
<span class="info">--- tags/Safari-5522.10/WebCore/ChangeLog 2007-07-03 22:04:29 UTC (rev 23958)
+++ tags/Safari-5522.10/WebCore/ChangeLog 2007-07-03 22:11:06 UTC (rev 23959)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2007-06-29 Justin Garcia <justin.garcia@apple.com>
+
+ Reviewed by Harrison.
+
+ <rdar://problem/5299513> REGRESSION: In Mail, a crash occurs when attempting to undo a newly created To Do
+
+ Rolled out a change made in r23787.
+
+ * editing/DeleteSelectionCommand.cpp:
+ (WebCore::DeleteSelectionCommand::handleGeneralDelete):
+
</ins><span class="cx"> 2007-06-26 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Mark Rowe.
</span></span></pre></div>
<a id="tagsSafari552210WebCoreeditingDeleteSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: tags/Safari-5522.10/WebCore/editing/DeleteSelectionCommand.cpp (23958 => 23959)</h4>
<pre class="diff"><span>
<span class="info">--- tags/Safari-5522.10/WebCore/editing/DeleteSelectionCommand.cpp 2007-07-03 22:04:29 UTC (rev 23958)
+++ tags/Safari-5522.10/WebCore/editing/DeleteSelectionCommand.cpp 2007-07-03 22:11:06 UTC (rev 23959)
</span><span class="lines">@@ -410,7 +410,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (m_downstreamEnd.node() != startNode && !m_upstreamStart.node()->isDescendantOf(m_downstreamEnd.node()) && m_downstreamEnd.node()->inDocument() && m_downstreamEnd.offset() >= m_downstreamEnd.node()->caretMinOffset()) {
</span><del>- if (m_downstreamEnd.offset() >= maxDeepOffset(m_downstreamEnd.node()) && !canHaveChildrenForEditing(m_downstreamEnd.node())) {
</del><ins>+ if (m_downstreamEnd.offset() >= maxDeepOffset(m_downstreamEnd.node())) {
+ // FIXME: Shouldn't remove m_downstreamEnd.node() if its offsets refer to children.
</ins><span class="cx"> // The node itself is fully selected, not just its contents. Delete it.
</span><span class="cx"> removeNode(m_downstreamEnd.node());
</span><span class="cx"> } else {
</span></span></pre>
</div>
</div>
</body>
</html>