<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23955] trunk/JavaScriptCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23955">23955</a></dd>
<dt>Author</dt> <dd>weinig</dd>
<dt>Date</dt> <dd>2007-07-03 14:35:25 -0700 (Tue, 03 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Brady Eidson.
Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>
- Add explicit casts.
* kjs/dtoa.cpp:
(Bigint::):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorekjsdtoacpp">trunk/JavaScriptCore/kjs/dtoa.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (23954 => 23955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog 2007-07-03 21:21:56 UTC (rev 23954)
+++ trunk/JavaScriptCore/ChangeLog 2007-07-03 21:35:25 UTC (rev 23955)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-07-03 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Brady Eidson.
+
+ Tenth round of fixes for implicit 64-32 bit conversion errors.
+ <rdar://problem/5292262>
+
+ - Add explicit casts.
+
+ * kjs/dtoa.cpp:
+ (Bigint::):
+
</ins><span class="cx"> 2007-07-02 Sam Weinig <sam@webkit.org>
</span><span class="cx">
</span><span class="cx"> Reviewed by Kevin McCullough.
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsdtoacpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/dtoa.cpp (23954 => 23955)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/dtoa.cpp 2007-07-03 21:21:56 UTC (rev 23954)
+++ trunk/JavaScriptCore/kjs/dtoa.cpp 2007-07-03 21:35:25 UTC (rev 23955)
</span><span class="lines">@@ -595,7 +595,7 @@
</span><span class="cx"> #ifdef ULLong
</span><span class="cx"> y = *x * (ULLong)m + carry;
</span><span class="cx"> carry = y >> 32;
</span><del>- *x++ = y & FFFFFFFF;
</del><ins>+ *x++ = (ULong)y & FFFFFFFF;
</ins><span class="cx"> #else
</span><span class="cx"> #ifdef Pack_32
</span><span class="cx"> xi = *x;
</span><span class="lines">@@ -618,7 +618,7 @@
</span><span class="cx"> Bfree(b);
</span><span class="cx"> b = b1;
</span><span class="cx"> }
</span><del>- b->x[wds++] = carry;
</del><ins>+ b->x[wds++] = (ULong)carry;
</ins><span class="cx"> b->wds = wds;
</span><span class="cx"> }
</span><span class="cx"> return b;
</span><span class="lines">@@ -809,10 +809,10 @@
</span><span class="cx"> do {
</span><span class="cx"> z = *x++ * (ULLong)y + *xc + carry;
</span><span class="cx"> carry = z >> 32;
</span><del>- *xc++ = z & FFFFFFFF;
</del><ins>+ *xc++ = (ULong)z & FFFFFFFF;
</ins><span class="cx"> }
</span><span class="cx"> while(x < xae);
</span><del>- *xc = carry;
</del><ins>+ *xc = (ULong)carry;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> #else
</span><span class="lines">@@ -1072,13 +1072,13 @@
</span><span class="cx"> do {
</span><span class="cx"> y = (ULLong)*xa++ - *xb++ - borrow;
</span><span class="cx"> borrow = y >> 32 & (ULong)1;
</span><del>- *xc++ = y & FFFFFFFF;
</del><ins>+ *xc++ = (ULong)y & FFFFFFFF;
</ins><span class="cx"> }
</span><span class="cx"> while(xb < xbe);
</span><span class="cx"> while(xa < xae) {
</span><span class="cx"> y = *xa++ - borrow;
</span><span class="cx"> borrow = y >> 32 & (ULong)1;
</span><del>- *xc++ = y & FFFFFFFF;
</del><ins>+ *xc++ = (ULong)y & FFFFFFFF;
</ins><span class="cx"> }
</span><span class="cx"> #else
</span><span class="cx"> #ifdef Pack_32
</span><span class="lines">@@ -2469,7 +2469,7 @@
</span><span class="cx"> carry = ys >> 32;
</span><span class="cx"> y = *bx - (ys & FFFFFFFF) - borrow;
</span><span class="cx"> borrow = y >> 32 & (ULong)1;
</span><del>- *bx++ = y & FFFFFFFF;
</del><ins>+ *bx++ = (ULong)y & FFFFFFFF;
</ins><span class="cx"> #else
</span><span class="cx"> #ifdef Pack_32
</span><span class="cx"> si = *sx++;
</span><span class="lines">@@ -2510,7 +2510,7 @@
</span><span class="cx"> carry = ys >> 32;
</span><span class="cx"> y = *bx - (ys & FFFFFFFF) - borrow;
</span><span class="cx"> borrow = y >> 32 & (ULong)1;
</span><del>- *bx++ = y & FFFFFFFF;
</del><ins>+ *bx++ = (ULong)y & FFFFFFFF;
</ins><span class="cx"> #else
</span><span class="cx"> #ifdef Pack_32
</span><span class="cx"> si = *sx++;
</span></span></pre>
</div>
</div>
</body>
</html>