<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[24002] trunk/WebCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/24002">24002</a></dd>
<dt>Author</dt> <dd>aroben</dd>
<dt>Date</dt> <dd>2007-07-04 22:21:28 -0700 (Wed, 04 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>Mac, Qt, and Gdk build fixes.
* page/EventHandler.h:
* page/gdk/EventHandlerGdk.cpp:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passSubframeEventToSubframe):
* page/qt/EventHandlerQt.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorepageEventHandlerh">trunk/WebCore/page/EventHandler.h</a></li>
<li><a href="#trunkWebCorepagegdkEventHandlerGdkcpp">trunk/WebCore/page/gdk/EventHandlerGdk.cpp</a></li>
<li><a href="#trunkWebCorepagemacEventHandlerMacmm">trunk/WebCore/page/mac/EventHandlerMac.mm</a></li>
<li><a href="#trunkWebCorepageqtEventHandlerQtcpp">trunk/WebCore/page/qt/EventHandlerQt.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (24001 => 24002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-07-05 03:23:48 UTC (rev 24001)
+++ trunk/WebCore/ChangeLog 2007-07-05 05:21:28 UTC (rev 24002)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2007-07-04 Adam Roben <aroben@apple.com>
</span><span class="cx">
</span><ins>+ Mac, Qt, and Gdk build fixes.
+
+ * page/EventHandler.h:
+ * page/gdk/EventHandlerGdk.cpp:
+ * page/mac/EventHandlerMac.mm:
+ (WebCore::EventHandler::passSubframeEventToSubframe):
+ * page/qt/EventHandlerQt.cpp:
+
+2007-07-04 Adam Roben <aroben@apple.com>
+
</ins><span class="cx"> Fix the Qt/Gdk builds.
</span><span class="cx">
</span><span class="cx"> * page/gdk/EventHandlerGdk.cpp:
</span></span></pre></div>
<a id="trunkWebCorepageEventHandlerh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/EventHandler.h (24001 => 24002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/EventHandler.h 2007-07-05 03:23:48 UTC (rev 24001)
+++ trunk/WebCore/page/EventHandler.h 2007-07-05 05:21:28 UTC (rev 24002)
</span><span class="lines">@@ -228,7 +228,7 @@
</span><span class="cx"> bool passMouseMoveEventToSubframe(MouseEventWithHitTestResults&, Frame* subframe, HitTestResult* hoveredNode = 0);
</span><span class="cx"> bool passMouseReleaseEventToSubframe(MouseEventWithHitTestResults&, Frame* subframe);
</span><span class="cx">
</span><del>- bool passSubframeEventToSubframe(MouseEventWithHitTestResults&, Frame* subframe);
</del><ins>+ bool passSubframeEventToSubframe(MouseEventWithHitTestResults&, Frame* subframe, HitTestResult* hoveredNode = 0);
</ins><span class="cx">
</span><span class="cx"> bool passMousePressEventToScrollbar(MouseEventWithHitTestResults&, PlatformScrollbar*);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebCorepagegdkEventHandlerGdkcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/gdk/EventHandlerGdk.cpp (24001 => 24002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/gdk/EventHandlerGdk.cpp 2007-07-05 03:23:48 UTC (rev 24001)
+++ trunk/WebCore/page/gdk/EventHandlerGdk.cpp 2007-07-05 05:21:28 UTC (rev 24002)
</span><span class="lines">@@ -91,7 +91,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe)
</del><ins>+bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe, HitTestResult*)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkWebCorepagemacEventHandlerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/mac/EventHandlerMac.mm (24001 => 24002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/mac/EventHandlerMac.mm 2007-07-05 03:23:48 UTC (rev 24001)
+++ trunk/WebCore/page/mac/EventHandlerMac.mm 2007-07-05 05:21:28 UTC (rev 24002)
</span><span class="lines">@@ -369,13 +369,16 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe)
</del><ins>+bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe, HitTestResult* hoveredNode)
</ins><span class="cx"> {
</span><span class="cx"> BEGIN_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx">
</span><span class="cx"> switch ([currentEvent().get() type]) {
</span><span class="cx"> case NSMouseMoved:
</span><del>- subframe->eventHandler()->mouseMoved(currentEvent().get());
</del><ins>+ // Since we're passing in currentEvent() here, we can call
+ // handleMouseMoveEvent() directly, since the save/restore of
+ // currentEvent() that mouseMoved() does would have no effect.
+ subframe->eventHandler()->handleMouseMoveEvent(currentEvent().get(), hoveredNode);
</ins><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> case NSLeftMouseDown: {
</span></span></pre></div>
<a id="trunkWebCorepageqtEventHandlerQtcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/qt/EventHandlerQt.cpp (24001 => 24002)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/qt/EventHandlerQt.cpp 2007-07-05 03:23:48 UTC (rev 24001)
+++ trunk/WebCore/page/qt/EventHandlerQt.cpp 2007-07-05 05:21:28 UTC (rev 24002)
</span><span class="lines">@@ -108,7 +108,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe)
</del><ins>+bool EventHandler::passSubframeEventToSubframe(MouseEventWithHitTestResults& event, Frame* subframe, HitTestResult*)
</ins><span class="cx"> {
</span><span class="cx"> notImplemented();
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>