<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[23996] trunk/WebCore</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/23996">23996</a></dd>
<dt>Author</dt> <dd>aroben</dd>
<dt>Date</dt> <dd>2007-07-04 20:00:03 -0700 (Wed, 04 Jul 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>Changed PlatformMouseEvent to store the modifier flags of the event
Reviewed by Sam.
* platform/PlatformMouseEvent.h:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/win/PlatformMouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformPlatformMouseEventh">trunk/WebCore/platform/PlatformMouseEvent.h</a></li>
<li><a href="#trunkWebCoreplatformmacPlatformMouseEventMacmm">trunk/WebCore/platform/mac/PlatformMouseEventMac.mm</a></li>
<li><a href="#trunkWebCoreplatformwinPlatformMouseEventWincpp">trunk/WebCore/platform/win/PlatformMouseEventWin.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (23995 => 23996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-07-05 02:59:52 UTC (rev 23995)
+++ trunk/WebCore/ChangeLog 2007-07-05 03:00:03 UTC (rev 23996)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2007-07-04 Adam Roben <aroben@apple.com>
</span><span class="cx">
</span><ins>+ Changed PlatformMouseEvent to store the modifier flags of the event
+
+ Reviewed by Sam.
+
+ * platform/PlatformMouseEvent.h:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/mac/PlatformMouseEventMac.mm:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+ * platform/win/PlatformMouseEventWin.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent):
+
+2007-07-04 Adam Roben <aroben@apple.com>
+
</ins><span class="cx"> Add HitTestResult::setToNonShadowAncestor
</span><span class="cx">
</span><span class="cx"> Reviewed by Sam.
</span></span></pre></div>
<a id="trunkWebCoreplatformPlatformMouseEventh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/PlatformMouseEvent.h (23995 => 23996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/PlatformMouseEvent.h 2007-07-05 02:59:52 UTC (rev 23995)
+++ trunk/WebCore/platform/PlatformMouseEvent.h 2007-07-05 03:00:03 UTC (rev 23996)
</span><span class="lines">@@ -73,6 +73,7 @@
</span><span class="cx"> , m_altKey(false)
</span><span class="cx"> , m_metaKey(false)
</span><span class="cx"> , m_timestamp(0)
</span><ins>+ , m_modifierFlags(0)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -86,6 +87,7 @@
</span><span class="cx"> , m_altKey(alt)
</span><span class="cx"> , m_metaKey(meta)
</span><span class="cx"> , m_timestamp(timestamp)
</span><ins>+ , m_modifierFlags(0)
</ins><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -101,6 +103,7 @@
</span><span class="cx"> bool ctrlKey() const { return m_ctrlKey; }
</span><span class="cx"> bool altKey() const { return m_altKey; }
</span><span class="cx"> bool metaKey() const { return m_metaKey; }
</span><ins>+ unsigned modifierFlags() const { return m_modifierFlags; }
</ins><span class="cx">
</span><span class="cx"> //time in seconds
</span><span class="cx"> double timestamp() const { return m_timestamp; }
</span><span class="lines">@@ -132,6 +135,7 @@
</span><span class="cx"> bool m_altKey;
</span><span class="cx"> bool m_metaKey;
</span><span class="cx"> double m_timestamp; // unit: seconds
</span><ins>+ unsigned m_modifierFlags;
</ins><span class="cx"> #if PLATFORM(MAC)
</span><span class="cx"> int m_eventNumber;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkWebCoreplatformmacPlatformMouseEventMacmm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/mac/PlatformMouseEventMac.mm (23995 => 23996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/mac/PlatformMouseEventMac.mm 2007-07-05 02:59:52 UTC (rev 23995)
+++ trunk/WebCore/platform/mac/PlatformMouseEventMac.mm 2007-07-05 03:00:03 UTC (rev 23996)
</span><span class="lines">@@ -169,6 +169,7 @@
</span><span class="cx"> , m_altKey([event modifierFlags] & NSAlternateKeyMask)
</span><span class="cx"> , m_metaKey([event modifierFlags] & NSCommandKeyMask)
</span><span class="cx"> , m_timestamp([event timestamp])
</span><ins>+ , m_modifierFlags([event modifierFlags])
</ins><span class="cx"> , m_eventNumber([event eventNumber])
</span><span class="cx"> {
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebCoreplatformwinPlatformMouseEventWincpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/win/PlatformMouseEventWin.cpp (23995 => 23996)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/win/PlatformMouseEventWin.cpp 2007-07-05 02:59:52 UTC (rev 23995)
+++ trunk/WebCore/platform/win/PlatformMouseEventWin.cpp 2007-07-05 03:00:03 UTC (rev 23996)
</span><span class="lines">@@ -82,6 +82,7 @@
</span><span class="cx"> , m_metaKey(m_altKey) // FIXME: We'll have to test other browsers
</span><span class="cx"> , m_activatedWebView(activatedWebView)
</span><span class="cx"> , m_eventType(messageToEventType(message))
</span><ins>+ , m_modifierFlags(wParam)
</ins><span class="cx"> {
</span><span class="cx"> m_timestamp = ::GetTickCount()*0.001; // GetTickCount returns milliseconds
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>