<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[24827] trunk/WebKit</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/24827">24827</a></dd>
<dt>Author</dt> <dd>beidson</dd>
<dt>Date</dt> <dd>2007-08-02 13:08:15 -0700 (Thu, 02 Aug 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre> Reviewed by Tim
<rdar://problem/5381463> - setMIMETypesShownAsHTML mutates while enumerating
* WebView/WebView.mm:
(+[WebView setMIMETypesShownAsHTML:]): Copy the dictionary before we work with it.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitChangeLog">trunk/WebKit/ChangeLog</a></li>
<li><a href="#trunkWebKitWebViewWebViewmm">trunk/WebKit/WebView/WebView.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/ChangeLog (24826 => 24827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/ChangeLog 2007-08-02 18:24:05 UTC (rev 24826)
+++ trunk/WebKit/ChangeLog 2007-08-02 20:08:15 UTC (rev 24827)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2007-08-02 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Tim
+
+ <rdar://problem/5381463> - setMIMETypesShownAsHTML mutates while enumerating
+
+ * WebView/WebView.mm:
+ (+[WebView setMIMETypesShownAsHTML:]): Copy the dictionary before we work with it.
+
</ins><span class="cx"> 2007-08-02 Alice Liu <alice.liu@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Kevin McCullough.
</span></span></pre></div>
<a id="trunkWebKitWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/WebView/WebView.mm (24826 => 24827)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/WebView/WebView.mm 2007-08-02 18:24:05 UTC (rev 24826)
+++ trunk/WebKit/WebView/WebView.mm 2007-08-02 20:08:15 UTC (rev 24827)
</span><span class="lines">@@ -1726,7 +1726,7 @@
</span><span class="cx">
</span><span class="cx"> + (void)setMIMETypesShownAsHTML:(NSArray *)MIMETypes
</span><span class="cx"> {
</span><del>- NSMutableDictionary *viewTypes = [WebFrameView _viewTypesAllowImageTypeOmission:YES];
</del><ins>+ NSDictionary *viewTypes = [[WebFrameView _viewTypesAllowImageTypeOmission:YES] copy];
</ins><span class="cx"> NSEnumerator *enumerator = [viewTypes keyEnumerator];
</span><span class="cx"> id key;
</span><span class="cx"> while ((key = [enumerator nextObject])) {
</span><span class="lines">@@ -1740,6 +1740,7 @@
</span><span class="cx"> representationClass:[WebHTMLRepresentation class]
</span><span class="cx"> forMIMEType:[MIMETypes objectAtIndex:i]];
</span><span class="cx"> }
</span><ins>+ [viewTypes release];
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> + (NSURL *)URLFromPasteboard:(NSPasteboard *)pasteboard
</span></span></pre>
</div>
</div>
</body>
</html>