<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[24822] trunk/LayoutTests</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/24822">24822</a></dd>
<dt>Author</dt> <dd>bdash</dd>
<dt>Date</dt> <dd>2007-08-02 03:01:46 -0700 (Thu, 02 Aug 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>2007-08-02 Mark Rowe <mrowe@apple.com>
Layout test fix, rubber-stamped by Oliver.
* fast/js/resources/string-concatenate-outofmemory.js: Don't let an out of memory exception during verification cause a failure.
The exception is a perfectly valid success case as it shows that access the string did not cause a crash.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastjsresourcesstringconcatenateoutofmemoryjs">trunk/LayoutTests/fast/js/resources/string-concatenate-outofmemory.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (24821 => 24822)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-08-02 09:49:12 UTC (rev 24821)
+++ trunk/LayoutTests/ChangeLog 2007-08-02 10:01:46 UTC (rev 24822)
</span><span class="lines">@@ -1,5 +1,12 @@
</span><span class="cx"> 2007-08-02 Mark Rowe <mrowe@apple.com>
</span><span class="cx">
</span><ins>+ Layout test fix, rubber-stamped by Oliver.
+
+ * fast/js/resources/string-concatenate-outofmemory.js: Don't let an out of memory exception during verification cause a failure.
+ The exception is a perfectly valid success case as it shows that access the string did not cause a crash.
+
+2007-08-02 Mark Rowe <mrowe@apple.com>
+
</ins><span class="cx"> Reviewed by Maciej.
</span><span class="cx">
</span><span class="cx"> <rdar://problem/5352887> "Out of memory" error during repeated JS string concatenation leaks hundreds of MBs of RAM
</span></span></pre></div>
<a id="trunkLayoutTestsfastjsresourcesstringconcatenateoutofmemoryjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/js/resources/string-concatenate-outofmemory.js (24821 => 24822)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/js/resources/string-concatenate-outofmemory.js 2007-08-02 09:49:12 UTC (rev 24821)
+++ trunk/LayoutTests/fast/js/resources/string-concatenate-outofmemory.js 2007-08-02 10:01:46 UTC (rev 24822)
</span><span class="lines">@@ -14,8 +14,8 @@
</span><span class="cx"> function ensureStringIsUsable(testName, stringName, str) {
</span><span class="cx"> str[str.length - 1];
</span><span class="cx"> try { [str, str].join(str); } catch (o) { }
</span><del>- "a" + str;
- str + "a";
</del><ins>+ try { "a" + str; } catch (o) { }
+ try { str + "a"; } catch (o) { }
</ins><span class="cx"> debug('PASS: String ' + stringName + ' was functional after ' + testName + ' raised out of memory exception.');
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -39,6 +39,7 @@
</span><span class="cx"> ensureStringIsUsable('expandPreCapacity', 's', s);
</span><span class="cx"> ensureStringIsUsable('expandPreCapacity', 't', t);
</span><span class="cx"> }
</span><ins>+delete t;
</ins><span class="cx">
</span><span class="cx"> s = "a";
</span><span class="cx"> try {
</span></span></pre>
</div>
</div>
</body>
</html>