<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[24857] trunk</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/24857">24857</a></dd>
<dt>Author</dt> <dd>adele</dd>
<dt>Date</dt> <dd>2007-08-03 15:15:13 -0700 (Fri, 03 Aug 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>LayoutTests:
Reviewed by Adele.
- test for http://bugs.webkit.org/show_bug.cgi?id=14879
REGRESSION: First item in select (pop-up menu) is displayed even if another item was selected via JavaScript
* fast/forms/menulist-deselect-update-expected.checksum: Added.
* fast/forms/menulist-deselect-update-expected.png: Added.
* fast/forms/menulist-deselect-update-expected.txt: Added.
* fast/forms/menulist-deselect-update.html: Added.
WebCore:
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=14879
REGRESSION: First item in select (pop-up menu) is displayed even if another item was selected via JavaScript
Test: fast/forms/menulist-deselect-update.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelected): Reordered to allow setSelectedIndex() to call setChanged().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorehtmlHTMLOptionElementcpp">trunk/WebCore/html/HTMLOptionElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastformsmenulistdeselectupdateexpectedchecksum">trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.checksum</a></li>
<li><a href="#trunkLayoutTestsfastformsmenulistdeselectupdateexpectedpng">trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.png</a></li>
<li><a href="#trunkLayoutTestsfastformsmenulistdeselectupdateexpectedtxt">trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastformsmenulistdeselectupdatehtml">trunk/LayoutTests/fast/forms/menulist-deselect-update.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (24856 => 24857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2007-08-03 21:42:35 UTC (rev 24856)
+++ trunk/LayoutTests/ChangeLog 2007-08-03 22:15:13 UTC (rev 24857)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2007-08-03 Mitz Pettel <mitz@webkit.org>
</span><span class="cx">
</span><ins>+ Reviewed by Adele.
+
+ - test for http://bugs.webkit.org/show_bug.cgi?id=14879
+ REGRESSION: First item in select (pop-up menu) is displayed even if another item was selected via JavaScript
+
+ * fast/forms/menulist-deselect-update-expected.checksum: Added.
+ * fast/forms/menulist-deselect-update-expected.png: Added.
+ * fast/forms/menulist-deselect-update-expected.txt: Added.
+ * fast/forms/menulist-deselect-update.html: Added.
+
+2007-08-03 Mitz Pettel <mitz@webkit.org>
+
</ins><span class="cx"> Reviewed by Darin.
</span><span class="cx">
</span><span class="cx"> - test for http://bugs.webkit.org/show_bug.cgi?id=14653
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsmenulistdeselectupdateexpectedchecksum"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.checksum (0 => 24857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.checksum (rev 0)
+++ trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.checksum 2007-08-03 22:15:13 UTC (rev 24857)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+e1cebbfd3b9c4fa9b331816c3dec641b
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastformsmenulistdeselectupdateexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.png
</span><span class="cx">___________________________________________________________________
</span><span class="cx">Name: svn:mime-type
</span><span class="cx"> + application/octet-stream
</span><a id="trunkLayoutTestsfastformsmenulistdeselectupdateexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.txt (0 => 24857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/menulist-deselect-update-expected.txt 2007-08-03 22:15:13 UTC (rev 24857)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (0,1) size 73x18
+ text run at (0,1) width 73: "Test result: "
+ RenderMenuList {SELECT} at (75,2) size 57x18 [bgcolor=#FFFFFF]
+ RenderBlock (anonymous) at (0,0) size 57x18
+ RenderText at (8,2) size 26x13
+ text run at (8,2) width 26: "PASS"
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
</ins></span></pre></div>
<a id="trunkLayoutTestsfastformsmenulistdeselectupdatehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/forms/menulist-deselect-update.html (0 => 24857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/forms/menulist-deselect-update.html (rev 0)
+++ trunk/LayoutTests/fast/forms/menulist-deselect-update.html 2007-08-03 22:15:13 UTC (rev 24857)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+Test result:
+<select id="target">
+ <option>FAIL</option>
+ <option>PASS</option>
+</select>
+<script type="text/javascript">
+ var select = document.getElementById("target");
+ select.offsetTop;
+
+ var opts = select.options;
+ opts[0].selected = false;
+ opts[1].selected = true;
+</script>
</ins></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (24856 => 24857)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog 2007-08-03 21:42:35 UTC (rev 24856)
+++ trunk/WebCore/ChangeLog 2007-08-03 22:15:13 UTC (rev 24857)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2007-08-03 Mitz Pettel <mitz@webkit.org>
+
+ Reviewed by Adele.
+
+ - fix http://bugs.webkit.org/show_bug.cgi?id=14879
+ REGRESSION: First item in select (pop-up menu) is displayed even if another item was selected via JavaScript
+
+ Test: fast/forms/menulist-deselect-update.html
+
+ * html/HTMLOptionElement.cpp:
+ (WebCore::HTMLOptionElement::setSelected): Reordered to allow setSelectedIndex() to call setChanged().
+
</ins><span class="cx"> 2007-08-03 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Reviewed by Darin.
</span></span></pre></div>
<a id="trunkWebCorehtmlHTMLOptionElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/html/HTMLOptionElement.cpp ( => )</h4>
<pre class="diff"><span>
<span class="info">
</span></span></pre>
</div>
</div>
</body>
</html>