<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[24853] S60/trunk/WebKit</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/24853">24853</a></dd>
<dt>Author</dt> <dd>spadma</dd>
<dt>Date</dt> <dd>2007-08-03 14:21:03 -0700 (Fri, 03 Aug 2007)</dd>
</dl>
<h3>Log Message</h3>
<pre>yadavall, reviewed by <sachin.padma@nokia.com>
DESC: Center key press must be sent to Engine
http://bugs.webkit.org/show_bug.cgi?id=14593
* BrowserView/src/KeyEventHandler.cpp:
(CKeyEventHandler::HandleOfferKeyEventL):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#S60trunkWebKitBrowserViewsrcKeyEventHandlercpp">S60/trunk/WebKit/BrowserView/src/KeyEventHandler.cpp</a></li>
<li><a href="#S60trunkWebKitChangeLog">S60/trunk/WebKit/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="S60trunkWebKitBrowserViewsrcKeyEventHandlercpp"></a>
<div class="modfile"><h4>Modified: S60/trunk/WebKit/BrowserView/src/KeyEventHandler.cpp (24852 => 24853)</h4>
<pre class="diff"><span>
<span class="info">--- S60/trunk/WebKit/BrowserView/src/KeyEventHandler.cpp 2007-08-03 21:04:56 UTC (rev 24852)
+++ S60/trunk/WebKit/BrowserView/src/KeyEventHandler.cpp 2007-08-03 21:21:03 UTC (rev 24853)
</span><span class="lines">@@ -187,8 +187,12 @@
</span><span class="cx"> CWebKitFrame* focused = iWebKitView->MainFrame().FocusedFrame();
</span><span class="cx"> if (iWebKitView->TabbedNavigation() && !iWebKitView->WebKitControl().InPageViewMode() && focused)
</span><span class="cx"> {
</span><del>- // send keyevent to the webcore
- focused->WebKitBridge().WebCoreBridge().KeyEvent(iLastEventKey,EFalse);
</del><ins>+ // send keyevent to the webcore & if webcore has consumed the event then there is no need to
+ // apply our navigation mechanism, hence return
+ if (focused->WebKitBridge().WebCoreBridge().KeyEvent(iLastEventKey,EFalse))
+ {
+ return EKeyWasConsumed;
+ }
</ins><span class="cx"> }
</span><span class="cx"> keyResponse = HandleArrowKeysL(aKeyEvent);
</span><span class="cx"> break;
</span><span class="lines">@@ -203,12 +207,13 @@
</span><span class="cx"> DHTML pages. Also, toolbar is activated when the user is not in fast scroll mode or in page overview mode
</span><span class="cx"> */
</span><span class="cx"> if( iElType == TBrCtlDefs::EElementNone
</span><ins>+ && !iWebKitView->TabbedNavigation()
</ins><span class="cx"> && iWebKitView->FocusedElementType() == TBrCtlDefs::EElementNone
</span><span class="cx"> && aKeyEvent.iRepeats
</span><span class="cx"> && iWebKitView->Cursor()
</span><span class="cx"> && iWebKitView->WebKitControl().BrCtl().Capabilities() & TBrCtlDefs::ECapabilityToolBar
</span><span class="cx"> && !iJoystickTimer->IsActive()
</span><del>- && !iWebKitView->WebKitControl().InPageViewMode()
</del><ins>+ && !iWebKitView->WebKitControl().InPageViewMode()
</ins><span class="cx"> )
</span><span class="cx"> {
</span><span class="cx"> iWebKitView->LaunchToolBarL();
</span><span class="lines">@@ -232,6 +237,16 @@
</span><span class="cx"> f->WebKitBridge().WebCoreBridge().PointerEvent(event);
</span><span class="cx"> return EKeyWasConsumed;
</span><span class="cx"> }
</span><ins>+
+ CWebKitFrame* focused = iWebKitView->MainFrame().FocusedFrame();
+ if (iWebKitView->TabbedNavigation() && !iWebKitView->WebKitControl().InPageViewMode() && focused)
+ {
+ // send keyevent to the webcore & if webcore has consumed the event then set keyResponse
+ if (focused->WebKitBridge().WebCoreBridge().KeyEvent(iLastEventKey,EFalse))
+ {
+ return EKeyWasConsumed;
+ }
+ }
</ins><span class="cx"> // fake key event down
</span><span class="cx"> keyResponse = HandleActivateKeysL( aKeyEvent, EEventKeyDown );
</span><span class="cx"> break;
</span></span></pre></div>
<a id="S60trunkWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: S60/trunk/WebKit/ChangeLog (24852 => 24853)</h4>
<pre class="diff"><span>
<span class="info">--- S60/trunk/WebKit/ChangeLog 2007-08-03 21:04:56 UTC (rev 24852)
+++ S60/trunk/WebKit/ChangeLog 2007-08-03 21:21:03 UTC (rev 24853)
</span><span class="lines">@@ -1,3 +1,10 @@
</span><ins>+yadavall, reviewed by <sachin.padma@nokia.com>
+ DESC: Center key press must be sent to Engine
+ http://bugs.webkit.org/show_bug.cgi?id=14593
+
+ * BrowserView/src/KeyEventHandler.cpp:
+ (CKeyEventHandler::HandleOfferKeyEventL):
+
</ins><span class="cx"> lebril, reviewed by Sachin
</span><span class="cx"> DESC: ELFN-7535HR: Operator manu: Both time stamps in Link-1 and Link-2 are same when opening link is in Expires Date header 1A iteam
</span><span class="cx"> http://bugs.webkit.org/show_bug.cgi?id=
</span></span></pre>
</div>
</div>
</body>
</html>