From susanne50432xinghao at LYCOS.ru Sat Jul 1 16:23:04 2006 From: susanne50432xinghao at LYCOS.ru (Faxon) Date: Tue Oct 9 17:56:31 2007 Subject: [webkit-reviews] re[9]: Don't get left behind, get phermones Message-ID: Remember how you felt when your dream girl shot you down? Well now you never have to feel that way again! Pheromones have been proven to work, and are guaranted to increase your attractiveness to women of all ages. Just look at some of the testimonials we have received back from 100% satisfied repeat customers! : "I've always had a problem approaching girls. They would just walk past me like I didn't exist. I sometimes felt like they purposely would not give me any attention just because they were snobby and stuck up. Now, when I use Ultra Allure Pheromones, it's alot easier to approach girls because THEY are usually the ones that will smile at me first or make eye contact." Robert K, Boise Idaho "I saw you guys offered a moneyback guarantee, so I though I would give it a go(I had nothing to lose). Well how glad am I that I did! My first night out with a little Ultra Allure on me I had 4 different girls ask me what I was wearing and what I was doing later(I met up with the hottest of the 4 ;) ) Now I don't even leave the house without throwing on a few dabs of Ultra Allure- its my (not so) secret weapon! I can honestly say this product truly works, women are really drawn to you once they catch a little bit of the scent." Brad M. Kentucky We receive dozens of emails daily just like these ones! Don't be left out! Pheromones have been studied extensively and profiled on such media outlets as CNN, Oprah Winfrey show, ABC, MSNBC, FOXNEWS, and magazines such as MAXIM, FHM and PLAYBOY! Visit our website now to check out the huge discount sale going on right now! Hurry though as discount specials will be discontinued within the next few days! Remove you e-mail -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/294fa9a8/attachment.html From win0spiro at guy.com Sat Jul 1 00:22:41 2006 From: win0spiro at guy.com (yonah) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Fw[4]: /!agra GET IT HERE!!! Message-ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060701/a842112c/attachment.html From bugzilla-request-daemon at opendarwin.org Sat Jul 1 03:53:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_R?= =?iso-8859-1?q?eplace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701105349.4CA6B1961C6F@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit From wuqui at yahoo.co.jp Sat Jul 1 03:55:07 2006 From: wuqui at yahoo.co.jp (=?iso-2022-jp?B?ZmVodQ==?=) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?GyRCOiM3biF6JSQlQSUqJTcbKEI=?= =?iso-2022-jp?b?GyRCIXolMyUzGyhC?= Message-ID: <20060701105507.F32311961D1A@sampson.opendarwin.org> ???????????? http://13196.com/susume/ okusamanosusume gongxi2010@tom.com okusamanosusume From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:23:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060701132333.7DD6B1969800@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Note that there is a possible time/space tradeoff here: RenderBlock::computeHorizontalPositionsForLine() knows the offsetForAlignRight() when it sets the InlineTextBox's width, so an alternative fix would involve adding this offset as an InlineTextBox member and having computeHorizontalPositionsForLine() set it. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:33:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repl?= =?iso-8859-1?q?ace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133337.288C11969A3C@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:33:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repl?= =?iso-8859-1?q?ace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133337.F27C61969A3B@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:34:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_denied=3A_=5BBug_9674=5D_?= =?iso-8859-1?q?REGRESSION_=28r15075=29=3A_Blank_or_incomplete_page?= =?iso-8859-1?q?s_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repla?= =?iso-8859-1?q?ce_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133445.BC7ED1969A9F@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler Another fix is to save, set, and then restore the bit rather than setting and clearing it. I think that would be better. Is there any reason that wouldn't work? From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:06:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140631.E1FBC196B597@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com See my previous comment as to why I think the bit doesn't belong in State. Of course, if you prefer it that way, I can go all the way and put it back into State. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:06:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140631.83FAC196B59D@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com See my previous comment as to why I think the bit doesn't belong in State. Of course, if you prefer it that way, I can go all the way and put it back into State. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_cancelled=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140949.E2B7A196B741@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140950.51C25196B744@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_cancelled=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140949.53028196B745@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140950.2091C196B74C@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:38:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_Save?= =?iso-8859-1?q?_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701213824.CF871197BC64@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from Darin Adler I think of the m_state as a more-or-less arbitrary set of bits, so the argument about this bit being global state and hence "not part of state" doesn't seem very compelling to me. Your argument about a byte on the stack vs. a count in the tokenizer object is actually a pretty compelling one. It didn't occur to me that the stack cost can be paid over and over again as you recurse and there is only one tokenizer. I think that either the original fix or this one is fine. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:38:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_Save?= =?iso-8859-1?q?_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701213824.C9B01197BC68@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from Darin Adler I think of the m_state as a more-or-less arbitrary set of bits, so the argument about this bit being global state and hence "not part of state" doesn't seem very compelling to me. Your argument about a byte on the stack vs. a count in the tokenizer object is actually a pretty compelling one. It didn't occur to me that the stack cost can be paid over and over again as you recurse and there is only one tokenizer. I think that either the original fix or this one is fine. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:49:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060701214948.00224197BF7A@sampson.opendarwin.org> Nicholas Shanks has asked Alexey Proskuryakov for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit ------- Additional Comments from Nicholas Shanks This patch doesn't have layout tests yet, and only does "odd" and "even" as I've not looked up how to convert the QString methods KHTML used for an+b yet. Posting here so that people who have a faster computer can compile it and tell me if it works. :-) From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:49:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060701214948.F22FE197BF79@sampson.opendarwin.org> Nicholas Shanks has asked Alexey Proskuryakov for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit ------- Additional Comments from Nicholas Shanks This patch doesn't have layout tests yet, and only does "odd" and "even" as I've not looked up how to convert the QString methods KHTML used for an+b yet. Posting here so that people who have a faster computer can compile it and tell me if it works. :-) From bugzilla-request-daemon at opendarwin.org Sat Jul 1 15:11:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060701221138.8903F197D433@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Björn Graf (boki) The workaround checks the arguments for infinity and only calls fmod when the divisor is not infinite. Otherwise it returns the dividend. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 15:13:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060701221303.F11A1197D4F5@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis The patch fixes the bug for me. I can do testcase(s) if the code gets okayed in the first place :-) Cheers, Rob. From replybns at yahoo.com Sat Jul 1 20:48:52 2006 From: replybns at yahoo.com (slim2uhealthcare@yahoo.com) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=BC=CD=C1=B6=D2=C7=C3_=BC=CD=C1?= =?iso-8859-1?q?=B6=D2=C7=C3_=BC=CD=C1=B6=D2=C7=C3_=C3=D1=BA=C3=CD?= =?iso-8859-1?q?=A7=BC=C5=C5=D1=BE=B7=EC_=E4=C1=E8=A1=C5=D1=BA=C1?= =?iso-8859-1?q?=D2=CD=E9=C7=B9=CD=D5=A1?= Message-ID: <20060702034857.8D39C1988966@sampson.opendarwin.org> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/49d9a914/attachment.html From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:35:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053528.555E3198D151@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit ------- Additional Comments from Timothy Hatcher r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053603.6CE0F198D21A@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053603.BDF7F198D265@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:48:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702054807.CF846198E240@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:04:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702060415.A52971990402@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:29:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702062908.EBCA619916E0@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702065748.1D6C21992505@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702065748.A8ABF19935CF@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702065748.9612319935CE@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 00:05:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702070528.C51AD19935D3@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit ------- Additional Comments from Timothy Hatcher This looks good now. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 00:05:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702070528.BE20F19935D1@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit ------- Additional Comments from Timothy Hatcher This looks good now. From bolt166 at og.plala.or.jp Sun Jul 2 03:52:49 2006 From: bolt166 at og.plala.or.jp (‹e’r —Žq) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=E6=82=EB=82=B5=82=AD=82=A8?= =?iso-8859-1?q?=8A=E8=82=A2=82=B5=82=DC=82=B7?= Message-ID: <06019375.986178.0491@acclimate-anb85.aol.com> ‚·„«‚ׄ«‚Ä„«‚ª„«–³„«—¿„«I„«Š®„«‘S„«–³„«—¿„«ƒT„«ƒC„«ƒg„« „ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„® @@@ˆú—Œn—«‚Ì“o˜^‚ª‘½‚­‚Ä‘ål‹C‚ÌŠ®‘S–³—¿ƒTƒCƒg @@@–Ú“I‚ªˆê‚¾‚©‚瑦ƒAƒ|A‘¦ƒnƒ‚ª“–‚½‚è‘Oô@ @@šŠ„‚èØ‚Á‚½ŒðÛšlȂƂ̔閧‚ÌŒðÛš‚R‚oŠó–]š @@@@@@—lX‚È—«‚ª“o˜^‚µ‚Ä‚¨‚è‚Ü‚·I Š®‘S–³—¿“üŒûË@http://5596.cc?seadx „¬„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš „«ƒŒƒfƒBƒRƒ~ƒbƒNŽ‘½”ŒfÚ’†š—«“o˜^”‹}㸒†II„« š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„® Š®‘S–³—¿“üŒûË@http://5596.cc?seadx @@@@@@@@Ÿs—«“o˜^ˆê•”‚²Ð‰îtŸ ™-----™„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ™-----™ @@–¼‘OFˆŸ”ü@@@@E‹ÆF‚n‚k@@@ƒXƒ^ƒCƒ‹F‹“û @@”N—îF‚Q‚SÎ@@@Šó–]F”é–§@@@ƒ^ƒCƒvF‚©‚í‚¢‚¢Œn ™„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš ‚o‚qF–é‚É‚È‚é‚ƃ€ƒ‰ƒ€ƒ‰‚µ‚Ä‚­‚鎖‚Á‚Ä‚ ‚è‚Ü‚¹‚ñ‚©HHH @@@ @@@Ž„‚Í¡‚»‚¤‚Å‚·c(;_;)‘ŠŽè‚ª‚¢‚È‚¢‚Ì‚Å—­‚Ü‚Á‚Ä‚Ü‚·c @@@’N‚©‘ŠŽè‚µ‚Ä‚­‚ê‚é‚©‚ÈHHHƒAƒhƒŒƒXŒðŠ·AŽÊƒŒðŠ· @@@o—ˆ‚Ü‚·Bƒ[ƒ‹‘Ò‚Á‚Ä‚Ü‚·B @@@@@ @@@Š®‘S–³—¿“üŒûË@http://5596.cc?seadx ™„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš@@ @@@@@@ From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:09:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702120917.498D319A0B5A@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:11:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702121100.EB62619A0BD3@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:11:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702121101.039B619A0BD5@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:49:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702124951.F0B8119A1AFB@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:56:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702125623.3F6D119A1C34@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:56:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702125623.DECA819A1C30@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:52:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702165222.103D819AA7D8@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:52:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702165222.DA01119AAA14@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:58:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060702165819.E888D19AAA17@sampson.opendarwin.org> Alexey Proskuryakov has cancelled Nicholas Shanks 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:58:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060702165819.EC82919AAA18@sampson.opendarwin.org> Alexey Proskuryakov has cancelled Nicholas Shanks 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 10:58:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702175843.D2E6019ACEF1@sampson.opendarwin.org> Justin Haygood has asked for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060702200922.6627C19B40CB@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060702200922.7277019B40CF@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060702200922.1C15519B40D7@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From fmihm at snip.net Sun Jul 2 13:19:38 2006 From: fmihm at snip.net (fmihm@snip.net) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Returned mail: Data format error Message-ID: <20060702201951.8238219B4406@sampson.opendarwin.org> -------------- next part -------------- A non-text attachment was scrubbed... Name: yfkw.zip Type: application/octet-stream Size: 41202 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/4b0ea912/yfkw.obj From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:34:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060702203411.4CE6D19B4B75@sampson.opendarwin.org> Nicholas Shanks has asked Dave Hyatt for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit ------- Additional Comments from Nicholas Shanks Does not attempt to support (an+b) yet, nor have functional implementations of nth-last-* as we are awaiting a decision from hyatt on how to implement :last-child and related pseudo classes. an+b support will come in another patch to be posted to this bug later in the week. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:34:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060702203411.61B3819B4B7B@sampson.opendarwin.org> Nicholas Shanks has asked Dave Hyatt for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit ------- Additional Comments from Nicholas Shanks Does not attempt to support (an+b) yet, nor have functional implementations of nth-last-* as we are awaiting a decision from hyatt on how to implement :last-child and related pseudo classes. an+b support will come in another patch to be posted to this bug later in the week. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702204123.8CB5F19B4E7D@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702204123.C22AF19B54AF@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060702204123.CBFD119B54B0@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:55:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060702205540.D3D7419B54B1@sampson.opendarwin.org> David Carson has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from David Carson Added support for HSL and HSLA colors. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 15:15:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702221555.E488D19B8D04@sampson.opendarwin.org> Michael Emmel has asked for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:22:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702232201.6FEFA19BB94C@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit ------- Additional Comments from Geoffrey Garen Our style guidlines also call for splitting lines like this into two: + if (!stringIdentifierDictionary) stringIdentifierDictionary = new HashMap< const char *, PrivateIdentifier *>(); The patch looks correct overall. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:22:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702232201.6FD5D19BB953@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit ------- Additional Comments from Geoffrey Garen Our style guidlines also call for splitting lines like this into two: + if (!stringIdentifierDictionary) stringIdentifierDictionary = new HashMap< const char *, PrivateIdentifier *>(); The patch looks correct overall. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:24:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9617] wx port compile fixes : [Attachment 9116] patch, with ImageDocument refactored to separate out the Objective-C Message-ID: <20060702232429.16EEC19BB9FF@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9116: patch, with ImageDocument refactored to separate out the Objective-C http://bugzilla.opendarwin.org/attachment.cgi?id=9116&action=edit ------- Additional Comments from Geoffrey Garen r- for missing files From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:24:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9617] wx port compile fixes : [Attachment 9116] patch, with ImageDocument refactored to separate out the Objective-C Message-ID: <20060702232429.719EF19BBC28@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9116: patch, with ImageDocument refactored to separate out the Objective-C http://bugzilla.opendarwin.org/attachment.cgi?id=9116&action=edit ------- Additional Comments from Geoffrey Garen r- for missing files From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:30:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702233054.8853319BBC2A@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit ------- Additional Comments from Geoffrey Garen Looks fine to me. + if (!jobs->isEmpty()){ + m_downloadTimer.startOneShot(pollTimeSeconds); + } For future reference, our style guidelines call for single-line if statements to be written without curly braces: From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:30:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702233054.B46DD19BBC30@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit ------- Additional Comments from Geoffrey Garen Looks fine to me. + if (!jobs->isEmpty()){ + m_downloadTimer.startOneShot(pollTimeSeconds); + } For future reference, our style guidelines call for single-line if statements to be written without curly braces: From bugzilla-request-daemon at opendarwin.org Sun Jul 2 18:49:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703014922.AB89F19C0382@sampson.opendarwin.org> Justin Haygood has asked for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From yuh-jiun99549sherif at peugeot-club.org Sun Jul 2 21:02:13 2006 From: yuh-jiun99549sherif at peugeot-club.org (=?iso-8859-2?B?0S7ILg==?=) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Fw[]: Beware of imitators, this is the original men's phermone Message-ID: <41c901c69e55$6256726c$4a526125@peugeot-club.org> Remember how you felt when your dream girl shot you down? Well now you never have to feel that way again! Pheromones have been proven to work, and are guaranted to increase your attractiveness to women of all ages. Just look at some of the testimonials we have received back from 100% satisfied repeat customers! : "I've always had a problem approaching girls. They would just walk past me like I didn't exist. I sometimes felt like they purposely would not give me any attention just because they were snobby and stuck up. Now, when I use Ultra Allure Pheromones, it's alot easier to approach girls because THEY are usually the ones that will smile at me first or make eye contact." Robert K, Boise Idaho "I saw you guys offered a moneyback guarantee, so I though I would give it a go(I had nothing to lose). Well how glad am I that I did! My first night out with a little Ultra Allure on me I had 4 different girls ask me what I was wearing and what I was doing later(I met up with the hottest of the 4 ;) ) Now I don't even leave the house without throwing on a few dabs of Ultra Allure- its my (not so) secret weapon! I can honestly say this product truly works, women are really drawn to you once they catch a little bit of the scent." Brad M. Kentucky We receive dozens of emails daily just like these ones! Don't be left out! Pheromones have been studied extensively and profiled on such media outlets as CNN, Oprah Winfrey show, ABC, MSNBC, FOXNEWS, and magazines such as MAXIM, FHM and PLAYBOY! Visit our website now to check out the huge discount sale going on right now! Hurry though as discount specials will be discontinued within the next few days! Remove you e-mail -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/c779a427/attachment.html From conradcurran at cihost.com Sun Jul 2 20:41:05 2006 From: conradcurran at cihost.com (tam naquin) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Re: Your Luxury Message-ID: <00df01c69e51$da617f00$a068a989@jcwvqzky> TOP BRANDS - LOW LOW PRICES Jewelry * Handbags * Pens * Watches * Neckties * Clutches * Wallets Leather, silk and white gold sound good? Visit our site for real photos. Everything comes with a certificate, tags and all the extras, plus a warranty. http://reconnectrecords.com/luxury/ Cali yuga moor blackbird medley cloth self-checking swift-posting guide flag well-sorted world-taming marsh spike grass good fellow choir rail store clothes sailor suit leg art pince-nez thunder-tipped sea pig veil-hid upsy-freesy spatulate-leaved conico-ovate doubting mania globe ranunculus good morning single-line all-inclusiveness dowel bit -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/107da8c7/attachment.html From bugzilla-request-daemon at opendarwin.org Sun Jul 2 23:10:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703061050.28D8E19C982A@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 23:48:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703064801.AEDCB19CA575@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 00:49:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703074931.002E419CCB4F@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit ------- Additional Comments from Eric Seidel Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 00:49:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703074932.0D54419CCB51@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit ------- Additional Comments from Eric Seidel Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 01:08:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703080846.B857319CE0D6@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit ------- Additional Comments from Eric Seidel I think it would be cleaner to have a line ending array, or regex. Since you seem to be using the same copy/paste list all over the place. I guess the list of line endings isn't ever going to change though, so it's not a huge deal. Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 01:08:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703080846.9847A19CE0DE@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit ------- Additional Comments from Eric Seidel I think it would be cleaner to have a line ending array, or regex. Since you seem to be using the same copy/paste list all over the place. I guess the list of line endings isn't ever going to change though, so it's not a huge deal. Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060703134516.74A3F19DC536@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060703134516.873F919DC538@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060703134517.40ADC19DC53A@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:33:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703173353.21F8719E4F90@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:33:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703173353.DC91219E4F8A@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:54:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060703175414.DEF9119E556D@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 12:05:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060703190555.1072219E8C56@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Updates since Patch v1 not covered in Comment #12: - Implemented IDL function overloading by introducing the "Optional" extended attribute for parameters.  Updated the GenerateImplementation() subroutine in CodeGeneratorJS.pm to incrementally check the argument list count as it processes optional parameters to determine when the argument list is complete.  Extracted the GenerateImplementationFunctionCall() subroutine.  Note that the "Optional" attribute only has to be listed on one argument since all others following it are assumed to be optional as well. - Added ChangeLog entries. From beeackerman at randomhouse.com Mon Jul 3 11:42:57 2006 From: beeackerman at randomhouse.com (angus gonzalez) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Luxury: Fendi Message-ID: <00a501c69ecf$ac228480$1d7136b0@blzc> TOP BRANDS - LOW LOW PRICES Jewelry * Handbags * Pens * Watches * Neckties * Clutches * Wallets Leather, silk and white gold sound good? Visit our site for real photos. Everything comes with a certificate, tags and all the extras, plus a warranty. http://santacruzers.com/luxury/ lead glass stage direction will-with-the-wisp silk cotton twice-sensed garment presser white-winged wringing-wet deformation ellipsoid slime mold honey weasel flat-floored Charlier shoe pear haw pump-back method fork forger mid-sea air bridge pseudo deputy employer-owned bear oak tidy-kept Muscovy company process butter wound rocket well-patronized development theory -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/8631c727/attachment.html From bugzilla-request-daemon at opendarwin.org Mon Jul 3 14:33:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9717?= =?iso-8859-1?q?=5D_Replace_IDL=A0ConvertUndefinedToTrue_parameter_?= =?iso-8859-1?q?attribute_with_Optional_attribute_=3A__=5BAttachmen?= =?iso-8859-1?q?t_9175=5D_Patch_v1?= Message-ID: <20060703213338.8F57C19EF39D@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Proposed patch. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:07:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703220703.DBE6C19F0E88@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:51:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703225101.0749E19F1AB3@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit ------- Additional Comments from Geoffrey Garen I guess I have to r- this over the license issue. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:51:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703225102.0EF1219F1AB5@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit ------- Additional Comments from Geoffrey Garen I guess I have to r- this over the license issue. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 17:48:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060704004837.633D219F5B31@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit ------- Additional Comments from Darin Adler I think that _web_isConditionalRequest would be more efficient if it called valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its way to be slow! Also, why not return BOOL rather than bool since it's a Objective-C method? Otherwise, looks fine. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 17:48:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060704004837.5D47019F5B37@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit ------- Additional Comments from Darin Adler I think that _web_isConditionalRequest would be more efficient if it called valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its way to be slow! Also, why not return BOOL rather than bool since it's a Objective-C method? Otherwise, looks fine. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:02:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060704010215.0FECC19F6F5B@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from Darin Adler The reason getNumber returns a boolean is so that you don't have to make a separate call to isNumber. And we don't use the function call syntax for type casts -- instead we use C++ cast syntax. So this: + if (value->isNumber()) { + double lengthValue; + value->getNumber(lengthValue); + if (lengthValue < 0.0) + return; + if (lengthValue > double(UINT_MAX)) + newLength = UINT_MAX; + else + newLength = unsigned(lengthValue); + } should be: double lengthValue; if (value->getNumber(lengthValue)) { if (lengthValue < 0.0) return; if (lengthValue > static_cast(UINT_MAX)) newLength = UINT_MAX; else newLength = static_cast(lengthValue); } I'd like to see tests that cover a few more of the branches, for example setting length to infinity and NaN. The code makes infinite try to set it to UINT_MAX, NaN sets it to 0, although -1 doesn't change the existing length. Is that really the behavior we want? If so, then lets make sure tests exercise those cases and perhaps try them in other browsers. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:02:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060704010214.0AD1D19F6F5A@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from Darin Adler The reason getNumber returns a boolean is so that you don't have to make a separate call to isNumber. And we don't use the function call syntax for type casts -- instead we use C++ cast syntax. So this: + if (value->isNumber()) { + double lengthValue; + value->getNumber(lengthValue); + if (lengthValue < 0.0) + return; + if (lengthValue > double(UINT_MAX)) + newLength = UINT_MAX; + else + newLength = unsigned(lengthValue); + } should be: double lengthValue; if (value->getNumber(lengthValue)) { if (lengthValue < 0.0) return; if (lengthValue > static_cast(UINT_MAX)) newLength = UINT_MAX; else newLength = static_cast(lengthValue); } I'd like to see tests that cover a few more of the branches, for example setting length to infinity and NaN. The code makes infinite try to set it to UINT_MAX, NaN sets it to 0, although -1 doesn't change the existing length. Is that really the behavior we want? If so, then lets make sure tests exercise those cases and perhaps try them in other browsers. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:03:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9717=5D?= =?iso-8859-1?q?_Replace_IDL=A0ConvertUndefinedToTrue_parameter_att?= =?iso-8859-1?q?ribute_with_Optional_attribute_=3A__=5BAttachment_9?= =?iso-8859-1?q?175=5D_Patch_v1?= Message-ID: <20060704010302.413A219F6FC7@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from Darin Adler Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:03:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9717=5D?= =?iso-8859-1?q?_Replace_IDL=A0ConvertUndefinedToTrue_parameter_att?= =?iso-8859-1?q?ribute_with_Optional_attribute_=3A__=5BAttachment_9?= =?iso-8859-1?q?175=5D_Patch_v1?= Message-ID: <20060704010302.8E2BE19F6FCD@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from Darin Adler Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:05:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060704010548.8E53119F70EA@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Darin Adler I'd like to see this workaround in MathExtras.h rather than inline in the JavaScript-specific files. We just need a name for the fmod with the workaround, and then we can use that. It can be an inline that expands to a call to fmod on platforms other than Win32. Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs. I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the whole check needed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:05:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060704010548.CE52019F70F0@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Darin Adler I'd like to see this workaround in MathExtras.h rather than inline in the JavaScript-specific files. We just need a name for the fmod with the workaround, and then we can use that. It can be an inline that expands to a call to fmod on platforms other than Win32. Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs. I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the whole check needed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:13:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9093] Custom implementations of time functions Message-ID: <20060704011300.D71BD19F78B0@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9093: Custom implementations of time functions http://bugzilla.opendarwin.org/attachment.cgi?id=9093&action=edit ------- Additional Comments from Darin Adler This seems like too much platform-specific code to put into this file. I suggest putting it somewhere in WTF instead, maybe a file named . Maybe we can move the Mac-specific data locale code there too. + //if (secs < time_tMin || secs > time_tMax) { We don't check in commented-out code. While the reformatting is fine, ideally I'd like to see that in a separate patch rather than in the same patch as a substantive change to the file. Maybe we can get that in first. I think it's not so great to have a KJS::tm on the Windows platform and a global tm on all the others. Maybe we can use a typedef instead? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:13:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9093] Custom implementations of time functions Message-ID: <20060704011300.83F8019F78BF@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9093: Custom implementations of time functions http://bugzilla.opendarwin.org/attachment.cgi?id=9093&action=edit ------- Additional Comments from Darin Adler This seems like too much platform-specific code to put into this file. I suggest putting it somewhere in WTF instead, maybe a file named . Maybe we can move the Mac-specific data locale code there too. + //if (secs < time_tMin || secs > time_tMax) { We don't check in commented-out code. While the reformatting is fine, ideally I'd like to see that in a separate patch rather than in the same patch as a substantive change to the file. Maybe we can get that in first. I think it's not so great to have a KJS::tm on the Windows platform and a global tm on all the others. Maybe we can use a typedef instead? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:20:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060704012036.4410519F7B2E@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from Darin Adler Looks pretty good. I have some relatively unimportant comments, but I think I'm going to review- so you can address at least some of them. Some minor formatting mistakes: + ValueList *args = value->function->args; + Value *v = args->current(); Please put the * next to tyhe type. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; Need spaces around all the operators, including the "/" and we prefer 360.0 to 360. for double constants. + for (int i = 1; i < 3; i++) + { Please put the { on the same line as the for statement. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; What does the line above to if fValue does not fit in an int? Need to check if it's in range? + colorValues[i] = v->fValue/100.; // needs to be value between 0 and 1.0 This code says it "needs to be" -- what checks that the number is between 0 and 100? - if (!validUnit(v, FInteger|FPercent, true)) Spaces around operators like "|" too. In makeRGBAfromHSLA, we'd normally capitalize the f. + bool parseColorParameters(Value* value, int* colorValues, bool parseAlpha); + bool parseHSLParameters(Value* value, float* colorValues, bool parseAlpha); We'd normally leave out the word "value" in these declarations. +float calcHue(float temp1, float temp2, float hueVal) Is there a better name than temp1/temp2 for these? If not, can you refer to place you found the algorithm? +RGBA32 makeRGBAfromHSLA(float h, float s, float l, float a) Why the use of float here, given the use of double in the code that's passing things in and the use of double-precision constants like "1.0"? This code is going to do some conversion from float to double and back that we might be able to avoid. The HSV code in this file references the URL of the place the color algorithm came from. Can you do the same with this new code? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:20:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060704012036.BB27F19F7B55@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from Darin Adler Looks pretty good. I have some relatively unimportant comments, but I think I'm going to review- so you can address at least some of them. Some minor formatting mistakes: + ValueList *args = value->function->args; + Value *v = args->current(); Please put the * next to tyhe type. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; Need spaces around all the operators, including the "/" and we prefer 360.0 to 360. for double constants. + for (int i = 1; i < 3; i++) + { Please put the { on the same line as the for statement. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; What does the line above to if fValue does not fit in an int? Need to check if it's in range? + colorValues[i] = v->fValue/100.; // needs to be value between 0 and 1.0 This code says it "needs to be" -- what checks that the number is between 0 and 100? - if (!validUnit(v, FInteger|FPercent, true)) Spaces around operators like "|" too. In makeRGBAfromHSLA, we'd normally capitalize the f. + bool parseColorParameters(Value* value, int* colorValues, bool parseAlpha); + bool parseHSLParameters(Value* value, float* colorValues, bool parseAlpha); We'd normally leave out the word "value" in these declarations. +float calcHue(float temp1, float temp2, float hueVal) Is there a better name than temp1/temp2 for these? If not, can you refer to place you found the algorithm? +RGBA32 makeRGBAfromHSLA(float h, float s, float l, float a) Why the use of float here, given the use of double in the code that's passing things in and the use of double-precision constants like "1.0"? This code is going to do some conversion from float to double and back that we might be able to avoid. The HSV code in this file references the URL of the place the color algorithm came from. Can you do the same with this new code? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060704012446.2EFD519F7D01@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit ------- Additional Comments from Darin Adler + if (completion.complType() == Throw) { + if (exception) + *exception = completion.value(); + return NULL; + } else if (completion.value()) + return toRef(completion.value()); + else // happens, for example, when the only statement is an empty (';') statement + return toRef(jsUndefined()); I find it more readable to omit the else after return in cases like this. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060704012446.3CFEB19F7D03@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit ------- Additional Comments from Darin Adler + if (completion.complType() == Throw) { + if (exception) + *exception = completion.value(); + return NULL; + } else if (completion.value()) + return toRef(completion.value()); + else // happens, for example, when the only statement is an empty (';') statement + return toRef(jsUndefined()); I find it more readable to omit the else after return in cases like this. r=me From claimsnight at hotmail.com Mon Jul 3 18:53:32 2006 From: claimsnight at hotmail.com (claimsnight@hotmail.com) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Very Important Message-ID: Dr.Lucas Tutu TEL: +27-73-442-5632 Fax: +27-11-507-5309 Email: tutu1@superdada.com Email: lucastutu@claimprocessingfiles.com I am Dr.Lukas Tutu, Director of Bid/Project Implementation South Africa 2010 Fifa world cup hosting committee , I apologized using this medium to reach you for a transaction/business of this magnitude. Be informed that I got your particulars from a member of the South Africa Export Promotion Council (SAEPC) who was at the Government delegation to your country during a trade exhibition. I have decided to seek a confidential co-operation with you in the execution of the deal described hereunder for the benefit of all parties and hope you will keep it confidential because of the nature of this transaction. you must be aware now that my country south africa won the bid to host the world cup by 2010,perior to this bid my committee was mandated to lobby the members of board of Federation International Football Association (FIFA) on selection of the country to host the world cup,the bidding was intensive but at the end we got the hosting right.My committee was given the sum of $29 million dollars to lobby the members of the FIFA ruling body to make sure that we win the hosting right. Considering the gain that comes with the hosting right,South Africa's economy will receive a massive direct boost from hosting the 2010 World Cup. Financial impact report for South Africa's World Cup bid committee shows that the 2010 World Cup will pump R21.3-billion into South Africa's economy,and creating an estimated 159000 new jobs. with the help the living legend of our time 86-year-old Nobel Peace Prize winner Dr.Nelson Mandela who made an emotive case for South Africa,we got the bid without spending all the money,i and my commitee members saw this as a God sent opportunity to secure our future and that of our family there for,l was mandated by other committee members to look for a way to move the remaining money to a safe place with the help of a foreigner who we can trust and is ready to assistus to move the funds considering the fact that we are still members of the bid/project commitee. we have in our possession the sum $21millon since we spent just $8million for lobbying. we are ready to give you 20% for all your assistance,me and my coleague will keep 80% lf you are willing,kindly reply to my letter and further directive will be given to you. Bearing in mind that confidentiality is of great essence so is time,i will await your response. I wait in anticipation of your fullest co-operation. Yours faithfully, Dr.Lucas Tutu TEL: +27-73-442-5632 Fax: +27-11-507-5309 Email: tutu1@superdada.com Email: lucastutu@claimprocessingfiles.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060704/4113ca2a/attachment.html From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:13:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704021315.C621C19F9D1D@sampson.opendarwin.org> David Carson has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:37:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704023753.8D62519FA8FC@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:53:59 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060704025359.8290F19FAF39@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 20:20:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704032050.83DBD19FC63E@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit ------- Additional Comments from Björn Graf (boki) This patch implements the necessary workaround in wtf/MathExtras.h. Defining fmod inside the KJS namespace would have worked, if all call sites where in the namespace explicitly. However, being implicitly declared in the namespace and defined in it via the using namespace KJS; directive requires the #define workaround. Needed to change isinf() because NaN is not finite. From thomas at paramed.biz Mon Jul 3 15:30:21 2006 From: thomas at paramed.biz (Robert) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] All products for your health! Message-ID: <000001c69f1a$2d9f0480$0100007f@bandos1> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 9212 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/f345d6bc/attachment.gif From necojp at citiz.net Mon Jul 3 20:53:56 2006 From: necojp at citiz.net (=?gb2312?B?g3SDjIOTg2hCQlMugrOCqILoguaC6A==?=) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?GyRCRUVPQyQvJEAkNSQkISMbKEIw?= =?iso-2022-jp?b?OTA1OTk2Njkx?= Message-ID: <20060704035356.8DD0F19FD083@sampson.opendarwin.org> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 1376 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 1376 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment-0001.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 3694 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment.jpe -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 573 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment-0002.gif From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:01:09 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040109.C02D019FE2AF@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040406.0925619FE341@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040406.CBDE319FE837@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704040406.D44CD19FE838@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:44:39 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704044439.4F61719FEEBD@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Alexey Proskuryakov (In reply to comment #9) The WebKit side doesn't have a separate code path for XHR-initiated requests (which is probably good), but other requests we are making do not carry manually set conditional headers, so they are not affected. I am not sure if bypassing the cache for all conditional requests is necessarily the expected behavior for NSURLConnection. (In reply to comment #10) > (From update of attachment 9171 [edit]) > I think that _web_isConditionalRequest would be more efficient if it called > valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its > way to be slow! I am not sure if this change makes it much faster (probably depends on the internal implementation of valueForHTTPHeaderField:), but the resulting code definitely looks better, thank you! > Also, why not return BOOL rather than bool since it's a Objective-C method? Oops, fixed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:02:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704060233.6A1C31A03198@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit ------- Additional Comments from Maciej Stachowiak otherwise r=me though From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:02:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704060233.3F5B51A03F26@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit ------- Additional Comments from Maciej Stachowiak otherwise r=me though From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:37:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704063747.CE11E1A04242@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:37:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704063747.5E0F61A04246@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Maciej Stachowiak r=me From wuqui at yahoo.co.jp Mon Jul 3 23:45:28 2006 From: wuqui at yahoo.co.jp (=?iso-2022-jp?B?ZmVodQ==?=) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?QUQbJEIhJzxjJCQ6IiRDJEYbKEI=?= =?iso-2022-jp?b?GyRCPychOSQiJGokXiQ3JD8kTRsoQg==?= Message-ID: <20060704064528.5AA091A04480@sampson.opendarwin.org> ???????????????? http://aiqihao.com/wildwild/ LALALALALALALALALA myxiaoxiaoniao@56.com LALALALALALALALALA From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:46:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704064649.417841A044DC@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:46:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704064649.8CEB61A045F7@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:54:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704065417.EB1471A046F8@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:54:18 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704065418.070461A046FA@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:07:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704070721.E46631A05C2E@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:07:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704070721.EC40C1A05C2F@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:25:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060704072543.4B50E1A0609C@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:25:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060704072543.035321A060A7@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:29:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9507] Empty style spans created in applyInlineStyle : [Attachment 8921] patch Message-ID: <20060704072953.43B4B1A062AB@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9507: Empty style spans created in applyInlineStyle http://bugzilla.opendarwin.org/show_bug.cgi?id=9507 Attachment 8921: patch http://bugzilla.opendarwin.org/attachment.cgi?id=8921&action=edit ------- Additional Comments from Maciej Stachowiak Looks ok to me. This should get a ChangeLog entry and should have the test case included in the patch, with expected results. Include that and I'll r+ it. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:29:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9507] Empty style spans created in applyInlineStyle : [Attachment 8921] patch Message-ID: <20060704072953.060B81A062BC@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9507: Empty style spans created in applyInlineStyle http://bugzilla.opendarwin.org/show_bug.cgi?id=9507 Attachment 8921: patch http://bugzilla.opendarwin.org/attachment.cgi?id=8921&action=edit ------- Additional Comments from Maciej Stachowiak Looks ok to me. This should get a ChangeLog entry and should have the test case included in the patch, with expected results. Include that and I'll r+ it. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:15:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060704081511.C0FBC1A0825A@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:15:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060704081511.927871A08257@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:22:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060704082202.CDEC51A0866A@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from Maciej Stachowiak I agree with darin's comment about offsetForAlignRight. I think if there is extra space around in an existing bitfield, it is ok to use one of those bits. However, this should be justified with some kind of measurement of the perf impact. I think since m_reversed is checked first, then at least the LTR case should be optimized already, but perhaps in many RTL cases the other calculations can be skipped. r- so you can decide what to do here but I think the patch is good to go either way (assuming I am right that LTR should normally be unaffected). From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:22:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060704082202.F3FD71A0866C@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from Maciej Stachowiak I agree with darin's comment about offsetForAlignRight. I think if there is extra space around in an existing bitfield, it is ok to use one of those bits. However, this should be justified with some kind of measurement of the perf impact. I think since m_reversed is checked first, then at least the LTR case should be optimized already, but perhaps in many RTL cases the other calculations can be skipped. r- so you can decide what to do here but I think the patch is good to go either way (assuming I am right that LTR should normally be unaffected). From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:42:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9008] Patch with no reviewer set Message-ID: <20060704084249.149761A08D00@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9008: Patch with no reviewer set http://bugzilla.opendarwin.org/attachment.cgi?id=9008&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:42:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9008] Patch with no reviewer set Message-ID: <20060704084248.F21E61A08CFE@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9008: Patch with no reviewer set http://bugzilla.opendarwin.org/attachment.cgi?id=9008&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:43:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8194] Style spans with no style are not always deleted : [Attachment 9076] patch Message-ID: <20060704084310.0C7931A08D74@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 8194: Style spans with no style are not always deleted http://bugzilla.opendarwin.org/show_bug.cgi?id=8194 Attachment 9076: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9076&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:43:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8194] Style spans with no style are not always deleted : [Attachment 9076] patch Message-ID: <20060704084310.B2DF51A08D69@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 8194: Style spans with no style are not always deleted http://bugzilla.opendarwin.org/show_bug.cgi?id=8194 Attachment 9076: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9076&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:16:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9188] updated patch Message-ID: <20060704131612.BE8E91A15F6D@sampson.opendarwin.org> Sam Weinig has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9188: updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9188&action=edit ------- Additional Comments from Sam Weinig updated patch From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:33:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9189] Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set Message-ID: <20060704133324.B878A1A166E8@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9189: Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set http://bugzilla.opendarwin.org/attachment.cgi?id=9189&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:46:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9188] updated patch Message-ID: <20060704134632.2B8151A17302@sampson.opendarwin.org> Sam Weinig has cancelled Sam Weinig 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9188: updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9188&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:46:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9188] updated patch Message-ID: <20060704134632.E519C1A1730C@sampson.opendarwin.org> Sam Weinig has cancelled Sam Weinig 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9188: updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9188&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:46:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9190] even more updated Message-ID: <20060704134633.1E3561A1730E@sampson.opendarwin.org> Sam Weinig has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9190: even more updated http://bugzilla.opendarwin.org/attachment.cgi?id=9190&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 07:38:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9190] even more updated Message-ID: <20060704143847.A12DA1A1A2F7@sampson.opendarwin.org> David Carson has cancelled Sam Weinig 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9190: even more updated http://bugzilla.opendarwin.org/attachment.cgi?id=9190&action=edit ------- Additional Comments from David Carson No code changes from Weinig updated patch, just improved the test hsl-color.html test cases. Regenerated expected results. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 07:38:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9190] even more updated Message-ID: <20060704143847.A296A1A1A2F8@sampson.opendarwin.org> David Carson has cancelled Sam Weinig 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9190: even more updated http://bugzilla.opendarwin.org/attachment.cgi?id=9190&action=edit ------- Additional Comments from David Carson No code changes from Weinig updated patch, just improved the test hsl-color.html test cases. Regenerated expected results. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 07:38:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9191] extended test case to more extensively test error cases and code paths Message-ID: <20060704143848.43ED31A1A2FA@sampson.opendarwin.org> David Carson has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9191: extended test case to more extensively test error cases and code paths http://bugzilla.opendarwin.org/attachment.cgi?id=9191&action=edit ------- Additional Comments from David Carson No code changes from Weinig updated patch, just improved the test hsl-color.html test cases. Regenerated expected results. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 09:59:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9189] Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set Message-ID: <20060704165944.375D51A20021@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9189: Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set http://bugzilla.opendarwin.org/attachment.cgi?id=9189&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 09:59:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9189] Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set Message-ID: <20060704165944.9D7C91A20028@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9189: Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set http://bugzilla.opendarwin.org/attachment.cgi?id=9189&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 10:33:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9191] extended test case to more extensively test error cases and code paths Message-ID: <20060704173300.798AB1A21EC6@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9191: extended test case to more extensively test error cases and code paths http://bugzilla.opendarwin.org/attachment.cgi?id=9191&action=edit ------- Additional Comments from Darin Adler Based on Maciej's earlier review, I'll say r=me. You didn't really address all my comments. For example, there's still no URL of a source for the color algorithm. But lets just get this into the tree as-is. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 10:33:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9191] extended test case to more extensively test error cases and code paths Message-ID: <20060704173300.E4B5E1A21EEC@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9191: extended test case to more extensively test error cases and code paths http://bugzilla.opendarwin.org/attachment.cgi?id=9191&action=edit ------- Additional Comments from Darin Adler Based on Maciej's earlier review, I'll say r=me. You didn't really address all my comments. For example, there's still no URL of a source for the color algorithm. But lets just get this into the tree as-is. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 12:25:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9193] my alternate version of the fmod patch Message-ID: <20060704192553.907DD1A26832@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9193: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9193&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 12:57:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9194] First attempt Message-ID: <20060704195712.DF52A1A2783E@sampson.opendarwin.org> Rob Buis has asked for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9194: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9194&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 13:06:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060704200602.F04D31A28B28@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 13:10:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9732] [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound : [Attachment 9196] Patch to fix the count underflow/wraparound Message-ID: <20060704201027.473121A28D96@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9732: [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound http://bugzilla.opendarwin.org/show_bug.cgi?id=9732 Attachment 9196: Patch to fix the count underflow/wraparound http://bugzilla.opendarwin.org/attachment.cgi?id=9196&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:40:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9732] [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound : [Attachment 9196] Patch to fix the count underflow/wraparound Message-ID: <20060704214005.CDE0E1A2C06C@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9732: [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound http://bugzilla.opendarwin.org/show_bug.cgi?id=9732 Attachment 9196: Patch to fix the count underflow/wraparound http://bugzilla.opendarwin.org/attachment.cgi?id=9196&action=edit ------- Additional Comments from Darin Adler Check for nil does not seem necessary. We'll just get nil for the class which is != [NSDistantObject class]. r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:40:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9732] [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound : [Attachment 9196] Patch to fix the count underflow/wraparound Message-ID: <20060704214005.77C701A2C072@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9732: [Drosera] calling removeListener to many times will cause WebKit's listener count to underflow/wraparound http://bugzilla.opendarwin.org/show_bug.cgi?id=9732 Attachment 9196: Patch to fix the count underflow/wraparound http://bugzilla.opendarwin.org/attachment.cgi?id=9196&action=edit ------- Additional Comments from Darin Adler Check for nil does not seem necessary. We'll just get nil for the class which is != [NSDistantObject class]. r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:41:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9194] First attempt Message-ID: <20060704214147.D60A71A2C1C8@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9194: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9194&action=edit ------- Additional Comments from Darin Adler Seems fine to do this, but: 1) We should be taking advantage of the header instead of adding still more one-off ifdefs. 2) A name of format _PLATFORM is reserved for the standard C library. Don't use leading underscores for this sort of thing. How about WEBCORE_NAVIGATOR_PLATFORM or something like that? From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:41:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9194] First attempt Message-ID: <20060704214147.986661A2C1D8@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9194: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9194&action=edit ------- Additional Comments from Darin Adler Seems fine to do this, but: 1) We should be taking advantage of the header instead of adding still more one-off ifdefs. 2) A name of format _PLATFORM is reserved for the standard C library. Don't use leading underscores for this sort of thing. How about WEBCORE_NAVIGATOR_PLATFORM or something like that? From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:52:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060704215208.889911A2C680@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit ------- Additional Comments from Darin Adler I talked to Tim and made it clear this is not a fix, but rather a workaround, for whatever bug he's run into. He's going to investigate further. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 14:52:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060704215208.822FA1A2C67E@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit ------- Additional Comments from Darin Adler I talked to Tim and made it clear this is not a fix, but rather a workaround, for whatever bug he's run into. He's going to investigate further. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 15:14:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9617] wx port compile fixes : [Attachment 9197] patch with added files Message-ID: <20060704221434.0BE8F1A2DED1@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9197: patch with added files http://bugzilla.opendarwin.org/attachment.cgi?id=9197&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 15:21:20 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review cancelled: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060704222120.EC05C1A2E337@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from David Kilzer (ddkilzer) I've got some improved tests for this patch which changed JSHTMLOptionsCollectionCustom.cpp. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 16:40:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review cancelled: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9193] my alternate version of the fmod patch Message-ID: <20060704234037.947321A31772@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9193: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9193&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 16:40:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review cancelled: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9193] my alternate version of the fmod patch Message-ID: <20060704234037.2E10D1A31779@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9193: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9193&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 16:40:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9198] my alternate version of the fmod patch Message-ID: <20060704234037.30A461A3177A@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9198: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9198&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 18:01:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9199] patch for review Message-ID: <20060705010146.5DEA51A355C8@sampson.opendarwin.org> James G. Speth has asked for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9199: patch for review http://bugzilla.opendarwin.org/attachment.cgi?id=9199&action=edit ------- Additional Comments from James G. Speth One thing to note is that when using this, tests will leak an additional frame (since the WebView itself is stored into the script environment). This leak can be avoided if the WebView reference is disposed of and garbage collection is forced. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 18:50:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9199] patch for review Message-ID: <20060705015005.A7A3B1A370BC@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9199: patch for review http://bugzilla.opendarwin.org/attachment.cgi?id=9199&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 18:50:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9199] patch for review Message-ID: <20060705015005.158F01A370C0@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9199: patch for review http://bugzilla.opendarwin.org/attachment.cgi?id=9199&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:41:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9734] Make SVG XPath tests dump as text to avoid random failure : [Attachment 9200] this should make that darn Attribute_Nodes.svg stop randomly failing Message-ID: <20060705034107.B85E11A3B551@sampson.opendarwin.org> Maciej Stachowiak has asked for review: Bug 9734: Make SVG XPath tests dump as text to avoid random failure http://bugzilla.opendarwin.org/show_bug.cgi?id=9734 Attachment 9200: this should make that darn Attribute_Nodes.svg stop randomly failing http://bugzilla.opendarwin.org/attachment.cgi?id=9200&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:45:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9198] my alternate version of the fmod patch Message-ID: <20060705034549.8898D1A3B644@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9198: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9198&action=edit ------- Additional Comments from Maciej Stachowiak This looks ok too, but I kinda like MathExtras.h being transparent and letting you use the normal function names. Saying wtf_fmod all over (w/ potential to mistakenly say fmod) seems worse to me than a macro solution. Agreed though that a macro with parameters would be better. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:45:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9198] my alternate version of the fmod patch Message-ID: <20060705034549.18E091A3B64E@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9198: my alternate version of the fmod patch http://bugzilla.opendarwin.org/attachment.cgi?id=9198&action=edit ------- Additional Comments from Maciej Stachowiak This looks ok too, but I kinda like MathExtras.h being transparent and letting you use the normal function names. Saying wtf_fmod all over (w/ potential to mistakenly say fmod) seems worse to me than a macro solution. Agreed though that a macro with parameters would be better. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:46:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9617] wx port compile fixes : [Attachment 9197] patch with added files Message-ID: <20060705034640.81B191A3B71A@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9197: patch with added files http://bugzilla.opendarwin.org/attachment.cgi?id=9197&action=edit ------- Additional Comments from Maciej Stachowiak Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:46:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9617] wx port compile fixes : [Attachment 9197] patch with added files Message-ID: <20060705034640.7F2FD1A3B719@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9197: patch with added files http://bugzilla.opendarwin.org/attachment.cgi?id=9197&action=edit ------- Additional Comments from Maciej Stachowiak Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:54:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9734] Make SVG XPath tests dump as text to avoid random failure : [Attachment 9200] this should make that darn Attribute_Nodes.svg stop randomly failing Message-ID: <20060705035446.E9D5A1A3BDB4@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9734: Make SVG XPath tests dump as text to avoid random failure http://bugzilla.opendarwin.org/show_bug.cgi?id=9734 Attachment 9200: this should make that darn Attribute_Nodes.svg stop randomly failing http://bugzilla.opendarwin.org/attachment.cgi?id=9200&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 20:54:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9734] Make SVG XPath tests dump as text to avoid random failure : [Attachment 9200] this should make that darn Attribute_Nodes.svg stop randomly failing Message-ID: <20060705035446.EB9701A3BDB5@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9734: Make SVG XPath tests dump as text to avoid random failure http://bugzilla.opendarwin.org/show_bug.cgi?id=9734 Attachment 9200: this should make that darn Attribute_Nodes.svg stop randomly failing http://bugzilla.opendarwin.org/attachment.cgi?id=9200&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 22:41:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060705054128.67C5F1A4097E@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 22:59:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060705055928.402F91A412F5@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 22:59:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9731] [Drosera] crash when trying to access the scope chain : [Attachment 9195] Patch to fix the crash Message-ID: <20060705055928.3F52B1A412F9@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9731: [Drosera] crash when trying to access the scope chain http://bugzilla.opendarwin.org/show_bug.cgi?id=9731 Attachment 9195: Patch to fix the crash http://bugzilla.opendarwin.org/attachment.cgi?id=9195&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 5 03:51:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9205] patch without leaks Message-ID: <20060705105114.A67F51A4DCA8@sampson.opendarwin.org> James G. Speth has asked for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9205: patch without leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9205&action=edit ------- Additional Comments from James G. Speth i changed the way scripts access the WebView and window to prevent leaking. this includes a test for the plugin method that exposes this access to the script. From bugzilla-request-daemon at opendarwin.org Wed Jul 5 04:39:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9208] Only ignore unqualified :hover rules in quirks mode Message-ID: <20060705113916.91A641A5208C@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9208: Only ignore unqualified :hover rules in quirks mode http://bugzilla.opendarwin.org/attachment.cgi?id=9208&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 11:28:18 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9210] Patch Message-ID: <20060705182818.785411A639C1@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9210: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9210&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 12:15:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9210] Patch Message-ID: <20060705191554.0DC6B1A6594A@sampson.opendarwin.org> Anders Carlsson has denied Anders Carlsson 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9210: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9210&action=edit ------- Additional Comments from Anders Carlsson This introduces crashes From bugzilla-request-daemon at opendarwin.org Wed Jul 5 12:15:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9210] Patch Message-ID: <20060705191553.F21B21A65948@sampson.opendarwin.org> Anders Carlsson has denied Anders Carlsson 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9210: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9210&action=edit ------- Additional Comments from Anders Carlsson This introduces crashes From bugzilla-request-daemon at opendarwin.org Wed Jul 5 12:49:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9213] Improved patch Message-ID: <20060705194930.02B8A1A6659D@sampson.opendarwin.org> Rob Buis has asked for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9213: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9213&action=edit ------- Additional Comments from Rob Buis Renamed to WEBCORE_NAVIGATOR_PLATFORM, reused CPU macro's and moved to wtf. I am not sure whether WEBCORE_NAVIGATOR_PLATFORM is useful anywhere outside kjs_navigator though... Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:08:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9214] Add an m_alignRight flag to InlineTextBox Message-ID: <20060705200823.247631A6830C@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9214: Add an m_alignRight flag to InlineTextBox http://bugzilla.opendarwin.org/attachment.cgi?id=9214&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com I think this version performs better since it measures the width only if it's really needed, even for RTL text with the relevant style (whereas the other approach measures the width of all RTL text with that style). Can m_toAdd be negative? If it can't, then the sign bit can be reclaimed. From alexander at euwest.biz Wed Jul 5 05:18:25 2006 From: alexander at euwest.biz (Robert) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] Want to be perfect lover? Message-ID: <000001c6a070$2b4ebe80$0100007f@ampm> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 14674 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060705/61f6c945/attachment.jpe From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:18:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9215] Better patch Message-ID: <20060705201852.E0BDE1A6899C@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9215: Better patch http://bugzilla.opendarwin.org/attachment.cgi?id=9215&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:32:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review cancelled: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9215] Better patch Message-ID: <20060705203217.3AC9C1A69202@sampson.opendarwin.org> Anders Carlsson has cancelled Anders Carlsson 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9215: Better patch http://bugzilla.opendarwin.org/attachment.cgi?id=9215&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:32:18 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review cancelled: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9215] Better patch Message-ID: <20060705203218.453AC1A69203@sampson.opendarwin.org> Anders Carlsson has cancelled Anders Carlsson 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9215: Better patch http://bugzilla.opendarwin.org/attachment.cgi?id=9215&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:32:18 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9216] Patch without tabs Message-ID: <20060705203218.5A6901A69205@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9216: Patch without tabs http://bugzilla.opendarwin.org/attachment.cgi?id=9216&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:57:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9216] Patch without tabs Message-ID: <20060705205705.72B5D1A699C1@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9216: Patch without tabs http://bugzilla.opendarwin.org/attachment.cgi?id=9216&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 5 13:57:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 3581] iFrames set to display:none are Missing from frames array : [Attachment 9216] Patch without tabs Message-ID: <20060705205705.0D3081A699CC@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 3581: iFrames set to display:none are Missing from frames array http://bugzilla.opendarwin.org/show_bug.cgi?id=3581 Attachment 9216: Patch without tabs http://bugzilla.opendarwin.org/attachment.cgi?id=9216&action=edit ------- Additional Comments from Maciej Stachowiak r=me From alexandria616 at ror.plala.or.jp Wed Jul 5 19:41:49 2006 From: alexandria616 at ror.plala.or.jp (ªŠÝ ˆÉ) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=B2=88=C4=93=E0?= Message-ID: “–ƒTƒCƒgw‚¤‚鹂â‚‚çx‚ÍA o‰ï‚¢ƒTƒCƒg‚É“o˜^‚µ‚Ä‚¢‚é‚à‚Ì‚ÌAo‰ï‚¦‚È‚¢”Þ—‚½‚¿‚©‚ç @@u‚Ç‚¤‚µ‚ÄŽ„‚ɺ‚ª‚©‚©‚ç‚È‚¢‚ÌHv @@uƒ[ƒ‹‚ª‚à‚炦‚Ü‚¹‚ñEEEBv ‚È‚Ç‚ÌŽ¿–â‚ð‚¢‚½‚¾‚«A‚±‚̃TƒCƒg‚Å‚»‚ñ‚Ȕޗ’B‚Ì Žè•‚¯‚ð‚µ‚Ä‚¨‚è‚Ü‚·B ‚à‚¿‚ë‚ñ‚±‚̃TƒCƒg‚ð‚²——‚É‚È‚Á‚½‹M•û‚Í“–‘R ”Þ—’B‚ƘA—‚ªŽæ‚è‚â‚·‚­‘¦‰ï‚¦‚é‰Â”\«‚ª ‚ ‚è‚Ü‚·B ‰º‹L‚̔ޗ’B‚ÍŽÀÝ‚µAƒ[ƒ‹ƒAƒhƒŒƒX‚Í”Þ —’B–{l‚Ì‚à‚Ì‚Å‚·B —â‚â‚©‚µ‚̃[ƒ‹‚âA—V‚Ñ”¼•ª‚È•û—˜—p‚Í‚²‰“—¶Šè‚¢‚Ü‚·B ‚Ü‚½A‚P‚WΖ¢–ž‚Ì‚²—˜—p‚à‹ÖŽ~‚Æ‚³‚¹‚Ä‚¢‚½‚¾‚«‚Ü‚·B ------------------------------------------------- ™@‚Ü‚ä‚Ý@™ ‚킽‚µ‚Í‚Q‚R΂ÌOL‚Å‚·Bŋߔގ‚Æ•Ê‚ê‚Ä‚¢‚Â‚à ‚Ð‚Æ‚è‚Ú‚Á‚¿EEEB Žv‚¢Ø‚Á‚Äo‰ï‚¢Œn‚É“o˜^‚µ‚½‚¯‚ǃ[ƒ‹‚ª‚ ‚Ü‚è ‚à‚炦‚¸‚É‚¢‚Ü‚µ‚½B —F’B‚Éo‰ï‚¢Œn‚Á‚Ä‚±‚ñ‚È‚à‚ñ‚È‚ÌH‚Á‚Ä•·‚¢‚½‚çA ‚»‚ñ‚È‚±‚Æ‚È‚¢‚æB‚Á‚ÄŒ¾‚í‚ê‚ăVƒ‡ƒbƒN‚È‚ñ‚Å‚·B ‚킽‚µ‚Ƀ[ƒ‹‚­‚¾‚³`‚¢B http://gape.scramblekosaten.com/a8/ ------------------------------------------------- ™@‚Ü‚È@™ ‰B‚µ‚Ä‚à‚µ‚傤‚ª‚È‚¢‚ñ‚ÅŒ¾‚Á‚¿‚á‚¢‚Ü‚·‚¯‚ÇA ‘Ì‚¾‚¯‚ÌŠÖŒWŠó–]‚Å‚·B ”ÞŽ‚Í‚¢‚Ü‚·‚ª‚»‚ê‚Å‚à‚¢‚¢‚Æ‚¢‚¤•û‚©‚çA ƒ[ƒ‹‚¢‚½‚¾‚¯‚½‚炤‚ꂵ‚¢‚È‚ŸB http://supersede.scramblekosaten.com/a8/ ------------------------------------------------- From bugzilla-request-daemon at opendarwin.org Thu Jul 6 05:08:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9736] -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent : [Attachment 9202] initKeyboardEvent attempt Message-ID: <20060706120806.E56411A8E1C8@sampson.opendarwin.org> Joost de Valk (AlthA) has asked for review: Bug 9736: -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent http://bugzilla.opendarwin.org/show_bug.cgi?id=9736 Attachment 9202: initKeyboardEvent attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9202&action=edit ------- Additional Comments from Joost de Valk (AlthA) Setting review on this patch, so that someone can have a look at it and deliver some comments. From cpuente at zooandaquarium.com Thu Jul 6 06:44:10 2006 From: cpuente at zooandaquarium.com (Camie Puente) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] Shavon Irizarry Message-ID: <1152193450.6971@zooandaquarium.com> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060706/220302eb/attachment.html From nlofton at zooandaquarium.com Thu Jul 6 07:51:19 2006 From: nlofton at zooandaquarium.com (Nakisha Lofton) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] Susana Dalton Message-ID: <1152197479.9401@zooandaquarium.com> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060706/90b0d9db/attachment.html From bugzilla-request-daemon at opendarwin.org Thu Jul 6 12:26:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9233] port of svn/changelog utilities Message-ID: <20060706192626.B0E001A9EAEF@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9233: port of svn/changelog utilities http://bugzilla.opendarwin.org/attachment.cgi?id=9233&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 6 12:26:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9233] port of svn/changelog utilities Message-ID: <20060706192626.658A11A9EAF5@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9233: port of svn/changelog utilities http://bugzilla.opendarwin.org/attachment.cgi?id=9233&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 6 13:00:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9233] port of svn/changelog utilities Message-ID: <20060706200028.AF82D1AA029A@sampson.opendarwin.org> David Carson has denied David Carson 's request for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9233: port of svn/changelog utilities http://bugzilla.opendarwin.org/attachment.cgi?id=9233&action=edit ------- Additional Comments from David Carson Generated paths in ChangeLog are not consistent, ie: * S60Tools\prepare-ChangeLog.bat: Added. * S60Tools\svn-apply.bat: Added. * S60Tools\svn-create-patch.bat: Added. * S60Tools\svn-unapply.bat: Added. * WebKit/BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::WaitForLastCharCommit): * WebKit/ResourceLoader/src/HttpPostDataSupplier.cpp: (THttpPostDataSupplier::GetNextDataPart): * WebKit\BrowserCore\Formcontrols\src\FControlInputSkin.cpp: * WebKit\ResourceLoader\src\HttpPostDataSupplier.cpp: And ChangeLogs should exist in each component, and not just the top level component. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 13:00:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9233] port of svn/changelog utilities Message-ID: <20060706200028.B68AB1AA0485@sampson.opendarwin.org> David Carson has denied David Carson 's request for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9233: port of svn/changelog utilities http://bugzilla.opendarwin.org/attachment.cgi?id=9233&action=edit ------- Additional Comments from David Carson Generated paths in ChangeLog are not consistent, ie: * S60Tools\prepare-ChangeLog.bat: Added. * S60Tools\svn-apply.bat: Added. * S60Tools\svn-create-patch.bat: Added. * S60Tools\svn-unapply.bat: Added. * WebKit/BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::WaitForLastCharCommit): * WebKit/ResourceLoader/src/HttpPostDataSupplier.cpp: (THttpPostDataSupplier::GetNextDataPart): * WebKit\BrowserCore\Formcontrols\src\FControlInputSkin.cpp: * WebKit\ResourceLoader\src\HttpPostDataSupplier.cpp: And ChangeLogs should exist in each component, and not just the top level component. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 13:26:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9238] New prepare_changelog now forces forward slashes Message-ID: <20060706202607.755B21AA159E@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9238: New prepare_changelog now forces forward slashes http://bugzilla.opendarwin.org/attachment.cgi?id=9238&action=edit ------- Additional Comments from Bradley Morrison Updated patch to force forward slashes in Changelog paths. This also removes duplicate entries shown in previous comment. Bug 9755 has been raised for ChangeLog location. Prepare Changelog utility in this patch does not need to be modified for this work. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 13:26:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9238] New prepare_changelog now forces forward slashes Message-ID: <20060706202607.47C991AA159D@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9238: New prepare_changelog now forces forward slashes http://bugzilla.opendarwin.org/attachment.cgi?id=9238&action=edit ------- Additional Comments from Bradley Morrison Updated patch to force forward slashes in Changelog paths. This also removes duplicate entries shown in previous comment. Bug 9755 has been raised for ChangeLog location. Prepare Changelog utility in this patch does not need to be modified for this work. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 15:14:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9238] New prepare_changelog now forces forward slashes Message-ID: <20060706221427.99A521AA52AB@sampson.opendarwin.org> David Carson has granted David Carson 's request for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9238: New prepare_changelog now forces forward slashes http://bugzilla.opendarwin.org/attachment.cgi?id=9238&action=edit ------- Additional Comments from David Carson Looks good. r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 6 15:14:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9754] S60WebKit should use svn scripts from WebKit ToT : [Attachment 9238] New prepare_changelog now forces forward slashes Message-ID: <20060706221427.A54251AA52AD@sampson.opendarwin.org> David Carson has granted David Carson 's request for review: Bug 9754: S60WebKit should use svn scripts from WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9754 Attachment 9238: New prepare_changelog now forces forward slashes http://bugzilla.opendarwin.org/attachment.cgi?id=9238&action=edit ------- Additional Comments from David Carson Looks good. r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 6 17:22:13 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9768] Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). : [Attachment 9241] patch Message-ID: <20060707002213.B5DF11AA9E7D@sampson.opendarwin.org> Sam Weinig has asked for review: Bug 9768: Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). http://bugzilla.opendarwin.org/show_bug.cgi?id=9768 Attachment 9241: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9241&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 6 17:40:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9528] REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes : [Attachment 9242] Patch with test case Message-ID: <20060707004054.06F071AAA513@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9528: REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes http://bugzilla.opendarwin.org/show_bug.cgi?id=9528 Attachment 9242: Patch with test case http://bugzilla.opendarwin.org/attachment.cgi?id=9242&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 6 17:48:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9528] REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes : [Attachment 9242] Patch with test case Message-ID: <20060707004850.222411AAA733@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9528: REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes http://bugzilla.opendarwin.org/show_bug.cgi?id=9528 Attachment 9242: Patch with test case http://bugzilla.opendarwin.org/attachment.cgi?id=9242&action=edit ------- Additional Comments from Adele Peterson Anders also tested WinIE and found that this matches their behavior. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 17:48:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9528] REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes : [Attachment 9242] Patch with test case Message-ID: <20060707004850.46DFD1AAA738@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9528: REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes http://bugzilla.opendarwin.org/show_bug.cgi?id=9528 Attachment 9242: Patch with test case http://bugzilla.opendarwin.org/attachment.cgi?id=9242&action=edit ------- Additional Comments from Adele Peterson Anders also tested WinIE and found that this matches their behavior. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 20:14:42 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9243] patch Message-ID: <20060707031442.9DE181AB0D07@sampson.opendarwin.org> Beth Dakin has asked Dave Hyatt for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9243: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9243&action=edit ------- Additional Comments from Beth Dakin I feel like this patch could not possibly be right. But it definitely hunts down the source of the problem. I remembered fixing a bug a while ago where the root cause was that a bunch of our old code held assumptions that positioned elements would always have line boxes, but it turns out that this isn't true. This assumption is also causing extra repaints because in layoutInlineChildren() we set fullLayout to true if we don't have any line boxes...meaning that positioned elements without line boxes always get a full layout. This is clearly overzealous. I imagine that the patch I attached is undezealous. (underzealous?? forgive me, for it has been a long day.) But I figure that attaching it is a good way to start a discussion about what the right fix is. Thoughts? From bugzilla-request-daemon at opendarwin.org Thu Jul 6 20:14:42 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9243] patch Message-ID: <20060707031442.BC6961AB0D09@sampson.opendarwin.org> Beth Dakin has asked Dave Hyatt for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9243: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9243&action=edit ------- Additional Comments from Beth Dakin I feel like this patch could not possibly be right. But it definitely hunts down the source of the problem. I remembered fixing a bug a while ago where the root cause was that a bunch of our old code held assumptions that positioned elements would always have line boxes, but it turns out that this isn't true. This assumption is also causing extra repaints because in layoutInlineChildren() we set fullLayout to true if we don't have any line boxes...meaning that positioned elements without line boxes always get a full layout. This is clearly overzealous. I imagine that the patch I attached is undezealous. (underzealous?? forgive me, for it has been a long day.) But I figure that attaching it is a good way to start a discussion about what the right fix is. Thoughts? From bugzilla-request-daemon at opendarwin.org Thu Jul 6 22:36:20 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9244] Custom implementaion of time functions in WTF Message-ID: <20060707053620.9327D1AB5A60@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9244: Custom implementaion of time functions in WTF http://bugzilla.opendarwin.org/attachment.cgi?id=9244&action=edit ------- Additional Comments from Björn Graf (boki) This patch moves the implementaion of the custom time functions into the WTF namespace. This requires the callers to specify the namespace for the functions and wrapper functions for other OSes. No whitespace was harmed during the creation of this patch. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 23:40:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9736] -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent : [Attachment 9202] initKeyboardEvent attempt Message-ID: <20060707064006.0D4F11AB8046@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9736: -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent http://bugzilla.opendarwin.org/show_bug.cgi?id=9736 Attachment 9202: initKeyboardEvent attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9202&action=edit ------- Additional Comments from Geoffrey Garen This patch looks correct, but it's missing the test you mentioned and a ChangeLog entry. From bugzilla-request-daemon at opendarwin.org Thu Jul 6 23:40:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review denied: [Bug 9736] -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent : [Attachment 9202] initKeyboardEvent attempt Message-ID: <20060707064005.F30661AB8044@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9736: -(void)init*Event missing in DOMKeyboardEvent and DOMWheelEvent http://bugzilla.opendarwin.org/show_bug.cgi?id=9736 Attachment 9202: initKeyboardEvent attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9202&action=edit ------- Additional Comments from Geoffrey Garen This patch looks correct, but it's missing the test you mentioned and a ChangeLog entry. From necojp at citiz.net Fri Jul 7 05:28:10 2006 From: necojp at citiz.net (=?gb2312?B?kWaQbEhQj9CJ7g==?=) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?GyRCQk40NiQ5JGsyQUNNJE8bKEI=?= =?iso-2022-jp?b?GyRCJCIkaiReJDkkaCEqGyhC?= Message-ID: <20060707122810.1C0A81AC79E0@sampson.opendarwin.org> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 955 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060707/c56395fc/attachment.jpe From bugzilla-request-daemon at opendarwin.org Fri Jul 7 08:52:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9248] New version of SDK has changed registry paths Message-ID: <20060707155257.A5DCB1ACF0F3@sampson.opendarwin.org> Bradley Morrison has asked for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9248: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9248&action=edit ------- Additional Comments from Bradley Morrison Recommending doing Svn update to get the new svn utils before review From bugzilla-request-daemon at opendarwin.org Fri Jul 7 08:53:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9248] New version of SDK has changed registry paths Message-ID: <20060707155323.E6CFE1ACF133@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9248: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9248&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 7 08:53:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9248] New version of SDK has changed registry paths Message-ID: <20060707155323.DA61D1ACF131@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9248: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9248&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 7 08:55:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9249] New version of SDK has changed registry paths Message-ID: <20060707155507.940E61ACF1D6@sampson.opendarwin.org> Bradley Morrison has asked for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9249: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9249&action=edit ------- Additional Comments from Bradley Morrison Recommending doing Svn update to get the new svn utils before review From bugzilla-request-daemon at opendarwin.org Fri Jul 7 09:29:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9250] Patch Message-ID: <20060707162933.E66871AD0DDD@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9250: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9250&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Changed the way the repaintRect is computed to account for the vertical edges of all lines that have been deleted, moved (before and after) or added. No test yet because I cannot get the tests to fail without the fix under the normal repaint test mechanism - the first repaint is big correct (or bigger than correct), for some reason (you can see this effect in Safari, too, i.e. in some instances the first time you mouseover and mouseout the repainting is correct, but from the second time onwards it isn't). From bugzilla-request-daemon at opendarwin.org Fri Jul 7 09:33:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9252] ChangeLog for this fix Message-ID: <20060707163300.9CA631AD0F3A@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9252: ChangeLog for this fix http://bugzilla.opendarwin.org/attachment.cgi?id=9252&action=edit ------- Additional Comments from Bradley Morrison Accompanies S60Headers.zip From bugzilla-request-daemon at opendarwin.org Fri Jul 7 09:33:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9252] ChangeLog for this fix Message-ID: <20060707163300.15D791AD0F3E@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9252: ChangeLog for this fix http://bugzilla.opendarwin.org/attachment.cgi?id=9252&action=edit ------- Additional Comments from Bradley Morrison Accompanies S60Headers.zip From bugzilla-request-daemon at opendarwin.org Fri Jul 7 09:43:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 8300] REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons : [Attachment 9253] Patch Message-ID: <20060707164322.BFF361AD157E@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 8300: REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons http://bugzilla.opendarwin.org/show_bug.cgi?id=8300 Attachment 9253: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9253&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 7 10:07:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 8300] REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons : [Attachment 9253] Patch Message-ID: <20060707170731.65CF21AD2AD3@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 8300: REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons http://bugzilla.opendarwin.org/show_bug.cgi?id=8300 Attachment 9253: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9253&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 7 10:07:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 8300] REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons : [Attachment 9253] Patch Message-ID: <20060707170731.8CB2E1AD2AD7@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 8300: REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons http://bugzilla.opendarwin.org/show_bug.cgi?id=8300 Attachment 9253: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9253&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 7 10:58:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9572] Add application/xhtml+xml to the Accept header : [Attachment 9254] proposed patch Message-ID: <20060707175801.EAF641AD3F79@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 9572: Add application/xhtml+xml to the Accept header http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Attachment 9254: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9254&action=edit ------- Additional Comments from Alexey Proskuryakov I am not aware of any reason for us to send something else than Firefox does in the Accept header, so I've just copied theirs. From bugzilla-request-daemon at opendarwin.org Fri Jul 7 11:06:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9768] Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). : [Attachment 9241] patch Message-ID: <20060707180623.835211AD53DE@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9768: Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). http://bugzilla.opendarwin.org/show_bug.cgi?id=9768 Attachment 9241: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9241&action=edit ------- Additional Comments from Eric Seidel looks great! From bugzilla-request-daemon at opendarwin.org Fri Jul 7 11:06:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9768] Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). : [Attachment 9241] patch Message-ID: <20060707180623.5668B1AD53E6@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9768: Split XSLImportRule out of XSLStyleSheet.* into separate files (one class per file). http://bugzilla.opendarwin.org/show_bug.cgi?id=9768 Attachment 9241: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9241&action=edit ------- Additional Comments from Eric Seidel looks great! From bugzilla-request-daemon at opendarwin.org Fri Jul 7 16:24:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review requested: [Bug 9777] Reproducible crash in Loading/Frames in ToT : [Attachment 9258] Patch Message-ID: <20060707232427.C6C311AE07D4@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9777: Reproducible crash in Loading/Frames in ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9777 Attachment 9258: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9258&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 7 16:42:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9777] Reproducible crash in Loading/Frames in ToT : [Attachment 9258] Patch Message-ID: <20060707234217.222F61AE1ECE@sampson.opendarwin.org> Brady Eidson has granted Brady Eidson 's request for review: Bug 9777: Reproducible crash in Loading/Frames in ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9777 Attachment 9258: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9258&action=edit ------- Additional Comments from Brady Eidson As long as you don't check-in your xcodeproj change, r+ ;) From bugzilla-request-daemon at opendarwin.org Fri Jul 7 16:42:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9777] Reproducible crash in Loading/Frames in ToT : [Attachment 9258] Patch Message-ID: <20060707234217.F22551AE1F9F@sampson.opendarwin.org> Brady Eidson has granted Brady Eidson 's request for review: Bug 9777: Reproducible crash in Loading/Frames in ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9777 Attachment 9258: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9258&action=edit ------- Additional Comments from Brady Eidson As long as you don't check-in your xcodeproj change, r+ ;) From bugzilla-request-daemon at opendarwin.org Sat Jul 8 05:50:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9572] Add application/xhtml+xml to the Accept header : [Attachment 9254] proposed patch Message-ID: <20060708125047.94B5D1B033F0@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9572: Add application/xhtml+xml to the Accept header http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Attachment 9254: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9254&action=edit ------- Additional Comments from Darin Adler This new string will need to be added to StringNotToBeLocalized.txt. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 8 05:50:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:34 2007 Subject: [webkit-reviews] review granted: [Bug 9572] Add application/xhtml+xml to the Accept header : [Attachment 9254] proposed patch Message-ID: <20060708125047.83ADF1B033F6@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9572: Add application/xhtml+xml to the Accept header http://bugzilla.opendarwin.org/show_bug.cgi?id=9572 Attachment 9254: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9254&action=edit ------- Additional Comments from Darin Adler This new string will need to be added to StringNotToBeLocalized.txt. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 8 06:28:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review denied: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9213] Improved patch Message-ID: <20060708132826.4D8631B04F33@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9213: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9213&action=edit ------- Additional Comments from Darin Adler Sorry to be difficult, but there is at least one problem here. If the macro is going to be in Platform.h, then the prefix should not be WEBCORE_ but rather WTF_. But also, if it's going to be in Platform.h it has to be the whole macro, not just the PPC part, with the WIN32 bit etc. I think we should go back to something more like the original patch that's in kjs_navigator.cpp, but not with something that starts with an underscore. I think that you should use PLATFORM(PPC) instead of a custom ifdef. And I think that all the platforms should use the macro instead of having ifdefs in the Platform case in the casae statement. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 06:28:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review denied: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9213] Improved patch Message-ID: <20060708132826.665081B04F3D@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9213: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9213&action=edit ------- Additional Comments from Darin Adler Sorry to be difficult, but there is at least one problem here. If the macro is going to be in Platform.h, then the prefix should not be WEBCORE_ but rather WTF_. But also, if it's going to be in Platform.h it has to be the whole macro, not just the PPC part, with the WIN32 bit etc. I think we should go back to something more like the original patch that's in kjs_navigator.cpp, but not with something that starts with an underscore. I think that you should use PLATFORM(PPC) instead of a custom ifdef. And I think that all the platforms should use the macro instead of having ifdefs in the Platform case in the casae statement. From webinquiry at foxcreekalaska.com Sat Jul 8 09:20:03 2006 From: webinquiry at foxcreekalaska.com (webinquiry@foxcreekalaska.com) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] Start earning the salary you deserve by obtaining the appropriate University Degree. Message-ID: WK1fKzAgU0wt5.3KLNDOkyxPkqE@foxcreekalaska.com An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060708/bf4e5c33/attachment.html From automatic545 at aol.com Sat Jul 8 07:37:35 2006 From: automatic545 at aol.com (‹{ì –G) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=A8=8Bv=82=B5=82=D4=82=E8=82?= =?iso-8859-1?q?=C5=82=B7?= Message-ID: <57408.51473770.2950848281@clergymen-s706.hotmail.co.jp> š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™ ™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š™š Ÿž Ÿž žŸ @@Ÿ”Þ—‚ªo—ˆ‚韃ZƒtƒŒ‚ªo—ˆ‚韗F’B‚ªo—ˆ‚éŸ žŸ Ÿž@@@@@@@@@@@@@@@@@@@@@@@@@@@ @@@ Ÿž žŸ„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªw ™Š®‘S–³—¿™ x„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª žŸ Ÿž @@@@@@@@@@@@@@@@@@@@@@ @@@ @@@@@ Ÿž žŸ@@ ƒf[ƒg‚ª‚µ‚½‚¢Iƒhƒ‰ƒCƒu‚És‚«‚½‚¢Iˆù‚Ý‚És‚«‚½‚¢ @@ žŸ Ÿž@@@@@@@ Ÿž žŸ™š™š™š@@@@@@‚g‚ª‚µ‚½`‚¢I@@ @@@@ ™š™š™šžŸ Š®‘S–³—¿“üŒûË@http://adage.scramblekosaten.com/a21/ ©Š®‘S–³—¿“üŒû „ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªcccccddddEEEE™™™ ‚¢‚‚à‚Ç[‚àBo‰ï‚¢ƒ‰ƒCƒ^[‚Ìw‚±‚¤‚¶x‚Å‚·I‘Š•Ï‚í‚炸o‰ï‚¢ŒnƒTƒCƒg‚É ¸‚ðo‚µ‚Ä‚¨‚è‚Ü‚·II‚Æ‚¢‚¤‚킯‚ÅA¡‰ñ‚Í‹M•û‚ɃIƒXƒXƒ‚Ì–³—¿ƒTƒCƒg‚𠂲Љî’v‚µ‚Ü‚·B‚Ç‚¿‚ç‚©‚Æ‚¢‚¤‚Æ‚gŒn‚Ì—«‚ª‘½‚­AƒZƒtƒŒì‚è‚É‚ÍÅ“K‚Å‚·B ŠÈ’P‚ɃIƒXƒXƒ“x‚ð‚Ü‚Æ‚ß‚Ü‚µ‚½‚Ì‚Å‚²ŽQl‚É‚Ç‚¤‚¼II ™„Ÿ„Ÿ„Ÿ„¦„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„¢ bˆú—“xbššššššššš™b @@@@ šŠ®‘S‰i‹v–³—¿š b‘¦‚g“xbššššššššššb b‘fl“xbššššššššššbË http://audible.scramblekosaten.com/a21/ bƒTƒNƒ‰bš™™™™™™™™™b blÈ“xbšššššš™™™™b „¤„Ÿ„Ÿ„Ÿ„¨„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„£ From bugzilla-request-daemon at opendarwin.org Sat Jul 8 08:26:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9788] storage leaks in Objective-C tests : [Attachment 9268] patch to fix the leaks Message-ID: <20060708152655.DA59B1B08E8D@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9788: storage leaks in Objective-C tests http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 Attachment 9268: patch to fix the leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9268&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 08:56:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9095] patch, including change log and a manual test Message-ID: <20060708155651.CF7A01B09800@sampson.opendarwin.org> Darin Adler has cancelled Anders Carlsson 's request for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9095: patch, including change log and a manual test http://bugzilla.opendarwin.org/attachment.cgi?id=9095&action=edit ------- Additional Comments from Darin Adler Further testing show this not working in some cases. New patch forthcoming. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:05:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9269] better patch with change log, can still use the old test case Message-ID: <20060708160546.A57B11B0A8ED@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9269: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9269&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:07:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review denied: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9205] patch without leaks Message-ID: <20060708160727.CF8331B0AA18@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9205: patch without leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9205&action=edit ------- Additional Comments from Darin Adler The call to removeBridgeRestrictions: here has the same leak I've fixed in my recent patch -- the JSObjC object is allocated but not released. Otherwise looks fine. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:07:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review denied: [Bug 9655] obj-c test scripts need access to WebView in DumpRenderTree : [Attachment 9205] patch without leaks Message-ID: <20060708160727.98BE01B0AA15@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9655: obj-c test scripts need access to WebView in DumpRenderTree http://bugzilla.opendarwin.org/show_bug.cgi?id=9655 Attachment 9205: patch without leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9205&action=edit ------- Additional Comments from Darin Adler The call to removeBridgeRestrictions: here has the same leak I've fixed in my recent patch -- the JSObjC object is allocated but not released. Otherwise looks fine. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:36:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060708163616.2E9C21B0B62A@sampson.opendarwin.org> Darin Adler has cancelled Maciej Stachowiak 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Darin Adler Clearing the review flag so this doesn't appear in our patches to be commited list. Please set the review flag again when you have a patch with tests that's ready to review and land. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:43:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9269] better patch with change log, can still use the old test case Message-ID: <20060708164316.1375A1B0B7FD@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9269: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9269&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:43:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9269] better patch with change log, can still use the old test case Message-ID: <20060708164316.392F11B0B804@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9269: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9269&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 09:43:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9271] better patch with change log, can still use the old test case Message-ID: <20060708164316.559B41B0B807@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9271: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9271&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 10:57:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9271] better patch with change log, can still use the old test case Message-ID: <20060708175716.8F5861B0DFF6@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9271: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9271&action=edit ------- Additional Comments from Geoffrey Garen r=me I think kjs_window.cpp could use a comment explaining why you need to do this: + if (!returnValue) + returnValue = dialogWindow->getDirect("returnValue"); Also, it looks like you changed the indenting in KJSProxy::clear from 4 spaces to 2. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 10:57:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9622] REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" : [Attachment 9271] better patch with change log, can still use the old test case Message-ID: <20060708175716.75BAA1B0DFF3@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9622: REGRESSION: showModalDialog returnValue ignored, function result is always "undefined" http://bugzilla.opendarwin.org/show_bug.cgi?id=9622 Attachment 9271: better patch with change log, can still use the old test case http://bugzilla.opendarwin.org/attachment.cgi?id=9271&action=edit ------- Additional Comments from Geoffrey Garen r=me I think kjs_window.cpp could use a comment explaining why you need to do this: + if (!returnValue) + returnValue = dialogWindow->getDirect("returnValue"); Also, it looks like you changed the indenting in KJSProxy::clear from 4 spaces to 2. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:01:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9275] Improved patch Message-ID: <20060708180150.9AEEC1B0F02C@sampson.opendarwin.org> Rob Buis has asked for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9275: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9275&action=edit ------- Additional Comments from Rob Buis Hi Darin, Justin, I interpreted the suggestions a bit wrong, I thought the macro should go into Platform.h, you probably meant just using Platform.h macros. This time I tried to merge both your suggestions. Let me know if a testcase is required (I tested using http://www.robinlionheart.com/stds/html4/objects) and if so, how to go about the multi-platform aspect. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:04:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9788] storage leaks in Objective-C tests : [Attachment 9268] patch to fix the leaks Message-ID: <20060708180435.722941B0F0DF@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9788: storage leaks in Objective-C tests http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 Attachment 9268: patch to fix the leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9268&action=edit ------- Additional Comments from Geoffrey Garen r=me die leaks die From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:04:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9788] storage leaks in Objective-C tests : [Attachment 9268] patch to fix the leaks Message-ID: <20060708180435.533801B0F0E5@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9788: storage leaks in Objective-C tests http://bugzilla.opendarwin.org/show_bug.cgi?id=9788 Attachment 9268: patch to fix the leaks http://bugzilla.opendarwin.org/attachment.cgi?id=9268&action=edit ------- Additional Comments from Geoffrey Garen r=me die leaks die From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:08:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9250] Patch Message-ID: <20060708180844.4CD481B0F285@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9250: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9250&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:08:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9276] Patch including change log and a repaint test Message-ID: <20060708180844.AE5F81B0F2AC@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9276: Patch including change log and a repaint test http://bugzilla.opendarwin.org/attachment.cgi?id=9276&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:08:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9250] Patch Message-ID: <20060708180844.A43B11B0F2AA@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9250: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9250&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 11:13:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9787] fast/frames tests failing (bad pointer to owner element) under MallocScribble : [Attachment 9277] Patch Message-ID: <20060708181301.706F91B0F380@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9787: fast/frames tests failing (bad pointer to owner element) under MallocScribble http://bugzilla.opendarwin.org/show_bug.cgi?id=9787 Attachment 9277: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9277&action=edit ------- Additional Comments from Anders Carlsson I reworked things a bit so that RenderPart doesn't have to know about the frame. Instead, the elements reset the owner element in ::detach. With this patch I can't reproduce the crash. From dtauyosclpm at vivid-imaging.com Sat Jul 8 15:28:51 2006 From: dtauyosclpm at vivid-imaging.com (you) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] pulled Message-ID: <000701c6a2bc$5c2a1150$2f124555@jean> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 8186 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060708/01f40465/attachment.gif From bugzilla-request-daemon at opendarwin.org Sat Jul 8 14:10:09 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9787] fast/frames tests failing (bad pointer to owner element) under MallocScribble : [Attachment 9277] Patch Message-ID: <20060708211009.E45D01B15779@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9787: fast/frames tests failing (bad pointer to owner element) under MallocScribble http://bugzilla.opendarwin.org/show_bug.cgi?id=9787 Attachment 9277: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9277&action=edit ------- Additional Comments from Darin Adler The line of code in Frame::~Frame that says d->m_ownerElement = 0 doesn't seem necessary. We're destroying the object and we don't need to nil out fields in it. The code should not use renderer->element() -- it should use the more efficient and more sensibly named node() function. Are you certain there's no code path where the frame element gets destroyed without a close call? For example, what about when a whole page and frame tree goes away at once. Same question about the other elements. It seems a little dangerous to me that the frame has a pointer to the owner element, and it's not ref'd. And in the other direction, the owner element has only an indirect memory of the frame -- a frame name. Can these two ever get out of sync? Because if they do, then the Frame has a bad pointer in it. The patch looks fine to me, but I'm still concerned that the object ownership relationship is too fragile. I'm going to say review+ because this is definitely an improvement. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 14:10:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9787] fast/frames tests failing (bad pointer to owner element) under MallocScribble : [Attachment 9277] Patch Message-ID: <20060708211010.857641B1577B@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9787: fast/frames tests failing (bad pointer to owner element) under MallocScribble http://bugzilla.opendarwin.org/show_bug.cgi?id=9787 Attachment 9277: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9277&action=edit ------- Additional Comments from Darin Adler The line of code in Frame::~Frame that says d->m_ownerElement = 0 doesn't seem necessary. We're destroying the object and we don't need to nil out fields in it. The code should not use renderer->element() -- it should use the more efficient and more sensibly named node() function. Are you certain there's no code path where the frame element gets destroyed without a close call? For example, what about when a whole page and frame tree goes away at once. Same question about the other elements. It seems a little dangerous to me that the frame has a pointer to the owner element, and it's not ref'd. And in the other direction, the owner element has only an indirect memory of the frame -- a frame name. Can these two ever get out of sync? Because if they do, then the Frame has a bad pointer in it. The patch looks fine to me, but I'm still concerned that the object ownership relationship is too fragile. I'm going to say review+ because this is definitely an improvement. From foxglove655 at dion.ne.jp Sat Jul 8 18:13:38 2006 From: foxglove655 at dion.ne.jp (‰iˆä —³”V‰î) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=A8=8C=B3=8BC=82=C5=82=B7=82?= =?iso-8859-1?q?=A9=81H?= Message-ID: yŽw–¼ŽóMƒ[ƒ‹1Œz“Í‚«‚Ü‚µ‚½B @@@@@ @¡„­@–³—¿‚̈ÀS™ŠmŽÀ‚Èo‰ï‚¢ @@@@@@ „¯„®„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ¨ @ @^^™—«‰ïˆõ‚Ì‚²Ð‰î™__ @*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-* @w–¼‘Ox[Ⴓ‚ñ @w”N—îx20‘ã @w‘ÌŒ^xƒXƒŒƒ“ƒ_[ @w—öˆ¤ŠÏxî”M“I‚È—öˆ¤ @*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-* @ ‘¦‰ï‚¢‚‚’˜A—æ‚ÌŒðŠ·‚Å‚«‚Ü‚·‚©(*^-^*)HH ‚Ü‚¸‚Í’‡—Ç‚­‚Ȃꂽ‚çƒCƒC‚Å‚·‚Ëù‘‚à‚¿‚ë‚ñˆê”ÓŒÀ‚è‚Ì•t‚«‡‚¢‚Å‚à ‚©‚Ü‚¢‚Ü‚¹‚ñ‚æô‚Ü‚ŸA‚Æ‚É‚©‚­Žn‚ß‚Ä‚Ý‚È‚«‚á‚í‚©‚è‚Ü‚¹‚ñ‚æ‚Ë S(EÍEjƒm‚Ü‚¸‚Í‹CŒy‚ÉŠy‚µ‚Ý‚Ü‚µ‚傤ôô‹X‚µ‚­‚¨Šè‚¢‚µ‚Ü‚·™ @*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-* @–³—¿•ÔM@F@http://love-flex.net/i0u/reg_apply.tpl.html?media=pc480 @“o˜^Šm”F@F@http://love-flex.net/i0u/index.html?media=pc480 @¦ƒtƒŠ[ƒ[ƒ‹ƒAƒhƒŒƒX‚à‚²—˜—p‰Â”\‚Å‚·B @¦Žw–¼‚Í2l‚Ì‚Ý‚Æ‚È‚Á‚Ä‚¨‚è‚Ü‚·‚Ì‚Å‚²’ˆÓ‚­‚¾‚³‚¢B @@@–³—¿‚̈ÀS™ŠmŽÀ‚Èo‰ï‚¢ @@@„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ @@@™@“o˜^@@@@‚O‰~I @@@™@‘ž‚Ý@@@‚O‰~I @@@™@ŒfŽ¦”‰{——@‚O‰~I @@@™@’¼ƒAƒhŒðŠ·@‚O‰~I @@@™@‘Þ‰ï@@@@‚O‰~I @¦ˆÀ‘S‚É‚²—˜—p’¸‚­‚½‚ß‚ÉB @@Š®‘S‰ïˆõŒÀ’è‚̃T[ƒrƒX‚Æ‚³‚¹‚Ä’¸‚¢‚Ä‚¨‚è‚Ü‚·‚»‚Ìˆ× @ –³—¿“o˜^‚ª•K—v‚Æ‚È‚Á‚Ä‚¨‚è‚Ü‚·B From bugzilla-request-daemon at opendarwin.org Sat Jul 8 19:56:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9275] Improved patch Message-ID: <20060709025612.1FC691B1D3C1@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9275: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9275&action=edit ------- Additional Comments from Darin Adler Great, lets land this. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 8 19:56:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs : [Attachment 9275] Improved patch Message-ID: <20060709025612.A1B931B1D3E5@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 8251: netscape.product incorrect in WebKit.app on Intel Macs http://bugzilla.opendarwin.org/show_bug.cgi?id=8251 Attachment 9275: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9275&action=edit ------- Additional Comments from Darin Adler Great, lets land this. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 8 20:27:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9794] Teach run-webkit-tests how to ignore tests with performance improvements : [Attachment 9280] Patch v1 Message-ID: <20060709032730.F11601B1E689@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9794: Teach run-webkit-tests how to ignore tests with performance improvements http://bugzilla.opendarwin.org/show_bug.cgi?id=9794 Attachment 9280: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9280&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes in Patch v1: - Added --ignore-tests command-line switch.  Takes a comma-separated list of tests and test directories to ignore (exclude) when running run-webkit-tests.  Added processIgnoreTests() subroutine to process the arguments. - Added --help command-line switch with usage statement. - Moved call to setConfiguration() before GetOptions() so that --debug/--release arguments are removed from @ARGV before calling GetOptions().  Keep result from call for use with build-dumprendertree later. - Check result of GetOptions() and exit run-webkit-tests if invalid arguments are used. - Made --singly imply --verbose so all of the "$verbose || $singly" checks could be reduced to "$verbose". - Switched from using the find(1) command via subshell to using the File::Find Perl module.  Directory filtering and file filtering are now expressed as anonymous subroutines rather than obscure find(1) command-line arguments.  It's faster, too! - Miscellaneous minor clean up. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 20:54:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 5312] comments aren't available via DOM : [Attachment 9281] Turns on comment nodes and fixes a few issues caused by it Message-ID: <20060709035443.AD7711B1EC50@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9281: Turns on comment nodes and fixes a few issues caused by it http://bugzilla.opendarwin.org/attachment.cgi?id=9281&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 8 21:11:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 5312] comments aren't available via DOM : [Attachment 9281] Turns on comment nodes and fixes a few issues caused by it Message-ID: <20060709041103.A6CCE1B1FB82@sampson.opendarwin.org> Timothy Hatcher has cancelled Timothy Hatcher 's request for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9281: Turns on comment nodes and fixes a few issues caused by it http://bugzilla.opendarwin.org/attachment.cgi?id=9281&action=edit ------- Additional Comments from Timothy Hatcher Uses the mutable keyword on m_documentElement to keep documentElement() a const. This eliminates my earlier const changes. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 21:11:04 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 5312] comments aren't available via DOM : [Attachment 9281] Turns on comment nodes and fixes a few issues caused by it Message-ID: <20060709041104.09ED71B1FB84@sampson.opendarwin.org> Timothy Hatcher has cancelled Timothy Hatcher 's request for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9281: Turns on comment nodes and fixes a few issues caused by it http://bugzilla.opendarwin.org/attachment.cgi?id=9281&action=edit ------- Additional Comments from Timothy Hatcher Uses the mutable keyword on m_documentElement to keep documentElement() a const. This eliminates my earlier const changes. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 21:11:04 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 5312] comments aren't available via DOM : [Attachment 9282] New version that keeps documentElement const Message-ID: <20060709041104.7630F1B1FBB3@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9282: New version that keeps documentElement const http://bugzilla.opendarwin.org/attachment.cgi?id=9282&action=edit ------- Additional Comments from Timothy Hatcher Uses the mutable keyword on m_documentElement to keep documentElement() a const. This eliminates my earlier const changes. From bugzilla-request-daemon at opendarwin.org Sat Jul 8 21:13:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9797] Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 : [Attachment 9283] Patch v1 Message-ID: <20060709041355.9FB6A1B1FC2B@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9797: Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 http://bugzilla.opendarwin.org/show_bug.cgi?id=9797 Attachment 9283: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9283&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Proposed patch. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 00:41:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 5312] comments aren't available via DOM : [Attachment 9282] New version that keeps documentElement const Message-ID: <20060709074100.1173C1B25883@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9282: New version that keeps documentElement const http://bugzilla.opendarwin.org/attachment.cgi?id=9282&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 00:40:59 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 5312] comments aren't available via DOM : [Attachment 9282] New version that keeps documentElement const Message-ID: <20060709074059.F32ED1B25881@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 5312: comments aren't available via DOM http://bugzilla.opendarwin.org/show_bug.cgi?id=5312 Attachment 9282: New version that keeps documentElement const http://bugzilla.opendarwin.org/attachment.cgi?id=9282&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 00:44:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9794] Teach run-webkit-tests how to ignore tests with performance improvements : [Attachment 9280] Patch v1 Message-ID: <20060709074408.BBD6A1B2595E@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9794: Teach run-webkit-tests how to ignore tests with performance improvements http://bugzilla.opendarwin.org/show_bug.cgi?id=9794 Attachment 9280: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9280&action=edit ------- Additional Comments from Timothy Hatcher Nice cleanup. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 00:44:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9794] Teach run-webkit-tests how to ignore tests with performance improvements : [Attachment 9280] Patch v1 Message-ID: <20060709074408.BEF731B2595F@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9794: Teach run-webkit-tests how to ignore tests with performance improvements http://bugzilla.opendarwin.org/show_bug.cgi?id=9794 Attachment 9280: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9280&action=edit ------- Additional Comments from Timothy Hatcher Nice cleanup. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 04:50:27 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9804] Spelling error in build-webkit script : [Attachment 9292] This patch fixes the error. Message-ID: <20060709115027.574241B2ECE2@sampson.opendarwin.org> coldwinter@katamail.com has asked for review: Bug 9804: Spelling error in build-webkit script http://bugzilla.opendarwin.org/show_bug.cgi?id=9804 Attachment 9292: This patch fixes the error. http://bugzilla.opendarwin.org/attachment.cgi?id=9292&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 04:58:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9804] Spelling error in build-webkit script : [Attachment 9292] This patch fixes the error. Message-ID: <20060709115815.333501B2EEDC@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9804: Spelling error in build-webkit script http://bugzilla.opendarwin.org/show_bug.cgi?id=9804 Attachment 9292: This patch fixes the error. http://bugzilla.opendarwin.org/attachment.cgi?id=9292&action=edit ------- Additional Comments from Eric Seidel Wow. I'm shocked no one caught this before now. This was my typo... many many months ago. :( From bugzilla-request-daemon at opendarwin.org Sun Jul 9 04:58:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9804] Spelling error in build-webkit script : [Attachment 9292] This patch fixes the error. Message-ID: <20060709115815.3C11F1B2EF6F@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9804: Spelling error in build-webkit script http://bugzilla.opendarwin.org/show_bug.cgi?id=9804 Attachment 9292: This patch fixes the error. http://bugzilla.opendarwin.org/attachment.cgi?id=9292&action=edit ------- Additional Comments from Eric Seidel Wow. I'm shocked no one caught this before now. This was my typo... many many months ago. :( From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:27:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9797] Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 : [Attachment 9283] Patch v1 Message-ID: <20060709142748.C27DF1B33B87@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9797: Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 http://bugzilla.opendarwin.org/show_bug.cgi?id=9797 Attachment 9283: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9283&action=edit ------- Additional Comments from Darin Adler OK. But if you want it to keep working with IE 6 you should probably add a comment so people don't modify it. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:27:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9797] Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 : [Attachment 9283] Patch v1 Message-ID: <20060709142748.90FA11B33B8E@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9797: Make description() in fast/js/resources/js-test-pre.js work with MSIE 6 http://bugzilla.opendarwin.org/show_bug.cgi?id=9797 Attachment 9283: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9283&action=edit ------- Additional Comments from Darin Adler OK. But if you want it to keep working with IE 6 you should probably add a comment so people don't modify it. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:28:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9296] First attempt Message-ID: <20060709142814.C08461B33C0B@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9296: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9296&action=edit ------- Additional Comments from Rob Buis This patch actually solves a bigger problem, relayouting/resizing of svg elements that depend on percentages. I will add a testcase should the code get okayed. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:36:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9693] svn-apply should set ChangeLog date correctly when applying patches : [Attachment 9297] Patch v1 Message-ID: <20060709143638.743601B33F82@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9693: svn-apply should set ChangeLog date correctly when applying patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9693 Attachment 9297: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9297&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes in this patch: - svn-apply changes the ChangeLog entry date in the patch before applying it to the actual ChangeLog file.  The new entry date is calculated using the "PST8PDT" timezone (Apple's home) by setting the TZ environment variable, formatting the "local" time in a string, then resetting the TZ env variable.  This works under Cygwin on Windows as well. - svn-unapply reads the current ChangeLog entry date contained in the file and changes the patch before unapplying it. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:46:41 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9296] First attempt Message-ID: <20060709144641.107B11B34270@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9296: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9296&action=edit ------- Additional Comments from Eric Seidel Looks good. There are a couple mis-placed *'s: RenderObject * RenderPath * Also, I've more commonly seen multi-line ifs broken before the binary operator, instead of after, example: if (foo || bar || baz) Not sure if there is an official practice in that regard or not. r=me. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 07:46:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9296] First attempt Message-ID: <20060709144640.EC9021B3426D@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9296: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9296&action=edit ------- Additional Comments from Eric Seidel Looks good. There are a couple mis-placed *'s: RenderObject * RenderPath * Also, I've more commonly seen multi-line ifs broken before the binary operator, instead of after, example: if (foo || bar || baz) Not sure if there is an official practice in that regard or not. r=me. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 11:18:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9300] Patch with manual test and changelog Message-ID: <20060709181834.0C6491B4066C@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9300: Patch with manual test and changelog http://bugzilla.opendarwin.org/attachment.cgi?id=9300&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com From bugzilla-request-daemon at opendarwin.org Sun Jul 9 12:32:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9304] Improved patch+testcase Message-ID: <20060709193253.5E3661B463C2@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9304: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9304&action=edit ------- Additional Comments from Rob Buis I fixed MacDome's issues, the || we decided is not crucial since it is done inconsistent throughout webkit codebase. I also added a testcase based on Joost's one. Note that all svg tests are changed because all RenderSVGText objects get 15 added to the width because the scrollbar is not taken into account anymore. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 13:52:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9304] Improved patch+testcase Message-ID: <20060709205200.0C7B01B48AD7@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9304: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9304&action=edit ------- Additional Comments from Rob Buis Fixing Weinigs issues :) Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 13:51:59 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9304] Improved patch+testcase Message-ID: <20060709205159.EB0951B48AD5@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9304: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9304&action=edit ------- Additional Comments from Rob Buis Fixing Weinigs issues :) Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 13:52:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9305] Improved patch+testcase Message-ID: <20060709205200.3C5731B48AF3@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9305: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9305&action=edit ------- Additional Comments from Rob Buis Fixing Weinigs issues :) Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 13:57:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9298] Final build fix patch Message-ID: <20060709205737.B450E1B4917F@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9298: Final build fix patch http://bugzilla.opendarwin.org/attachment.cgi?id=9298&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 14:29:58 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9812] LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed : [Attachment 9309] Patch v1 Message-ID: <20060709212958.C1E601B4A49B@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9812: LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9812 Attachment 9309: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9309&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Updated pixel test results. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 15:09:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9245] Quirksmode: Incorrect handling of disabled BUTTON elements : [Attachment 9312] Patch Message-ID: <20060709220952.0DE8E1B4BCAF@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9245: Quirksmode: Incorrect handling of disabled BUTTON elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9245 Attachment 9312: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9312&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 15:41:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9487] The XPath section should be removed and/or moved. : [Attachment 9314] Removes the XPath section Message-ID: <20060709224145.7E3F31B4C713@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9487: The XPath section should be removed and/or moved. http://bugzilla.opendarwin.org/show_bug.cgi?id=9487 Attachment 9314: Removes the XPath section http://bugzilla.opendarwin.org/attachment.cgi?id=9314&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 16:57:58 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9814] Move WebView new API that has been through API review to public headers : [Attachment 9315] Moves the API Message-ID: <20060709235758.8305E1B5099F@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9814: Move WebView new API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9814 Attachment 9315: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9315&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:03:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9487] The XPath section should be removed and/or moved. : [Attachment 9314] Removes the XPath section Message-ID: <20060710000310.8D1161B51A81@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9487: The XPath section should be removed and/or moved. http://bugzilla.opendarwin.org/show_bug.cgi?id=9487 Attachment 9314: Removes the XPath section http://bugzilla.opendarwin.org/attachment.cgi?id=9314&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:03:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9487] The XPath section should be removed and/or moved. : [Attachment 9314] Removes the XPath section Message-ID: <20060710000310.27D8D1B51A85@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9487: The XPath section should be removed and/or moved. http://bugzilla.opendarwin.org/show_bug.cgi?id=9487 Attachment 9314: Removes the XPath section http://bugzilla.opendarwin.org/attachment.cgi?id=9314&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:04:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9245] Quirksmode: Incorrect handling of disabled BUTTON elements : [Attachment 9312] Patch Message-ID: <20060710000446.5ADB81B51CDA@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9245: Quirksmode: Incorrect handling of disabled BUTTON elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9245 Attachment 9312: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9312&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:04:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9245] Quirksmode: Incorrect handling of disabled BUTTON elements : [Attachment 9312] Patch Message-ID: <20060710000446.750F11B51CDD@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9245: Quirksmode: Incorrect handling of disabled BUTTON elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9245 Attachment 9312: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9312&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:32:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9812] LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed : [Attachment 9309] Patch v1 Message-ID: <20060710003250.A2C251B547AD@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9812: LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9812 Attachment 9309: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9309&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:32:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9812] LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed : [Attachment 9309] Patch v1 Message-ID: <20060710003250.AEE581B547AE@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9812: LayoutTests/svg/custom/foreign-object-skew.svg seems to be fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9812 Attachment 9309: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9309&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:34:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9814] Move new WebView API that has been through API review to public headers : [Attachment 9315] Moves the API Message-ID: <20060710003449.D8F571B549C3@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9814: Move new WebView API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9814 Attachment 9315: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9315&action=edit ------- Additional Comments from Darin Adler + @param drawsBackround YES to cause the receiver draws a default white background, NO otherwise. Typo. r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:34:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9814] Move new WebView API that has been through API review to public headers : [Attachment 9315] Moves the API Message-ID: <20060710003450.8D7451B549C7@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9814: Move new WebView API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9814 Attachment 9315: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9315&action=edit ------- Additional Comments from Darin Adler + @param drawsBackround YES to cause the receiver draws a default white background, NO otherwise. Typo. r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9693] svn-apply should set ChangeLog date correctly when applying patches : [Attachment 9297] Patch v1 Message-ID: <20060710003603.BFE891B54A98@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9693: svn-apply should set ChangeLog date correctly when applying patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9693 Attachment 9297: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9297&action=edit ------- Additional Comments from Darin Adler Can we make it use the current time zone on Mac OS X automatically? r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9693] svn-apply should set ChangeLog date correctly when applying patches : [Attachment 9297] Patch v1 Message-ID: <20060710003603.B79701B54A9F@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9693: svn-apply should set ChangeLog date correctly when applying patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9693 Attachment 9297: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9297&action=edit ------- Additional Comments from Darin Adler Can we make it use the current time zone on Mac OS X automatically? r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:37:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9300] Patch with manual test and changelog Message-ID: <20060710003724.51A931B554F1@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9300: Patch with manual test and changelog http://bugzilla.opendarwin.org/attachment.cgi?id=9300&action=edit ------- Additional Comments from Darin Adler Will this extra check have a measurable performance impact? If not, then r=me, but how can we be sure? From bugzilla-request-daemon at opendarwin.org Sun Jul 9 17:37:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9300] Patch with manual test and changelog Message-ID: <20060710003724.6DB0D1B55522@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9300: Patch with manual test and changelog http://bugzilla.opendarwin.org/attachment.cgi?id=9300&action=edit ------- Additional Comments from Darin Adler Will this extra check have a measurable performance impact? If not, then r=me, but how can we be sure? From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:27:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9319] Moves the API Message-ID: <20060710012752.D77541B5A39A@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9319: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9319&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:37:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9243] patch Message-ID: <20060710013757.BC1011B5A568@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9243: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9243&action=edit ------- Additional Comments from Beth Dakin So Maciej and I talked about this on IRC, and we couldn't figure out why the check for the firstLineBox was there at all. So this patch just removes that check entirey. It causes no layout test failures. We are assuming that its presense in determining if we need a full layout is antiquated. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:37:58 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9320] New patch Message-ID: <20060710013758.10DE11B5A56B@sampson.opendarwin.org> Beth Dakin has asked for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9320: New patch http://bugzilla.opendarwin.org/attachment.cgi?id=9320&action=edit ------- Additional Comments from Beth Dakin So Maciej and I talked about this on IRC, and we couldn't figure out why the check for the firstLineBox was there at all. So this patch just removes that check entirey. It causes no layout test failures. We are assuming that its presense in determining if we need a full layout is antiquated. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:37:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9243] patch Message-ID: <20060710013757.17E5E1B5A56C@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9243: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9243&action=edit ------- Additional Comments from Beth Dakin So Maciej and I talked about this on IRC, and we couldn't figure out why the check for the firstLineBox was there at all. So this patch just removes that check entirey. It causes no layout test failures. We are assuming that its presense in determining if we need a full layout is antiquated. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:40:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9320] New patch Message-ID: <20060710014022.244621B5A662@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9320: New patch http://bugzilla.opendarwin.org/attachment.cgi?id=9320&action=edit ------- Additional Comments from Maciej Stachowiak r=me May the lord have mercy on my soul if this was wrong. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:40:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9749] A nested content editable div causes unnecessary screen redraws. : [Attachment 9320] New patch Message-ID: <20060710014022.9ABD71B5A65E@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9749: A nested content editable div causes unnecessary screen redraws. http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 Attachment 9320: New patch http://bugzilla.opendarwin.org/attachment.cgi?id=9320&action=edit ------- Additional Comments from Maciej Stachowiak r=me May the lord have mercy on my soul if this was wrong. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:40:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9319] Moves the API Message-ID: <20060710014054.C2F3F1B5A6B8@sampson.opendarwin.org> Timothy Hatcher has cancelled Timothy Hatcher 's request for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9319: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9319&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:40:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review cancelled: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9319] Moves the API Message-ID: <20060710014054.C027B1B5A6B6@sampson.opendarwin.org> Timothy Hatcher has cancelled Timothy Hatcher 's request for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9319: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9319&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 18:40:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9321] New version that keeps the deprecated methods. Message-ID: <20060710014054.A08D51B5BDC1@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9321: New version that keeps the deprecated methods. http://bugzilla.opendarwin.org/attachment.cgi?id=9321&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 19:47:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review requested: [Bug 9820] Move new DOM API that has been through API review to public headers : [Attachment 9322] Moves the API Message-ID: <20060710024748.8FFE31B5C92A@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9820: Move new DOM API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9820 Attachment 9322: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9322&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 19:50:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9820] Move new DOM API that has been through API review to public headers : [Attachment 9322] Moves the API Message-ID: <20060710025025.28D701B5C991@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9820: Move new DOM API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9820 Attachment 9322: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9322&action=edit ------- Additional Comments from Darin Adler In DOMXPath.mm, the config.h should be outside the if, since it can help set XPATH_SUPPORT in theory. r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 19:50:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9820] Move new DOM API that has been through API review to public headers : [Attachment 9322] Moves the API Message-ID: <20060710025025.CAD681B5C98D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9820: Move new DOM API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9820 Attachment 9322: Moves the API http://bugzilla.opendarwin.org/attachment.cgi?id=9322&action=edit ------- Additional Comments from Darin Adler In DOMXPath.mm, the config.h should be outside the if, since it can help set XPATH_SUPPORT in theory. r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 9 19:55:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] review granted: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9321] New version that keeps the deprecated methods. Message-ID: <20060710025519.BBDB81B5CA79@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9321: New version that keeps the deprecated methods. http://bugzilla.opendarwin.org/attachment.cgi?id=9321&action=edit ------- Additional Comments from Timothy Hatcher Reviewed by Kevin on IRC. From dismissal885 at lycos.co.jp Sun Jul 9 20:11:32 2006 From: dismissal885 at lycos.co.jp (ªŠÝ ãÄ^) Date: Tue Oct 9 17:56:35 2007 Subject: [webkit-reviews] Re: Message-ID: „¡„Ÿ„¦„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„¢ „ ¡„ @—öˆ¤ŒoŒ±’l‚ð10”{‰Ò‚®¬Œ÷–@@@@„  „¤„Ÿ„¨„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„£ ™ƒlƒbƒg—öˆ¤‚ð¬Œ÷‚³‚¹‚邽‚ß‚É•K—v‚ÈŽ–F ƒŠƒAƒ‹‚Åoˆ§‚¤‚æ‚èƒlƒbƒg‚Å‚Ìo‰ï‚¢‚Í Šî–{“I‚É‘¼‚Ì’j«‚Æ‚Ì‹£‘ˆ‚É‚È‚è‚Ü‚·B “–‘R‚Ç‚±‚©‚Å—DˆÊ‚É—§‚Ä‚éƒ|ƒCƒ“ƒg‚ª‚È‚¯‚ê‚ÎA –Ú“I‚̈٫‚©‚ç‚͉“‚´‚©‚Á‚Ä‚µ‚Ü‚¢‚Ü‚·B ™—öˆ¤ŒoŒ±’l‚Æ‚ÍHF —öˆ¤ŒoŒ±’l‚ÍŒoŒ±‚Ì—Ê‚Å‚Í‚È‚­Ž¿‚ÅŒˆ‚Ü‚é‚ÆŽv‚¢‚Ü‚·B ˆê–éŒÀ‚è‚ÌŠÖŒW‚àAŒ‹¥‚Ü‚ÅŽŠ‚éŠÖŒW‚à —öˆ¤ŒoŒ±’l‚Ì‚‚¢•û‚ª—L—˜‚ÈŽ–‚ÍŒ¾‚¤‚Ü‚Å‚à‚È‚¢‚Å‚µ‚傤B ™—öˆ¤ŒoŒ±’l‚ð10”{‰Ò‚®‚É‚ÍHF ‚±‚±‚Å‚ÍŽc”O‚È‚ª‚çAŽ„‚ª¡‚Ü‚Å‚É ŽŽ‚µA•ªÍ‚µA‚»‚ÌŒ‹‰Ê•ª‚©‚Á‚½ ׂ©‚¢ƒmƒEƒnƒE‚â‘ÌŒ±’k‚È‚Ç‚ð‚¨“`‚¦o—ˆ‚éƒXƒy[ƒX‚ª‚ ‚è‚Ü‚¹‚ñB ‚»‚Ì‘ã‚í‚è‚ÉŒoŒ±’l‚ðã‚°‚ç‚ê‚éƒTƒCƒg‚ð‚²Ð‰î‚µ‚Ü‚·B —öˆ¤—ƒ}ƒbƒ` http://love-flex.net/index.html?media=pc343 —öˆ¤‚̓}ƒbƒ`ƒ“ƒO«‚ª‚Æ‚Ä‚àd—v‚Å‚·B FX‚È—«‚Æ•t‚«‡‚¤‚±‚Æ‚à•×‹­‚É‚È‚è‚Ü‚·‚ªA ‚¨ŒÝ‚¢‚ð[‚­’m‚Á‚Ä‚¢‚­‚±‚Æ‚ª—öˆ¤‚ÌŽ¿‚ðã‚°‚邱‚Æ‚É‚È‚è‚Ü‚·B –³—¿‚Å—˜—po—ˆ‚Ü‚·‚Ì‚ÅA —öˆ¤ŒoŒ±’l‚ðã‚°‚邽‚ß‚É—lX‚È•û–@‚ðŽŽ‚µ‚ĉº‚³‚¢B @--------™ š ™@@@@@—öˆ¤@ƒ}ƒbƒ`@@@@@™ š ™-------- @@Profile @@”Å°½‚Ì—‘ù‘‚Ÿ‚コ‚ñ @@”10‘ãi18ΈÈãj@‘ÌŒ^F‚Û‚Á‚¿‚á‚è @@”‚Ó‚í‚Ó‚í“V‘RŒn \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ @@ŽhŒƒ“I‚ȶݹ²‚É‚È‚è‚Ü‚µ‚傤`ù‘ùš @@Ú×F@http://love-flex.net/reg_apply.tpl.html?media=pc343 @--------™ š ™@@@@@—öˆ¤@ƒ}ƒbƒ`@@@@@™ š ™-------- @@Profile @@”ƒiƒ‹ƒ~‚³‚ñ @@”20‘ã@‘ÌŒ^F•W€ @@”ƒjƒRƒjƒRŽÐŒðŒn \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ @@‚o‚q‚Á‚ĉ½‘‚¢‚½‚ç‚¢‚¢‚©‚í‚©‚ç‚È‚¢‚Å‚·(AGL 3`)–é‚ÌŽdŽ–‚ð @@‚µ‚Ä‚¢‚Ä¡”N‚Å26΂ɂȂè‚Ü‚·‚£S(L¤M*)ƒm™½·‚ȺĂ͙‚¨Žð @@‚Ɖ·ò—·s‚ÆȲٙ*š*™Å‹ß‚ÌϲÌްт͎₵‚¢1l•é‚炵‚ÌŽ©•ª‚É @@‚¨”N‹Ê‹C•ª‚Å”ƒ‚Á‚½ˆ¤Œ¢‚ÌÊÛ°‚Å‚·ôÒ¯¾°¼Þ‘Ò‚Á‚Ä‚Ü‚·‚£II @@Ú×F@http://love-flex.net/reg_apply.tpl.html?media=pc343 @--------™ š ™@@@@@—öˆ¤@ƒ}ƒbƒ`@@@@@™ š ™-------- @@Profile @@”m”ü‚³‚ñ @@”30‘ã@‘ÌŒ^FƒXƒŒƒ“ƒ_[ @@”ƒAƒNƒeƒBƒuŠˆ“®Œn \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\ @@—£¥‚µ‹Ž”N‚ÌI‚í‚è‚©‚炱‚Á‚¿(ŽÀ‰Æ)‚É–ß‚Á‚Ä—ˆ‚Ü‚µ‚½B @@‚à‚Æ‚à‚Æê‹ÆŽå•w‚¾‚Á‚½‚Ì‚ÅA‚±‚ê‚©‚çAEŠˆ“®(Î)¡‚Í—¼e‚É @@¬Œ¾‚ðŒ¾‚í‚ê‚È‚ª‚ç‰ÆŽ–‚ðŽè“`‚¤–ˆ“ú‚È‚Ì‚ÅAÄAE‚ªŒˆ‚Ü‚é‚Ü‚Å @@—\’è‚à‚È‚­‰É‚ÈŽžŠÔ‚𖈓ú‰ß‚²‚µ‚Ä‚¢‚Ü‚·B—Ç‚©‚Á‚½‚炨º‚ð‚©‚¯ @@‚Ä‚­‚¾‚³‚¢BpsŽq‹Ÿ‚Í‚¢‚Ü‚¹‚ñ‚Ì‚Å‚²ˆÀS‚­‚¾‚³‚¢(Î) @@Ú×F@http://love-flex.net/reg_apply.tpl.html?media=pc343 From bugzilla-request-daemon at opendarwin.org Sun Jul 9 20:20:20 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9822] move more from the global namespace into the WebCore namespace : [Attachment 9323] patch, including change log Message-ID: <20060710032020.D5A861B5DBB4@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9822: move more from the global namespace into the WebCore namespace http://bugzilla.opendarwin.org/show_bug.cgi?id=9822 Attachment 9323: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9323&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 19:55:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9818] move new UIDelegate API that has been through API review to public headers : [Attachment 9321] New version that keeps the deprecated methods. Message-ID: <20060710025519.D7AB71B5DBB5@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9818: move new UIDelegate API that has been through API review to public headers http://bugzilla.opendarwin.org/show_bug.cgi?id=9818 Attachment 9321: New version that keeps the deprecated methods. http://bugzilla.opendarwin.org/attachment.cgi?id=9321&action=edit ------- Additional Comments from Timothy Hatcher Reviewed by Kevin on IRC. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 21:41:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9189] Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set Message-ID: <20060710044101.9AE831B5FE1C@sampson.opendarwin.org> David Kilzer (ddkilzer) has denied David Kilzer (ddkilzer) 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9189: Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set http://bugzilla.opendarwin.org/attachment.cgi?id=9189&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 21:41:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9298] Final build fix patch Message-ID: <20060710044114.A99601B5FE80@sampson.opendarwin.org> David Kilzer (ddkilzer) has denied David Kilzer (ddkilzer) 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9298: Final build fix patch http://bugzilla.opendarwin.org/attachment.cgi?id=9298&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 22:09:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9822] move more from the global namespace into the WebCore namespace : [Attachment 9323] patch, including change log Message-ID: <20060710050951.73EC91B61020@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9822: move more from the global namespace into the WebCore namespace http://bugzilla.opendarwin.org/show_bug.cgi?id=9822 Attachment 9323: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9323&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 22:09:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9822] move more from the global namespace into the WebCore namespace : [Attachment 9323] patch, including change log Message-ID: <20060710050951.6A68B1B6101F@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9822: move more from the global namespace into the WebCore namespace http://bugzilla.opendarwin.org/show_bug.cgi?id=9822 Attachment 9323: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9323&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 9 22:26:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9179] Implement select.options.add() method : [Attachment 9325] Patch v3 Message-ID: <20060710052646.860241B61839@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9325: Patch v3 http://bugzilla.opendarwin.org/attachment.cgi?id=9325&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes since Patch v2: - Added more test cases specifically targeting -Infinity, NaN and +Infinity in fast/dom/select-selectedIndex-multiple.html and fast/js/select-options-add.html. - Made sure fast/dom/select-selectedIndex.html was kept in sync with test cases from select-selectedIndex-multiple.html. - Overloaded KJS::JSValue::toInt32() to take a boolean 'Ok' argument to flag when zero is returned for a float with a value of +-Infinity or NaN. - Setting the options.length to a negative value now throws an exception.  (This mimics MSIE 6, but differs from Firefox 1.5.0.x.) - Passing anything other than an option element to options.add() causes an exception to be thrown for all cases now (including +-Infinity and NaN, which were being valued to zero before; this is where the new toInt32() method is used to trap these values as errors). - Changed overloaded function feature in CodeGeneratorJS.pm to use "argCount <" instead of "argCount ==" comparison. - Changed CanFailTypeConversion() in CodeGeneratorJS.pm to return true for "unsigned long" and "long" types.  (They now use the new toInt32() overloaded method.) - Changed JSValueToNative() in CodeGeneratorJS.pm to use new toInt32() overloaded method. All layout tests still pass with these changes.  Will upload Firefox 1.5.0.5rc3 and MSIE 6 test results next. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 23:26:58 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9300] Patch with manual test and changelog Message-ID: <20060710062658.83BE21B630B7@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled Darin Adler 's request for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9300: Patch with manual test and changelog http://bugzilla.opendarwin.org/attachment.cgi?id=9300&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Going to play it safe performance-wise and move the check into the complex path where it matters. From bugzilla-request-daemon at opendarwin.org Sun Jul 9 23:32:56 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9179] Implement select.options.add() method : [Attachment 9325] Patch v3 Message-ID: <20060710063256.3A2661B631B6@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9325: Patch v3 http://bugzilla.opendarwin.org/attachment.cgi?id=9325&action=edit ------- Additional Comments from Darin Adler This seems nearly perfect even though I have a few minor quibbles. I'm concerned about adding another level of function call for every caller of toInt32, which might be hot. Maybe just repeat the code twice? I think the bool& parameter's purpose is not self-explanatory and so I think it should have a name in the header. I don't see the code to set $maybeOkParam! + return 1; # 0; # or can it? The above line of code is confusing, even more than it was before. This is getting really close, but review- for now for at least some of these questions. This change looks really great. Lets get it landed! From bugzilla-request-daemon at opendarwin.org Sun Jul 9 23:32:56 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9179] Implement select.options.add() method : [Attachment 9325] Patch v3 Message-ID: <20060710063256.3C2861B631BC@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9325: Patch v3 http://bugzilla.opendarwin.org/attachment.cgi?id=9325&action=edit ------- Additional Comments from Darin Adler This seems nearly perfect even though I have a few minor quibbles. I'm concerned about adding another level of function call for every caller of toInt32, which might be hot. Maybe just repeat the code twice? I think the bool& parameter's purpose is not self-explanatory and so I think it should have a name in the header. I don't see the code to set $maybeOkParam! + return 1; # 0; # or can it? The above line of code is confusing, even more than it was before. This is getting really close, but review- for now for at least some of these questions. This change looks really great. Lets get it landed! From bugzilla-request-daemon at opendarwin.org Mon Jul 10 00:44:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9305] Improved patch+testcase Message-ID: <20060710074440.B773F1B656CC@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9305: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9305&action=edit ------- Additional Comments from Maciej Stachowiak r=me Really though I think we ultimately want more of percentage handling to be in the render tree, not the DOM. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 00:44:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9305] Improved patch+testcase Message-ID: <20060710074440.3289E1B656D2@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9305: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9305&action=edit ------- Additional Comments from Maciej Stachowiak r=me Really though I think we ultimately want more of percentage handling to be in the render tree, not the DOM. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:00:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9244] Custom implementaion of time functions in WTF Message-ID: <20060710080050.B71921B664DA@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9244: Custom implementaion of time functions in WTF http://bugzilla.opendarwin.org/attachment.cgi?id=9244&action=edit ------- Additional Comments from Darin Adler Looks like a step in the right direction. But why are all these functions entirely inlined? That doesn't seem right for code as big as this. Lets put the implementation in the .cpp file. In yearFromTime, it looks to me like the code would be better if instead of calling floor in the year expression the code simply cast to (int). That does the floor "for free" and we want year to be an int anyway. The only uses of it are casted to int later and the only operation done subsequently is to subtract 1. This looks great. Please fix DateExtras.h to not be all inline, and then lets get that in! From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:00:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9244] Custom implementaion of time functions in WTF Message-ID: <20060710080050.57A4C1B664F6@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9244: Custom implementaion of time functions in WTF http://bugzilla.opendarwin.org/attachment.cgi?id=9244&action=edit ------- Additional Comments from Darin Adler Looks like a step in the right direction. But why are all these functions entirely inlined? That doesn't seem right for code as big as this. Lets put the implementation in the .cpp file. In yearFromTime, it looks to me like the code would be better if instead of calling floor in the year expression the code simply cast to (int). That does the floor "for free" and we want year to be an int anyway. The only uses of it are casted to int later and the only operation done subsequently is to subtract 1. This looks great. Please fix DateExtras.h to not be all inline, and then lets get that in! From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:34:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9208] Only ignore unqualified :hover rules in quirks mode Message-ID: <20060710083415.538A01B67244@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9208: Only ignore unqualified :hover rules in quirks mode http://bugzilla.opendarwin.org/attachment.cgi?id=9208&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:34:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9208] Only ignore unqualified :hover rules in quirks mode Message-ID: <20060710083415.38E651B67241@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9208: Only ignore unqualified :hover rules in quirks mode http://bugzilla.opendarwin.org/attachment.cgi?id=9208&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:35:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9208] Only ignore unqualified :hover rules in quirks mode Message-ID: <20060710083505.121B31B672E5@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9208: Only ignore unqualified :hover rules in quirks mode http://bugzilla.opendarwin.org/attachment.cgi?id=9208&action=edit ------- Additional Comments from Maciej Stachowiak Er, meant to r- this due to comments above. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 01:47:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9827] Support CSS3 content: : [Attachment 9332] First patch Message-ID: <20060710084707.331891B675C1@sampson.opendarwin.org> Beth Dakin has asked for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9332: First patch http://bugzilla.opendarwin.org/attachment.cgi?id=9332&action=edit ------- Additional Comments from Beth Dakin So here is a patch. I am not sure it's right. I am not sure I am even interpreting the spec correctly. And even if I am, this patch ignores text (there will need to be a follow-up bug about that). Also, I am not sure that peppering all of the createRenderer() functions with the check for contentData() is the most elegant implementation. Feedback desired! From bugzilla-request-daemon at opendarwin.org Mon Jul 10 02:20:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9333] Updated patch Message-ID: <20060710092025.C4C301B68D95@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9333: Updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9333&action=edit ------- Additional Comments from Mark Rowe (bdash) Changed point of use as per Maciej's comment. I'm not really sure why I missed that initially. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:05:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9827] Support CSS3 content: : [Attachment 9332] First patch Message-ID: <20060710110543.05C731B6C382@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9332: First patch http://bugzilla.opendarwin.org/attachment.cgi?id=9332&action=edit ------- Additional Comments from Beth Dakin Maciej and I talked about this a bunch over iChat. Here is a revised patch based on our conversation. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:05:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9827] Support CSS3 content: : [Attachment 9332] First patch Message-ID: <20060710110543.25E341B6C40A@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9332: First patch http://bugzilla.opendarwin.org/attachment.cgi?id=9332&action=edit ------- Additional Comments from Beth Dakin Maciej and I talked about this a bunch over iChat. Here is a revised patch based on our conversation. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:05:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9827] Support CSS3 content: : [Attachment 9336] newer Message-ID: <20060710110543.32CCE1B6C40C@sampson.opendarwin.org> Beth Dakin has asked for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9336: newer http://bugzilla.opendarwin.org/attachment.cgi?id=9336&action=edit ------- Additional Comments from Beth Dakin Maciej and I talked about this a bunch over iChat. Here is a revised patch based on our conversation. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:29:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9827] Support CSS3 content: : [Attachment 9336] newer Message-ID: <20060710112925.DD1641B6EE4D@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9336: newer http://bugzilla.opendarwin.org/attachment.cgi?id=9336&action=edit ------- Additional Comments from Beth Dakin A little more tweaking, some changelogs, and some layout tests. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:29:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9827] Support CSS3 content: : [Attachment 9337] again! Message-ID: <20060710112926.2728E1B6EE50@sampson.opendarwin.org> Beth Dakin has asked for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9337: again! http://bugzilla.opendarwin.org/attachment.cgi?id=9337&action=edit ------- Additional Comments from Beth Dakin A little more tweaking, some changelogs, and some layout tests. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:29:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9827] Support CSS3 content: : [Attachment 9336] newer Message-ID: <20060710112925.2D99E1B6EE51@sampson.opendarwin.org> Beth Dakin has cancelled Beth Dakin 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9336: newer http://bugzilla.opendarwin.org/attachment.cgi?id=9336&action=edit ------- Additional Comments from Beth Dakin A little more tweaking, some changelogs, and some layout tests. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:30:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9827] Support CSS3 content: : [Attachment 9337] again! Message-ID: <20060710113034.8DFB81B6EEF1@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9337: again! http://bugzilla.opendarwin.org/attachment.cgi?id=9337&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 04:30:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9827] Support CSS3 content: : [Attachment 9337] again! Message-ID: <20060710113034.0FF3D1B6EF25@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9827: Support CSS3 content: http://bugzilla.opendarwin.org/show_bug.cgi?id=9827 Attachment 9337: again! http://bugzilla.opendarwin.org/attachment.cgi?id=9337&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:04:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9512] [S60] build script does not support s60 for 3rd edition, Maint Rel : [Attachment 9338] Support for maint release of SDK Message-ID: <20060710140417.604121B73A46@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9512: [S60] build script does not support s60 for 3rd edition, Maint Rel http://bugzilla.opendarwin.org/show_bug.cgi?id=9512 Attachment 9338: Support for maint release of SDK http://bugzilla.opendarwin.org/attachment.cgi?id=9338&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:04:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9512] [S60] build script does not support s60 for 3rd edition, Maint Rel : [Attachment 9338] Support for maint release of SDK Message-ID: <20060710140417.6F7CE1B73A47@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9512: [S60] build script does not support s60 for 3rd edition, Maint Rel http://bugzilla.opendarwin.org/show_bug.cgi?id=9512 Attachment 9338: Support for maint release of SDK http://bugzilla.opendarwin.org/attachment.cgi?id=9338&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:05:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9248] New version of SDK has changed registry paths Message-ID: <20060710140516.F3F001B73ACE@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9248: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9248&action=edit ------- Additional Comments from Bradley Morrison Oops - I attached the wrong patch for this bug ;-) From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:05:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9248] New version of SDK has changed registry paths Message-ID: <20060710140516.16F211B73ACF@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9248: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9248&action=edit ------- Additional Comments from Bradley Morrison Oops - I attached the wrong patch for this bug ;-) From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:05:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9249] New version of SDK has changed registry paths Message-ID: <20060710140545.CE9631B73B45@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9249: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9249&action=edit ------- Additional Comments from Bradley Morrison Oops - I attached the wrong patch for this bug ;-) From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:05:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9249] New version of SDK has changed registry paths Message-ID: <20060710140545.DE6D41B73B47@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9249: New version of SDK has changed registry paths http://bugzilla.opendarwin.org/attachment.cgi?id=9249&action=edit ------- Additional Comments from Bradley Morrison Oops - I attached the wrong patch for this bug ;-) From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:34:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9179] Implement select.options.add() method : [Attachment 9339] Patch v4 Message-ID: <20060710143452.F3B411B74B15@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9339: Patch v4 http://bugzilla.opendarwin.org/attachment.cgi?id=9339&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes since Patch v3: (In reply to comment #27) > (From update of attachment 9325 [edit]) > I'm concerned about adding another level of function call for every caller of > toInt32, which might be hot. Maybe just repeat the code twice? I hate duplicating code. I made the one-argument method inline in value.h. Is that okay? > I think the bool& parameter's purpose is not self-explanatory and so I think it > should have a name in the header. Added. > I don't see the code to set $maybeOkParam! This value is set from the return value of TypeCanFailConversion(), which is the line of code in question below. > + return 1; # 0; # or can it? > > The above line of code is confusing, even more than it was before. Sorry...I left the old code in when first attempting to change the value. I removed "# 0; # or can it?" in this patch. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:38:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9339] Patch v4 Message-ID: <20060710143828.1CAA31B74D73@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9339: Patch v4 http://bugzilla.opendarwin.org/attachment.cgi?id=9339&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:38:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9339] Patch v4 Message-ID: <20060710143828.85FC61B74D77@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9339: Patch v4 http://bugzilla.opendarwin.org/attachment.cgi?id=9339&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:40:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9333] Updated patch Message-ID: <20060710144021.DA4391B74E47@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9333: Updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9333&action=edit ------- Additional Comments from Darin Adler r=mjs From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:40:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9738] Unqualified :hover selector ignored in strict parsing mode : [Attachment 9333] Updated patch Message-ID: <20060710144021.3B74C1B74E4D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9738: Unqualified :hover selector ignored in strict parsing mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9738 Attachment 9333: Updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9333&action=edit ------- Additional Comments from Darin Adler r=mjs From bugzilla-request-daemon at opendarwin.org Mon Jul 10 07:46:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9341] Patch Message-ID: <20060710144626.87B0B1B7537F@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9341: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9341&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Move the empty run check down into floatWidthForComplexText() From bugzilla-request-daemon at opendarwin.org Mon Jul 10 08:29:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9341] Patch Message-ID: <20060710152923.63B781B76D70@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9341: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9341&action=edit ------- Additional Comments from Darin Adler r=me Even better if there was a comment explaining that this is not just an optimization, but required for correct results, but the layout test should suffice. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 08:29:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9808] REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text : [Attachment 9341] Patch Message-ID: <20060710152923.728C61B76D73@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9808: REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text http://bugzilla.opendarwin.org/show_bug.cgi?id=9808 Attachment 9341: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9341&action=edit ------- Additional Comments from Darin Adler r=me Even better if there was a comment explaining that this is not just an optimization, but required for correct results, but the layout test should suffice. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 08:41:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9833] REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' : [Attachment 9345] patch, including change log and Mitz's reduction as a manual test Message-ID: <20060710154115.BCBAC1B7707F@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9833: REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' http://bugzilla.opendarwin.org/show_bug.cgi?id=9833 Attachment 9345: patch, including change log and Mitz's reduction as a manual test http://bugzilla.opendarwin.org/attachment.cgi?id=9345&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 08:45:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9833] REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' : [Attachment 9345] patch, including change log and Mitz's reduction as a manual test Message-ID: <20060710154533.02FE01B77156@sampson.opendarwin.org> Anders Carlsson has granted Anders Carlsson 's request for review: Bug 9833: REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' http://bugzilla.opendarwin.org/show_bug.cgi?id=9833 Attachment 9345: patch, including change log and Mitz's reduction as a manual test http://bugzilla.opendarwin.org/attachment.cgi?id=9345&action=edit ------- Additional Comments from Anders Carlsson r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 08:45:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9833] REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' : [Attachment 9345] patch, including change log and Mitz's reduction as a manual test Message-ID: <20060710154534.0D1C71B77158@sampson.opendarwin.org> Anders Carlsson has granted Anders Carlsson 's request for review: Bug 9833: REGRESSION: Reproducible crash: RenderMenuList.cpp:58: failed assertion `!m_first' http://bugzilla.opendarwin.org/show_bug.cgi?id=9833 Attachment 9345: patch, including change log and Mitz's reduction as a manual test http://bugzilla.opendarwin.org/attachment.cgi?id=9345&action=edit ------- Additional Comments from Anders Carlsson r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 10 11:04:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9451] [S60] Redundant code in connection management : [Attachment 8861] correct pointer check Message-ID: <20060710180405.7AD7D1B7BDA1@sampson.opendarwin.org> Sachin Padma has granted Sachin Padma 's request for review: Bug 9451: [S60] Redundant code in connection management http://bugzilla.opendarwin.org/show_bug.cgi?id=9451 Attachment 8861: correct pointer check http://bugzilla.opendarwin.org/attachment.cgi?id=8861&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 11:04:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9451] [S60] Redundant code in connection management : [Attachment 8861] correct pointer check Message-ID: <20060710180405.AAF6A1B7BDA8@sampson.opendarwin.org> Sachin Padma has granted Sachin Padma 's request for review: Bug 9451: [S60] Redundant code in connection management http://bugzilla.opendarwin.org/show_bug.cgi?id=9451 Attachment 8861: correct pointer check http://bugzilla.opendarwin.org/attachment.cgi?id=8861&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 13:13:56 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9346] Improved patch+testcase Message-ID: <20060710201356.78FFC1B7FD5E@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9346: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9346&action=edit ------- Additional Comments from Rob Buis This patch has a better testcase, now it also tests resizing of lines, circles and ellipses, which proved to have some logical errors in the way they resize using percentages, the improved testcase should catch this in future. Sorry for having to clear the review bits again :} Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 14:09:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9838] REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache : [Attachment 9347] Proposed patch Message-ID: <20060710210917.1E0C51B81AEF@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9838: REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache http://bugzilla.opendarwin.org/show_bug.cgi?id=9838 Attachment 9347: Proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9347&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 14:26:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9838] REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache : [Attachment 9347] Proposed patch Message-ID: <20060710212648.3832C1B82A8E@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9838: REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache http://bugzilla.opendarwin.org/show_bug.cgi?id=9838 Attachment 9347: Proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9347&action=edit ------- Additional Comments from John Sullivan Looks good. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 14:26:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9838] REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache : [Attachment 9347] Proposed patch Message-ID: <20060710212648.1464A1B82A98@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9838: REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache http://bugzilla.opendarwin.org/show_bug.cgi?id=9838 Attachment 9347: Proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9347&action=edit ------- Additional Comments from John Sullivan Looks good. From chiefdom368 at dr.ocn.ne.jp Mon Jul 10 16:30:34 2006 From: chiefdom368 at dr.ocn.ne.jp (ìè m) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=E6=82=EB=82=B5=82=AD=82=A8?= =?iso-8859-1?q?=8A=E8=82=A2=82=B5=82=DC=82=B7?= Message-ID:  ¡ š™š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš™š ¡  @@@@@@@@š‚ ‚È‚½‚Ì‚²’•¶‚Í‚Ç‚Á‚¿Hš@ @@@@@@@@@@‚Q‚QÎ@or@‚R‚VÎ@  ¡ š™š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš™š ¡  ƒnƒWƒƒ}ƒVƒeBЉî’S“–‚𖱂߂³‚¹‚Ä’¸‚¢‚Ä‚¨‚è‚Ü‚·A‹àˆä—DŽq‚Æ\‚µ‚Ü‚·B ƒXƒ|ƒ“ƒT[ƒTƒCƒg—l‚æ‚è“ñl‚Ì—«‚ÌЉîˆË—Š‚ðŽó‚¯‚Ü‚µ‚½‚Ì‚Å‚²ˆÄ“à’v‚µ‚Ü‚·B ˆêØ—¿‹à–³‚µ‚Ì‚²Ð‰î‚Æ‚È‚è‚Ü‚·‚Ì‚ÅA ƒ[ƒ‹‚Ì‘—ŽóM‚ðŠÜ‚߂ǂꂾ‚¯—˜—p‚µ‚Ä’¸‚¢‚Ä‚àŠ®‘S‚É‚OB Š®‘S–³—¿‚Å‚Ì‚²Ð‰î‚Å‚·‚Ì‚Å‘Šú’÷‚ßØ‚è‚Ìꇂª‚²‚´‚¢‚Ü‚·B ‚Ü‚½A’÷‚ßØ‚è‚Æ‚È‚Á‚½‚Æ‚«‚Í—\‚È‚­—«‚Ì•ÏX‚ð‚·‚éê‡‚à‚²‚´‚¢‚Ü‚·‚ªA ‚²—eŽÍ‚­‚¾‚³‚¢B ¡„«‰ñ„«‚²„«Ð„«‰î„«‚Ì„«•û„«‚Í„« „ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„® @@@@–¼‘OFƒ}ƒC‚³‚ñ@@@@@@@@@@@@@–¼‘OF—ÇŽq‚³‚ñ @@@@”N—îF22Î@@@@@@@@@@@@@@@”N—îF37Î @@@@E‹ÆFŽ•‰È•Žè@@@@@@@@@@@@@E‹ÆF“ñl‚̃}ƒ} @‚¨“ñl‚ÌÚ‚µ‚¢Úׂ͂±‚¿‚çË@http://canonic.scramblekosaten.org/a12/ From bugzilla-request-daemon at opendarwin.org Mon Jul 10 18:59:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9839] Nightly launcher fails to detect extensions when extension causes crash on load : [Attachment 9349] Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading Message-ID: <20060711015949.530771B8B58E@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load http://bugzilla.opendarwin.org/show_bug.cgi?id=9839 Attachment 9349: Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading http://bugzilla.opendarwin.org/attachment.cgi?id=9349&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 19:51:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9839] Nightly launcher fails to detect extensions when extension causes crash on load : [Attachment 9349] Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading Message-ID: <20060711025143.729201B8CF9D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load http://bugzilla.opendarwin.org/show_bug.cgi?id=9839 Attachment 9349: Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading http://bugzilla.opendarwin.org/attachment.cgi?id=9349&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 19:51:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9839] Nightly launcher fails to detect extensions when extension causes crash on load : [Attachment 9349] Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading Message-ID: <20060711025143.7DA941B8CF9F@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9839: Nightly launcher fails to detect extensions when extension causes crash on load http://bugzilla.opendarwin.org/show_bug.cgi?id=9839 Attachment 9349: Patch - track intialization so we can tell if a crash occurrs prior to the conclusion of extension loading http://bugzilla.opendarwin.org/attachment.cgi?id=9349&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 20:09:04 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9806] REGRESSION: Large rowspan causes WebKit to call abort() : [Attachment 9350] patch, including change log and a layout test Message-ID: <20060711030904.BAA921B8DE7A@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9806: REGRESSION: Large rowspan causes WebKit to call abort() http://bugzilla.opendarwin.org/show_bug.cgi?id=9806 Attachment 9350: patch, including change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9350&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 20:15:41 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9351] Custom implementaion of time functions in WTF, not inlined Message-ID: <20060711031541.671231B8E064@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9351: Custom implementaion of time functions in WTF, not inlined http://bugzilla.opendarwin.org/attachment.cgi?id=9351&action=edit ------- Additional Comments from Björn Graf (boki) This patch is the same as before with Darins comments applied. New to this patch is the use of wcsftime over strftime and the minimal implementation of wcsftime to support DateProtoFunc::callAsFunction() on Windows. While I am not absolutely sure if the use of wcsftime is better than using strftime and let the convertion from the system code page to Unicode be performed by UString it feels more logical to get the Unicode string and save the conversion. From bugzilla-request-daemon at opendarwin.org Mon Jul 10 21:55:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9810] OPTGROUP label text is using the default font instead of Lucida Grande : [Attachment 9352] patch, including change log Message-ID: <20060711045547.362581B90838@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9810: OPTGROUP label text is using the default font instead of Lucida Grande http://bugzilla.opendarwin.org/show_bug.cgi?id=9810 Attachment 9352: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9352&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 22:26:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9810] OPTGROUP label text is using the default font instead of Lucida Grande : [Attachment 9352] patch, including change log Message-ID: <20060711052638.47B971B91BB4@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9810: OPTGROUP label text is using the default font instead of Lucida Grande http://bugzilla.opendarwin.org/show_bug.cgi?id=9810 Attachment 9352: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9352&action=edit ------- Additional Comments from Geoffrey Garen r=me land test case too, please From bugzilla-request-daemon at opendarwin.org Mon Jul 10 22:26:39 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9810] OPTGROUP label text is using the default font instead of Lucida Grande : [Attachment 9352] patch, including change log Message-ID: <20060711052639.4B93B1B91BB6@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9810: OPTGROUP label text is using the default font instead of Lucida Grande http://bugzilla.opendarwin.org/show_bug.cgi?id=9810 Attachment 9352: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9352&action=edit ------- Additional Comments from Geoffrey Garen r=me land test case too, please From bugzilla-request-daemon at opendarwin.org Mon Jul 10 22:31:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9811] OPTION text contained in OPTGROUP appears at the wrong size : [Attachment 9353] patch, including change log Message-ID: <20060711053107.EFBA61B91DC0@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9811: OPTION text contained in OPTGROUP appears at the wrong size http://bugzilla.opendarwin.org/show_bug.cgi?id=9811 Attachment 9353: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9353&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 10 22:33:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9811] OPTION text contained in OPTGROUP appears at the wrong size : [Attachment 9353] patch, including change log Message-ID: <20060711053350.8DF461B91E79@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9811: OPTION text contained in OPTGROUP appears at the wrong size http://bugzilla.opendarwin.org/show_bug.cgi?id=9811 Attachment 9353: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9353&action=edit ------- Additional Comments from Geoffrey Garen r=me, since i am now a const expert land with test case, please From bugzilla-request-daemon at opendarwin.org Mon Jul 10 22:33:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9811] OPTION text contained in OPTGROUP appears at the wrong size : [Attachment 9353] patch, including change log Message-ID: <20060711053350.9070F1B91E7A@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9811: OPTION text contained in OPTGROUP appears at the wrong size http://bugzilla.opendarwin.org/show_bug.cgi?id=9811 Attachment 9353: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9353&action=edit ------- Additional Comments from Geoffrey Garen r=me, since i am now a const expert land with test case, please From GJanet7 at pcslink.com Tue Jul 11 00:09:56 2006 From: GJanet7 at pcslink.com (KerriBurks) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] Samantha Mcleod or take cutting Message-ID: Shooting Star Report Every trader dreams about having a method of predicting the future. Me too. What I got instead is some information on most promising stocks not yetpopular with most traders. And I’d like to share! Shares were moving up for this one recent weeks. You’d regret if you miss this great stock opportunity! Get HYWI.PK First Thing Today, This Is Going To Explode! Company: Hollywood Intermediate Symbol: HYWI Last Trade: $0.59 7 Day Target: $1.6 300% Increase! Red Hot News - Must READ! - Hollywood Intermediate Announces Hiring of Industry Veteran Allan Levine Monday June 26, 9:33 am ET GLENDALE, CA--(MARKET WIRE)--Jun 25, 2006 -- Hollywood Intermediate, Inc. (Other OTC:HYWI.PK - News), a provider of digital intermediate film mastering services, announced today that Allan Levine has joined its Matchframe Digital Intermediate (MDI) team as Director of Sales and Marketing. This position was created in anticipation of further expansion of MDI's efficient, cost-effective production environment for both the independent and studio films. Levine's responsibilities will include expanding the current client base as MDI's capacity has increased. Mr. Levine has been involved in post-production for thirty years, beginning as Dailies Manager at film laboratories where he supervised film dailies and then transitioned to supervising video dailies as liaison for cinematographers and directors. Helping directors of photography achieve their creative vision both photochemically and digitally has been "the most fun I have had in a dark room since the 70s," Levine quips. "With MDI, I welcome the chance to work with a bright and talented group in an efficient boutique atmosphere, it is simply refreshing, and I know filmmakers will find that alluring." About Hollywood Intermediate - Hollywood Intermediate, affords Motion Pictures the ability to scan their selected original camera negative at 2K or 4K film resolution, conforming a high resolution digital master for theatrical and broadcast release including dirt removal, opticals and visual effects, and includes the output of a High Definition preview master (to be used for preview screenings and focus groups and can be deployed in any worldwide theater location) as well as final film, broadcast and DVD distribution. Watch this one trade tomorrow! fear that it might displease him I could have held him round the neck and cried plane But of what is he dying asked glance Life is simply familiar out replied the reporter wyman said be inadequate You are so welcome to our home Thank you for having me Pattys eyes locked on to husband He had been easy going during their marriage She From bugzilla-request-daemon at opendarwin.org Mon Jul 10 23:54:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9355] Patch and layout test Message-ID: <20060711065412.F35CE1B93FD7@sampson.opendarwin.org> Tim Omernick has asked for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9355: Patch and layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9355&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:01:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9844] Add DOM access test to DumpRenderTree's Netscape plug-in : [Attachment 9356] patchy patch patch Message-ID: <20060711070114.E5EEC1B94C74@sampson.opendarwin.org> Tim Omernick has asked for review: Bug 9844: Add DOM access test to DumpRenderTree's Netscape plug-in http://bugzilla.opendarwin.org/show_bug.cgi?id=9844 Attachment 9356: patchy patch patch http://bugzilla.opendarwin.org/attachment.cgi?id=9356&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:16:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9844] Add DOM access test to DumpRenderTree's Netscape plug-in : [Attachment 9356] patchy patch patch Message-ID: <20060711071603.64EEF1B95046@sampson.opendarwin.org> Beth Dakin has granted Beth Dakin 's request for review: Bug 9844: Add DOM access test to DumpRenderTree's Netscape plug-in http://bugzilla.opendarwin.org/show_bug.cgi?id=9844 Attachment 9356: patchy patch patch http://bugzilla.opendarwin.org/attachment.cgi?id=9356&action=edit ------- Additional Comments from Beth Dakin r=me! From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:16:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9844] Add DOM access test to DumpRenderTree's Netscape plug-in : [Attachment 9356] patchy patch patch Message-ID: <20060711071603.3F81D1B9504A@sampson.opendarwin.org> Beth Dakin has granted Beth Dakin 's request for review: Bug 9844: Add DOM access test to DumpRenderTree's Netscape plug-in http://bugzilla.opendarwin.org/show_bug.cgi?id=9844 Attachment 9356: patchy patch patch http://bugzilla.opendarwin.org/attachment.cgi?id=9356&action=edit ------- Additional Comments from Beth Dakin r=me! From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:18:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9355] Patch and layout test Message-ID: <20060711071832.ECE701B951C2@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9355: Patch and layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9355&action=edit ------- Additional Comments from Geoffrey Garen We talked about this on IRC. Tim is going to move the implementation of createNPObjectForElement into the element class, and out of Frame. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:18:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9355] Patch and layout test Message-ID: <20060711071833.0CF581B951C4@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9355: Patch and layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9355&action=edit ------- Additional Comments from Geoffrey Garen We talked about this on IRC. Tim is going to move the implementation of createNPObjectForElement into the element class, and out of Frame. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:21:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9597] [Drosera] hook up the variables table to show stack variables : [Attachment 9357] Hooks up the variables pane Message-ID: <20060711072126.713841B952AE@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9597: [Drosera] hook up the variables table to show stack variables http://bugzilla.opendarwin.org/show_bug.cgi?id=9597 Attachment 9357: Hooks up the variables pane http://bugzilla.opendarwin.org/attachment.cgi?id=9357&action=edit ------- Additional Comments from Timothy Hatcher This is a first cut at the variables pane. It can be improved by adding toggles to see properties on objects and nested/global scope in some way. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:26:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9358] the lost WebKit part Message-ID: <20060711072611.4F2A61B95458@sampson.opendarwin.org> Tim Omernick has asked for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9358: the lost WebKit part http://bugzilla.opendarwin.org/attachment.cgi?id=9358&action=edit ------- Additional Comments from Tim Omernick I forgot the WebKit part.  Here it is. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:29:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9358] the lost WebKit part Message-ID: <20060711072912.528641B955C2@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9358: the lost WebKit part http://bugzilla.opendarwin.org/attachment.cgi?id=9358&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:29:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9358] the lost WebKit part Message-ID: <20060711072912.0D9261B9586D@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9358: the lost WebKit part http://bugzilla.opendarwin.org/attachment.cgi?id=9358&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:43:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9597] [Drosera] hook up the variables table to show stack variables : [Attachment 9357] Hooks up the variables pane Message-ID: <20060711074312.A3B131B95BC3@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9597: [Drosera] hook up the variables table to show stack variables http://bugzilla.opendarwin.org/show_bug.cgi?id=9597 Attachment 9357: Hooks up the variables pane http://bugzilla.opendarwin.org/attachment.cgi?id=9357&action=edit ------- Additional Comments from Timothy Hatcher ggaren "r=tired me" this patch on IRC before vanishing to Neverland From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:43:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9597] [Drosera] hook up the variables table to show stack variables : [Attachment 9357] Hooks up the variables pane Message-ID: <20060711074312.6B2561B95BCC@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9597: [Drosera] hook up the variables table to show stack variables http://bugzilla.opendarwin.org/show_bug.cgi?id=9597 Attachment 9357: Hooks up the variables pane http://bugzilla.opendarwin.org/attachment.cgi?id=9357&action=edit ------- Additional Comments from Timothy Hatcher ggaren "r=tired me" this patch on IRC before vanishing to Neverland From bugzilla-request-daemon at opendarwin.org Tue Jul 11 00:51:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9598] [Drosera] add a JavaScript evaluator console : [Attachment 9359] Adds a console Message-ID: <20060711075130.238C41B95EF4@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9598: [Drosera] add a JavaScript evaluator console http://bugzilla.opendarwin.org/show_bug.cgi?id=9598 Attachment 9359: Adds a console http://bugzilla.opendarwin.org/attachment.cgi?id=9359&action=edit ------- Additional Comments from Timothy Hatcher This console is just a place to evaluate scripts against the currently selected call frame. In the future then can be used to show exceptions and other things like XMlHTTPRequests, etc. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 06:57:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9512] [S60] build script does not support s60 for 3rd edition, Maint Rel : [Attachment 9338] Support for maint release of SDK Message-ID: <20060711135725.69FA61BA3DE7@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9512: [S60] build script does not support s60 for 3rd edition, Maint Rel http://bugzilla.opendarwin.org/show_bug.cgi?id=9512 Attachment 9338: Support for maint release of SDK http://bugzilla.opendarwin.org/attachment.cgi?id=9338&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 06:57:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9512] [S60] build script does not support s60 for 3rd edition, Maint Rel : [Attachment 9338] Support for maint release of SDK Message-ID: <20060711135725.37A1B1BA3DF0@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9512: [S60] build script does not support s60 for 3rd edition, Maint Rel http://bugzilla.opendarwin.org/show_bug.cgi?id=9512 Attachment 9338: Support for maint release of SDK http://bugzilla.opendarwin.org/attachment.cgi?id=9338&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:47:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9252] ChangeLog for this fix Message-ID: <20060711144735.3868D1BA5A1A@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9252: ChangeLog for this fix http://bugzilla.opendarwin.org/attachment.cgi?id=9252&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:47:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review cancelled: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9252] ChangeLog for this fix Message-ID: <20060711144735.10DB51BA5A14@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9252: ChangeLog for this fix http://bugzilla.opendarwin.org/attachment.cgi?id=9252&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:47:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9368] Patch to changelog for updated s60headers.zip Message-ID: <20060711144735.214731BA5A21@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9368: Patch to changelog for updated s60headers.zip http://bugzilla.opendarwin.org/attachment.cgi?id=9368&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:47:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9368] Patch to changelog for updated s60headers.zip Message-ID: <20060711144735.2673B1BA5A22@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9368: Patch to changelog for updated s60headers.zip http://bugzilla.opendarwin.org/attachment.cgi?id=9368&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:50:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9368] Patch to changelog for updated s60headers.zip Message-ID: <20060711145029.BA10F1BA5B0A@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9368: Patch to changelog for updated s60headers.zip http://bugzilla.opendarwin.org/attachment.cgi?id=9368&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 07:50:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9776] [S60] data_caging_paths.hrh: No such file or directory : [Attachment 9368] Patch to changelog for updated s60headers.zip Message-ID: <20060711145029.1B21A1BA5B0E@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9776: [S60] data_caging_paths.hrh: No such file or directory http://bugzilla.opendarwin.org/show_bug.cgi?id=9776 Attachment 9368: Patch to changelog for updated s60headers.zip http://bugzilla.opendarwin.org/attachment.cgi?id=9368&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:26:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 7808] Page freezes Safari & Webkit Nightly Build : [Attachment 9370] fix assertion failure Message-ID: <20060711172631.AF8CA1BAAFDC@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 7808: Page freezes Safari & Webkit Nightly Build http://bugzilla.opendarwin.org/show_bug.cgi?id=7808 Attachment 9370: fix assertion failure http://bugzilla.opendarwin.org/attachment.cgi?id=9370&action=edit ------- Additional Comments from Alexey Proskuryakov The plugin was requesting an invalid (empty) URL, and this fix just removes an early return in this case. Not sure why it was there, NSURLConnection seems to handle this nicely. BTW, looks scarily similar to the completely unrelated bug 9802 :) As noted in comment 4, scrollbars in subframes don't work, but this is certainly a separate issue. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:40:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9598] [Drosera] add a JavaScript evaluator console : [Attachment 9359] Adds a console Message-ID: <20060711174034.9B5511BAB477@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9598: [Drosera] add a JavaScript evaluator console http://bugzilla.opendarwin.org/show_bug.cgi?id=9598 Attachment 9359: Adds a console http://bugzilla.opendarwin.org/attachment.cgi?id=9359&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:40:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9598] [Drosera] add a JavaScript evaluator console : [Attachment 9359] Adds a console Message-ID: <20060711174033.E618E1BAB46D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9598: [Drosera] add a JavaScript evaluator console http://bugzilla.opendarwin.org/show_bug.cgi?id=9598 Attachment 9359: Adds a console http://bugzilla.opendarwin.org/attachment.cgi?id=9359&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:42:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9853] some improvements to the select menu implementation : [Attachment 9371] first cut, for Adele to look at Message-ID: <20060711174210.69F571BAB52C@sampson.opendarwin.org> Darin Adler has asked Adele Peterson for review: Bug 9853: some improvements to the select menu implementation http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 Attachment 9371: first cut, for Adele to look at http://bugzilla.opendarwin.org/attachment.cgi?id=9371&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:42:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9853] some improvements to the select menu implementation : [Attachment 9371] first cut, for Adele to look at Message-ID: <20060711174210.791A61BAB5EC@sampson.opendarwin.org> Darin Adler has asked Adele Peterson for review: Bug 9853: some improvements to the select menu implementation http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 Attachment 9371: first cut, for Adele to look at http://bugzilla.opendarwin.org/attachment.cgi?id=9371&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:44:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9372] Adds MR support to runatf Message-ID: <20060711174437.7B0141BAB5ED@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9372: Adds MR support to runatf http://bugzilla.opendarwin.org/attachment.cgi?id=9372&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:44:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9372] Adds MR support to runatf Message-ID: <20060711174437.AF0A41BAB635@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9372: Adds MR support to runatf http://bugzilla.opendarwin.org/attachment.cgi?id=9372&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:55:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 7808] Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL : [Attachment 9370] fix assertion failure Message-ID: <20060711175511.D08411BAB9C6@sampson.opendarwin.org> Tim Omernick has granted Tim Omernick 's request for review: Bug 7808: Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL http://bugzilla.opendarwin.org/show_bug.cgi?id=7808 Attachment 9370: fix assertion failure http://bugzilla.opendarwin.org/attachment.cgi?id=9370&action=edit ------- Additional Comments from Tim Omernick Looks good! r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 10:55:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 7808] Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL : [Attachment 9370] fix assertion failure Message-ID: <20060711175511.B30D01BAB9CD@sampson.opendarwin.org> Tim Omernick has granted Tim Omernick 's request for review: Bug 7808: Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL http://bugzilla.opendarwin.org/show_bug.cgi?id=7808 Attachment 9370: fix assertion failure http://bugzilla.opendarwin.org/attachment.cgi?id=9370&action=edit ------- Additional Comments from Tim Omernick Looks good! r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 11:48:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9374] re-arrangements changelogs Message-ID: <20060711184807.B16ED1BAD934@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9374: re-arrangements changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9374&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 11:48:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9374] re-arrangements changelogs Message-ID: <20060711184807.ADCD11BAD932@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9374: re-arrangements changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9374&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 12:04:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9214] Add an m_alignRight flag to InlineTextBox Message-ID: <20060711190454.77D491BAE9D3@sampson.opendarwin.org> Dave Hyatt has denied Dave Hyatt 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9214: Add an m_alignRight flag to InlineTextBox http://bugzilla.opendarwin.org/attachment.cgi?id=9214&action=edit ------- Additional Comments from Dave Hyatt I think a slicker approach that would work for LTR and RTL (and thus avoid having to do this special case code just for RTL) would be to take the problematic white space that is truncated at the edge of the line and put it in its own separate text box. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 12:06:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9853] some improvements to the select menu implementation : [Attachment 9371] first cut, for Adele to look at Message-ID: <20060711190608.3B1691BAEA79@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9853: some improvements to the select menu implementation http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 Attachment 9371: first cut, for Adele to look at http://bugzilla.opendarwin.org/attachment.cgi?id=9371&action=edit ------- Additional Comments from Adele Peterson I think this looks good. We need bugs about some of the FIXMEs. For example, I don't think we handle the switch from popup to list box. I'll work on some test cases, and start filing. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 12:04:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9214] Add an m_alignRight flag to InlineTextBox Message-ID: <20060711190454.3C4C51BAEA7A@sampson.opendarwin.org> Dave Hyatt has denied Dave Hyatt 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9214: Add an m_alignRight flag to InlineTextBox http://bugzilla.opendarwin.org/attachment.cgi?id=9214&action=edit ------- Additional Comments from Dave Hyatt I think a slicker approach that would work for LTR and RTL (and thus avoid having to do this special case code just for RTL) would be to take the problematic white space that is truncated at the edge of the line and put it in its own separate text box. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 12:06:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:36 2007 Subject: [webkit-reviews] review granted: [Bug 9853] some improvements to the select menu implementation : [Attachment 9371] first cut, for Adele to look at Message-ID: <20060711190608.571AC1BAEA7E@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9853: some improvements to the select menu implementation http://bugzilla.opendarwin.org/show_bug.cgi?id=9853 Attachment 9371: first cut, for Adele to look at http://bugzilla.opendarwin.org/attachment.cgi?id=9371&action=edit ------- Additional Comments from Adele Peterson I think this looks good. We need bugs about some of the FIXMEs. For example, I don't think we handle the switch from popup to list box. I'll work on some test cases, and start filing. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 14:31:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9859] REGRESSION: Can't dynamically change popup to list box : [Attachment 9377] patch Message-ID: <20060711213124.ADEFB1BB3B3F@sampson.opendarwin.org> Adele Peterson has asked for review: Bug 9859: REGRESSION: Can't dynamically change popup to list box http://bugzilla.opendarwin.org/show_bug.cgi?id=9859 Attachment 9377: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9377&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 14:37:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9859] REGRESSION: Can't dynamically change popup to list box : [Attachment 9377] patch Message-ID: <20060711213701.0717B1BB3FA0@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9859: REGRESSION: Can't dynamically change popup to list box http://bugzilla.opendarwin.org/show_bug.cgi?id=9859 Attachment 9377: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9377&action=edit ------- Additional Comments from Adele Peterson hyatt reviewed this From bugzilla-request-daemon at opendarwin.org Tue Jul 11 14:37:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9859] REGRESSION: Can't dynamically change popup to list box : [Attachment 9377] patch Message-ID: <20060711213701.28EB21BB4089@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9859: REGRESSION: Can't dynamically change popup to list box http://bugzilla.opendarwin.org/show_bug.cgi?id=9859 Attachment 9377: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9377&action=edit ------- Additional Comments from Adele Peterson hyatt reviewed this From bugzilla-request-daemon at opendarwin.org Tue Jul 11 14:40:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9276] Patch including change log and a repaint test Message-ID: <20060711214017.2AFBE1BB408A@sampson.opendarwin.org> Dave Hyatt has granted Dave Hyatt 's request for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9276: Patch including change log and a repaint test http://bugzilla.opendarwin.org/attachment.cgi?id=9276&action=edit ------- Additional Comments from Dave Hyatt r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 14:40:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9669] Incomplete repaint when changing an inline's border : [Attachment 9276] Patch including change log and a repaint test Message-ID: <20060711214017.1FA001BB4091@sampson.opendarwin.org> Dave Hyatt has granted Dave Hyatt 's request for review: Bug 9669: Incomplete repaint when changing an inline's border http://bugzilla.opendarwin.org/show_bug.cgi?id=9669 Attachment 9276: Patch including change log and a repaint test http://bugzilla.opendarwin.org/attachment.cgi?id=9276&action=edit ------- Additional Comments from Dave Hyatt r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 15:32:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9861] REGRESSION: Can't dynamically change list box to popup : [Attachment 9378] patch Message-ID: <20060711223215.15F5A1BB5E44@sampson.opendarwin.org> Adele Peterson has asked for review: Bug 9861: REGRESSION: Can't dynamically change list box to popup http://bugzilla.opendarwin.org/show_bug.cgi?id=9861 Attachment 9378: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9378&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 15:55:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9372] Adds MR support to runatf Message-ID: <20060711225554.8CFC21BB63CB@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9372: Adds MR support to runatf http://bugzilla.opendarwin.org/attachment.cgi?id=9372&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 15:55:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9372] Adds MR support to runatf Message-ID: <20060711225554.98BB51BB6773@sampson.opendarwin.org> Bradley Morrison has cancelled Bradley Morrison 's request for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9372: Adds MR support to runatf http://bugzilla.opendarwin.org/attachment.cgi?id=9372&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 15:55:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9379] This patch also includes emu.bat Message-ID: <20060711225554.9D2641BB6774@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9379: This patch also includes emu.bat http://bugzilla.opendarwin.org/attachment.cgi?id=9379&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 15:55:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9379] This patch also includes emu.bat Message-ID: <20060711225554.A1B7A1BB6775@sampson.opendarwin.org> Bradley Morrison has asked Zalan Bujtas for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9379: This patch also includes emu.bat http://bugzilla.opendarwin.org/attachment.cgi?id=9379&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:02:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9381] Move NPObject creation out of Frame, into HTMLPlugInElement Message-ID: <20060711230214.79E501BB7365@sampson.opendarwin.org> Tim Omernick has asked for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9381: Move NPObject creation out of Frame, into HTMLPlugInElement http://bugzilla.opendarwin.org/attachment.cgi?id=9381&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:04:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9381] Move NPObject creation out of Frame, into HTMLPlugInElement Message-ID: <20060711230405.6F2821BB740F@sampson.opendarwin.org> Tim Omernick has asked Geoffrey Garen for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9381: Move NPObject creation out of Frame, into HTMLPlugInElement http://bugzilla.opendarwin.org/attachment.cgi?id=9381&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:04:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9381] Move NPObject creation out of Frame, into HTMLPlugInElement Message-ID: <20060711230405.7B8FB1BB745C@sampson.opendarwin.org> Tim Omernick has asked Geoffrey Garen for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9381: Move NPObject creation out of Frame, into HTMLPlugInElement http://bugzilla.opendarwin.org/attachment.cgi?id=9381&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:27:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9381] Move NPObject creation out of Frame, into HTMLPlugInElement Message-ID: <20060711232733.219741BB7C92@sampson.opendarwin.org> Anders Carlsson has denied Anders Carlsson 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9381: Move NPObject creation out of Frame, into HTMLPlugInElement http://bugzilla.opendarwin.org/attachment.cgi?id=9381&action=edit ------- Additional Comments from Anders Carlsson I discussed some possible changes to the patch with Tim O on IRC From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:32:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9861] REGRESSION: Can't dynamically change list box to popup : [Attachment 9378] patch Message-ID: <20060711233222.E499B1BB7E1D@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9861: REGRESSION: Can't dynamically change list box to popup http://bugzilla.opendarwin.org/show_bug.cgi?id=9861 Attachment 9378: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9378&action=edit ------- Additional Comments from Adele Peterson hyatt reviewed this From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:27:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9381] Move NPObject creation out of Frame, into HTMLPlugInElement Message-ID: <20060711232733.D9F511BB7E1A@sampson.opendarwin.org> Anders Carlsson has denied Anders Carlsson 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9381: Move NPObject creation out of Frame, into HTMLPlugInElement http://bugzilla.opendarwin.org/attachment.cgi?id=9381&action=edit ------- Additional Comments from Anders Carlsson I discussed some possible changes to the patch with Tim O on IRC From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:32:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9861] REGRESSION: Can't dynamically change list box to popup : [Attachment 9378] patch Message-ID: <20060711233222.EED8C1BB7E1E@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9861: REGRESSION: Can't dynamically change list box to popup http://bugzilla.opendarwin.org/show_bug.cgi?id=9861 Attachment 9378: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9378&action=edit ------- Additional Comments from Adele Peterson hyatt reviewed this From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:41:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9382] try and try again Message-ID: <20060711234148.0DBC91BB8182@sampson.opendarwin.org> Tim Omernick has asked for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9382: try and try again http://bugzilla.opendarwin.org/attachment.cgi?id=9382&action=edit ------- Additional Comments from Tim Omernick Made the change that Anders suggested -- removed Element::getNPObject().  Now the ObjC DOM code explicitly checks for applet, embed, and object elements. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:45:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9382] try and try again Message-ID: <20060711234535.8A2FC1BB8237@sampson.opendarwin.org> Anders Carlsson has granted Anders Carlsson 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9382: try and try again http://bugzilla.opendarwin.org/attachment.cgi?id=9382&action=edit ------- Additional Comments from Anders Carlsson r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:45:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9843] Give Netscape plug-ins access to their own DOM element : [Attachment 9382] try and try again Message-ID: <20060711234535.EA34D1BB8323@sampson.opendarwin.org> Anders Carlsson has granted Anders Carlsson 's request for review: Bug 9843: Give Netscape plug-ins access to their own DOM element http://bugzilla.opendarwin.org/show_bug.cgi?id=9843 Attachment 9382: try and try again http://bugzilla.opendarwin.org/attachment.cgi?id=9382&action=edit ------- Additional Comments from Anders Carlsson r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:47:42 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9351] Custom implementaion of time functions in WTF, not inlined Message-ID: <20060711234742.BF47A1BB83FD@sampson.opendarwin.org> Björn Graf (boki) has cancelled Björn Graf (boki) 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9351: Custom implementaion of time functions in WTF, not inlined http://bugzilla.opendarwin.org/attachment.cgi?id=9351&action=edit ------- Additional Comments from Björn Graf (boki) Same as 9351 but with a compiler error fix. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:47:42 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9351] Custom implementaion of time functions in WTF, not inlined Message-ID: <20060711234742.3B8A71BB8404@sampson.opendarwin.org> Björn Graf (boki) has cancelled Björn Graf (boki) 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9351: Custom implementaion of time functions in WTF, not inlined http://bugzilla.opendarwin.org/attachment.cgi?id=9351&action=edit ------- Additional Comments from Björn Graf (boki) Same as 9351 but with a compiler error fix. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:47:42 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9383] Custom implementaion of time functions in WTF, not inlined 2 Message-ID: <20060711234742.41A7D1BB8405@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9383: Custom implementaion of time functions in WTF, not inlined 2 http://bugzilla.opendarwin.org/attachment.cgi?id=9383&action=edit ------- Additional Comments from Björn Graf (boki) Same as 9351 but with a compiler error fix. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 16:55:39 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9635] REGRESSION: Crash when adding to cart at : [Attachment 9384] Patch Message-ID: <20060711235539.BE4131BB8974@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9635: REGRESSION: Crash when adding to cart at http://bugzilla.opendarwin.org/show_bug.cgi?id=9635 Attachment 9384: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9384&action=edit ------- Additional Comments from Anders Carlsson The reason that scriptNode was 0 is that the parser is stopped by a previous script (using window.close). Stopping the parser causes processToken to return 0 as the node. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 17:08:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9635] REGRESSION: Crash when adding to cart at : [Attachment 9384] Patch Message-ID: <20060712000824.DB3851BB99B4@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9635: REGRESSION: Crash when adding to cart at http://bugzilla.opendarwin.org/show_bug.cgi?id=9635 Attachment 9384: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9384&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 17:08:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9635] REGRESSION: Crash when adding to cart at : [Attachment 9384] Patch Message-ID: <20060712000825.4AB361BB99D0@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9635: REGRESSION: Crash when adding to cart at http://bugzilla.opendarwin.org/show_bug.cgi?id=9635 Attachment 9384: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9384&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 11 20:02:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9383] Custom implementaion of time functions in WTF, not inlined 2 Message-ID: <20060712030225.468A11BBF4BF@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9383: Custom implementaion of time functions in WTF, not inlined 2 http://bugzilla.opendarwin.org/attachment.cgi?id=9383&action=edit ------- Additional Comments from Darin Adler + int dfy = dayFromYear((int)year); no need for type cast + if (day < dfy) { + // The first day of year is beyond day, so we have right year + 1 + year -= 1; } no need for braces - static double time_tMin = (time_tIsSigned ? - (double)(1ULL << (8 * sizeof(time_t) - 1)) : 0); + if (secs < 0 || secs > time_tMax) { If this is removed, so that mean that time_tIsSigned is not needed any more? - char timebuffer[bufsize]; + wchar_t timebuffer[bufsize]; What's the rationale for this change? + size_t len = WTF::wcsftime(timebuffer, bufsize, L"%c", &t); + return jsString(UString((UChar*)timebuffer, len)); This assumes that wchar_t is the same as UChar, but that's not going to be true on platforms other than Windows. + struct tm t3; Should be just "tm", not "struct tm", right? +/* +*/ What is that empty comment about? +inline bool getTimeZoneInfo() { +inline SYSTEMTIME tmToSystemTime(const struct tm& tm) { We put braces on the next line when defining functions. + //FIXME: Cache the result per thread We put spaces after // comments. +inline bool operator >=(const struct tm& a, const struct tm& b) +{ + bool res = false; + if (a.tm_year == b.tm_year) { + if (a.tm_mon > b.tm_mon) { + res = true; + } else if (a.tm_mon == b.tm_mon) { + if (a.tm_mday > b.tm_mday) { + res = true; + } else if (a.tm_mday == b.tm_mday) { + if (a.tm_hour > b.tm_hour) { + res = true; + } else if (a.tm_hour == b.tm_hour) { + if (a.tm_min >= b.tm_min) { + res = true; + } + } + } + } + } + return res; Would read a lot better if it had a few more return statements in it. +static inline tm* gmtime(const time_t* timer) { return ::gmtime(timer); } +static inline tm* localtime(const time_t* timer) { return ::localtime(timer); } +static inline time_t mktime(tm* time) { return ::mktime(time); } +static inline size_t wcsftime(wchar_t* dest, size_t maxsize, const wchar_t* format, const tm* timeptr) { return ::wcsftime(dest, maxsize, format, timeptr); } These should not have "static" in front of them -- just inline. +#ifndef _DATEEXTRAS_H_ Should not use a leading underscore -- that's reserved for the compiler and library. +#if HAVE(SYS_TIME_H) +#if PLATFORM(WIN) Need to include "Platform.h" first if a header file is going to use these macros. From bugzilla-request-daemon at opendarwin.org Tue Jul 11 20:02:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9383] Custom implementaion of time functions in WTF, not inlined 2 Message-ID: <20060712030225.6792C1BBF4C6@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9383: Custom implementaion of time functions in WTF, not inlined 2 http://bugzilla.opendarwin.org/attachment.cgi?id=9383&action=edit ------- Additional Comments from Darin Adler + int dfy = dayFromYear((int)year); no need for type cast + if (day < dfy) { + // The first day of year is beyond day, so we have right year + 1 + year -= 1; } no need for braces - static double time_tMin = (time_tIsSigned ? - (double)(1ULL << (8 * sizeof(time_t) - 1)) : 0); + if (secs < 0 || secs > time_tMax) { If this is removed, so that mean that time_tIsSigned is not needed any more? - char timebuffer[bufsize]; + wchar_t timebuffer[bufsize]; What's the rationale for this change? + size_t len = WTF::wcsftime(timebuffer, bufsize, L"%c", &t); + return jsString(UString((UChar*)timebuffer, len)); This assumes that wchar_t is the same as UChar, but that's not going to be true on platforms other than Windows. + struct tm t3; Should be just "tm", not "struct tm", right? +/* +*/ What is that empty comment about? +inline bool getTimeZoneInfo() { +inline SYSTEMTIME tmToSystemTime(const struct tm& tm) { We put braces on the next line when defining functions. + //FIXME: Cache the result per thread We put spaces after // comments. +inline bool operator >=(const struct tm& a, const struct tm& b) +{ + bool res = false; + if (a.tm_year == b.tm_year) { + if (a.tm_mon > b.tm_mon) { + res = true; + } else if (a.tm_mon == b.tm_mon) { + if (a.tm_mday > b.tm_mday) { + res = true; + } else if (a.tm_mday == b.tm_mday) { + if (a.tm_hour > b.tm_hour) { + res = true; + } else if (a.tm_hour == b.tm_hour) { + if (a.tm_min >= b.tm_min) { + res = true; + } + } + } + } + } + return res; Would read a lot better if it had a few more return statements in it. +static inline tm* gmtime(const time_t* timer) { return ::gmtime(timer); } +static inline tm* localtime(const time_t* timer) { return ::localtime(timer); } +static inline time_t mktime(tm* time) { return ::mktime(time); } +static inline size_t wcsftime(wchar_t* dest, size_t maxsize, const wchar_t* format, const tm* timeptr) { return ::wcsftime(dest, maxsize, format, timeptr); } These should not have "static" in front of them -- just inline. +#ifndef _DATEEXTRAS_H_ Should not use a leading underscore -- that's reserved for the compiler and library. +#if HAVE(SYS_TIME_H) +#if PLATFORM(WIN) Need to include "Platform.h" first if a header file is going to use these macros. From safopkzuqja at hotmail.com Wed Jul 12 02:35:27 2006 From: safopkzuqja at hotmail.com (TITANSTEEL) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] Enlarge your dick extremely quick with Penis Enlarge Patch. Message-ID: xZyJ4SU1nd4VJ.gNuGE6hdW8LdM@hotmail.com An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060712/7ed81611/attachment.html From bugzilla-request-daemon at opendarwin.org Tue Jul 11 23:57:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9862] REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF : [Attachment 9389] Add missing null check Message-ID: <20060712065722.744101BC61E5@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9862: REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF http://bugzilla.opendarwin.org/show_bug.cgi?id=9862 Attachment 9389: Add missing null check http://bugzilla.opendarwin.org/attachment.cgi?id=9389&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 00:22:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9862] REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF : [Attachment 9389] Add missing null check Message-ID: <20060712072216.2E39A1BC76AF@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9862: REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF http://bugzilla.opendarwin.org/show_bug.cgi?id=9862 Attachment 9389: Add missing null check http://bugzilla.opendarwin.org/attachment.cgi?id=9389&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 00:22:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9862] REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF : [Attachment 9389] Add missing null check Message-ID: <20060712072216.2B7FF1BC7766@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9862: REGRESSION: GMail: Crash in RenderView::repaintViewRectangle when spoofing as FF http://bugzilla.opendarwin.org/show_bug.cgi?id=9862 Attachment 9389: Add missing null check http://bugzilla.opendarwin.org/attachment.cgi?id=9389&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 01:06:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9813] OPTION text can paint over select element's scrollbar : [Attachment 9390] patch Message-ID: <20060712080608.EDA4E1BC8B90@sampson.opendarwin.org> Adele Peterson has asked for review: Bug 9813: OPTION text can paint over select element's scrollbar http://bugzilla.opendarwin.org/show_bug.cgi?id=9813 Attachment 9390: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9390&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 01:12:41 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9813] OPTION text can paint over select element's scrollbar : [Attachment 9390] patch Message-ID: <20060712081241.719521BC8E18@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9813: OPTION text can paint over select element's scrollbar http://bugzilla.opendarwin.org/show_bug.cgi?id=9813 Attachment 9390: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9390&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 01:12:41 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9813] OPTION text can paint over select element's scrollbar : [Attachment 9390] patch Message-ID: <20060712081241.0565A1BC8E1F@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9813: OPTION text can paint over select element's scrollbar http://bugzilla.opendarwin.org/show_bug.cgi?id=9813 Attachment 9390: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9390&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 02:17:59 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9868] Applications shown in Drosera's "Attach" window remain after exit : [Attachment 9393] Patch Message-ID: <20060712091759.632BC1BCB337@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9868: Applications shown in Drosera's "Attach" window remain after exit http://bugzilla.opendarwin.org/show_bug.cgi?id=9868 Attachment 9393: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9393&action=edit ------- Additional Comments from Mark Rowe (bdash) This patch listens for NSApplicationWillTerminateNotification, and sends WebScriptDebugServerWillUnloadNotification as a distributed notification if it arrives. This doesn't handle the case where the application exits unexpectedly. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 02:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9868] Applications shown in Drosera's "Attach" window remain after exit : [Attachment 9393] Patch Message-ID: <20060712092446.896CC1BCB444@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9868: Applications shown in Drosera's "Attach" window remain after exit http://bugzilla.opendarwin.org/show_bug.cgi?id=9868 Attachment 9393: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9393&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 02:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9868] Applications shown in Drosera's "Attach" window remain after exit : [Attachment 9393] Patch Message-ID: <20060712092446.1C2BC1BCB55B@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9868: Applications shown in Drosera's "Attach" window remain after exit http://bugzilla.opendarwin.org/show_bug.cgi?id=9868 Attachment 9393: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9393&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:22:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9869] [Drosera] JS Console fails to evaluate input when paused in global scope : [Attachment 9394] Patch Message-ID: <20060712102257.306651BCD084@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope http://bugzilla.opendarwin.org/show_bug.cgi?id=9869 Attachment 9394: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9394&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:25:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9863] Drosera needs to show something at launch : [Attachment 9395] Patch Message-ID: <20060712102543.53D2D1BCD14B@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9863: Drosera needs to show something at launch http://bugzilla.opendarwin.org/show_bug.cgi?id=9863 Attachment 9395: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9395&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:28:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9869] [Drosera] JS Console fails to evaluate input when paused in global scope : [Attachment 9394] Patch Message-ID: <20060712102826.6C1D41BCD340@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope http://bugzilla.opendarwin.org/show_bug.cgi?id=9869 Attachment 9394: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9394&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:28:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9869] [Drosera] JS Console fails to evaluate input when paused in global scope : [Attachment 9394] Patch Message-ID: <20060712102826.93A041BCD345@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope http://bugzilla.opendarwin.org/show_bug.cgi?id=9869 Attachment 9394: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9394&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:28:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9863] Drosera needs to show something at launch : [Attachment 9395] Patch Message-ID: <20060712102847.2C7B61BCD3C8@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9863: Drosera needs to show something at launch http://bugzilla.opendarwin.org/show_bug.cgi?id=9863 Attachment 9395: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9395&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 03:28:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9863] Drosera needs to show something at launch : [Attachment 9395] Patch Message-ID: <20060712102847.3F3FB1BCD3CB@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9863: Drosera needs to show something at launch http://bugzilla.opendarwin.org/show_bug.cgi?id=9863 Attachment 9395: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9395&action=edit ------- Additional Comments from Geoffrey Garen r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 05:11:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9806] REGRESSION: Large rowspan causes WebKit to call abort() : [Attachment 9350] patch, including change log and a layout test Message-ID: <20060712121128.292D21BD3080@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9806: REGRESSION: Large rowspan causes WebKit to call abort() http://bugzilla.opendarwin.org/show_bug.cgi?id=9806 Attachment 9350: patch, including change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9350&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 05:11:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9806] REGRESSION: Large rowspan causes WebKit to call abort() : [Attachment 9350] patch, including change log and a layout test Message-ID: <20060712121128.187B91BD30B0@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9806: REGRESSION: Large rowspan causes WebKit to call abort() http://bugzilla.opendarwin.org/show_bug.cgi?id=9806 Attachment 9350: patch, including change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9350&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 06:38:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9400] Patch v1 Message-ID: <20060712133815.3C1C91BD580D@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9400: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9400&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Proposed patch. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 06:50:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9400] Patch v1 Message-ID: <20060712135016.30D1F1BD5C1A@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled David Kilzer (ddkilzer) 's request for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9400: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9400&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes from Patch v1: - Removed magic number, "3", and replaced it with a named variable in all three scripts. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 06:50:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9400] Patch v1 Message-ID: <20060712135016.281961BD5C22@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled David Kilzer (ddkilzer) 's request for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9400: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9400&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes from Patch v1: - Removed magic number, "3", and replaced it with a named variable in all three scripts. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 06:50:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9401] Patch v2 Message-ID: <20060712135016.2FB3B1BD5C24@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9401: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9401&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Changes from Patch v1: - Removed magic number, "3", and replaced it with a named variable in all three scripts. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 07:38:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9296] First attempt Message-ID: <20060712143835.DDA4C1BD7852@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled Eric Seidel 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9296: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9296&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Clearing review flag. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 07:41:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9305] Improved patch+testcase Message-ID: <20060712144129.B036D1BD7945@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled Maciej Stachowiak 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9305: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9305&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Clearing review flag. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 08:07:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9401] Patch v2 Message-ID: <20060712150754.DD89C1BD8D15@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9401: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9401&action=edit ------- Additional Comments from Darin Adler Neat. As these get fancier and fancier, eventually we *will* want to start using a library. But for now I still think it's OK to have 3 copies. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 08:07:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9848] Teach svn-create-patch and friends to fix ChangeLog patches : [Attachment 9401] Patch v2 Message-ID: <20060712150754.E01F51BD8D16@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9848: Teach svn-create-patch and friends to fix ChangeLog patches http://bugzilla.opendarwin.org/show_bug.cgi?id=9848 Attachment 9401: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9401&action=edit ------- Additional Comments from Darin Adler Neat. As these get fancier and fancier, eventually we *will* want to start using a library. But for now I still think it's OK to have 3 copies. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 08:49:26 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9872] REGRESSION: Items in multiple select lists are now bold : [Attachment 9403] patch, including change log Message-ID: <20060712154926.930781BD9BE3@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9872: REGRESSION: Items in multiple select lists are now bold http://bugzilla.opendarwin.org/show_bug.cgi?id=9872 Attachment 9403: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9403&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 09:38:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9374] re-arrangements changelogs Message-ID: <20060712163853.E4E2D1BDB967@sampson.opendarwin.org> David Carson has denied David Carson 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9374: re-arrangements changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9374&action=edit ------- Additional Comments from David Carson LayoutTests also need a change log. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 09:38:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review denied: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9374] re-arrangements changelogs Message-ID: <20060712163853.5529D1BDB970@sampson.opendarwin.org> David Carson has denied David Carson 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9374: re-arrangements changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9374&action=edit ------- Additional Comments from David Carson LayoutTests also need a change log. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 10:36:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9405] Split overflowing white space into its own box Message-ID: <20060712173633.19B921BDE228@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9405: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9405&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Did as Hyatt suggested :-) There is a remaining issue with the trailing white space of right-aligned LTR text (and other conditions involving RTL), but I think it belongs in a separate lower-priority bug. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 11:43:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9379] This patch also includes emu.bat Message-ID: <20060712184334.876D21BE0627@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9379: This patch also includes emu.bat http://bugzilla.opendarwin.org/attachment.cgi?id=9379&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 11:43:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9852] [S60] runATF needs Sdk 3rd ed support : [Attachment 9379] This patch also includes emu.bat Message-ID: <20060712184334.BE74A1BE072C@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9852: [S60] runATF needs Sdk 3rd ed support http://bugzilla.opendarwin.org/show_bug.cgi?id=9852 Attachment 9379: This patch also includes emu.bat http://bugzilla.opendarwin.org/attachment.cgi?id=9379&action=edit ------- Additional Comments from Zalan Bujtas r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 11:47:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9880] Memory leaks running DOM-Hanoi : [Attachment 9409] proposed patch Message-ID: <20060712184722.464BF1BE0884@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 9880: Memory leaks running DOM-Hanoi http://bugzilla.opendarwin.org/show_bug.cgi?id=9880 Attachment 9409: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9409&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 12:47:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9879] REGRESSION: Repro crash when clicking to the side of an anonymous table : [Attachment 9412] One-liner patch with layout test and change log entry Message-ID: <20060712194736.EB1291BE2FA2@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9879: REGRESSION: Repro crash when clicking to the side of an anonymous table http://bugzilla.opendarwin.org/show_bug.cgi?id=9879 Attachment 9412: One-liner patch with layout test and change log entry http://bugzilla.opendarwin.org/attachment.cgi?id=9412&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 13:34:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9624] REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items : [Attachment 9415] Patch Message-ID: <20060712203417.4CDC61BE482F@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9624: REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items http://bugzilla.opendarwin.org/show_bug.cgi?id=9624 Attachment 9415: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9415&action=edit ------- Additional Comments from Anders Carlsson Here's a patch. Darin, is there something wrong with doing it this way? From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:23:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9624] REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items : [Attachment 9415] Patch Message-ID: <20060712212349.0F88F1BE6649@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9624: REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items http://bugzilla.opendarwin.org/show_bug.cgi?id=9624 Attachment 9415: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9415&action=edit ------- Additional Comments from Darin Adler Seems to me that the thing we want to check here is not "is the item selected" but rather "is there any text selected in this item", but I think we should land this and refine later after more testing. r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:23:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9624] REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items : [Attachment 9415] Patch Message-ID: <20060712212348.04A7B1BE6647@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9624: REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items http://bugzilla.opendarwin.org/show_bug.cgi?id=9624 Attachment 9415: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9415&action=edit ------- Additional Comments from Darin Adler Seems to me that the thing we want to check here is not "is the item selected" but rather "is there any text selected in this item", but I think we should land this and refine later after more testing. r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:25:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9880] Memory leaks running DOM-Hanoi : [Attachment 9409] proposed patch Message-ID: <20060712212531.8D87B1BE6776@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9880: Memory leaks running DOM-Hanoi http://bugzilla.opendarwin.org/show_bug.cgi?id=9880 Attachment 9409: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9409&action=edit ------- Additional Comments from Darin Adler Looks good. r=me But are there any other calls besides "set status bar text" that need an autorelease pool for the same reason? From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:25:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9879] REGRESSION: Repro crash when clicking to the side of an anonymous table : [Attachment 9412] One-liner patch with layout test and change log entry Message-ID: <20060712212557.AFEE31BE67B2@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9879: REGRESSION: Repro crash when clicking to the side of an anonymous table http://bugzilla.opendarwin.org/show_bug.cgi?id=9879 Attachment 9412: One-liner patch with layout test and change log entry http://bugzilla.opendarwin.org/attachment.cgi?id=9412&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:25:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9880] Memory leaks running DOM-Hanoi : [Attachment 9409] proposed patch Message-ID: <20060712212531.ADF5F1BE67B1@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9880: Memory leaks running DOM-Hanoi http://bugzilla.opendarwin.org/show_bug.cgi?id=9880 Attachment 9409: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9409&action=edit ------- Additional Comments from Darin Adler Looks good. r=me But are there any other calls besides "set status bar text" that need an autorelease pool for the same reason? From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:25:57 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9879] REGRESSION: Repro crash when clicking to the side of an anonymous table : [Attachment 9412] One-liner patch with layout test and change log entry Message-ID: <20060712212557.D19441BE67B6@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9879: REGRESSION: Repro crash when clicking to the side of an anonymous table http://bugzilla.opendarwin.org/show_bug.cgi?id=9879 Attachment 9412: One-liner patch with layout test and change log entry http://bugzilla.opendarwin.org/attachment.cgi?id=9412&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:26:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9872] REGRESSION: Items in multiple select lists are now bold : [Attachment 9403] patch, including change log Message-ID: <20060712212630.42F761BE693D@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9872: REGRESSION: Items in multiple select lists are now bold http://bugzilla.opendarwin.org/show_bug.cgi?id=9872 Attachment 9403: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9403&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 14:26:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9872] REGRESSION: Items in multiple select lists are now bold : [Attachment 9403] patch, including change log Message-ID: <20060712212630.59ADF1BE6940@sampson.opendarwin.org> Darin Adler has cancelled Darin Adler 's request for review: Bug 9872: REGRESSION: Items in multiple select lists are now bold http://bugzilla.opendarwin.org/show_bug.cgi?id=9872 Attachment 9403: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9403&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 17:07:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9663] REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus : [Attachment 9419] Patch Message-ID: <20060713000749.215BC1BEC5B4@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9663: REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus http://bugzilla.opendarwin.org/show_bug.cgi?id=9663 Attachment 9419: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9419&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 17:09:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9663] REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus : [Attachment 9419] Patch Message-ID: <20060713000905.F01A31BEC65D@sampson.opendarwin.org> Justin Garcia has granted Justin Garcia 's request for review: Bug 9663: REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus http://bugzilla.opendarwin.org/show_bug.cgi?id=9663 Attachment 9419: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9419&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 17:09:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9663] REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus : [Attachment 9419] Patch Message-ID: <20060713000906.0733C1BEC65F@sampson.opendarwin.org> Justin Garcia has granted Justin Garcia 's request for review: Bug 9663: REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus http://bugzilla.opendarwin.org/show_bug.cgi?id=9663 Attachment 9419: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9419&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 19:12:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9872] REGRESSION: Items in multiple select lists are now bold : [Attachment 9403] patch, including change log Message-ID: <20060713021228.9E0591BF00F0@sampson.opendarwin.org> Beth Dakin has granted Beth Dakin 's request for review: Bug 9872: REGRESSION: Items in multiple select lists are now bold http://bugzilla.opendarwin.org/show_bug.cgi?id=9872 Attachment 9403: patch, including change log http://bugzilla.opendarwin.org/attachment.cgi?id=9403&action=edit ------- Additional Comments from Beth Dakin r=me! From bugzilla-request-daemon at opendarwin.org Wed Jul 12 22:06:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9888] Icon database leaks when running iExploder and mangleme tests : [Attachment 9421] proposed patch Message-ID: <20060713050606.82CF21BF62B9@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 9888: Icon database leaks when running iExploder and mangleme tests http://bugzilla.opendarwin.org/show_bug.cgi?id=9888 Attachment 9421: proposed patch http://bugzilla.opendarwin.org/attachment.cgi?id=9421&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 22:28:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9013] Let correct CSS custom cursor declarations parse : [Attachment 8433] proposed fix Message-ID: <20060713052852.12B261BF6B73@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 9013: Let correct CSS custom cursor declarations parse http://bugzilla.opendarwin.org/show_bug.cgi?id=9013 Attachment 8433: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=8433&action=edit From modulate310 at dion.ne.jp Wed Jul 12 22:34:33 2006 From: modulate310 at dion.ne.jp (¼–ì —y) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=A8=92m=82=E7=82=B9?= Message-ID: ¡ž¦„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª¦ž¡ @ž‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡ž @¦@@@@‚ÐE‚ÆE‚ÂE‚Ü@•¨Œê@@@@@@@@@@@@@@¦ @¦@@@@@@@@@@@@lÈ‚Æ—V‚ñ‚Å‚Ý‚Ü‚¹‚ñ‚©I@@@@¦ @ž‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡–‡ž ¡ž¦„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª¦ž¡ @@@ šœcš@http://anglican.scramblekosaten.org/a10/@šœcš š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª™ 27Î’j«i‰ïŽÐˆõj‘ÌŒ±ƒŒƒ|[ƒg lÈ‘åD‚«‚Ì27΂ł·A‚±‚±‚̃TƒCƒg‚ð—˜—p‚µ‚Ä1”N‚É‚È‚è‚Ü‚·B lÈ‚ª‘½‚­‚Åo‰ï‚¦‚éŠm—§‚ª‚ß‚¿‚á‚­‚¿‚á‚‚¢‚ñ‚Å‚·‚æB ‚µ‚©‚à–³—¿‚ÅŽg‚¦‚é‚Ì‚Å‚©‚È‚èÅ‚‚Å‚·B ‚±‚Ì‘O‚±‚±‚̃TƒCƒg‚Åo‰ï‚Á‚½lÈ‚ª‚©‚È‚èÅ‚‚Å‚µ‚½B ŽÐ’·•vl‚Å‚©‚Ȃ肨‹àŽ‚¿‚̂悤‚ÅAƒf[ƒg‚Ì”ï—p‚©‚ç‘S‚Äo‚µ‚Ä‚­‚ê‚Ü‚µ‚½B ‚©‚È‚è—Ç‚¢lÈ•ß‚Ü‚¦‚¿‚á‚¢‚Ü‚µ‚½B ‚±‚̃TƒCƒg‚ɂ͉º‹L‚̂悤‚ȃƒbƒZ[ƒW‚ªˆê”t‚Å‚·B ‚µ‚©‚àAŠ®‘S–³—¿I@¥”ñ‚²—˜—p‚­‚¾‚³‚¢B š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª™ –¼‘OF‚©‚¸‚Ý ”N—îF30Î Šy‚µ‚­—V‚ׂél’T‚µ‚Ä‚¢‚Ü‚·B Œ‹¥‚µ‚Ä‚é‚Ì‚Å‚»‚ê‚Å‚à–â‘è‚È‚¢l‚¢‚½‚ç—V‚Ñ‚Ü‚¹‚ñ‚©H šœcš@http://drowse.scramblekosaten.org/a10/@šœcš š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª™ –¼‘OF‚È‚¨‚Ý ”N—îF33Î Å‹ß‘S‘RƒGƒbƒ`‚µ‚Ä‚È‚¢‚̂ŃZƒtƒŒ•åW‚µ‚Ü‚·B Šç‚Í‚Û‚¿‚á‚è‚ÅŽ©M‚È‚¢‚¯‚ǃGƒbƒ`‚Í‚ ‚肾‚æB šœcš@http://triplet.scramblekosaten.org/a10/@šœcš š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª™ –¼‘OF^”ü ”N—îF29Î ’U“ß‚Í“ú–{l‚Å‚·‚ªŽ„‚ÍŠØ‘l‚Å‚·BŠØ‘l ‚Å‚à‚¢‚¢lƒ[ƒ‹‰º‚³‚¢B—V‚Ñ‚Ü‚µ‚傤B šœcš@http://cardiod.scramblekosaten.org/a10/@šœcš š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª™ From bugzilla-request-daemon at opendarwin.org Wed Jul 12 22:41:13 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9889] [Drosera] Stepping out when paused after last statement in function skips a frame : [Attachment 9422] Patch Message-ID: <20060713054113.734511BF6F6A@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame http://bugzilla.opendarwin.org/show_bug.cgi?id=9889 Attachment 9422: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9422&action=edit From bugzilla-request-daemon at opendarwin.org Wed Jul 12 22:44:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9889] [Drosera] Stepping out when paused after last statement in function skips a frame : [Attachment 9422] Patch Message-ID: <20060713054423.783771BF700E@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame http://bugzilla.opendarwin.org/show_bug.cgi?id=9889 Attachment 9422: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9422&action=edit ------- Additional Comments from Timothy Hatcher Thanks for the fix! This is an interesting edge case. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 22:44:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9889] [Drosera] Stepping out when paused after last statement in function skips a frame : [Attachment 9422] Patch Message-ID: <20060713054423.E4BDD1BF81A2@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame http://bugzilla.opendarwin.org/show_bug.cgi?id=9889 Attachment 9422: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9422&action=edit ------- Additional Comments from Timothy Hatcher Thanks for the fix! This is an interesting edge case. From ounfqwlf at latter.com Thu Jul 13 03:45:09 2006 From: ounfqwlf at latter.com (focused providing) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] Action Sport Message-ID: <001101c6a647$e27f7310$a197ff51@CDTI1> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 9193 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060713/1e97c7f4/attachment.gif From bugzilla-request-daemon at opendarwin.org Wed Jul 12 23:59:13 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9405] Split overflowing white space into its own box Message-ID: <20060713065913.77C6C1BF92E5@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9405: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9405&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Moved the totWidth > availableWidth check to the beginning of the condition. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 23:59:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9424] Split overflowing white space into its own box Message-ID: <20060713065914.1C9401BF92E9@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9424: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9424&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Moved the totWidth > availableWidth check to the beginning of the condition. From bugzilla-request-daemon at opendarwin.org Wed Jul 12 23:59:13 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review cancelled: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9405] Split overflowing white space into its own box Message-ID: <20060713065913.1E5441BF92EA@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9405: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9405&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Moved the totWidth > availableWidth check to the beginning of the condition. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 00:03:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9424] Split overflowing white space into its own box Message-ID: <20060713070317.1F9A71BF9ED1@sampson.opendarwin.org> Dave Hyatt has granted Dave Hyatt 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9424: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9424&action=edit ------- Additional Comments from Dave Hyatt r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 00:03:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9424] Split overflowing white space into its own box Message-ID: <20060713070317.0C5731BF9ECE@sampson.opendarwin.org> Dave Hyatt has granted Dave Hyatt 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9424: Split overflowing white space into its own box http://bugzilla.opendarwin.org/attachment.cgi?id=9424&action=edit ------- Additional Comments from Dave Hyatt r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 00:39:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9346] Improved patch+testcase Message-ID: <20060713073932.4E0901BFB5FC@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9346: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9346&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 00:39:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review granted: [Bug 9753] SVG with width and height 100% leaves room for scrollbar on the right. : [Attachment 9346] Improved patch+testcase Message-ID: <20060713073932.95ACF1BFB66C@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9753: SVG with width and height 100% leaves room for scrollbar on the right. http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 Attachment 9346: Improved patch+testcase http://bugzilla.opendarwin.org/attachment.cgi?id=9346&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 02:10:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:37 2007 Subject: [webkit-reviews] review requested: [Bug 9686] [Drosera] Need the ability to break into Drosera on Javascript exceptions : [Attachment 9425] Patch Message-ID: <20060713091049.594AD1BFE745@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions http://bugzilla.opendarwin.org/show_bug.cgi?id=9686 Attachment 9425: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9425&action=edit ------- Additional Comments from Mark Rowe (bdash) I've updated the patch based on feedback from Maciej on IRC. The exception callback is now called for all exceptions rather than only Object instances, and the KJS::Debugger tracks which exceptions it has seen rather than KJS::Node setting a magical property on the exception object. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 06:53:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9428] Patch Message-ID: <20060713135301.692D91C09260@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9428: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9428&action=edit ------- Additional Comments from Mark Rowe (bdash) This patch only allows immediate types tagged as numeric to be converted to UInt32. This resolves the issue without affecting any JSCore or layout tests. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 06:56:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9428] Patch Message-ID: <20060713135643.73FF41C093DD@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9428: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9428&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 13 06:56:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9428] Patch Message-ID: <20060713135643.5A9B71C093E8@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9428: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9428&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 13 06:56:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9429] Updated patch including ChangeLog entry for the layout test Message-ID: <20060713135643.5D7031C093E9@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9429: Updated patch including ChangeLog entry for the layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9429&action=edit From bugzilla-request-daemon at opendarwin.org Thu Jul 13 07:28:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9795?= =?iso-8859-1?q?=5D_REGRESSION=3A_Crash_in_=5BWebHTMLView=28WebPriv?= =?iso-8859-1?q?ate=29_=5FupdateMouseoverWithEvent=3A=5D_=3A__=5BAt?= =?iso-8859-1?q?tachment_9430=5D_Return_immediately_from=A0=5Fupdat?= =?iso-8859-1?q?eMouseoverWithEvent_when_already_closed?= Message-ID: <20060713142814.A4AC81C0B0CB@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9795: REGRESSION: Crash in [WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] http://bugzilla.opendarwin.org/show_bug.cgi?id=9795 Attachment 9430: Return immediately from _updateMouseoverWithEvent when already closed http://bugzilla.opendarwin.org/attachment.cgi?id=9430&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com I'm pretty sure now that this is the fix. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 09:16:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9795=5D?= =?iso-8859-1?q?_REGRESSION=3A_Crash_in_=5BWebHTMLView=28WebPrivate?= =?iso-8859-1?q?=29_=5FupdateMouseoverWithEvent=3A=5D_=3A__=5BAttac?= =?iso-8859-1?q?hment_9430=5D_Return_immediately_from=A0=5FupdateMo?= =?iso-8859-1?q?useoverWithEvent_when_already_closed?= Message-ID: <20060713161612.42FB31C0F43D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9795: REGRESSION: Crash in [WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] http://bugzilla.opendarwin.org/show_bug.cgi?id=9795 Attachment 9430: Return immediately from _updateMouseoverWithEvent when already closed http://bugzilla.opendarwin.org/attachment.cgi?id=9430&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 09:16:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9795=5D?= =?iso-8859-1?q?_REGRESSION=3A_Crash_in_=5BWebHTMLView=28WebPrivate?= =?iso-8859-1?q?=29_=5FupdateMouseoverWithEvent=3A=5D_=3A__=5BAttac?= =?iso-8859-1?q?hment_9430=5D_Return_immediately_from=A0=5FupdateMo?= =?iso-8859-1?q?useoverWithEvent_when_already_closed?= Message-ID: <20060713161612.101891C0F44E@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9795: REGRESSION: Crash in [WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] http://bugzilla.opendarwin.org/show_bug.cgi?id=9795 Attachment 9430: Return immediately from _updateMouseoverWithEvent when already closed http://bugzilla.opendarwin.org/attachment.cgi?id=9430&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 09:18:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9429] Updated patch including ChangeLog entry for the layout test Message-ID: <20060713161836.60E3F1C0F5C3@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9429: Updated patch including ChangeLog entry for the layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9429&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 09:18:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9429] Updated patch including ChangeLog entry for the layout test Message-ID: <20060713161836.0DB3F1C0F628@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9429: Updated patch including ChangeLog entry for the layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9429&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 09:21:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review denied: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9429] Updated patch including ChangeLog entry for the layout test Message-ID: <20060713162117.74C041C0F800@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9429: Updated patch including ChangeLog entry for the layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9429&action=edit ------- Additional Comments from Geoffrey Garen Great catch! Two objections: 1. JavaScript layout tests should be written as pure JavaScript, and the HTML to run them in DumpRenderTree generated by the /WebKitTools/Scripts/make-js-test-wrappers script. You can see example .js files in LayoutTests/fast/js/resources. The reason for this is that we want to be able to run these tests outside of the browser, too. 2. It looks like the other get functions, like getNumber, have the same issue. It would be best to change them too. Note to commiter: We'll need to performance test the final patch before landing, since it may change the inlining behavior of some hot functions. From pwindham at zooandaquarium.com Thu Jul 13 14:11:24 2006 From: pwindham at zooandaquarium.com (Penney Windham) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] January Counts Message-ID: <1152825084.264966@zooandaquarium.com> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060713/dc513404/attachment.html From bugzilla-request-daemon at opendarwin.org Thu Jul 13 19:18:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9437] Patch Message-ID: <20060714021845.C36C61C2242B@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9437: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9437&action=edit ------- Additional Comments from Mark Rowe (bdash) Updated patch that uses Geoffrey's suggested change to getUInt32. This omits the change to getNumber for the reasons stated in comment #12. I have also updated two existing tests related to JSHTMLOptionsCollection::setLength to ensure that regressions such as the one the getNumber change would have introduced are noticed in future. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 19:49:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9437] Patch Message-ID: <20060714024952.167EF1C22D1F@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9437: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9437&action=edit ------- Additional Comments from Geoffrey Garen These tests fill me with warm fuzzies. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 19:49:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9742] REGRESSION: WebKit hangs when loading : [Attachment 9437] Patch Message-ID: <20060714024952.7AD191C22D27@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9742: REGRESSION: WebKit hangs when loading http://bugzilla.opendarwin.org/show_bug.cgi?id=9742 Attachment 9437: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9437&action=edit ------- Additional Comments from Geoffrey Garen These tests fill me with warm fuzzies. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 20:47:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9686] [Drosera] Need the ability to break into Drosera on Javascript exceptions : [Attachment 9425] Patch Message-ID: <20060714034719.C7ECB1C248CE@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions http://bugzilla.opendarwin.org/show_bug.cgi?id=9686 Attachment 9425: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9425&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 20:47:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9686] [Drosera] Need the ability to break into Drosera on Javascript exceptions : [Attachment 9425] Patch Message-ID: <20060714034719.71D6A1C248D5@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions http://bugzilla.opendarwin.org/show_bug.cgi?id=9686 Attachment 9425: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9425&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Thu Jul 13 21:21:34 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9903] Fix JSHTMLOptionsCollection::setLength() to use getNumber() properly : [Attachment 9438] Patch v1 Message-ID: <20060714042134.EBC501C25A0A@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9903: Fix JSHTMLOptionsCollection::setLength() to use getNumber() properly http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9438: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9438&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Proposed patch.  (I hope I interpreted your comment correctly, Geoff!) From prong981 at mail.goo.ne.jp Thu Jul 13 21:45:52 2006 From: prong981 at mail.goo.ne.jp (‹{–{ m) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=A8=98l=82=D1?= Message-ID: <46510si04458jvu$8906x27$4541y53yvn932@mawr> @@-------------------------------------------------- @@@‹ßŠ‚Éö‚Þ‚¦‚Á‚¿‚Ȉ٫ @@@@@@@–³—¿‚Å—V‚ׂéˆê–é‚ÌŠÖŒW @@E‚¢‚â‚炵‚­–ü‚³‚ꂽ‚¢‚Ì‚Í—‚ÌŽq‚àˆê @@EŒû‚Éo‚µ‚Ä‚ÍŒ¾‚¦‚È‚¢‚¯‚Ç‘å’_‚ÈŽ–‚µ‚Ä‚Ý‚½‚¢ @@E”ÞŽE•v‚É“à‚ÌŠÖŒW‚ª—~‚µ‚¢I @@’j«‚Ì•û‚ª’Ê킦‚Á‚¿‚ÈŽ–‚ðl‚¦‚Ä‚¢‚é‚ÆŽv‚í‚ꂪ‚¿‚Å‚·‚ªA @@—«‚à“¯‚¶‚­‚ç‚¢‚©‚»‚êˆÈã‚É‚¦‚Á‚¿‚ÈŽ–‚ðl‚¦‚Ä‚¢‚Ü‚·B @@‚»‚µ‚Ä—F’BŠÖŒW‚Ìl‚æ‚è‚àŠ®‘SŠ„‚èØ‚è‚Å‘Ì‚¾‚¯‚ÌŠÖŒW‚ð‹‚ßA @@o‰ï‚¢ƒTƒCƒg‚É“o˜^‚·‚éƒP[ƒX‚ª”ñí‚É‘½‚¢‚Å‚·B @@ @@http://fr-q.com/r20/index.html?media=pc343 @@ƒZƒtƒŒA•s—Ï‘ŠŽè’T‚µ‚ÉBˆÓŠO‚Ƌߊ‚ÅŒ©‚‚©‚è‚Ü‚·B @@ @@’j—Š®‘S–³—¿‚É‚·‚邱‚Æ‚É‚æ‚Á‚ÄA—«‚Í‚æ‚葽‚­‚Ì @@‘Ì‚¾‚¯‚ÌŠÖŒW‚ð‹‚ß‚él‚Æo‰ï‚¦‚Ü‚·B @@ƒIƒgƒi‚ÌŠÖŒW‚ðŠó–]‚·‚é•û‚¾‚¯‚ªW‚Ü‚è‚Ü‚·‚Ì‚ÅA @@‚æ‚èŒø—¦“I‚É‚¨–]‚݂̃p[ƒgƒi[‚ð’T‚·‚±‚Æ‚ªo—ˆ‚Ü‚·B @@http://fr-q.com/r20/index.html?media=pc343 @@‘S‚ÄŠ®‘S–³—¿‚Å‚·BˆÀS‚µ‚Ä‚²—˜—p‰º‚³‚¢B ******************************************************************* @[Ⴓ‚ñ@ @g’·@@@F160-164cm @ƒXƒ^ƒCƒ‹@FƒXƒŒƒ“ƒ_[ @—öˆ¤ŠÏ@@F‚»‚Ì‘¼ @‰ï‚¢‚½‚¢‚È‚Ÿù‘24΂ÌÊÞ½¶Þ²ÄÞ‚Å‚·(*^-^*) @‚±‚ñ‚É‚¿‚Í(*^-^*)‚»‚µ‚ÄA‰‚ß‚Ü‚µ‚Äù‘Ž„‚ÍÊÞ½¶Þ²ÄÞ‚ð @‚â‚Á‚Ä‚Ü‚·ù•–¾“ú‚Í‹x‚Ý‚È‚Ì‚Å¡‚©‚ç‰ï‚¦‚½‚ç‚¢‚¢‚È‚Ÿ‚Á @‚ÄŽv‚Á‚Ä‘‚«ž‚Ý‚µ‚Ü‚µ‚½ù• @‹}‚È‚Ì‚Å‚à‚µ¡‚©‚ç–³—‚È‚ç“s‡‚Ì‚¢‚¢“ú‚ð‹³‚¦‚Ä‚­‚¾‚³‚¢‚Ëù’ @‘Ò‚Á‚Ä‚Ü‚·ôF‚ñ‚ÈŽ–‚µ‚½‚¢‚Èù‘ @“o˜^Šm”FF@http://fr-q.com/r20/index.html?media=pc343 ******************************************************************* @‚d‚q‚h‚j‚` @g’·@@@F165cm` @ƒXƒ^ƒCƒ‹@FƒXƒŒƒ“ƒ_[ @—öˆ¤ŠÏ@@Fƒvƒ‰ƒgƒjƒbƒNŽå‹` @´Ø¶27΂ł·ù’ @‰‚ß‚Ü‚µ‚Äù•‰‚ß‚Ä»²Ä‚É“o˜^‚µ‚Ä‚Ü‚¾‚킯‚à‚í‚©‚炸cù— @‚¢‚«‚È‚è‘‚«ž‚Ý‚µ‚¿‚á‚¢@‚Ü‚µ‚½(^-^) @‘ål‚Ì•t‚«‡‚¢‚ð‚µ‚½‚¢‚Å‚·ù• @—Ç‚¯‚ê‚Î1“xHŽ–‚És‚«‚Ü‚¹‚ñ‚©?´Ø¶ù’ @“o˜^Šm”FF@http://fr-q.com/r20/index.html?media=pc343 ******************************************************************* ”ü“Þ @g’·@@@F155-159cm @ƒXƒ^ƒCƒ‹@F•W€ @—öˆ¤ŠÏ@@Fƒvƒ‰ƒgƒjƒbƒNŽå‹` @‹M•ûŽŸ‘æ‚Åùr“d˜b‚ÉØ‘ÖOK‚Å‚·I‚¢‚«‚È‚è‰ß‚¬‚Ü‚·‚©H @‚¨ŒÝ‚¢‚Ìe–r‚ð[‚߂邽‚ß‚É‚¨HŽ–‚àŒ“‚˂Ċ燂킹‚µ‚Ü‚¹‚ñ‚©H @ŽdŽ–‚ª‚玞ŠÔ‚Í‚ ‚é’ö“x—Z’Ê‚ª—˜‚­‚Ì‚Å‚¢‚Â‚Å‚à‚¢‚¢‚Ì‚Å‚·‚ªA @‚Å‚«‚ê‚΂±‚ê‚©‚炪‚¢@‚¢‚©‚à(^-^) @‚Ü‚¸˜A—‰º‚³‚¢B‹M•ûŽŸ‘æ‚Å“d˜b‚Éؑ։”\‚Å‚·‚æB‚¨˜b‚µ‚Ä‚Ý‚Ü‚·‚©H @“o˜^Šm”FF@http://fr-q.com/r20/index.html?media=pc343 @******************************************************************* @ˆÀS‚µ‚Ä‚¦‚Á‚¿‚ÈŠÖŒW‚ðŠy‚µ‚Þ•û‚Ì‚½‚ß‚ÉA @–³—¿“o˜^‚ª•K—v‚Æ‚È‚Á‚Ä‚¢‚Ü‚·B @‚²—˜—p‚Í–³—¿“o˜^Œã‚Æ‚È‚è‚Ü‚·B http://fr-q.com/r20/index.html?media=pc343 From bugzilla-request-daemon at opendarwin.org Thu Jul 13 21:58:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9903] Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() : [Attachment 9438] Patch v1 Message-ID: <20060714045835.396791C26482@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled David Kilzer (ddkilzer) 's request for review: Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9438: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9438&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Oops. I need to include the bug information in the ChangeLog! From bugzilla-request-daemon at opendarwin.org Thu Jul 13 21:58:35 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9903] Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() : [Attachment 9438] Patch v1 Message-ID: <20060714045835.3B42B1C26483@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled David Kilzer (ddkilzer) 's request for review: Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9438: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9438&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Oops. I need to include the bug information in the ChangeLog! From bugzilla-request-daemon at opendarwin.org Thu Jul 13 22:24:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9879] REGRESSION: Repro crash when clicking to the side of an anonymous table : [Attachment 9412] One-liner patch with layout test and change log entry Message-ID: <20060714052440.0375C1C274AE@sampson.opendarwin.org> David Kilzer (ddkilzer) has cancelled Darin Adler 's request for review: Bug 9879: REGRESSION: Repro crash when clicking to the side of an anonymous table http://bugzilla.opendarwin.org/show_bug.cgi?id=9879 Attachment 9412: One-liner patch with layout test and change log entry http://bugzilla.opendarwin.org/attachment.cgi?id=9412&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Clearing review flag due to bit rottedness.  See Comment #6. From bugzilla-request-daemon at opendarwin.org Thu Jul 13 22:33:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9903] Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() : [Attachment 9439] Patch v2 Message-ID: <20060714053332.2BAAD1C276E2@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9439: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9439&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Now with Bugzilla bug information in the ChangeLog! From bugzilla-request-daemon at opendarwin.org Fri Jul 14 01:27:09 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9903] Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() : [Attachment 9439] Patch v2 Message-ID: <20060714082709.877E71C2C482@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9439: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9439&action=edit ------- Additional Comments from Geoffrey Garen That's right. This patch enables landing the getNumber part of my JavaScriptCore patch: { if (JSImmediate::isImmediate(this)) { v = JSImmediate::toDouble(this); - return true; + return JSImmediate::isNumber(this); } return downcast()->getNumber(v); From bugzilla-request-daemon at opendarwin.org Fri Jul 14 01:27:09 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9903] Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() : [Attachment 9439] Patch v2 Message-ID: <20060714082709.51D701C2C47F@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9903: Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() http://bugzilla.opendarwin.org/show_bug.cgi?id=9903 Attachment 9439: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9439&action=edit ------- Additional Comments from Geoffrey Garen That's right. This patch enables landing the getNumber part of my JavaScriptCore patch: { if (JSImmediate::isImmediate(this)) { v = JSImmediate::toDouble(this); - return true; + return JSImmediate::isNumber(this); } return downcast()->getNumber(v); From replybns at yahoo.com Fri Jul 14 01:49:35 2006 From: replybns at yahoo.com (bns_opportunity@yahoo.com) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=B8=D8=C3=A1=D4=A8=CA=D3=E0=C3?= =?iso-8859-1?q?=E7=A8=C3=D9=BB=A7=E8=D2=C2_=E6_=BA=B9_Internet_=C5?= =?iso-8859-1?q?=A7=B7=D8=B9=B5=E8=D3_=C3=D2=C2=E4=B4=E9=B4=D5?= Message-ID: <20060714084938.A80811C2C978@sampson.opendarwin.org> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060714/a9dcdd2c/attachment.html From webkeep at slais.ubc.ca Fri Jul 14 05:44:21 2006 From: webkeep at slais.ubc.ca (webkeep@slais.ubc.ca) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] Turn your professional experience into the University Degree you deserve. Message-ID: 62YhQWabqn3fm.idgBk4SOxkOBd@slais.ubc.ca An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060714/8f856283/attachment.html From bugzilla-request-daemon at opendarwin.org Fri Jul 14 03:05:52 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9442] Add missing null checks Message-ID: <20060714100552.7A19D1C2F14D@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9442: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9442&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 04:26:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9907] REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode : [Attachment 9443] Fix the calculation of min/max allowable caret position Message-ID: <20060714112610.083BB1C3363D@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9907: REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9907 Attachment 9443: Fix the calculation of min/max allowable caret position http://bugzilla.opendarwin.org/attachment.cgi?id=9443&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Fixes the regression and doesn't introduce new failures in run-webkit-tests --pixel editing fast. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:12:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9442] Add missing null checks Message-ID: <20060714121251.445911C356CF@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9442: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9442&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Changes to the test -- removed stray comment and added missing newline. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:12:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9444] Add missing null checks Message-ID: <20060714121251.1525F1C356D9@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9444: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9444&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Changes to the test -- removed stray comment and added missing newline. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:12:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review cancelled: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9442] Add missing null checks Message-ID: <20060714121251.12EC61C356D8@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9442: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9442&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Changes to the test -- removed stray comment and added missing newline. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:31:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9444] Add missing null checks Message-ID: <20060714123131.583F41C36F8A@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9444: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9444&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:31:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9905] REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div : [Attachment 9444] Add missing null checks Message-ID: <20060714123131.54E401C36F89@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9905: REGRESSION (r15404-r15415): Repro crash when pressing delete in an empty editable div http://bugzilla.opendarwin.org/show_bug.cgi?id=9905 Attachment 9444: Add missing null checks http://bugzilla.opendarwin.org/attachment.cgi?id=9444&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:32:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9907] REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode : [Attachment 9443] Fix the calculation of min/max allowable caret position Message-ID: <20060714123230.37B9F1C371BF@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9907: REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9907 Attachment 9443: Fix the calculation of min/max allowable caret position http://bugzilla.opendarwin.org/attachment.cgi?id=9443&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 05:32:30 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9907] REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode : [Attachment 9443] Fix the calculation of min/max allowable caret position Message-ID: <20060714123230.3E4E91C37277@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9907: REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode http://bugzilla.opendarwin.org/show_bug.cgi?id=9907 Attachment 9443: Fix the calculation of min/max allowable caret position http://bugzilla.opendarwin.org/attachment.cgi?id=9443&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 06:01:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 8952] REGRESSION: crash on drag of highlighted Google custom home page modules : [Attachment 9445] patch with detailed change log and a layout test Message-ID: <20060714130112.7CBD51C3B79A@sampson.opendarwin.org> Darin Adler has asked for review: Bug 8952: REGRESSION: crash on drag of highlighted Google custom home page modules http://bugzilla.opendarwin.org/show_bug.cgi?id=8952 Attachment 9445: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9445&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 06:40:13 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 8587] REGRESSION: {display:list-item} on items outside an ol or ul element no longer causes incremental numbering : [Attachment 9446] patch with detailed change log and a layout test Message-ID: <20060714134013.777AF1C3E4B8@sampson.opendarwin.org> Darin Adler has asked for review: Bug 8587: REGRESSION: {display:list-item} on items outside an ol or ul element no longer causes incremental numbering http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 Attachment 9446: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9446&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 08:57:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 8395] REGRESSION: RegEx seems broken for hex escaped non breaking space : [Attachment 9448] patch with detailed change log and a layout test Message-ID: <20060714155743.550D51C42ADA@sampson.opendarwin.org> Darin Adler has asked for review: Bug 8395: REGRESSION: RegEx seems broken for hex escaped non breaking space http://bugzilla.opendarwin.org/show_bug.cgi?id=8395 Attachment 9448: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9448&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 09:11:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9449] Patch now adds ChangeLog to LayoutTests & toplevel group Message-ID: <20060714161102.D68FE1C43941@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9449: Patch now adds ChangeLog to LayoutTests & toplevel group http://bugzilla.opendarwin.org/attachment.cgi?id=9449&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 09:11:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9449] Patch now adds ChangeLog to LayoutTests & toplevel group Message-ID: <20060714161102.415861C43949@sampson.opendarwin.org> Bradley Morrison has asked David Carson for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9449: Patch now adds ChangeLog to LayoutTests & toplevel group http://bugzilla.opendarwin.org/attachment.cgi?id=9449&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 09:41:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 8871] REGRESSION: Pressing Enter/Return in a text input removes the selected text : [Attachment 9450] patch with detailed change log and a layout test Message-ID: <20060714164106.6B6DA1C44171@sampson.opendarwin.org> Darin Adler has asked for review: Bug 8871: REGRESSION: Pressing Enter/Return in a text input removes the selected text http://bugzilla.opendarwin.org/show_bug.cgi?id=8871 Attachment 9450: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9450&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 09:46:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8871] REGRESSION: Pressing Enter/Return in a text input removes the selected text : [Attachment 9450] patch with detailed change log and a layout test Message-ID: <20060714164616.E2DC01C44286@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 8871: REGRESSION: Pressing Enter/Return in a text input removes the selected text http://bugzilla.opendarwin.org/show_bug.cgi?id=8871 Attachment 9450: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9450&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 09:46:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8871] REGRESSION: Pressing Enter/Return in a text input removes the selected text : [Attachment 9450] patch with detailed change log and a layout test Message-ID: <20060714164616.697171C4428C@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 8871: REGRESSION: Pressing Enter/Return in a text input removes the selected text http://bugzilla.opendarwin.org/show_bug.cgi?id=8871 Attachment 9450: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9450&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 11:06:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8395] REGRESSION: RegEx seems broken for hex escaped non breaking space : [Attachment 9448] patch with detailed change log and a layout test Message-ID: <20060714180615.EFBCC1C47542@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 8395: REGRESSION: RegEx seems broken for hex escaped non breaking space http://bugzilla.opendarwin.org/show_bug.cgi?id=8395 Attachment 9448: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9448&action=edit ------- Additional Comments from Geoffrey Garen these non-layout bugs are just too easy From bugzilla-request-daemon at opendarwin.org Fri Jul 14 11:06:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8395] REGRESSION: RegEx seems broken for hex escaped non breaking space : [Attachment 9448] patch with detailed change log and a layout test Message-ID: <20060714180615.F2BC01C47543@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 8395: REGRESSION: RegEx seems broken for hex escaped non breaking space http://bugzilla.opendarwin.org/show_bug.cgi?id=8395 Attachment 9448: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9448&action=edit ------- Additional Comments from Geoffrey Garen these non-layout bugs are just too easy From bugzilla-request-daemon at opendarwin.org Fri Jul 14 12:04:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9902] jsNull and NSNull not properly converted between JS and ObjC : [Attachment 9451] Patch to fix JSnull <-> NSNull Message-ID: <20060714190445.4D3471C494C5@sampson.opendarwin.org> Dan Waylonis has asked for review: Bug 9902: jsNull and NSNull not properly converted between JS and ObjC http://bugzilla.opendarwin.org/show_bug.cgi?id=9902 Attachment 9451: Patch to fix JSnull <-> NSNull http://bugzilla.opendarwin.org/attachment.cgi?id=9451&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:02:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9658] REGRESSION: Check Spelling does not work in textarea elements : [Attachment 9452] Patch Message-ID: <20060714200245.ED0C71C4B513@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9658: REGRESSION: Check Spelling does not work in textarea elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9658 Attachment 9452: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9452&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:03:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 4195] REGRESSION: KOI8-U encoding no longer supported : [Attachment 9453] proposed fix Message-ID: <20060714200308.8626B1C4B575@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 4195: REGRESSION: KOI8-U encoding no longer supported http://bugzilla.opendarwin.org/show_bug.cgi?id=4195 Attachment 9453: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9453&action=edit ------- Additional Comments from Alexey Proskuryakov At the moment, StreamingTextDecoderMac is a complete implementation, and I have verified that all existing tests pass even with StreamingTextDecoderICU disabled. I haven't attempted to factor out any common code, as the TEC/CFString code path will be simplified in the future; also, Unity may have a largely different implementation with its Qt back-end. WebCoreTextDecoder was dead code (used for WebTextView before it was moved to WebCore). From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:10:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9449] Patch now adds ChangeLog to LayoutTests & toplevel group Message-ID: <20060714201005.686831C4B913@sampson.opendarwin.org> David Carson has granted David Carson 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9449: Patch now adds ChangeLog to LayoutTests & toplevel group http://bugzilla.opendarwin.org/attachment.cgi?id=9449&action=edit ------- Additional Comments from David Carson Looks good. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:10:05 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9755] S60WebKit should have ChangeLogs in the same locations as WebKit ToT : [Attachment 9449] Patch now adds ChangeLog to LayoutTests & toplevel group Message-ID: <20060714201005.5977C1C4B919@sampson.opendarwin.org> David Carson has granted David Carson 's request for review: Bug 9755: S60WebKit should have ChangeLogs in the same locations as WebKit ToT http://bugzilla.opendarwin.org/show_bug.cgi?id=9755 Attachment 9449: Patch now adds ChangeLog to LayoutTests & toplevel group http://bugzilla.opendarwin.org/attachment.cgi?id=9449&action=edit ------- Additional Comments from David Carson Looks good. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:19:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9658] REGRESSION: Check Spelling does not work in textarea elements : [Attachment 9452] Patch Message-ID: <20060714201932.2B78E1C4BC25@sampson.opendarwin.org> Justin Garcia has granted Justin Garcia 's request for review: Bug 9658: REGRESSION: Check Spelling does not work in textarea elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9658 Attachment 9452: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9452&action=edit ------- Additional Comments from Justin Garcia Hey anders I think you could set the start/end to the first/last nodes in an editable div for all editable divs.  I don't think you need to special case shadow divs.  but this  is just a suggestion. r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:19:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9658] REGRESSION: Check Spelling does not work in textarea elements : [Attachment 9452] Patch Message-ID: <20060714201932.0BB721C4BC2B@sampson.opendarwin.org> Justin Garcia has granted Justin Garcia 's request for review: Bug 9658: REGRESSION: Check Spelling does not work in textarea elements http://bugzilla.opendarwin.org/show_bug.cgi?id=9658 Attachment 9452: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9452&action=edit ------- Additional Comments from Justin Garcia Hey anders I think you could set the start/end to the first/last nodes in an editable div for all editable divs.  I don't think you need to special case shadow divs.  but this  is just a suggestion. r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:36:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9919] [S60] Tool to updated s60internals\*.zip : [Attachment 9454] Implements refresh_zips.bat + minor fix to prepare_changelogs Message-ID: <20060714203614.F13691C4C025@sampson.opendarwin.org> Bradley Morrison has asked Sachin Padma for review: Bug 9919: [S60] Tool to updated s60internals\*.zip http://bugzilla.opendarwin.org/show_bug.cgi?id=9919 Attachment 9454: Implements refresh_zips.bat + minor fix to prepare_changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9454&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 13:36:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9919] [S60] Tool to updated s60internals\*.zip : [Attachment 9454] Implements refresh_zips.bat + minor fix to prepare_changelogs Message-ID: <20060714203615.0CB5F1C4C027@sampson.opendarwin.org> Bradley Morrison has asked Sachin Padma for review: Bug 9919: [S60] Tool to updated s60internals\*.zip http://bugzilla.opendarwin.org/show_bug.cgi?id=9919 Attachment 9454: Implements refresh_zips.bat + minor fix to prepare_changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9454&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 14:11:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9919] [S60] Tool to updated s60internals\*.zip : [Attachment 9454] Implements refresh_zips.bat + minor fix to prepare_changelogs Message-ID: <20060714211151.06AF51C4D700@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9919: [S60] Tool to updated s60internals\*.zip http://bugzilla.opendarwin.org/show_bug.cgi?id=9919 Attachment 9454: Implements refresh_zips.bat + minor fix to prepare_changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9454&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 14:11:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9919] [S60] Tool to updated s60internals\*.zip : [Attachment 9454] Implements refresh_zips.bat + minor fix to prepare_changelogs Message-ID: <20060714211151.A61661C4D6FB@sampson.opendarwin.org> Zalan Bujtas has granted Zalan Bujtas 's request for review: Bug 9919: [S60] Tool to updated s60internals\*.zip http://bugzilla.opendarwin.org/show_bug.cgi?id=9919 Attachment 9454: Implements refresh_zips.bat + minor fix to prepare_changelogs http://bugzilla.opendarwin.org/attachment.cgi?id=9454&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 17:06:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9866] REGRESSION: Repro crash from mangleme using iframe, only from server : [Attachment 9456] Patch Message-ID: <20060715000625.D82551C535D8@sampson.opendarwin.org> Anders Carlsson has asked for review: Bug 9866: REGRESSION: Repro crash from mangleme using iframe, only from server http://bugzilla.opendarwin.org/show_bug.cgi?id=9866 Attachment 9456: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9456&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 18:41:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9866] REGRESSION: Repro crash from mangleme using iframe, only from server : [Attachment 9456] Patch Message-ID: <20060715014125.430F61C5686C@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9866: REGRESSION: Repro crash from mangleme using iframe, only from server http://bugzilla.opendarwin.org/show_bug.cgi?id=9866 Attachment 9456: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9456&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 18:45:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 4195] REGRESSION: KOI8-U encoding no longer supported : [Attachment 9453] proposed fix Message-ID: <20060715014529.85B601C56996@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 4195: REGRESSION: KOI8-U encoding no longer supported http://bugzilla.opendarwin.org/show_bug.cgi?id=4195 Attachment 9453: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9453&action=edit ------- Additional Comments from Darin Adler Looks great! r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 18:41:25 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9866] REGRESSION: Repro crash from mangleme using iframe, only from server : [Attachment 9456] Patch Message-ID: <20060715014125.77D411C56995@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9866: REGRESSION: Repro crash from mangleme using iframe, only from server http://bugzilla.opendarwin.org/show_bug.cgi?id=9866 Attachment 9456: Patch http://bugzilla.opendarwin.org/attachment.cgi?id=9456&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 18:45:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 4195] REGRESSION: KOI8-U encoding no longer supported : [Attachment 9453] proposed fix Message-ID: <20060715014529.9D8401C5699D@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 4195: REGRESSION: KOI8-U encoding no longer supported http://bugzilla.opendarwin.org/show_bug.cgi?id=4195 Attachment 9453: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9453&action=edit ------- Additional Comments from Darin Adler Looks great! r=me From bugzilla-request-daemon at opendarwin.org Fri Jul 14 19:41:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9911] REGRESSION: Reproducible crash on FCKeditor demo : [Attachment 9458] patch with detailed change log and a layout test Message-ID: <20060715024114.0C4381C584FC@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9911: REGRESSION: Reproducible crash on FCKeditor demo http://bugzilla.opendarwin.org/show_bug.cgi?id=9911 Attachment 9458: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9458&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 21:42:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9883] REGRESSION: NativePopups don't work correctly in some forum software : [Attachment 9462] patch with detailed change log and a layout test Message-ID: <20060715044206.574881C5B7DB@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9883: REGRESSION: NativePopups don't work correctly in some forum software http://bugzilla.opendarwin.org/show_bug.cgi?id=9883 Attachment 9462: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9462&action=edit From bugzilla-request-daemon at opendarwin.org Fri Jul 14 21:47:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9883] REGRESSION: NativePopups don't work correctly in some forum software : [Attachment 9462] patch with detailed change log and a layout test Message-ID: <20060715044716.0C0B81C5B9F8@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9883: REGRESSION: NativePopups don't work correctly in some forum software http://bugzilla.opendarwin.org/show_bug.cgi?id=9883 Attachment 9462: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9462&action=edit ------- Additional Comments from John Sullivan There's a wordo in the ChangeLog ("because" for "before"). And I don't know if "to ... index" is a typo, a placeholder, or terminology that I'm unfamiliar with. But the change itself looks good. From bugzilla-request-daemon at opendarwin.org Fri Jul 14 21:47:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9883] REGRESSION: NativePopups don't work correctly in some forum software : [Attachment 9462] patch with detailed change log and a layout test Message-ID: <20060715044716.31CD91C5BA00@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9883: REGRESSION: NativePopups don't work correctly in some forum software http://bugzilla.opendarwin.org/show_bug.cgi?id=9883 Attachment 9462: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9462&action=edit ------- Additional Comments from John Sullivan There's a wordo in the ChangeLog ("because" for "before"). And I don't know if "to ... index" is a typo, a placeholder, or terminology that I'm unfamiliar with. But the change itself looks good. From bugzilla-request-daemon at opendarwin.org Sat Jul 15 07:04:20 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review requested: [Bug 9928] REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) : [Attachment 9465] patch to actually implement the new categories Message-ID: <20060715140420.CAEED1C6E6BE@sampson.opendarwin.org> Darin Adler has asked for review: Bug 9928: REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) http://bugzilla.opendarwin.org/show_bug.cgi?id=9928 Attachment 9465: patch to actually implement the new categories http://bugzilla.opendarwin.org/attachment.cgi?id=9465&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 15 07:23:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9928] REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) : [Attachment 9465] patch to actually implement the new categories Message-ID: <20060715142337.66B6D1C6ED49@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9928: REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) http://bugzilla.opendarwin.org/show_bug.cgi?id=9928 Attachment 9465: patch to actually implement the new categories http://bugzilla.opendarwin.org/attachment.cgi?id=9465&action=edit ------- Additional Comments from John Sullivan Makes it tempting to fix that prepare-ChangeLog bug, eh? From bugzilla-request-daemon at opendarwin.org Sat Jul 15 07:23:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 9928] REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) : [Attachment 9465] patch to actually implement the new categories Message-ID: <20060715142337.4B8131C6ED50@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 9928: REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix) http://bugzilla.opendarwin.org/show_bug.cgi?id=9928 Attachment 9465: patch to actually implement the new categories http://bugzilla.opendarwin.org/attachment.cgi?id=9465&action=edit ------- Additional Comments from John Sullivan Makes it tempting to fix that prepare-ChangeLog bug, eh? From bugzilla-request-daemon at opendarwin.org Sat Jul 15 09:20:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8952] REGRESSION: crash on drag of highlighted Google custom home page modules : [Attachment 9445] patch with detailed change log and a layout test Message-ID: <20060715162044.8D91B1C723B2@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 8952: REGRESSION: crash on drag of highlighted Google custom home page modules http://bugzilla.opendarwin.org/show_bug.cgi?id=8952 Attachment 9445: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9445&action=edit ------- Additional Comments from John Sullivan r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 15 09:20:44 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-reviews] review granted: [Bug 8952] REGRESSION: crash on drag of highlighted Google custom home page modules : [Attachment 9445] patch with detailed change log and a layout test Message-ID: <20060715162044.DB2661C723B5@sampson.opendarwin.org> John Sullivan has granted John Sullivan 's request for review: Bug 8952: REGRESSION: crash on drag of highlighted Google custom home page modules http://bugzilla.opendarwin.org/show_bug.cgi?id=8952 Attachment 9445: patch with detailed change log and a layout test http://bugzilla.opendarwin.org/attachment.cgi?id=9445&action=edit ------- Additional Comments from John Sullivan r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 15 09:21:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:38 2007 Subject: [webkit-revi