From susanne50432xinghao at LYCOS.ru Sat Jul 1 16:23:04 2006 From: susanne50432xinghao at LYCOS.ru (Faxon) Date: Tue Oct 9 17:56:31 2007 Subject: [webkit-reviews] re[9]: Don't get left behind, get phermones Message-ID: Remember how you felt when your dream girl shot you down? Well now you never have to feel that way again! Pheromones have been proven to work, and are guaranted to increase your attractiveness to women of all ages. Just look at some of the testimonials we have received back from 100% satisfied repeat customers! : "I've always had a problem approaching girls. They would just walk past me like I didn't exist. I sometimes felt like they purposely would not give me any attention just because they were snobby and stuck up. Now, when I use Ultra Allure Pheromones, it's alot easier to approach girls because THEY are usually the ones that will smile at me first or make eye contact." Robert K, Boise Idaho "I saw you guys offered a moneyback guarantee, so I though I would give it a go(I had nothing to lose). Well how glad am I that I did! My first night out with a little Ultra Allure on me I had 4 different girls ask me what I was wearing and what I was doing later(I met up with the hottest of the 4 ;) ) Now I don't even leave the house without throwing on a few dabs of Ultra Allure- its my (not so) secret weapon! I can honestly say this product truly works, women are really drawn to you once they catch a little bit of the scent." Brad M. Kentucky We receive dozens of emails daily just like these ones! Don't be left out! Pheromones have been studied extensively and profiled on such media outlets as CNN, Oprah Winfrey show, ABC, MSNBC, FOXNEWS, and magazines such as MAXIM, FHM and PLAYBOY! Visit our website now to check out the huge discount sale going on right now! Hurry though as discount specials will be discontinued within the next few days! Remove you e-mail -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/294fa9a8/attachment.html From win0spiro at guy.com Sat Jul 1 00:22:41 2006 From: win0spiro at guy.com (yonah) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Fw[4]: /!agra GET IT HERE!!! Message-ID: -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060701/a842112c/attachment.html From bugzilla-request-daemon at opendarwin.org Sat Jul 1 03:53:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_R?= =?iso-8859-1?q?eplace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701105349.4CA6B1961C6F@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit From wuqui at yahoo.co.jp Sat Jul 1 03:55:07 2006 From: wuqui at yahoo.co.jp (=?iso-2022-jp?B?ZmVodQ==?=) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?GyRCOiM3biF6JSQlQSUqJTcbKEI=?= =?iso-2022-jp?b?GyRCIXolMyUzGyhC?= Message-ID: <20060701105507.F32311961D1A@sampson.opendarwin.org> ???????????? http://13196.com/susume/ okusamanosusume gongxi2010@tom.com okusamanosusume From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:23:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060701132333.7DD6B1969800@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Note that there is a possible time/space tradeoff here: RenderBlock::computeHorizontalPositionsForLine() knows the offsetForAlignRight() when it sets the InlineTextBox's width, so an alternative fix would involve adding this offset as an InlineTextBox member and having computeHorizontalPositionsForLine() set it. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:33:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repl?= =?iso-8859-1?q?ace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133337.288C11969A3C@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:33:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repl?= =?iso-8859-1?q?ace_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133337.F27C61969A3B@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 06:34:45 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_denied=3A_=5BBug_9674=5D_?= =?iso-8859-1?q?REGRESSION_=28r15075=29=3A_Blank_or_incomplete_page?= =?iso-8859-1?q?s_on_digg=2Ecom=A0_=3A__=5BAttachment_9118=5D_Repla?= =?iso-8859-1?q?ce_the_requestingScript_state_bit_with_a_count?= Message-ID: <20060701133445.BC7ED1969A9F@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9118: Replace the requestingScript state bit with a count http://bugzilla.opendarwin.org/attachment.cgi?id=9118&action=edit ------- Additional Comments from Darin Adler Another fix is to save, set, and then restore the bit rather than setting and clearing it. I think that would be better. Is there any reason that wouldn't work? From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:06:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140631.E1FBC196B597@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com See my previous comment as to why I think the bit doesn't belong in State. Of course, if you prefer it that way, I can go all the way and put it back into State. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:06:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140631.83FAC196B59D@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com See my previous comment as to why I think the bit doesn't belong in State. Of course, if you prefer it that way, I can go all the way and put it back into State. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_cancelled=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140949.E2B7A196B741@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140950.51C25196B744@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_cancelled=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9120=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140949.53028196B745@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has cancelled opendarwin.org@mitzpettel.com's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9120: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9120&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 07:09:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9674?= =?iso-8859-1?q?=5D_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_?= =?iso-8859-1?q?pages_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_S?= =?iso-8859-1?q?ave_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701140950.2091C196B74C@sampson.opendarwin.org> opendarwin.org@mitzpettel.com has asked Darin Adler for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from opendarwin.org@mitzpettel.com Added a missing test subresource. Please see previous comments. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:38:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_Save?= =?iso-8859-1?q?_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701213824.CF871197BC64@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from Darin Adler I think of the m_state as a more-or-less arbitrary set of bits, so the argument about this bit being global state and hence "not part of state" doesn't seem very compelling to me. Your argument about a byte on the stack vs. a count in the tokenizer object is actually a pretty compelling one. It didn't occur to me that the stack cost can be paid over and over again as you recurse and there is only one tokenizer. I think that either the original fix or this one is fine. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:38:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9674=5D?= =?iso-8859-1?q?_REGRESSION_=28r15075=29=3A_Blank_or_incomplete_pag?= =?iso-8859-1?q?es_on_digg=2Ecom=A0_=3A__=5BAttachment_9121=5D_Save?= =?iso-8859-1?q?_and_restore_the_m=5FrequestingScript_flag?= Message-ID: <20060701213824.C9B01197BC68@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9674: REGRESSION (r15075): Blank or incomplete pages on digg.com  http://bugzilla.opendarwin.org/show_bug.cgi?id=9674 Attachment 9121: Save and restore the m_requestingScript flag http://bugzilla.opendarwin.org/attachment.cgi?id=9121&action=edit ------- Additional Comments from Darin Adler I think of the m_state as a more-or-less arbitrary set of bits, so the argument about this bit being global state and hence "not part of state" doesn't seem very compelling to me. Your argument about a byte on the stack vs. a count in the tokenizer object is actually a pretty compelling one. It didn't occur to me that the stack cost can be paid over and over again as you recurse and there is only one tokenizer. I think that either the original fix or this one is fine. r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:49:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060701214948.00224197BF7A@sampson.opendarwin.org> Nicholas Shanks has asked Alexey Proskuryakov for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit ------- Additional Comments from Nicholas Shanks This patch doesn't have layout tests yet, and only does "odd" and "even" as I've not looked up how to convert the QString methods KHTML used for an+b yet. Posting here so that people who have a faster computer can compile it and tell me if it works. :-) From bugzilla-request-daemon at opendarwin.org Sat Jul 1 14:49:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060701214948.F22FE197BF79@sampson.opendarwin.org> Nicholas Shanks has asked Alexey Proskuryakov for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit ------- Additional Comments from Nicholas Shanks This patch doesn't have layout tests yet, and only does "odd" and "even" as I've not looked up how to convert the QString methods KHTML used for an+b yet. Posting here so that people who have a faster computer can compile it and tell me if it works. :-) From bugzilla-request-daemon at opendarwin.org Sat Jul 1 15:11:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060701221138.8903F197D433@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Björn Graf (boki) The workaround checks the arguments for infinity and only calls fmod when the divisor is not infinite. Otherwise it returns the dividend. From bugzilla-request-daemon at opendarwin.org Sat Jul 1 15:13:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060701221303.F11A1197D4F5@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis The patch fixes the bug for me. I can do testcase(s) if the code gets okayed in the first place :-) Cheers, Rob. From replybns at yahoo.com Sat Jul 1 20:48:52 2006 From: replybns at yahoo.com (slim2uhealthcare@yahoo.com) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=BC=CD=C1=B6=D2=C7=C3_=BC=CD=C1?= =?iso-8859-1?q?=B6=D2=C7=C3_=BC=CD=C1=B6=D2=C7=C3_=C3=D1=BA=C3=CD?= =?iso-8859-1?q?=A7=BC=C5=C5=D1=BE=B7=EC_=E4=C1=E8=A1=C5=D1=BA=C1?= =?iso-8859-1?q?=D2=CD=E9=C7=B9=CD=D5=A1?= Message-ID: <20060702034857.8D39C1988966@sampson.opendarwin.org> An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/49d9a914/attachment.html From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:35:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053528.555E3198D151@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit ------- Additional Comments from Timothy Hatcher r=me From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053603.6CE0F198D21A@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:36:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9684] [GDK] multiple little fixes and a few new things for Templinkstubs : [Attachment 9132] basic patch Message-ID: <20060702053603.BDF7F198D265@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9684: [GDK] multiple little fixes and a few new things for Templinkstubs http://bugzilla.opendarwin.org/show_bug.cgi?id=9684 Attachment 9132: basic patch http://bugzilla.opendarwin.org/attachment.cgi?id=9132&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 22:48:07 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702054807.CF846198E240@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:04:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702060415.A52971990402@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:29:08 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702062908.EBCA619916E0@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702065748.1D6C21992505@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702065748.A8ABF19935CF@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit From bugzilla-request-daemon at opendarwin.org Sat Jul 1 23:57:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9135] Implement as described Message-ID: <20060702065748.9612319935CE@sampson.opendarwin.org> Mark Rowe (bdash) has cancelled Mark Rowe (bdash) 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9135: Implement as described http://bugzilla.opendarwin.org/attachment.cgi?id=9135&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 00:05:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702070528.C51AD19935D3@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit ------- Additional Comments from Timothy Hatcher This looks good now. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 00:05:28 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9689] Nightly builds should warn a user about potential problems when using "Safari extensions" : [Attachment 9139] Update to explicitly check that bundle is in known extension paths Message-ID: <20060702070528.BE20F19935D1@sampson.opendarwin.org> Timothy Hatcher has granted Timothy Hatcher 's request for review: Bug 9689: Nightly builds should warn a user about potential problems when using "Safari extensions" http://bugzilla.opendarwin.org/show_bug.cgi?id=9689 Attachment 9139: Update to explicitly check that bundle is in known extension paths http://bugzilla.opendarwin.org/attachment.cgi?id=9139&action=edit ------- Additional Comments from Timothy Hatcher This looks good now. From bolt166 at og.plala.or.jp Sun Jul 2 03:52:49 2006 From: bolt166 at og.plala.or.jp (‹e’r —Žq) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] =?iso-8859-1?q?=82=E6=82=EB=82=B5=82=AD=82=A8?= =?iso-8859-1?q?=8A=E8=82=A2=82=B5=82=DC=82=B7?= Message-ID: <06019375.986178.0491@acclimate-anb85.aol.com> ‚·„«‚ׄ«‚Ä„«‚ª„«–³„«—¿„«I„«Š®„«‘S„«–³„«—¿„«ƒT„«ƒC„«ƒg„« „ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„®„ª„® @@@ˆú—Œn—«‚Ì“o˜^‚ª‘½‚­‚Ä‘ål‹C‚ÌŠ®‘S–³—¿ƒTƒCƒg @@@–Ú“I‚ªˆê‚¾‚©‚瑦ƒAƒ|A‘¦ƒnƒ‚ª“–‚½‚è‘Oô@ @@šŠ„‚èØ‚Á‚½ŒðÛšlȂƂ̔閧‚ÌŒðÛš‚R‚oŠó–]š @@@@@@—lX‚È—«‚ª“o˜^‚µ‚Ä‚¨‚è‚Ü‚·I Š®‘S–³—¿“üŒûË@http://5596.cc?seadx „¬„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš „«ƒŒƒfƒBƒRƒ~ƒbƒNŽ‘½”ŒfÚ’†š—«“o˜^”‹}㸒†II„« š„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„® Š®‘S–³—¿“üŒûË@http://5596.cc?seadx @@@@@@@@Ÿs—«“o˜^ˆê•”‚²Ð‰îtŸ ™-----™„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ„Ÿ™-----™ @@–¼‘OFˆŸ”ü@@@@E‹ÆF‚n‚k@@@ƒXƒ^ƒCƒ‹F‹“û @@”N—îF‚Q‚SÎ@@@Šó–]F”é–§@@@ƒ^ƒCƒvF‚©‚í‚¢‚¢Œn ™„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš ‚o‚qF–é‚É‚È‚é‚ƃ€ƒ‰ƒ€ƒ‰‚µ‚Ä‚­‚鎖‚Á‚Ä‚ ‚è‚Ü‚¹‚ñ‚©HHH @@@ @@@Ž„‚Í¡‚»‚¤‚Å‚·c(;_;)‘ŠŽè‚ª‚¢‚È‚¢‚Ì‚Å—­‚Ü‚Á‚Ä‚Ü‚·c @@@’N‚©‘ŠŽè‚µ‚Ä‚­‚ê‚é‚©‚ÈHHHƒAƒhƒŒƒXŒðŠ·AŽÊƒŒðŠ· @@@o—ˆ‚Ü‚·Bƒ[ƒ‹‘Ò‚Á‚Ä‚Ü‚·B @@@@@ @@@Š®‘S–³—¿“üŒûË@http://5596.cc?seadx ™„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ª„ªš@@ @@@@@@ From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:09:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702120917.498D319A0B5A@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:11:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702121100.EB62619A0BD3@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:11:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9654] Refresh Loop when accessing feed URLs : [Attachment 9145] Don't claim to handle feed:// URLs in WebKit.app Message-ID: <20060702121101.039B619A0BD5@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9654: Refresh Loop when accessing feed URLs http://bugzilla.opendarwin.org/show_bug.cgi?id=9654 Attachment 9145: Don't claim to handle feed:// URLs in WebKit.app http://bugzilla.opendarwin.org/attachment.cgi?id=9145&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:49:51 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702124951.F0B8119A1AFB@sampson.opendarwin.org> Mark Rowe (bdash) has asked for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:56:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702125623.3F6D119A1C34@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 05:56:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9692] Warning about Safari extensions on every launch is obnoxious : [Attachment 9146] Only display the warning if WebKit did not exit cleanly on it's last invocation Message-ID: <20060702125623.DECA819A1C30@sampson.opendarwin.org> Alexey Proskuryakov has granted Alexey Proskuryakov 's request for review: Bug 9692: Warning about Safari extensions on every launch is obnoxious http://bugzilla.opendarwin.org/show_bug.cgi?id=9692 Attachment 9146: Only display the warning if WebKit did not exit cleanly on it's last invocation http://bugzilla.opendarwin.org/attachment.cgi?id=9146&action=edit ------- Additional Comments from Alexey Proskuryakov r=me From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:52:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702165222.103D819AA7D8@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:52:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9690] REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html : [Attachment 9138] patch Message-ID: <20060702165222.DA01119AAA14@sampson.opendarwin.org> Adele Peterson has granted Adele Peterson 's request for review: Bug 9690: REGRESSION: Liveconnect with Java test fails at http://www-sor.inria.fr/~dedieu/notes/liveconnect/simple_example.html http://bugzilla.opendarwin.org/show_bug.cgi?id=9690 Attachment 9138: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9138&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:58:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060702165819.E888D19AAA17@sampson.opendarwin.org> Alexey Proskuryakov has cancelled Nicholas Shanks 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 09:58:19 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9127] Updated patch (only supports odd and even) Message-ID: <20060702165819.EC82919AAA18@sampson.opendarwin.org> Alexey Proskuryakov has cancelled Nicholas Shanks 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9127: Updated patch (only supports odd and even) http://bugzilla.opendarwin.org/attachment.cgi?id=9127&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 10:58:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702175843.D2E6019ACEF1@sampson.opendarwin.org> Justin Haygood has asked for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060702200922.6627C19B40CB@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9129] First attempt Message-ID: <20060702200922.7277019B40CF@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9129: First attempt http://bugzilla.opendarwin.org/attachment.cgi?id=9129&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:09:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060702200922.1C15519B40D7@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob. From fmihm at snip.net Sun Jul 2 13:19:38 2006 From: fmihm at snip.net (fmihm@snip.net) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Returned mail: Data format error Message-ID: <20060702201951.8238219B4406@sampson.opendarwin.org> -------------- next part -------------- A non-text attachment was scrubbed... Name: yfkw.zip Type: application/octet-stream Size: 41202 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060702/4b0ea912/yfkw.obj From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:34:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060702203411.4CE6D19B4B75@sampson.opendarwin.org> Nicholas Shanks has asked Dave Hyatt for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit ------- Additional Comments from Nicholas Shanks Does not attempt to support (an+b) yet, nor have functional implementations of nth-last-* as we are awaiting a decision from hyatt on how to implement :last-child and related pseudo classes. an+b support will come in another patch to be posted to this bug later in the week. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:34:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060702203411.61B3819B4B7B@sampson.opendarwin.org> Nicholas Shanks has asked Dave Hyatt for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit ------- Additional Comments from Nicholas Shanks Does not attempt to support (an+b) yet, nor have functional implementations of nth-last-* as we are awaiting a decision from hyatt on how to implement :last-child and related pseudo classes. an+b support will come in another patch to be posted to this bug later in the week. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702204123.8CB5F19B4E7D@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review cancelled: [Bug 9688] Fix up value conversions in JS API : [Attachment 9133] patch Message-ID: <20060702204123.C22AF19B54AF@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9133: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9133&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:41:23 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060702204123.CBFD119B54B0@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 13:55:40 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060702205540.D3D7419B54B1@sampson.opendarwin.org> David Carson has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from David Carson Added support for HSL and HSLA colors. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 15:15:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702221555.E488D19B8D04@sampson.opendarwin.org> Michael Emmel has asked for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:22:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702232201.6FEFA19BB94C@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit ------- Additional Comments from Geoffrey Garen Our style guidlines also call for splitting lines like this into two: + if (!stringIdentifierDictionary) stringIdentifierDictionary = new HashMap< const char *, PrivateIdentifier *>(); The patch looks correct overall. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:22:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9148] Make NPRuntime use HashMap Message-ID: <20060702232201.6FD5D19BB953@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9148: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9148&action=edit ------- Additional Comments from Geoffrey Garen Our style guidlines also call for splitting lines like this into two: + if (!stringIdentifierDictionary) stringIdentifierDictionary = new HashMap< const char *, PrivateIdentifier *>(); The patch looks correct overall. From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:24:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9617] wx port compile fixes : [Attachment 9116] patch, with ImageDocument refactored to separate out the Objective-C Message-ID: <20060702232429.16EEC19BB9FF@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9116: patch, with ImageDocument refactored to separate out the Objective-C http://bugzilla.opendarwin.org/attachment.cgi?id=9116&action=edit ------- Additional Comments from Geoffrey Garen r- for missing files From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:24:29 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review denied: [Bug 9617] wx port compile fixes : [Attachment 9116] patch, with ImageDocument refactored to separate out the Objective-C Message-ID: <20060702232429.719EF19BBC28@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9617: wx port compile fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9617 Attachment 9116: patch, with ImageDocument refactored to separate out the Objective-C http://bugzilla.opendarwin.org/attachment.cgi?id=9116&action=edit ------- Additional Comments from Geoffrey Garen r- for missing files From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:30:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702233054.8853319BBC2A@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit ------- Additional Comments from Geoffrey Garen Looks fine to me. + if (!jobs->isEmpty()){ + m_downloadTimer.startOneShot(pollTimeSeconds); + } For future reference, our style guidelines call for single-line if statements to be written without curly braces: From bugzilla-request-daemon at opendarwin.org Sun Jul 2 16:30:54 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review granted: [Bug 9703] Patch to make linux port execute : [Attachment 9160] Patch to allow linux port to execute Message-ID: <20060702233054.B46DD19BBC30@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9703: Patch to make linux port execute http://bugzilla.opendarwin.org/show_bug.cgi?id=9703 Attachment 9160: Patch to allow linux port to execute http://bugzilla.opendarwin.org/attachment.cgi?id=9160&action=edit ------- Additional Comments from Geoffrey Garen Looks fine to me. + if (!jobs->isEmpty()){ + m_downloadTimer.startOneShot(pollTimeSeconds); + } For future reference, our style guidelines call for single-line if statements to be written without curly braces: From bugzilla-request-daemon at opendarwin.org Sun Jul 2 18:49:22 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] review requested: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703014922.AB89F19C0382@sampson.opendarwin.org> Justin Haygood has asked for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From yuh-jiun99549sherif at peugeot-club.org Sun Jul 2 21:02:13 2006 From: yuh-jiun99549sherif at peugeot-club.org (=?iso-8859-2?B?0S7ILg==?=) Date: Tue Oct 9 17:56:32 2007 Subject: [webkit-reviews] Fw[]: Beware of imitators, this is the original men's phermone Message-ID: <41c901c69e55$6256726c$4a526125@peugeot-club.org> Remember how you felt when your dream girl shot you down? Well now you never have to feel that way again! Pheromones have been proven to work, and are guaranted to increase your attractiveness to women of all ages. Just look at some of the testimonials we have received back from 100% satisfied repeat customers! : "I've always had a problem approaching girls. They would just walk past me like I didn't exist. I sometimes felt like they purposely would not give me any attention just because they were snobby and stuck up. Now, when I use Ultra Allure Pheromones, it's alot easier to approach girls because THEY are usually the ones that will smile at me first or make eye contact." Robert K, Boise Idaho "I saw you guys offered a moneyback guarantee, so I though I would give it a go(I had nothing to lose). Well how glad am I that I did! My first night out with a little Ultra Allure on me I had 4 different girls ask me what I was wearing and what I was doing later(I met up with the hottest of the 4 ;) ) Now I don't even leave the house without throwing on a few dabs of Ultra Allure- its my (not so) secret weapon! I can honestly say this product truly works, women are really drawn to you once they catch a little bit of the scent." Brad M. Kentucky We receive dozens of emails daily just like these ones! Don't be left out! Pheromones have been studied extensively and profiled on such media outlets as CNN, Oprah Winfrey show, ABC, MSNBC, FOXNEWS, and magazines such as MAXIM, FHM and PLAYBOY! Visit our website now to check out the huge discount sale going on right now! Hurry though as discount specials will be discontinued within the next few days! Remove you e-mail -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/c779a427/attachment.html From conradcurran at cihost.com Sun Jul 2 20:41:05 2006 From: conradcurran at cihost.com (tam naquin) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Re: Your Luxury Message-ID: <00df01c69e51$da617f00$a068a989@jcwvqzky> TOP BRANDS - LOW LOW PRICES Jewelry * Handbags * Pens * Watches * Neckties * Clutches * Wallets Leather, silk and white gold sound good? Visit our site for real photos. Everything comes with a certificate, tags and all the extras, plus a warranty. http://reconnectrecords.com/luxury/ Cali yuga moor blackbird medley cloth self-checking swift-posting guide flag well-sorted world-taming marsh spike grass good fellow choir rail store clothes sailor suit leg art pince-nez thunder-tipped sea pig veil-hid upsy-freesy spatulate-leaved conico-ovate doubting mania globe ranunculus good morning single-line all-inclusiveness dowel bit -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/107da8c7/attachment.html From bugzilla-request-daemon at opendarwin.org Sun Jul 2 23:10:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703061050.28D8E19C982A@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit From bugzilla-request-daemon at opendarwin.org Sun Jul 2 23:48:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703064801.AEDCB19CA575@sampson.opendarwin.org> Timothy Hatcher has asked for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 00:49:31 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703074931.002E419CCB4F@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit ------- Additional Comments from Eric Seidel Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 00:49:32 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9628] [Drosera] Split Views acting oddly : [Attachment 9164] Implements the expected behavior Message-ID: <20060703074932.0D54419CCB51@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9628: [Drosera] Split Views acting oddly http://bugzilla.opendarwin.org/show_bug.cgi?id=9628 Attachment 9164: Implements the expected behavior http://bugzilla.opendarwin.org/attachment.cgi?id=9164&action=edit ------- Additional Comments from Eric Seidel Looks fine. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 01:08:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703080846.B857319CE0D6@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit ------- Additional Comments from Eric Seidel I think it would be cleaner to have a line ending array, or regex. Since you seem to be using the same copy/paste list all over the place. I guess the list of line endings isn't ever going to change though, so it's not a huge deal. Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 01:08:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9631] [Drosera] Add "Step Over" and "Step Out" : [Attachment 9163] Implements step over and step out Message-ID: <20060703080846.9847A19CE0DE@sampson.opendarwin.org> Eric Seidel has granted Eric Seidel 's request for review: Bug 9631: [Drosera] Add "Step Over" and "Step Out" http://bugzilla.opendarwin.org/show_bug.cgi?id=9631 Attachment 9163: Implements step over and step out http://bugzilla.opendarwin.org/attachment.cgi?id=9163&action=edit ------- Additional Comments from Eric Seidel I think it would be cleaner to have a line ending array, or regex. Since you seem to be using the same copy/paste list all over the place. I guess the list of line endings isn't ever going to change though, so it's not a huge deal. Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060703134516.74A3F19DC536@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:16 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9151] Improved patch Message-ID: <20060703134516.873F919DC538@sampson.opendarwin.org> Rob Buis has cancelled Rob Buis 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9151: Improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9151&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 06:45:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060703134517.40ADC19DC53A@sampson.opendarwin.org> Rob Buis has asked for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Rob Buis I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:33:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703173353.21F8719E4F90@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:33:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060703173353.DC91219E4F8A@sampson.opendarwin.org> Geoffrey Garen has granted Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 10:54:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060703175414.DEF9119E556D@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 12:05:55 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060703190555.1072219E8C56@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Updates since Patch v1 not covered in Comment #12: - Implemented IDL function overloading by introducing the "Optional" extended attribute for parameters.  Updated the GenerateImplementation() subroutine in CodeGeneratorJS.pm to incrementally check the argument list count as it processes optional parameters to determine when the argument list is complete.  Extracted the GenerateImplementationFunctionCall() subroutine.  Note that the "Optional" attribute only has to be listed on one argument since all others following it are assumed to be optional as well. - Added ChangeLog entries. From beeackerman at randomhouse.com Mon Jul 3 11:42:57 2006 From: beeackerman at randomhouse.com (angus gonzalez) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Luxury: Fendi Message-ID: <00a501c69ecf$ac228480$1d7136b0@blzc> TOP BRANDS - LOW LOW PRICES Jewelry * Handbags * Pens * Watches * Neckties * Clutches * Wallets Leather, silk and white gold sound good? Visit our site for real photos. Everything comes with a certificate, tags and all the extras, plus a warranty. http://santacruzers.com/luxury/ lead glass stage direction will-with-the-wisp silk cotton twice-sensed garment presser white-winged wringing-wet deformation ellipsoid slime mold honey weasel flat-floored Charlier shoe pear haw pump-back method fork forger mid-sea air bridge pseudo deputy employer-owned bear oak tidy-kept Muscovy company process butter wound rocket well-patronized development theory -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/8631c727/attachment.html From bugzilla-request-daemon at opendarwin.org Mon Jul 3 14:33:38 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_requested=3A_=5BBug_9717?= =?iso-8859-1?q?=5D_Replace_IDL=A0ConvertUndefinedToTrue_parameter_?= =?iso-8859-1?q?attribute_with_Optional_attribute_=3A__=5BAttachmen?= =?iso-8859-1?q?t_9175=5D_Patch_v1?= Message-ID: <20060703213338.8F57C19EF39D@sampson.opendarwin.org> David Kilzer (ddkilzer) has asked for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from David Kilzer (ddkilzer) Proposed patch. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:07:03 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703220703.DBE6C19F0E88@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:51:01 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703225101.0749E19F1AB3@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit ------- Additional Comments from Geoffrey Garen I guess I have to r- this over the license issue. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 15:51:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9697] parseInt results may be inaccurate for numbers greater than 2^53 : [Attachment 9178] Adds checking and reparsing for numbers that may overflow the double range Message-ID: <20060703225102.0EF1219F1AB5@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9697: parseInt results may be inaccurate for numbers greater than 2^53 http://bugzilla.opendarwin.org/show_bug.cgi?id=9697 Attachment 9178: Adds checking and reparsing for numbers that may overflow the double range http://bugzilla.opendarwin.org/attachment.cgi?id=9178&action=edit ------- Additional Comments from Geoffrey Garen I guess I have to r- this over the license issue. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 17:48:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060704004837.633D219F5B31@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit ------- Additional Comments from Darin Adler I think that _web_isConditionalRequest would be more efficient if it called valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its way to be slow! Also, why not return BOOL rather than bool since it's a Objective-C method? Otherwise, looks fine. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 17:48:37 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9171] proposed fix Message-ID: <20060704004837.5D47019F5B37@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9171: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9171&action=edit ------- Additional Comments from Darin Adler I think that _web_isConditionalRequest would be more efficient if it called valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its way to be slow! Also, why not return BOOL rather than bool since it's a Objective-C method? Otherwise, looks fine. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:02:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060704010215.0FECC19F6F5B@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from Darin Adler The reason getNumber returns a boolean is so that you don't have to make a separate call to isNumber. And we don't use the function call syntax for type casts -- instead we use C++ cast syntax. So this: + if (value->isNumber()) { + double lengthValue; + value->getNumber(lengthValue); + if (lengthValue < 0.0) + return; + if (lengthValue > double(UINT_MAX)) + newLength = UINT_MAX; + else + newLength = unsigned(lengthValue); + } should be: double lengthValue; if (value->getNumber(lengthValue)) { if (lengthValue < 0.0) return; if (lengthValue > static_cast(UINT_MAX)) newLength = UINT_MAX; else newLength = static_cast(lengthValue); } I'd like to see tests that cover a few more of the branches, for example setting length to infinity and NaN. The code makes infinite try to set it to UINT_MAX, NaN sets it to 0, although -1 doesn't change the existing length. Is that really the behavior we want? If so, then lets make sure tests exercise those cases and perhaps try them in other browsers. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:02:14 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9179] Implement select.options.add() method : [Attachment 9174] Patch v2 Message-ID: <20060704010214.0AD1D19F6F5A@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9179: Implement select.options.add() method http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Attachment 9174: Patch v2 http://bugzilla.opendarwin.org/attachment.cgi?id=9174&action=edit ------- Additional Comments from Darin Adler The reason getNumber returns a boolean is so that you don't have to make a separate call to isNumber. And we don't use the function call syntax for type casts -- instead we use C++ cast syntax. So this: + if (value->isNumber()) { + double lengthValue; + value->getNumber(lengthValue); + if (lengthValue < 0.0) + return; + if (lengthValue > double(UINT_MAX)) + newLength = UINT_MAX; + else + newLength = unsigned(lengthValue); + } should be: double lengthValue; if (value->getNumber(lengthValue)) { if (lengthValue < 0.0) return; if (lengthValue > static_cast(UINT_MAX)) newLength = UINT_MAX; else newLength = static_cast(lengthValue); } I'd like to see tests that cover a few more of the branches, for example setting length to infinity and NaN. The code makes infinite try to set it to UINT_MAX, NaN sets it to 0, although -1 doesn't change the existing length. Is that really the behavior we want? If so, then lets make sure tests exercise those cases and perhaps try them in other browsers. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:03:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9717=5D?= =?iso-8859-1?q?_Replace_IDL=A0ConvertUndefinedToTrue_parameter_att?= =?iso-8859-1?q?ribute_with_Optional_attribute_=3A__=5BAttachment_9?= =?iso-8859-1?q?175=5D_Patch_v1?= Message-ID: <20060704010302.413A219F6FC7@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from Darin Adler Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:03:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-8859-1?q?review_granted=3A_=5BBug_9717=5D?= =?iso-8859-1?q?_Replace_IDL=A0ConvertUndefinedToTrue_parameter_att?= =?iso-8859-1?q?ribute_with_Optional_attribute_=3A__=5BAttachment_9?= =?iso-8859-1?q?175=5D_Patch_v1?= Message-ID: <20060704010302.8E2BE19F6FCD@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9717: Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute http://bugzilla.opendarwin.org/show_bug.cgi?id=9717 Attachment 9175: Patch v1 http://bugzilla.opendarwin.org/attachment.cgi?id=9175&action=edit ------- Additional Comments from Darin Adler Looks good. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:05:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060704010548.8E53119F70EA@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Darin Adler I'd like to see this workaround in MathExtras.h rather than inline in the JavaScript-specific files. We just need a name for the fmod with the workaround, and then we can use that. It can be an inline that expands to a call to fmod on platforms other than Win32. Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs. I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the whole check needed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:05:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9128] MS CRT fmod bug workaround where x % (1/0) = NaN, not x. Message-ID: <20060704010548.CE52019F70F0@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9128: MS CRT fmod bug workaround where x % (1/0) = NaN, not x. http://bugzilla.opendarwin.org/attachment.cgi?id=9128&action=edit ------- Additional Comments from Darin Adler I'd like to see this workaround in MathExtras.h rather than inline in the JavaScript-specific files. We just need a name for the fmod with the workaround, and then we can use that. It can be an inline that expands to a call to fmod on platforms other than Win32. Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs. I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the whole check needed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:13:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9093] Custom implementations of time functions Message-ID: <20060704011300.D71BD19F78B0@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9093: Custom implementations of time functions http://bugzilla.opendarwin.org/attachment.cgi?id=9093&action=edit ------- Additional Comments from Darin Adler This seems like too much platform-specific code to put into this file. I suggest putting it somewhere in WTF instead, maybe a file named . Maybe we can move the Mac-specific data locale code there too. + //if (secs < time_tMin || secs > time_tMax) { We don't check in commented-out code. While the reformatting is fine, ideally I'd like to see that in a separate patch rather than in the same patch as a substantive change to the file. Maybe we can get that in first. I think it's not so great to have a KJS::tm on the Windows platform and a global tm on all the others. Maybe we can use a typedef instead? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:13:00 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9651] MSVCRT time functions are too strict : [Attachment 9093] Custom implementations of time functions Message-ID: <20060704011300.83F8019F78BF@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9651: MSVCRT time functions are too strict http://bugzilla.opendarwin.org/show_bug.cgi?id=9651 Attachment 9093: Custom implementations of time functions http://bugzilla.opendarwin.org/attachment.cgi?id=9093&action=edit ------- Additional Comments from Darin Adler This seems like too much platform-specific code to put into this file. I suggest putting it somewhere in WTF instead, maybe a file named . Maybe we can move the Mac-specific data locale code there too. + //if (secs < time_tMin || secs > time_tMax) { We don't check in commented-out code. While the reformatting is fine, ideally I'd like to see that in a separate patch rather than in the same patch as a substantive change to the file. Maybe we can get that in first. I think it's not so great to have a KJS::tm on the Windows platform and a global tm on all the others. Maybe we can use a typedef instead? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:20:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060704012036.4410519F7B2E@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from Darin Adler Looks pretty good. I have some relatively unimportant comments, but I think I'm going to review- so you can address at least some of them. Some minor formatting mistakes: + ValueList *args = value->function->args; + Value *v = args->current(); Please put the * next to tyhe type. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; Need spaces around all the operators, including the "/" and we prefer 360.0 to 360. for double constants. + for (int i = 1; i < 3; i++) + { Please put the { on the same line as the for statement. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; What does the line above to if fValue does not fit in an int? Need to check if it's in range? + colorValues[i] = v->fValue/100.; // needs to be value between 0 and 1.0 This code says it "needs to be" -- what checks that the number is between 0 and 100? - if (!validUnit(v, FInteger|FPercent, true)) Spaces around operators like "|" too. In makeRGBAfromHSLA, we'd normally capitalize the f. + bool parseColorParameters(Value* value, int* colorValues, bool parseAlpha); + bool parseHSLParameters(Value* value, float* colorValues, bool parseAlpha); We'd normally leave out the word "value" in these declarations. +float calcHue(float temp1, float temp2, float hueVal) Is there a better name than temp1/temp2 for these? If not, can you refer to place you found the algorithm? +RGBA32 makeRGBAfromHSLA(float h, float s, float l, float a) Why the use of float here, given the use of double in the code that's passing things in and the use of double-precision constants like "1.0"? This code is going to do some conversion from float to double and back that we might be able to avoid. The HSV code in this file references the URL of the place the color algorithm came from. Can you do the same with this new code? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:20:36 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9155] patch, test cases and change logs Message-ID: <20060704012036.BB27F19F7B55@sampson.opendarwin.org> Darin Adler has denied Darin Adler 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9155: patch, test cases and change logs http://bugzilla.opendarwin.org/attachment.cgi?id=9155&action=edit ------- Additional Comments from Darin Adler Looks pretty good. I have some relatively unimportant comments, but I think I'm going to review- so you can address at least some of them. Some minor formatting mistakes: + ValueList *args = value->function->args; + Value *v = args->current(); Please put the * next to tyhe type. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; Need spaces around all the operators, including the "/" and we prefer 360.0 to 360. for double constants. + for (int i = 1; i < 3; i++) + { Please put the { on the same line as the for statement. + colorValues[0] = ((((int)(v->fValue) % 360) + 360) % 360)/360.; What does the line above to if fValue does not fit in an int? Need to check if it's in range? + colorValues[i] = v->fValue/100.; // needs to be value between 0 and 1.0 This code says it "needs to be" -- what checks that the number is between 0 and 100? - if (!validUnit(v, FInteger|FPercent, true)) Spaces around operators like "|" too. In makeRGBAfromHSLA, we'd normally capitalize the f. + bool parseColorParameters(Value* value, int* colorValues, bool parseAlpha); + bool parseHSLParameters(Value* value, float* colorValues, bool parseAlpha); We'd normally leave out the word "value" in these declarations. +float calcHue(float temp1, float temp2, float hueVal) Is there a better name than temp1/temp2 for these? If not, can you refer to place you found the algorithm? +RGBA32 makeRGBAfromHSLA(float h, float s, float l, float a) Why the use of float here, given the use of double in the code that's passing things in and the use of double-precision constants like "1.0"? This code is going to do some conversion from float to double and back that we might be able to avoid. The HSV code in this file references the URL of the place the color algorithm came from. Can you do the same with this new code? From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060704012446.2EFD519F7D01@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit ------- Additional Comments from Darin Adler + if (completion.complType() == Throw) { + if (exception) + *exception = completion.value(); + return NULL; + } else if (completion.value()) + return toRef(completion.value()); + else // happens, for example, when the only statement is an empty (';') statement + return toRef(jsUndefined()); I find it more readable to omit the else after return in cases like this. r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 18:24:46 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9688] Fix up value conversions in JS API : [Attachment 9154] patch including exception handling Message-ID: <20060704012446.3CFEB19F7D03@sampson.opendarwin.org> Darin Adler has granted Darin Adler 's request for review: Bug 9688: Fix up value conversions in JS API http://bugzilla.opendarwin.org/show_bug.cgi?id=9688 Attachment 9154: patch including exception handling http://bugzilla.opendarwin.org/attachment.cgi?id=9154&action=edit ------- Additional Comments from Darin Adler + if (completion.complType() == Throw) { + if (exception) + *exception = completion.value(); + return NULL; + } else if (completion.value()) + return toRef(completion.value()); + else // happens, for example, when the only statement is an empty (';') statement + return toRef(jsUndefined()); I find it more readable to omit the else after return in cases like this. r=me From claimsnight at hotmail.com Mon Jul 3 18:53:32 2006 From: claimsnight at hotmail.com (claimsnight@hotmail.com) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] Very Important Message-ID: Dr.Lucas Tutu TEL: +27-73-442-5632 Fax: +27-11-507-5309 Email: tutu1@superdada.com Email: lucastutu@claimprocessingfiles.com I am Dr.Lukas Tutu, Director of Bid/Project Implementation South Africa 2010 Fifa world cup hosting committee , I apologized using this medium to reach you for a transaction/business of this magnitude. Be informed that I got your particulars from a member of the South Africa Export Promotion Council (SAEPC) who was at the Government delegation to your country during a trade exhibition. I have decided to seek a confidential co-operation with you in the execution of the deal described hereunder for the benefit of all parties and hope you will keep it confidential because of the nature of this transaction. you must be aware now that my country south africa won the bid to host the world cup by 2010,perior to this bid my committee was mandated to lobby the members of board of Federation International Football Association (FIFA) on selection of the country to host the world cup,the bidding was intensive but at the end we got the hosting right.My committee was given the sum of $29 million dollars to lobby the members of the FIFA ruling body to make sure that we win the hosting right. Considering the gain that comes with the hosting right,South Africa's economy will receive a massive direct boost from hosting the 2010 World Cup. Financial impact report for South Africa's World Cup bid committee shows that the 2010 World Cup will pump R21.3-billion into South Africa's economy,and creating an estimated 159000 new jobs. with the help the living legend of our time 86-year-old Nobel Peace Prize winner Dr.Nelson Mandela who made an emotive case for South Africa,we got the bid without spending all the money,i and my commitee members saw this as a God sent opportunity to secure our future and that of our family there for,l was mandated by other committee members to look for a way to move the remaining money to a safe place with the help of a foreigner who we can trust and is ready to assistus to move the funds considering the fact that we are still members of the bid/project commitee. we have in our possession the sum $21millon since we spent just $8million for lobbying. we are ready to give you 20% for all your assistance,me and my coleague will keep 80% lf you are willing,kindly reply to my letter and further directive will be given to you. Bearing in mind that confidentiality is of great essence so is time,i will await your response. I wait in anticipation of your fullest co-operation. Yours faithfully, Dr.Lucas Tutu TEL: +27-73-442-5632 Fax: +27-11-507-5309 Email: tutu1@superdada.com Email: lucastutu@claimprocessingfiles.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060704/4113ca2a/attachment.html From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:13:15 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704021315.C621C19F9D1D@sampson.opendarwin.org> David Carson has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:37:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704023753.8D62519FA8FC@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 19:53:59 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9698] Switch JSC Bindings from CFDictionary to HashMap : [Attachment 9162] Make NPRuntime use HashMap Message-ID: <20060704025359.8290F19FAF39@sampson.opendarwin.org> Geoffrey Garen has denied Geoffrey Garen 's request for review: Bug 9698: Switch JSC Bindings from CFDictionary to HashMap http://bugzilla.opendarwin.org/show_bug.cgi?id=9698 Attachment 9162: Make NPRuntime use HashMap http://bugzilla.opendarwin.org/attachment.cgi?id=9162&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 20:20:50 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704032050.83DBD19FC63E@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit ------- Additional Comments from Björn Graf (boki) This patch implements the necessary workaround in wtf/MathExtras.h. Defining fmod inside the KJS namespace would have worked, if all call sites where in the namespace explicitly. However, being implicitly declared in the namespace and defined in it via the using namespace KJS; directive requires the #define workaround. Needed to change isinf() because NaN is not finite. From thomas at paramed.biz Mon Jul 3 15:30:21 2006 From: thomas at paramed.biz (Robert) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] All products for your health! Message-ID: <000001c69f1a$2d9f0480$0100007f@bandos1> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 9212 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/f345d6bc/attachment.gif From necojp at citiz.net Mon Jul 3 20:53:56 2006 From: necojp at citiz.net (=?gb2312?B?g3SDjIOTg2hCQlMugrOCqILoguaC6A==?=) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?GyRCRUVPQyQvJEAkNSQkISMbKEIw?= =?iso-2022-jp?b?OTA1OTk2Njkx?= Message-ID: <20060704035356.8DD0F19FD083@sampson.opendarwin.org> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 1376 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 1376 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment-0001.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/jpeg Size: 3694 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment.jpe -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: image/gif Size: 573 bytes Desc: not available Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20060703/cc8bcc30/attachment-0002.gif From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:01:09 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040109.C02D019FE2AF@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040406.0925619FE341@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review cancelled: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9184] patch Message-ID: <20060704040406.CBDE319FE837@sampson.opendarwin.org> Geoffrey Garen has cancelled Geoffrey Garen 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9184: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9184&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:04:06 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704040406.D44CD19FE838@sampson.opendarwin.org> Geoffrey Garen has asked for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Geoffrey Garen psych From bugzilla-request-daemon at opendarwin.org Mon Jul 3 21:44:39 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704044439.4F61719FEEBD@sampson.opendarwin.org> Alexey Proskuryakov has asked for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Alexey Proskuryakov (In reply to comment #9) The WebKit side doesn't have a separate code path for XHR-initiated requests (which is probably good), but other requests we are making do not carry manually set conditional headers, so they are not affected. I am not sure if bypassing the cache for all conditional requests is necessarily the expected behavior for NSURLConnection. (In reply to comment #10) > (From update of attachment 9171 [edit]) > I think that _web_isConditionalRequest would be more efficient if it called > valueForHTTPHeaderField: instead of keyEnumerator. It's almost going out of its > way to be slow! I am not sure if this change makes it much faster (probably depends on the internal implementation of valueForHTTPHeaderField:), but the resulting code definitely looks better, thank you! > Also, why not return BOOL rather than bool since it's a Objective-C method? Oops, fixed. From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:02:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704060233.6A1C31A03198@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit ------- Additional Comments from Maciej Stachowiak otherwise r=me though From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:02:33 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9723] API: Add error reporting to JSCheckSyntax : [Attachment 9182] patch Message-ID: <20060704060233.3F5B51A03F26@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9723: API: Add error reporting to JSCheckSyntax http://bugzilla.opendarwin.org/show_bug.cgi?id=9723 Attachment 9182: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9182&action=edit ------- Additional Comments from Maciej Stachowiak otherwise r=me though From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:37:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704063747.CE11E1A04242@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:37:47 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9725] API: Add mechanism for parsing script into a function object : [Attachment 9185] patch Message-ID: <20060704063747.5E0F61A04246@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9725: API: Add mechanism for parsing script into a function object http://bugzilla.opendarwin.org/show_bug.cgi?id=9725 Attachment 9185: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9185&action=edit ------- Additional Comments from Maciej Stachowiak r=me From wuqui at yahoo.co.jp Mon Jul 3 23:45:28 2006 From: wuqui at yahoo.co.jp (=?iso-2022-jp?B?ZmVodQ==?=) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] =?iso-2022-jp?b?QUQbJEIhJzxjJCQ6IiRDJEYbKEI=?= =?iso-2022-jp?b?GyRCPychOSQiJGokXiQ3JD8kTRsoQg==?= Message-ID: <20060704064528.5AA091A04480@sampson.opendarwin.org> ???????????????? http://aiqihao.com/wildwild/ LALALALALALALALALA myxiaoxiaoniao@56.com LALALALALALALALALA From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:46:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704064649.417841A044DC@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:46:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 8210] Conditional XMLHttpRequest gets should pass 304 responses unchanged : [Attachment 9186] proposed fix Message-ID: <20060704064649.8CEB61A045F7@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 8210: Conditional XMLHttpRequest gets should pass 304 responses unchanged http://bugzilla.opendarwin.org/show_bug.cgi?id=8210 Attachment 9186: proposed fix http://bugzilla.opendarwin.org/attachment.cgi?id=9186&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:54:17 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704065417.EB1471A046F8@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit From bugzilla-request-daemon at opendarwin.org Mon Jul 3 23:54:18 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9678] fmod function of MS CRT returns NaN for x / Inf : [Attachment 9183] Workaround for MSVCRTs fmod function Message-ID: <20060704065418.070461A046FA@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9678: fmod function of MS CRT returns NaN for x / Inf http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 Attachment 9183: Workaround for MSVCRTs fmod function http://bugzilla.opendarwin.org/attachment.cgi?id=9183&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:07:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704070721.E46631A05C2E@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:07:21 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9181] Patch updated with some of the changes. Message-ID: <20060704070721.EC40C1A05C2F@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9181: Patch updated with some of the changes. http://bugzilla.opendarwin.org/attachment.cgi?id=9181&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:25:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060704072543.4B50E1A0609C@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:25:43 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 6248] CSS3: implement nth-* selectors : [Attachment 9153] Patch for nth-child and nth-of-type Message-ID: <20060704072543.035321A060A7@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 6248: CSS3: implement nth-* selectors http://bugzilla.opendarwin.org/show_bug.cgi?id=6248 Attachment 9153: Patch for nth-child and nth-of-type http://bugzilla.opendarwin.org/attachment.cgi?id=9153&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:29:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9507] Empty style spans created in applyInlineStyle : [Attachment 8921] patch Message-ID: <20060704072953.43B4B1A062AB@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9507: Empty style spans created in applyInlineStyle http://bugzilla.opendarwin.org/show_bug.cgi?id=9507 Attachment 8921: patch http://bugzilla.opendarwin.org/attachment.cgi?id=8921&action=edit ------- Additional Comments from Maciej Stachowiak Looks ok to me. This should get a ChangeLog entry and should have the test case included in the patch, with expected results. Include that and I'll r+ it. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 00:29:53 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9507] Empty style spans created in applyInlineStyle : [Attachment 8921] patch Message-ID: <20060704072953.060B81A062BC@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9507: Empty style spans created in applyInlineStyle http://bugzilla.opendarwin.org/show_bug.cgi?id=9507 Attachment 8921: patch http://bugzilla.opendarwin.org/attachment.cgi?id=8921&action=edit ------- Additional Comments from Maciej Stachowiak Looks ok to me. This should get a ChangeLog entry and should have the test case included in the patch, with expected results. Include that and I'll r+ it. From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:15:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060704081511.C0FBC1A0825A@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:15:11 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review granted: [Bug 9577] Fallback for not rendered if plug-in unavailable : [Attachment 9166] improved patch Message-ID: <20060704081511.927871A08257@sampson.opendarwin.org> Maciej Stachowiak has granted Maciej Stachowiak 's request for review: Bug 9577: Fallback for not rendered if plug-in unavailable http://bugzilla.opendarwin.org/show_bug.cgi?id=9577 Attachment 9166: improved patch http://bugzilla.opendarwin.org/attachment.cgi?id=9166&action=edit ------- Additional Comments from Maciej Stachowiak r=me From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:22:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060704082202.CDEC51A0866A@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from Maciej Stachowiak I agree with darin's comment about offsetForAlignRight. I think if there is extra space around in an existing bitfield, it is ok to use one of those bits. However, this should be justified with some kind of measurement of the perf impact. I think since m_reversed is checked first, then at least the LTR case should be optimized already, but perhaps in many RTL cases the other calculations can be skipped. r- so you can decide what to do here but I think the patch is good to go either way (assuming I am right that LTR should normally be unaffected). From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:22:02 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right : [Attachment 9119] Align RTL white-space:pre text with the right edge of the text box Message-ID: <20060704082202.F3FD71A0866C@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 9670: REGRESSION: RTL white-space:pre-wrap text is offset to the right http://bugzilla.opendarwin.org/show_bug.cgi?id=9670 Attachment 9119: Align RTL white-space:pre text with the right edge of the text box http://bugzilla.opendarwin.org/attachment.cgi?id=9119&action=edit ------- Additional Comments from Maciej Stachowiak I agree with darin's comment about offsetForAlignRight. I think if there is extra space around in an existing bitfield, it is ok to use one of those bits. However, this should be justified with some kind of measurement of the perf impact. I think since m_reversed is checked first, then at least the LTR case should be optimized already, but perhaps in many RTL cases the other calculations can be skipped. r- so you can decide what to do here but I think the patch is good to go either way (assuming I am right that LTR should normally be unaffected). From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:42:49 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9008] Patch with no reviewer set Message-ID: <20060704084249.149761A08D00@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9008: Patch with no reviewer set http://bugzilla.opendarwin.org/attachment.cgi?id=9008&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:42:48 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9008] Patch with no reviewer set Message-ID: <20060704084248.F21E61A08CFE@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9008: Patch with no reviewer set http://bugzilla.opendarwin.org/attachment.cgi?id=9008&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:43:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8194] Style spans with no style are not always deleted : [Attachment 9076] patch Message-ID: <20060704084310.0C7931A08D74@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 8194: Style spans with no style are not always deleted http://bugzilla.opendarwin.org/show_bug.cgi?id=8194 Attachment 9076: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9076&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 01:43:10 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review denied: [Bug 8194] Style spans with no style are not always deleted : [Attachment 9076] patch Message-ID: <20060704084310.B2DF51A08D69@sampson.opendarwin.org> Maciej Stachowiak has denied Maciej Stachowiak 's request for review: Bug 8194: Style spans with no style are not always deleted http://bugzilla.opendarwin.org/show_bug.cgi?id=8194 Attachment 9076: patch http://bugzilla.opendarwin.org/attachment.cgi?id=9076&action=edit From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:16:12 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 9506] Implement HSL, and HSLA colors in WebKit : [Attachment 9188] updated patch Message-ID: <20060704131612.BE8E91A15F6D@sampson.opendarwin.org> Sam Weinig has asked for review: Bug 9506: Implement HSL, and HSLA colors in WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=9506 Attachment 9188: updated patch http://bugzilla.opendarwin.org/attachment.cgi?id=9188&action=edit ------- Additional Comments from Sam Weinig updated patch From bugzilla-request-daemon at opendarwin.org Tue Jul 4 06:33:24 2006 From: bugzilla-request-daemon at opendarwin.org (bugzilla-request-daemon@opendarwin.org) Date: Tue Oct 9 17:56:33 2007 Subject: [webkit-reviews] review requested: [Bug 7802] devenv.com not available in VC++ Express installations : [Attachment 9189] Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set Message-ID: <20060704133324.B878A1A166E8@sampson.opendarwin.org> Björn Graf (boki) has asked for review: Bug 7802: devenv.com not available in VC++ Express installations http://bugzilla.opendarwin.org/show_bug.cgi?id=7802 Attachment 9189: Updated patch to default to $ProgramFiles if VCINSTALLDIR is not set http://bugzilla.opendarwin.org/attachment.cgi?id=9189&action=edit From bugzilla-request-daemon at opendarwin.o