From bugzilla-daemon at webkit.org Fri Aug 1 00:04:48 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 00:04:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20248] Assertion failure in FrameView::scheduleRelayoutOfSubtree (m_frame->view() == this) In-Reply-To: Message-ID: <20080801070448.DB049597C63@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20248 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mitz at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 00:06:29 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 00:06:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19249] Assertion failure in FrameView::scheduleRelayout() (m_frame->view() == this) clicking an image from the Phoenix Mars mission In-Reply-To: Message-ID: <20080801070629.02EE7597D3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19249 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |webkit at mattlilek.com ------- Comment #9 from mitz at webkit.org 2008-08-01 00:06 PDT ------- *** Bug 20248 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 00:06:28 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 00:06:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20248] Assertion failure in FrameView::scheduleRelayoutOfSubtree (m_frame->view() == this) In-Reply-To: Message-ID: <20080801070628.E4989597D35@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20248 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE ------- Comment #2 from mitz at webkit.org 2008-08-01 00:06 PDT ------- (In reply to comment #1) > This may be a dupe of bug 19564, bug 19249, bug 18000, or bug 16211. And the winner is: bug 19249! *** This bug has been marked as a duplicate of 19249 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 00:29:49 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 00:29:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor In-Reply-To: Message-ID: <20080801072949.762C1598590@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20013 sankaraditya+bugzilla at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22593| |review? Flag| | ------- Comment #46 from sankaraditya+bugzilla at gmail.com 2008-08-01 00:29 PDT ------- Created an attachment (id=22593) --> (https://bugs.webkit.org/attachment.cgi?id=22593&action=view) Patch to expose only Relavant Accessible Objects This patch contains only the changes to expose only the relevant accessible objects. Implemented few heuristics to clean MSAA tree. These heuristics have been implemented to sync up the behaviour with Firefox 2.0.0.14. As Jon suggested, updated the patch with all comments inline. ~ Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 00:41:56 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 00:41:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor In-Reply-To: Message-ID: <20080801074156.142365989AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20013 ------- Comment #47 from sankaraditya+bugzilla at gmail.com 2008-08-01 00:41 PDT ------- (In reply to comment #46) Jon, I have created this patch to expose relavant objects. I have created a new function textformattinglements. I have changed the order in heuristics are implemented. According to the new heuristics, This will be present in the tree as a button: Test. This will be present as a list item: Test. This will be ignored: Test. This will also be ignored. This is done to match the behavior in firefox 2.0.0.14. Test. ~ Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 01:10:30 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 01:10:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16814] Give plugin a chance to handle ActiveX objects In-Reply-To: Message-ID: <20080801081030.0560A59942E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16814 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 ------- Comment #4 from eric at webkit.org 2008-08-01 01:10 PDT ------- Curious what ever happened to this patch? Looks like Rui might have been waiting for Anders' "ack" of his comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 01:49:54 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 01:49:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18665] HTMLTokenizer double allocates strings for -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 14:20:17 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 14:20:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20258] New: HTML5 canvas: fillRect() and friends do not support negative heights Message-ID: https://bugs.webkit.org/show_bug.cgi?id=20258 Summary: HTML5 canvas: fillRect() and friends do not support negative heights Product: WebKit Version: 525.x (Safari 3.1) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: drj at pobox.com PROBLEM fillRect(x, y, w, h) will fail with "INDEX_SIZE_ERR: INDEX_SIZE_ERR: DOM Exception 1" (or something like that) when h is negative. There's nothing in the spec to prohibit fillRect() from taking a negative h. The specification requires that the path be formed from the four coordinates: "(x, y), (x+w, y), (x+w, y+h), (x, y+h)". These four coodinates still have a perfectly sensible interpretation when either h or w is negative, and there's nothing I can see in the spec from prohibiting h and w from being negative. It is sometimes even quite natural to use a negative h, for example if one has flipped the Y-axis by issuing a scale(1,-1) then one still might want (x,y) to be the top-left of a rectangle, in which case h will be negative. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:01:10 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:01:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18548] Web Inspector freezes if a search fires with a small number of letters In-Reply-To: Message-ID: <20080801220110.952CD5ABA9A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18548 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21356|review? |review?(timothy at hatcher.name Flag| |) ------- Comment #11 from eric at webkit.org 2008-08-01 15:01 PDT ------- (From update of attachment 21356) Assigning to Tim to review. Adam also knows this code well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:03:58 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:03:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19690] SharedBuffer::buffer() fails with platform data In-Reply-To: Message-ID: <20080801220358.B6DB35ABBC7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19690 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21857|review? |review?(andersca at apple.com) Flag| | ------- Comment #5 from eric at webkit.org 2008-08-01 15:03 PDT ------- (From update of attachment 21857) Assigning this to Anders for review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:09:23 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:09:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19690] SharedBuffer::buffer() fails with platform data In-Reply-To: Message-ID: <20080801220923.1ABC35ABE23@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19690 andersca at apple.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21857|review?(andersca at apple.com) |review- Flag| | ------- Comment #6 from andersca at apple.com 2008-08-01 15:09 PDT ------- (From update of attachment 21857) I think that we should state that calling buffer() on a SharedBuffer that wraps platform data is invalid, and add an assert. I don't blindly want to add a maybeTransferPlatformData() because that is a potentially expensive operation and we'd like to avoid that, especially since buffer() returns a const reference. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:11:45 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20252] make install does not install WebKitAvailability.h In-Reply-To: Message-ID: <20080801221145.A08745ABF3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20252 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22606|review? |review+ Flag| | ------- Comment #4 from eric at webkit.org 2008-08-01 15:11 PDT ------- (From update of attachment 22606) Looks great. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:12:58 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:12:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18548] Web Inspector freezes if a search fires with a small number of letters In-Reply-To: Message-ID: <20080801221258.686255ABFB9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18548 timothy at hatcher.name changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21356|review?(timothy at hatcher.name|review- Flag|) | ------- Comment #12 from timothy at hatcher.name 2008-08-01 15:12 PDT ------- (From update of attachment 21356) + var forceSearch = event.keyCode == 13; You should use event.keyIdentifier === "Enter" here. + if (!forceSearch && this.lastQuery && this.lastQuery == query) You should use === here. Otherwise I will r+ it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:20:23 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:20:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16313] text search (find) keybindings should work in the Web Inspector In-Reply-To: Message-ID: <20080801222023.0CECE5AC20B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16313 timothy at hatcher.name changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22507|review? |review+ Flag| | ------- Comment #11 from timothy at hatcher.name 2008-08-01 15:20 PDT ------- (From update of attachment 22507) We should find a way to hook up to the menu, for sure. But I think this is fine for now. We might also have different find in the future, like a current file find (Command-F and Command-G). Then the global search, so the shortcut might change to mean local find in the future. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:26:53 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:26:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20212] [XBL] Add full support for element="" attachment In-Reply-To: Message-ID: <20080801222653.1BAD15AC41E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20212 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22552|review? |review- Flag| | ------- Comment #3 from eric at webkit.org 2008-08-01 15:26 PDT ------- (From update of attachment 22552) Shouldn't: 49 String currentAttr = getAttribute(XBLNames::elementAttr); Just be: attr->value(); ? + Document* boundDocument = document()->isXBLDocument() ? 0 : document(); is confusing to me. What would we do in the XBLDocument case? Um... we'll crash here: + // Update the styleSelector so that bindings are updated. + // FIXME: is it always required? + boundDocument->updateStyleSelector(); This patch crashes for inline XBL. Can't land it that way. Argument names are not neede here: + XBLBindingElement(const WebCore::QualifiedName& qName, WebCore::Document* doc); The fist one is not needed here: + virtual void attributeChanged(Attribute* attr, bool preserveDecls); This should use early return, or early ASSERT: +void XBLBindingManager::removeBindingSheet(Document* document, PassRefPtr sheet) +{ + StyleSheetVector* documentSheets = m_bindingSheets.get(document); + + if (documentSheets) { + for (StyleSheetVector::iterator it = documentSheets->begin(); it != documentSheets->end(); ++it) + if (*it == sheet) { + documentSheets->remove(it - documentSheets->begin()); + return; + } + } + // We should have the sheet in our binding sheets. + ASSERT_NOT_REACHED(); is it OK to call removeBindingSheet after the document has already been removed from the sheets list? Part of the code seems to assume it is, part doesn't... You need to include a test case which tests the inline xbl case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:30:47 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:30:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it In-Reply-To: Message-ID: <20080801223048.027BE5AC54E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20253 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22597|review? |review- Flag| | ------- Comment #4 from eric at webkit.org 2008-08-01 15:30 PDT ------- (From update of attachment 22597) This seems very complicated. Are we sure there is no simpler way to do this check in configure.ac? I did a little google searching: http://archives.postgresql.org/pgsql-patches/2003-07/msg00019.php http://cvs.tuxbox.org/lists/tuxbox-cvs-0505/msg00086.html https://gna.org/bugs/?11627 I'm sure there are more pages... r- until David's question and the above complexity question are answered. Thanks for the patch! Looking forward to hearing your reply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:31:39 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:31:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17697] Selection placed after anchor but typing types into anchor In-Reply-To: Message-ID: <20080801223139.720075AC5AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17697 ------- Comment #3 from ddkilzer at webkit.org 2008-08-01 15:31 PDT ------- (In reply to comment #1) > Marked duplicate of radar for Bug 15256. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:33:14 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:33:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 15312] WebKit applies an incorrect min width for fields In-Reply-To: Message-ID: <20080801223314.619075AC655@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=15312 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mitz at webkit.org ------- Comment #26 from mitz at webkit.org 2008-08-01 15:33 PDT ------- (In reply to comment #25) > Hyatt, can you provide Ojan information as to how he'd get the average char > width from CG? Windows seems to have explicit APIs for this. I don't think CG > exposes this information as API. I don't know a high-level Mac OS X API for "average character width". I am not sure what the value that the Windows API returns is based on. If it is the xAvgCharWidth field from the font's OS/2 table, then there is Mac OS X API for accessing font tables which can be used (ATSFontGetTable). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:33:30 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:33:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20237] Zero width and space characters are displayed incorrectly if not contained in a fallback font. In-Reply-To: Message-ID: <20080801223330.ADB205AC68A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20237 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22591|review? |review?(mitz at webkit.org) Flag| | ------- Comment #3 from eric at webkit.org 2008-08-01 15:33 PDT ------- (From update of attachment 22591) Hyatt says that mitz is the man to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:37:01 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:37:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18294] Strange Result for getComputedStyle on borderWidth set in em In-Reply-To: Message-ID: <20080801223701.7420D5AC7D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18294 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21925|review? |review- Flag| | ------- Comment #5 from eric at webkit.org 2008-08-01 15:37 PDT ------- (From update of attachment 21925) r- for needing a better test case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:47:30 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:47:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20231] accNavigate: no screen element found in the specified direction should return S_FALSE In-Reply-To: Message-ID: <20080801224730.B231C5ACB20@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20231 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 15:47:50 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 15:47:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20231] accNavigate: no screen element found in the specified direction should return S_FALSE In-Reply-To: Message-ID: <20080801224750.76FDF5ACB45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20231 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22567|review? |review?(jhoneycutt at apple.com Flag| |) ------- Comment #3 from eric at webkit.org 2008-08-01 15:47 PDT ------- (From update of attachment 22567) I assume Jon is the best person to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:13:04 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:13:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20259] New: Scrollbar missing from page Message-ID: https://bugs.webkit.org/show_bug.cgi?id=20259 Summary: Scrollbar missing from page Product: WebKit Version: 526+ (Nightly build) Platform: All URL: http://bbs.ogame.net OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: minatoar at gmail.com The page at http://bbs.ogame.net/ cannot be scrolled. There is no scrollbar, nor does dragging a selection downwards work. Didn't work in Safari 3.1 and WebKit-SVN-r35417. Worked on Firefox 2, Firefox 3, IE7, Opera 9.5 This needs further reduction. While I tentatively filed this as "Layout and Rendering" it could be a javascript/event problem, since it looks like they are hooking into onscroll. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:17:07 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:17:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20073] Pending resource requests not always stopped when new request is loaded In-Reply-To: Message-ID: <20080801231707.209CB5AD485@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20073 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:17:35 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:17:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20073] Pending resource requests not always stopped when new request is loaded In-Reply-To: Message-ID: <20080801231735.8C5A65AD4D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20073 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22331|review? |review?(beidson at apple.com) Flag| | ------- Comment #4 from eric at webkit.org 2008-08-01 16:17 PDT ------- (From update of attachment 22331) Bradee should review this -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:23:24 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:23:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19408] Constant folding in parser In-Reply-To: Message-ID: <20080801232324.83CD05AD6A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19408 cwzwarich at uwaterloo.ca changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22422|review? |review- Flag| | ------- Comment #16 from cwzwarich at uwaterloo.ca 2008-08-01 16:23 PDT ------- (From update of attachment 22422) As Geoff mentions, you should probably see what happens when you do constant folding for division. Why don't you fold the other bitwise operations. +static ExpressionNode* makeMultNode(void*, ExpressionNode*, ExpressionNode*, bool); +static ExpressionNode* makeAddNode(void*, ExpressionNode*, ExpressionNode*, bool); +static ExpressionNode* makeLeftShiftNode(void*, ExpressionNode*, ExpressionNode*, bool); +static ExpressionNode* makeRightShiftNode(void*, ExpressionNode*, ExpressionNode*, bool); The last bool argument should probably be named here, because it isn't clear what it means. It should also be given a descriptive name in the functions themselves, at least something better than "ra". + if (m1->isNumber() && m2->isNumber()) + return makeNumberNode(globalPtr, static_cast(m1)->value() * static_cast(m2)->value()); + else + return new MultNode(GLOBAL_DATA, m1, m2, ra); In WebKit, we don't return from an else like this, we simply remove the else and put the return statement after the if statement. +description( +"This test checks constant folding algorithm." +); This might be better put as "This test checks the correctness of constant folding." We tend to prefer 4 space indentation in JavaScript tests, but why did you make your own shouldBe() function? I don't see any reason why you can't use the standard one. Other than that, it seems like a good patch. I apologize on behalf of the JavaScript team for not reviewing your patch earlier. Most of the development takes place on IRC, so sometimes we are not as responsive to one-off patches posted on the Bugzilla as we should be. I will try to ensure that this doesn't happen in the future. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:40:29 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:40:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20260] New: border-collapse collapse paints border on the wrong table cell Message-ID: https://bugs.webkit.org/show_bug.cgi?id=20260 Summary: border-collapse collapse paints border on the wrong table cell Product: WebKit Version: 526+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: erik.arvidsson at gmail.com When using border-collapse: collapse the border sometimes gets painted on the wrong cell. This does not happen when using cellSpacing = 0 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:41:08 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:41:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20260] border-collapse collapse paints border on the wrong table cell In-Reply-To: Message-ID: <20080801234108.17FC75ADB73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20260 ------- Comment #1 from erik.arvidsson at gmail.com 2008-08-01 16:41 PDT ------- Created an attachment (id=22612) --> (https://bugs.webkit.org/attachment.cgi?id=22612&action=view) Test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:41:17 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:41:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20260] border-collapse collapse paints border on the wrong table cell In-Reply-To: Message-ID: <20080801234117.8A6F65ADB8A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20260 erik.arvidsson at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:47:21 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:47:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 13666] Canvas: fill() blows away the current path In-Reply-To: Message-ID: <20080801234721.25CF75ADD0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=13666 ian at hixie.ch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #6 from ian at hixie.ch 2008-08-01 16:47 PDT ------- Yeah this is bogus, the spec changed since I wrote those tests. Sorry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:47:38 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:47:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20212] [XBL] Add full support for element="" attachment In-Reply-To: Message-ID: <20080801234738.ED7EA5ADD29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20212 ------- Comment #4 from jchaffraix at webkit.org 2008-08-01 16:47 PDT ------- (In reply to comment #3) > (From update of attachment 22552 [edit]) > Shouldn't: > 49 String currentAttr = getAttribute(XBLNames::elementAttr); > > Just be: > attr->value(); ? Nope: attr may be hold the old value if the attribute has really changed. That's why we check it against the real value to determine if it is a change or an addition. > > + Document* boundDocument = document()->isXBLDocument() ? 0 : > document(); > is confusing to me. What would we do in the XBLDocument case? If our Document is an XBLDocument we need to get the proper bound document but that logic is not implemented yet (the crash was intended as inline binding is the common case that would have appeared pretty soon). I will remove the isXBLDocument() and just take the current document (leaving a FIXME). > Argument names are not neede here: > + XBLBindingElement(const WebCore::QualifiedName& qName, > WebCore::Document* doc); > > The fist one is not needed here: > + virtual void attributeChanged(Attribute* attr, bool preserveDecls); > Will fix this. > This should use early return, or early ASSERT: > +void XBLBindingManager::removeBindingSheet(Document* document, > PassRefPtr sheet) > +{ > + StyleSheetVector* documentSheets = m_bindingSheets.get(document); > + > + if (documentSheets) { > + for (StyleSheetVector::iterator it = documentSheets->begin(); it != > documentSheets->end(); ++it) > + if (*it == sheet) { > + documentSheets->remove(it - documentSheets->begin()); > + return; > + } > + } > + // We should have the sheet in our binding sheets. > + ASSERT_NOT_REACHED(); > > is it OK to call removeBindingSheet after the document has already been removed > from the sheets list? Part of the code seems to assume it is, part doesn't... No; we should have the sheet in the document's list or something went wrong (but we do not want to crash). > You need to include a test case which tests the inline xbl case. Will be added. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:50:21 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19578] [CURL] problem in parseDataUrl In-Reply-To: Message-ID: <20080801235021.841735ADE1E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19578 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21727|review? |review- Flag| | ------- Comment #4 from eric at webkit.org 2008-08-01 16:50 PDT ------- (From update of attachment 21727) We don't use malloc() and free directly. We use fastMalloc() and fastFree() when possible, or new/delete. Also, this should just be held in an OwnPtr or an OwnArrayPtr so that it's automatically cleaned up when the block is exited. No reason to use manual c-style memory management when we have nicer c++ tools. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:54:25 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:54:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19676] [Gtk] text-shadow should apply to text decorations as well In-Reply-To: Message-ID: <20080801235425.7BC055ADF6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19676 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21914|review? |review- Flag| | ------- Comment #3 from eric at webkit.org 2008-08-01 16:54 PDT ------- (From update of attachment 21914) Isn't "drawLineForText" used for drawing underlines? Also this seems like kinda a gross hack. But maybe this is the cleanest way to do this with Cairo. Also, you don't respect Shadow-blur. I think that we should come up with a better way of drawing Cairo shadows instead of this. A shadow is a second copy of the entire image drawn at an offset and blurred. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:55:53 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:55:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19603] [SOUP] segfault when closing a file using gio In-Reply-To: Message-ID: <20080801235553.8C85E5AE00C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19603 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21754|review? |review+ Flag| | ------- Comment #5 from eric at webkit.org 2008-08-01 16:55 PDT ------- (From update of attachment 21754) Looks sane. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 16:57:52 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 16:57:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19794] [CURL] Crash if a local file has an unknow extension In-Reply-To: Message-ID: <20080801235752.765B05AE0C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19794 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22023|review? |review- Flag| | ------- Comment #4 from eric at webkit.org 2008-08-01 16:57 PDT ------- (From update of attachment 22023) Why does curl crash when passed an empty string? The right fix is right next to the line of curl code which is going to crash... At least an ASSERT should go next to said line. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 17:05:21 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 17:05:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19370] [Gtk] Assertion failure at ScrollWindow.update for r34340 In-Reply-To: Message-ID: <20080802000521.8A4005AE30E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19370 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22339|review? |review- Flag| | ------- Comment #6 from eric at webkit.org 2008-08-01 17:05 PDT ------- (From update of attachment 22339) Better to fix the bug, or explain why it is OK for a ScrollView to ever not have a window. Printing perhaps? During teardown? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 17:06:46 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 17:06:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18662] Extend keyboard navigation In-Reply-To: Message-ID: <20080802000646.C5E325AE3BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18662 ------- Comment #6 from eric at webkit.org 2008-08-01 17:06 PDT ------- How can we test this? Who do we have who can review this well? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 22:01:52 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 22:01:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19603] [SOUP] segfault when closing a file using gio In-Reply-To: Message-ID: <20080802050152.2C9D35B8355@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19603 jmalonzo at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #6 from jmalonzo at gmail.com 2008-08-01 22:01 PDT ------- landed in r35520 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Fri Aug 1 22:01:52 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 1 Aug 2008 22:01:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19392] [Gtk] Enable WebInspector in the Gtk port In-Reply-To: Message-ID: <20080802050152.4E7805B8362@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19392 Bug 19392 depends on bug 19603, which changed state. Bug 19603 Summary: [SOUP] segfault when closing a file using gio https://bugs.webkit.org/show_bug.cgi?id=19603 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:11:56 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:11:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it In-Reply-To: Message-ID: <20080802071156.C42615BA413@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20253 ------- Comment #5 from zuh at iki.fi 2008-08-02 00:11 PDT ------- (In reply to comment #3) > Why can't the "PKG_CHECK_MODULES" macro be used as is done elsewhere in > configure.ac? That macro requires the checked software to install a .pc file for pkg-config to find, and that practice is not too widespread outside the GNOME/freedesktop.org circles... Which is a bit unfortunate since it would make life so much simpler. About the complicated approach, well yes, I suppose I went a bit overboard to provide easy update should the requirement ever change :) It's not like flex would have had even minor version bump in the last decade... I'll redo the test so that it only looks at the micro version directly, like the PostgreSQL does. And create a proper patch this time. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:30:45 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:30:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20261] New: Support Top Level Array Generics Message-ID: https://bugs.webkit.org/show_bug.cgi?id=20261 Summary: Support Top Level Array Generics Product: WebKit Version: 526+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.4 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dhtmlkitchen at gmail.com Array Generics the built-in Array.prototype methods as generic static methods on the built in Array. Array Generics accept an Array-like object as the first argument and return the method of the same name, called in context of the Array-like object. // Non-generic. Array.prototype.slice.call(arrayLike); // Generic. Array.slice(arrayLike); The generic approach reduces clutter and property lookups. It is cleaner and faster. These methods are implemented in Firefox for quite some time now. For details, please see: http://developer.mozilla.org/en/docs/New_in_JavaScript_1.6#Array_and_String_generics Still unimplemented in: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_4_11; en) AppleWebKit/527.3+ (KHTML, like Gecko) Version/3.1.1 Safari/525.18 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:31:46 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:31:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it In-Reply-To: Message-ID: <20080802073146.103AE5BA98D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20253 zuh at iki.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22597|0 |1 is obsolete| | Attachment #22615| |review? Flag| | ------- Comment #6 from zuh at iki.fi 2008-08-02 00:31 PDT ------- Created an attachment (id=22615) --> (https://bugs.webkit.org/attachment.cgi?id=22615&action=view) Version 2 of flex checking So here is a simplified version check, only looking at the micro version, and a proper changelog entry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:48:25 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:48:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19742] [GTK] Auto generate webkitmarshal.list In-Reply-To: Message-ID: <20080802074825.2B1655BAE07@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19742 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22607|review? |review+ Flag| | ------- Comment #7 from eric at webkit.org 2008-08-02 00:48 PDT ------- (From update of attachment 22607) Looks good to me. This won't show up in the commit queue because it's marked as Fixed. Perhaps this was already commited? If not, please re-open the bug so it will show up in the queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:50:37 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:50:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20253] A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it In-Reply-To: Message-ID: <20080802075037.4DC675BAEC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20253 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22615|review? |review- Flag| | ------- Comment #7 from eric at webkit.org 2008-08-02 00:50 PDT ------- (From update of attachment 22615) Won't this check break with Flex 2.6? Geez autoconf syntax sucks. This patch would make our behavior with Flex 2.6 worse than our current behavior. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:52:04 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:52:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20223] Add QWebPage::contentsChanged() signal In-Reply-To: Message-ID: <20080802075204.4032C5BAF55@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20223 eric at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22549|review? |review+ Flag| | ------- Comment #2 from eric at webkit.org 2008-08-02 00:52 PDT ------- (From update of attachment 22549) Looks fine to me. If someone who actually knows Qt feels otherwise, they should comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at webkit.org Sat Aug 2 00:58:52 2008 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 2 Aug 2008 00:58:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18665] HTMLTokenizer double allocates strings for