Hi Wilfredo, --On February 15, 2007 11:54:34 AM -0800 Wilfredo Sánchez Vega <wsanchez@wsanchez.net> wrote:
Is this code necessary? If we're ending up with multiple entries in the property, that should be fixed in the caller, not here.
If this makes a performance difference, I guess OK, but it should be an exact match using ==, not a .find() call.
I think we have three choices here: 1) Not default the server to inserting the principal URIs into the calendar-user-address-set by default. Instead require each directory service to do that. The appleopendirectory.py does that via the %(principaluri) (though I will have to do some work to actually make that work). The XML file should be hard-coded to add them itself. 2) Leave the default mechanism in place and remove %(principaluri) as an option for the OD schema on the basis that the server is always using that. 3) Leave the default as-is, but support %(principaluri) properly. In terms of performance, all of this stuff will end up in the property database - so the on-the-fly default mechanism won't be a problem. -- Cyrus Daboo