[Calendar and Contacts Server] #473: Internal Server Error on sync-report with invalid sync-token
#473: Internal Server Error on sync-report with invalid sync-token ----------------------------------+----------------------------------------- Reporter: mail@… | Owner: wsanchez@… Type: Defect | Status: new Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Other Keywords: | Radar: ----------------------------------+----------------------------------------- Andrew just debugged aCal against my Calendar Server and we found that it crashes when sending an invalid sync-token in the sync-report. {{{ 2012-01-19 11:09:11+0100 [-] [caldav-0] [PooledMemCacheProtocol,client] [twistedcaldav.memcachepool.MemCachePool#debug] Clients #free: 5, #busy: 0, #pending: 0, #queued: 0 2012-01-19 11:09:11+0100 [-] [caldav-0] [-] [twext.web2.server#info] Exception rendering: 2012-01-19 11:09:11+0100 [-] [caldav-0] [-] [twext.web2.server#error] [Failure instance: Traceback: <type 'exceptions.ValueError'>: invalid literal for int() with base 10: 'None' 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:388:errback 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:455:_startRunCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:542:_runCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1076:gotResult 2012-01-19 11:09:11+0100 [-] [caldav-0] --- <exception caught here> --- 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1018:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/python/failure.py:350:throwExceptionIntoGenerator 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twistedcaldav/resource.py:309:renderHTTP 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1018:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/python/failure.py:350:throwExceptionIntoGenerator 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twext/web2/static.py:128:renderHTTP 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1018:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/python/failure.py:350:throwExceptionIntoGenerator 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twext/web2/resource.py:109:renderHTTP 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1018:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/python/failure.py:350:throwExceptionIntoGenerator 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twistedcaldav/method/report.py:134:http_REPORT 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1018:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/python/failure.py:350:throwExceptionIntoGenerator 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site- packages/twistedcaldav/method/report_sync_collection.py:113:report_DAV__sync_collection 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twisted/internet/defer.py:1020:_inlineCallbacks 2012-01-19 11:09:11+0100 [-] [caldav-0] /usr/lib64/python2.7 /site-packages/twistedcaldav/resource.py:1401:whatchanged 2012-01-19 11:09:11+0100 [-] [caldav-0] ] }}} According to Andrew this should yield a "400 Bad Request" instead of the "500 Server Error". I am using recent trunk: {{{ root@vserver:~ # rpm -qa | grep Calend CalendarServer-3.0.svn8541-1.fc16.x86_64 }}} -- Ticket URL: <http://trac.calendarserver.org/ticket/473> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
#473: Internal Server Error on sync-report with invalid sync-token ----------------------------------+----------------------------------------- Reporter: mail@… | Owner: wsanchez@… Type: Defect | Status: new Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Other Keywords: | Radar: ----------------------------------+----------------------------------------- Comment(by mail@…): The whole request was: {{{ <?xml version="1.0" encoding="utf-8" ?> <sync-collection xmlns="DAV:"> <prop> <getetag/> </prop> <sync-token>null</sync-token> </sync-collection> }}} -- Ticket URL: <http://trac.calendarserver.org/ticket/473#comment:1> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
#473: Internal Server Error on sync-report with invalid sync-token ----------------------------------+----------------------------------------- Reporter: mail@… | Owner: cdaboo@… Type: Defect | Status: new Priority: 3: Important | Milestone: CalendarServer-4.x Component: Calendar Server | Severity: Other Keywords: | Radar: ----------------------------------+----------------------------------------- Changes (by wsanchez@…): * priority: 5: Not set => 3: Important * owner: wsanchez@… => cdaboo@… * milestone: => CalendarServer-4.x Comment: I'm not sure `CalendarServer-3.0.svn8541-1.fc16.x86_64` is recent trunk, but this does sound like a bug. -- Ticket URL: <http://trac.calendarserver.org/ticket/473#comment:2> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
#473: Internal Server Error on sync-report with invalid sync-token ----------------------------------+----------------------------------------- Reporter: mail@… | Owner: cdaboo@… Type: Defect | Status: new Priority: 4: Nice to have | Milestone: CalendarServer-4.x Component: Calendar Server | Severity: Other Keywords: | Radar: ----------------------------------+----------------------------------------- Changes (by wsanchez@…): * priority: 3: Important => 4: Nice to have -- Ticket URL: <http://trac.calendarserver.org/ticket/473#comment:3> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
participants (1)
-
Calendar and Contacts Server