[Calendar and Contacts Server] #486: 'sqlparse.sql.Identifier' instances: Field 'value' is 'None'
#486: 'sqlparse.sql.Identifier' instances: Field 'value' is 'None' ---------------------------------+------------------------------------------ Reporter: carlos@… | Owner: wsanchez@… Type: Defect | Status: new Priority: 5: Not set | Milestone: CalendarServer-4.x Component: Calendar Server | Severity: Other Keywords: | Radar: ---------------------------------+------------------------------------------ When parsing the following SQL fragment: {{{ create table INVITE ( INVITE_UID varchar(255) not null, NAME varchar(255) not null, RECIPIENT_ADDRESS varchar(255) not null, HOME_RESOURCE_ID integer not null, RESOURCE_ID integer not null -- Need primary key on (INVITE_UID, NAME, RECIPIENT_ADDRESS)? ); }}} {{{sqlparse}}} generates an instance of type {{{sqlparse.sql.Identifier}}} to represent the {{{varchar}}} keyword. With my version of {{{sqlparse}}} (0.1.3), the field {{{value}}} of that instance is {{{None}}}, and CalendarServer dies at {{{twext.enterprise.dal.parseschema._ColumnParser.parseColumn()}}}. The attached patch (diff against branches/release/CalendarServer-4.1.1-dev) attemts to address this. -- Ticket URL: <http://trac.calendarserver.org/ticket/486> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
#486: 'sqlparse.sql.Identifier' instances: Field 'value' is 'None' ---------------------------------+------------------------------------------ Reporter: carlos@… | Owner: wsanchez@… Type: Task | Status: new Priority: 4: Nice to have | Milestone: CalendarServer-4.x Component: Calendar Server | Severity: Other Keywords: | Radar: ---------------------------------+------------------------------------------ Changes (by glyph@…): * priority: 5: Not set => 4: Nice to have * type: Defect => Task Comment: Thanks for submitting this patch. A few minor points: - patches should generally be submitted against trunk; we'll backport them to earlier releases if necessary. - we do have a very precise version requirement for sqlparse. Is our build script allowing for newer versions to be used? That would be problematic. - this would be quicker to integrate if you wouldn't mind writing a direct test, something to go in `test_sqlparse.py`. If you don't feel up to it, don't worry, we'll pick it up eventually. Thanks again, -glyph -- Ticket URL: <http://trac.calendarserver.org/ticket/486#comment:1> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
#486: 'sqlparse.sql.Identifier' instances: Field 'value' is 'None' ---------------------------------+------------------------------------------ Reporter: carlos@… | Owner: glyph@… Type: Task | Status: new Priority: 4: Nice to have | Milestone: CalendarServer-4.x Component: Calendar Server | Severity: Other Keywords: | Radar: ---------------------------------+------------------------------------------ Changes (by glyph@…): * owner: wsanchez@… => glyph@… -- Ticket URL: <http://trac.calendarserver.org/ticket/486#comment:2> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
participants (1)
-
Calendar and Contacts Server