[CalendarServer] #287: Breaks with python-vobject 0.6.6
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: new Priority: 5: Not set | Milestone: Component: Calendar Server | Version: Severity: Other | Keywords: -----------------------------+---------------------------------------------- When replacing python-vobject 0.6.0 by 0.6.6 one gets and exception when trying to add a new appointment. Exception is attached to this report. This is calendarserver 1.2 -- Ticket URL: <http://trac.calendarserver.org/ticket/287> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: cdaboo@apple.com Type: Defect | Status: new Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: Keywords: | -----------------------------+---------------------------------------------- Changes (by wsanchez@apple.com): * owner: wsanchez@apple.com => cdaboo@apple.com * priority: 5: Not set => 2: Expected * milestone: => 2.x Comment: I guess we don't strictly have to fix this until we upgrade the version of vobject we use, but we probably should get on this before a possibly small bug becomes a possibly bigger one. -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:1> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: cdaboo@apple.com Type: Defect | Status: new Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: Keywords: | -----------------------------+---------------------------------------------- Comment (by agx@sigxcpu.org): Being stuck at a certain vobject version doesn't seem ideal since we might be missing out on other fixes. From the report it seems that something previously hashable turned into a list. Maybe Jeffrey has an immediate idea? -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:2> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: cdaboo@apple.com Type: Defect | Status: new Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: Keywords: | -----------------------------+---------------------------------------------- Comment (by jeffrey@osafoundation.org): I'm sorry, I could've sworn I sent an email about this change to Cyrus, but looking back at my sent mail it looks like I didn't. vobject uses lists for pretty much everything, including parameters. It was a bug (that was causing exceptions in certain use cases) that X-VOBJ- ORIGINAL-TZID was being stored as a plain value, not a single-valued-list. I was going to say: to fix this, use getattr(property, 'x_vobj_original_tzid_param', None) instead of property.params().get() but I'm not sure what's going on with params being a function. So alternately, do property.params().get('X-VOBJ-ORIGINAL-TZID', [None])[0] -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:3> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: sagen@apple.com Type: Defect | Status: new Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: Keywords: | -----------------------------+---------------------------------------------- Changes (by wsanchez@apple.com): * owner: cdaboo@apple.com => sagen@apple.com -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:4> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: Keywords: | -----------------------------+---------------------------------------------- Changes (by wsanchez@apple.com): * owner: sagen@apple.com => wsanchez@apple.com * status: new => assigned Comment: Jeffrey, params() is a method on the Property class in our code. I assume the same true for fetching 'TZID' in the previous line. -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:5> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: closed Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: fixed Keywords: | -----------------------------+---------------------------------------------- Changes (by wsanchez@apple.com): * status: assigned => closed * resolution: => fixed Comment: r2825 updates to r208 in vobject and handles single-value parameters as list or non-list. (Looks like vobject r208 still returns some parameters as non-lists.) -- Ticket URL: <http://trac.calendarserver.org/ticket/287#comment:6> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: closed Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: fixed Keywords: | -----------------------------+---------------------------------------------- Comment (by jeffrey@osafoundation.org): Cool, glad it's fixed. Can you tell me which parameters are still being returned as non-lists? I'd like to fix that. -- Ticket URL: <https://trac.calendarserver.org/ticket/287#comment:7> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: closed Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: fixed Keywords: | -----------------------------+---------------------------------------------- Comment (by wsanchez@apple.com): Actually, it still returns a non-list for `X-VOBJ-ORIGINAL-TZID` in r208 when I run it. -- Ticket URL: <https://trac.calendarserver.org/ticket/287#comment:8> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: closed Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: fixed Keywords: | -----------------------------+---------------------------------------------- Comment (by wsanchez@apple.com): Wait, looks like my PYTHONPATH is wrong -- Ticket URL: <https://trac.calendarserver.org/ticket/287#comment:9> CalendarServer </> HTTP/WebDAV/CalDAV Server
#287: Breaks with python-vobject 0.6.6 -----------------------------+---------------------------------------------- Reporter: agx@sigxcpu.org | Owner: wsanchez@apple.com Type: Defect | Status: closed Priority: 2: Expected | Milestone: 2.x Component: Calendar Server | Version: Severity: Other | Resolution: fixed Keywords: | -----------------------------+---------------------------------------------- Comment (by wsanchez@apple.com): OK, never mind, not a problem. Thanks. -- Ticket URL: <https://trac.calendarserver.org/ticket/287#comment:10> CalendarServer </> HTTP/WebDAV/CalDAV Server
participants (1)
-
CalendarServer