[CalendarServer] #305: Apache directory service types broken?
#305: Apache directory service types broken? ------------------------------------+--------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: new Priority: 5: Not set | Milestone: Component: Calendar Server | Version: trunk Severity: Crash/data loss | Keywords: ------------------------------------+--------------------------------------- It appears that the Apache directory service types are broken. Code in udpateDirectoryService() in config.py seems to be trying to validate the directory service parameters from the config file against the known keywords, but there is no entry for them in serviceDefaultParams[], so the code takes a KeyError exception at this line: if param not in serviceDefaultParams[dsType]: because dsType is twistedcaldav.directory.apache.DigestDirectoryService, but the list in config.py only has entries for: twistedcaldav.directory.xmlfile.XMLDirectoryService twistedcaldav.directory.appleopendirectory.OpenDirectoryService Maybe that list is supposed to be updated somewhere else (from apache.py?), but I couldn't find any such place. -- Ticket URL: <http://trac.calendarserver.org/ticket/305> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Crash/data loss Resolution: | Keywords: -------------------------------------+-------------------------------------- Changes (by wsanchez@apple.com): * status: new => assigned Comment: See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503727 for a Debian bug on this and a patch. -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:1> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Crash/data loss Resolution: | Keywords: -------------------------------------+-------------------------------------- Old description:
It appears that the Apache directory service types are broken. Code in udpateDirectoryService() in config.py seems to be trying to validate the directory service parameters from the config file against the known keywords, but there is no entry for them in serviceDefaultParams[], so the code takes a KeyError exception at this line:
if param not in serviceDefaultParams[dsType]:
because dsType is twistedcaldav.directory.apache.DigestDirectoryService, but the list in config.py only has entries for:
twistedcaldav.directory.xmlfile.XMLDirectoryService twistedcaldav.directory.appleopendirectory.OpenDirectoryService
Maybe that list is supposed to be updated somewhere else (from apache.py?), but I couldn't find any such place.
New description: Hi Winfredo, the patch in the BTS -- Comment(by agx@sigxcpu.org): Hi Winfredo, the patch makes sense to me. Can it be applied? -- Guido -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:2> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Crash/data loss Resolution: | Keywords: -------------------------------------+-------------------------------------- Old description:
Hi Winfredo, the patch in the BTS
New description: It appears that the Apache directory service types are broken. Code in udpateDirectoryService() in config.py seems to be trying to validate the directory service parameters from the config file against the known keywords, but there is no entry for them in serviceDefaultParams[], so the code takes a KeyError exception at this line: if param not in serviceDefaultParams[dsType]: because dsType is twistedcaldav.directory.apache.DigestDirectoryService, but the list in config.py only has entries for: twistedcaldav.directory.xmlfile.XMLDirectoryService twistedcaldav.directory.appleopendirectory.OpenDirectoryService Maybe that list is supposed to be updated somewhere else (from apache.py?), but I couldn't find any such place. -- Comment(by agx@sigxcpu.org): Replying to [ticket:305 msantos@…]:
Hi Winfredo, the patch in the BTS
-- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:3> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Crash/data loss Resolution: | Keywords: -------------------------------------+-------------------------------------- Comment(by agx@sigxcpu.org): Whoops. I didn't mean to change the description, just wanted to add a comment.
Hi Winfredo, the patch makes sense to me. Can it be applied?
Sorry for the noise. -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:4> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@santosland.com | Owner: wsanchez@apple.com Type: Defect | Status: assigned Priority: 5: Not set | Milestone: Component: Calendar Server | Severity: Crash/data loss Resolution: | Keywords: -------------------------------------+-------------------------------------- Comment(by wsanchez@apple.com): OK, I applied these and some other work that seemed obviously lacking. The files appear to read in correctly, but a couple of things (at least) are still broken: * the basic verifyCredentials bits still don't work for me; I wasn't able to auth * the digest verifyCredentials bits are unimplemented * the digest directory service doesn't filter out records with a non- matching realm (realm seems irrelevant to basic) -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:5> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? ------------------------------------+--------------------------------------- Reporter: msantos@… | Owner: wsanchez@… Type: Defect | Status: assigned Priority: 3: Important | Milestone: Later Component: Calendar Server | Severity: Crash/data loss Keywords: | ------------------------------------+--------------------------------------- Changes (by wsanchez@…): * priority: 5: Not set => 3: Important * milestone: => Later -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:6> CalendarServer </> HTTP/WebDAV/CalDAV Server
#305: Apache directory service types broken? -------------------------------------+-------------------------------------- Reporter: msantos@… | Owner: wsanchez@… Type: Defect | Status: closed Priority: 3: Important | Milestone: Later Component: Calendar Server | Severity: Crash/data loss Resolution: Software changed | Keywords: -------------------------------------+-------------------------------------- Changes (by wsanchez@…): * status: assigned => closed * resolution: => Software changed Comment: This functionality was removed for 3.0 -- Ticket URL: <http://trac.calendarserver.org/ticket/305#comment:7> Calendar and Contacts Server </> HTTP/WebDAV/CalDAV Server
participants (2)
-
Calendar and Contacts Server
-
CalendarServer