July 2007 - launchd-changes - lists.macosforge.org

[23293] trunk/launchd/src/libvproc.c
by source_changes＠macosforge.org 03 Jul '07

03 Jul '07

Revision: 23293 http://trac.macosforge.org/projects/launchd/changeset/23293 Author: zarzycki(a)apple.com Date: 2007-07-03 12:53:19 -0700 (Tue, 03 Jul 2007) Log Message: ----------- <rdar://problem/5247777> STD:VSC nohup tests failing Modified Paths: -------------- trunk/launchd/src/libvproc.c Modified: trunk/launchd/src/libvproc.c =================================================================== --- trunk/launchd/src/libvproc.c 2007-07-03 17:31:02 UTC (rev 23292) +++ trunk/launchd/src/libvproc.c 2007-07-03 19:53:19 UTC (rev 23293) @@ -158,10 +158,13 @@ return (vproc_err_t)_vprocmgr_move_subset_to_user; } - if (vproc_swap_complex(NULL, VPROC_GSK_ENVIRONMENT, NULL, &output_obj) == NULL) { - if (launch_data_get_type(output_obj) == LAUNCH_DATA_DICTIONARY) { - launch_data_dict_iterate(output_obj, setup_env_hack, NULL); - launch_data_free(output_obj); + /* XXX We need to give 'nohup' a better API after Leopard ships */ + if (getprogname() && strcmp(getprogname(), "nohup") != 0) { + if (vproc_swap_complex(NULL, VPROC_GSK_ENVIRONMENT, NULL, &output_obj) == NULL) { + if (launch_data_get_type(output_obj) == LAUNCH_DATA_DICTIONARY) { + launch_data_dict_iterate(output_obj, setup_env_hack, NULL); + launch_data_free(output_obj); + } } }

1 0

[23292] trunk/launchd/src/launchd_core_logic.c
by source_changes＠macosforge.org 03 Jul '07

03 Jul '07

Revision: 23292 http://trac.macosforge.org/projects/launchd/changeset/23292 Author: zarzycki(a)apple.com Date: 2007-07-03 10:31:02 -0700 (Tue, 03 Jul 2007) Log Message: ----------- <rdar://problem/5299540> Aqua session launch agent jobs not loaded for root user session Modified Paths: -------------- trunk/launchd/src/launchd_core_logic.c Modified: trunk/launchd/src/launchd_core_logic.c =================================================================== --- trunk/launchd/src/launchd_core_logic.c 2007-07-02 21:31:19 UTC (rev 23291) +++ trunk/launchd/src/launchd_core_logic.c 2007-07-03 17:31:02 UTC (rev 23292) @@ -5422,7 +5422,7 @@ void job_reparent_hack(job_t j, const char *where) { - jobmgr_t jmi = NULL; + jobmgr_t jmi, jmi2; ensure_root_bkgd_setup(); @@ -5445,10 +5445,18 @@ SLIST_FOREACH(jmi, &root_jobmgr->submgrs, sle) { if (strcasecmp(jmi->name, where) == 0) { - break; + goto jm_found; + } else if (strcasecmp(jmi->name, VPROCMGR_SESSION_BACKGROUND) == 0 && getpid() == 1) { + SLIST_FOREACH(jmi2, &jmi->submgrs, sle) { + if (strcasecmp(jmi2->name, where) == 0) { + jmi = jmi2; + goto jm_found; + } + } } } +jm_found: if (job_assumes(j, jmi != NULL)) { struct machservice *msi;

1 0

[23291] tags/launchd-224/
by source_changes＠macosforge.org 02 Jul '07

02 Jul '07

Revision: 23291 http://trac.macosforge.org/projects/launchd/changeset/23291 Author: zarzycki(a)apple.com Date: 2007-07-02 14:31:19 -0700 (Mon, 02 Jul 2007) Log Message: ----------- "Tagging launchd-224 from https://svn.macosforge.org/repository/launchd/trunk" Added Paths: ----------- tags/launchd-224/ Copied: tags/launchd-224 (from rev 23290, trunk)

1 0

[23290] trunk/launchd/src/launchd_core_logic.c
by source_changes＠macosforge.org 02 Jul '07

02 Jul '07

Revision: 23290 http://trac.macosforge.org/projects/launchd/changeset/23290 Author: zarzycki(a)apple.com Date: 2007-07-02 14:30:55 -0700 (Mon, 02 Jul 2007) Log Message: ----------- Extra logging. Modified Paths: -------------- trunk/launchd/src/launchd_core_logic.c Modified: trunk/launchd/src/launchd_core_logic.c =================================================================== --- trunk/launchd/src/launchd_core_logic.c 2007-07-02 20:21:25 UTC (rev 23289) +++ trunk/launchd/src/launchd_core_logic.c 2007-07-02 21:30:55 UTC (rev 23290) @@ -1003,6 +1003,7 @@ if (kevent_mod(jr->p, EVFILT_PROC, EV_ADD, proc_fflags, 0, root_jobmgr) == -1 && job_assumes(jr, errno == ESRCH)) { /* zombies are weird */ + job_log(jr, LOG_ERR, "Failed to add kevent for PID %u. Will unload at MIG return.", jr->p); jr->unload_at_mig_return = true; } @@ -1805,6 +1806,7 @@ job_mig_destructor(job_t j) { if (j->unload_at_mig_return) { + job_log(j, LOG_NOTICE, "Unloading PID %u at MIG return.", j->p); job_remove(j); }

1 0

[23289] trunk/launchd/src/launchctl.c
by source_changes＠macosforge.org 02 Jul '07

02 Jul '07

Revision: 23289 http://trac.macosforge.org/projects/launchd/changeset/23289 Author: zarzycki(a)apple.com Date: 2007-07-02 13:21:25 -0700 (Mon, 02 Jul 2007) Log Message: ----------- <rdar://problem/5279302> Bug: launchctl.c:1556 (23257):2: load_and_unload_cmd(the_argc, load_launchd_items) == 0 Modified Paths: -------------- trunk/launchd/src/launchctl.c Modified: trunk/launchd/src/launchctl.c =================================================================== --- trunk/launchd/src/launchctl.c 2007-07-02 16:29:12 UTC (rev 23288) +++ trunk/launchd/src/launchctl.c 2007-07-02 20:21:25 UTC (rev 23289) @@ -1559,7 +1559,7 @@ assumes(SessionCreate(sessionKeepCurrentBootstrap, 0) == 0); } - assumes(load_and_unload_cmd(the_argc, load_launchd_items) == 0); + return load_and_unload_cmd(the_argc, load_launchd_items); } return 0;

1 0

[23288] trunk/launchd/src
by source_changes＠macosforge.org 02 Jul '07

02 Jul '07

Revision: 23288 http://trac.macosforge.org/projects/launchd/changeset/23288 Author: zarzycki(a)apple.com Date: 2007-07-02 09:29:12 -0700 (Mon, 02 Jul 2007) Log Message: ----------- <rdar://problem/5284661> Per-user agents run in root security context Modified Paths: -------------- trunk/launchd/src/Makefile.am trunk/launchd/src/Makefile.in trunk/launchd/src/launchctl.c Modified: trunk/launchd/src/Makefile.am =================================================================== --- trunk/launchd/src/Makefile.am 2007-06-29 20:24:46 UTC (rev 23287) +++ trunk/launchd/src/Makefile.am 2007-07-02 16:29:12 UTC (rev 23288) @@ -40,7 +40,7 @@ sysconf_DATA = hostconfig rc.common rc.netboot launchctl_CFLAGS = $(AM_CFLAGS) -I/System/Library/Frameworks/System.framework/PrivateHeaders -launchctl_LDFLAGS = -framework CoreFoundation -framework IOKit -weak_library /usr/lib/libedit.dylib +launchctl_LDFLAGS = -framework CoreFoundation -framework IOKit -framework Security -weak_library /usr/lib/libedit.dylib SystemStarter_CFLAGS = -mdynamic-no-pic $(AM_CFLAGS) SystemStarter_LDFLAGS = -framework CoreFoundation -framework IOKit Modified: trunk/launchd/src/Makefile.in =================================================================== --- trunk/launchd/src/Makefile.in 2007-06-29 20:24:46 UTC (rev 23287) +++ trunk/launchd/src/Makefile.in 2007-07-02 16:29:12 UTC (rev 23288) @@ -246,7 +246,7 @@ @LIBS_ONLY_TRUE@liblaunch_profile_a_SOURCES = liblaunch.c libvproc.c libbootstrap.c protocol_vprocUser.c __version.c @LIBS_ONLY_FALSE@sysconf_DATA = hostconfig rc.common rc.netboot @LIBS_ONLY_FALSE@launchctl_CFLAGS = $(AM_CFLAGS) -I/System/Library/Frameworks/System.framework/PrivateHeaders -@LIBS_ONLY_FALSE@launchctl_LDFLAGS = -framework CoreFoundation -framework IOKit -weak_library /usr/lib/libedit.dylib +@LIBS_ONLY_FALSE@launchctl_LDFLAGS = -framework CoreFoundation -framework IOKit -framework Security -weak_library /usr/lib/libedit.dylib @LIBS_ONLY_FALSE@SystemStarter_CFLAGS = -mdynamic-no-pic $(AM_CFLAGS) @LIBS_ONLY_FALSE@SystemStarter_LDFLAGS = -framework CoreFoundation -framework IOKit @LIBS_ONLY_FALSE@SystemStarter_SOURCES = StartupItems.c IPC.c SystemStarter.c Modified: trunk/launchd/src/launchctl.c =================================================================== --- trunk/launchd/src/launchctl.c 2007-06-29 20:24:46 UTC (rev 23287) +++ trunk/launchd/src/launchctl.c 2007-07-02 16:29:12 UTC (rev 23288) @@ -22,6 +22,8 @@ #include <CoreFoundation/CoreFoundation.h> #include <CoreFoundation/CFPriv.h> +#include <Security/Security.h> +#include <Security/AuthSession.h> #include <IOKit/IOKitLib.h> #include <NSSystemDirectories.h> #include <mach/mach.h> @@ -1553,6 +1555,10 @@ the_argc += 1; } + if (strcasecmp(session_type, "Background") == 0) { + assumes(SessionCreate(sessionKeepCurrentBootstrap, 0) == 0); + } + assumes(load_and_unload_cmd(the_argc, load_launchd_items) == 0); }

1 0