August 2007 - launchd-changes - lists.macosforge.org

[23329] trunk/launchd/src/StartupItems.c
by source_changes＠macosforge.org 06 Aug '07

06 Aug '07

Revision: 23329 http://trac.macosforge.org/projects/launchd/changeset/23329 Author: zarzycki(a)apple.com Date: 2007-08-06 08:24:48 -0700 (Mon, 06 Aug 2007) Log Message: ----------- <rdar://problem/5385870> 9A510: SystemStarter: shouldn't require user write bit on startup items Modified Paths: -------------- trunk/launchd/src/StartupItems.c Modified: trunk/launchd/src/StartupItems.c =================================================================== --- trunk/launchd/src/StartupItems.c 2007-08-02 20:29:24 UTC (rev 23328) +++ trunk/launchd/src/StartupItems.c 2007-08-06 15:24:48 UTC (rev 23329) @@ -229,10 +229,14 @@ syslog(LOG_WARNING, "\"%s\" failed security check: not a directory or regular file", aPath); r = false; } - if ((aStatBuf.st_mode & ALLPERMS) & ~(S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH)) { - syslog(LOG_WARNING, "\"%s\" failed security check: permissions", aPath); + if (aStatBuf.st_mode & S_IWOTH) { + syslog(LOG_WARNING, "\"%s\" failed security check: world writable", aPath); r = false; } + if (aStatBuf.st_mode & S_IWGRP) { + syslog(LOG_WARNING, "\"%s\" failed security check: group writable", aPath); + r = false; + } if (aStatBuf.st_uid != 0) { syslog(LOG_WARNING, "\"%s\" failed security check: not owned by UID 0", aPath); r = false;

1 0

[23328] tags/launchd-235/
by source_changes＠macosforge.org 02 Aug '07

02 Aug '07

Revision: 23328 http://trac.macosforge.org/projects/launchd/changeset/23328 Author: zarzycki(a)apple.com Date: 2007-08-02 13:29:24 -0700 (Thu, 02 Aug 2007) Log Message: ----------- "Tagging launchd-235 from https://svn.macosforge.org/repository/launchd/trunk" Added Paths: ----------- tags/launchd-235/ Copied: tags/launchd-235 (from rev 23327, trunk)

1 0

[23327] trunk/launchd/src
by source_changes＠macosforge.org 02 Aug '07

02 Aug '07

Revision: 23327 http://trac.macosforge.org/projects/launchd/changeset/23327 Author: zarzycki(a)apple.com Date: 2007-08-02 13:29:02 -0700 (Thu, 02 Aug 2007) Log Message: ----------- <rdar://problem/5378922> 9A509: screen hangs on launch in root shell Modified Paths: -------------- trunk/launchd/src/launchd_core_logic.c trunk/launchd/src/libvproc.c Modified: trunk/launchd/src/launchd_core_logic.c =================================================================== --- trunk/launchd/src/launchd_core_logic.c 2007-08-01 22:11:19 UTC (rev 23326) +++ trunk/launchd/src/launchd_core_logic.c 2007-08-02 20:29:02 UTC (rev 23327) @@ -5658,7 +5658,11 @@ */ } else if (strcmp(j->mgr->name, VPROCMGR_SESSION_AQUA) == 0) { + job_log(j, LOG_DEBUG, "Tried to move the Aqua session."); return 0; + } else if (strcmp(j->mgr->name, VPROCMGR_SESSION_BACKGROUND) == 0) { + job_log(j, LOG_DEBUG, "Tried to move the background session."); + return 0; } else { job_log(j, LOG_ERR, "Tried to initialize an already setup session!"); kr = BOOTSTRAP_NOT_PRIVILEGED; Modified: trunk/launchd/src/libvproc.c =================================================================== --- trunk/launchd/src/libvproc.c 2007-08-01 22:11:19 UTC (rev 23326) +++ trunk/launchd/src/libvproc.c 2007-08-02 20:29:02 UTC (rev 23327) @@ -111,7 +111,7 @@ return (vproc_err_t)_vprocmgr_move_subset_to_user; } - if (ldpid != 1) { + if (!is_bkgd && ldpid != 1) { if (lduid == getuid()) { return NULL; }

1 0

[23326] tags/launchd-234/
by source_changes＠macosforge.org 01 Aug '07

01 Aug '07

Revision: 23326 http://trac.macosforge.org/projects/launchd/changeset/23326 Author: zarzycki(a)apple.com Date: 2007-08-01 15:11:19 -0700 (Wed, 01 Aug 2007) Log Message: ----------- "Tagging launchd-234 from https://svn.macosforge.org/repository/launchd/trunk" Added Paths: ----------- tags/launchd-234/ Copied: tags/launchd-234 (from rev 23325, trunk)

1 0

[23325] trunk/launchd/src/launchctl.c
by source_changes＠macosforge.org 01 Aug '07

01 Aug '07

Revision: 23325 http://trac.macosforge.org/projects/launchd/changeset/23325 Author: zarzycki(a)apple.com Date: 2007-08-01 09:25:38 -0700 (Wed, 01 Aug 2007) Log Message: ----------- Fix an editing error that inversed the logic. Modified Paths: -------------- trunk/launchd/src/launchctl.c Modified: trunk/launchd/src/launchctl.c =================================================================== --- trunk/launchd/src/launchctl.c 2007-08-01 15:38:50 UTC (rev 23324) +++ trunk/launchd/src/launchctl.c 2007-08-01 16:25:38 UTC (rev 23325) @@ -224,7 +224,7 @@ is_managed = true; } - if (getuid() && !is_managed) { + if (getuid() == 0 && !is_managed) { mach_port_t root_bs = str2bsport("/"); task_set_bootstrap_port(mach_task_self(), root_bs); mach_port_deallocate(mach_task_self(), bootstrap_port);

1 0

[23324] trunk/launchd/src/launchctl.c
by source_changes＠macosforge.org 01 Aug '07

01 Aug '07

Revision: 23324 http://trac.macosforge.org/projects/launchd/changeset/23324 Author: zarzycki(a)apple.com Date: 2007-08-01 08:38:50 -0700 (Wed, 01 Aug 2007) Log Message: ----------- <rdar://problem/5374857> launchd unnecessarily logs a warning when there is nothing to load in StandardIO Modified Paths: -------------- trunk/launchd/src/launchctl.c Modified: trunk/launchd/src/launchctl.c =================================================================== --- trunk/launchd/src/launchctl.c 2007-07-30 22:05:14 UTC (rev 23323) +++ trunk/launchd/src/launchctl.c 2007-08-01 15:38:50 UTC (rev 23324) @@ -210,16 +210,21 @@ { "help", help_cmd, "This help output" }, }; -static bool istty = false; -static bool verbose = false; +static bool istty; +static bool verbose; +static bool is_managed; int main(int argc, char *const argv[]) { - int64_t is_managed = 0; + int64_t is_managed_val = 0; char *l; - if ((getuid() == 0) && (vproc_swap_integer(NULL, VPROC_GSK_IS_MANAGED, NULL, &is_managed) == NULL) && (is_managed == 0)) { + if (vproc_swap_integer(NULL, VPROC_GSK_IS_MANAGED, NULL, &is_managed_val) == NULL && is_managed_val) { + is_managed = true; + } + + if (getuid() && !is_managed) { mach_port_t root_bs = str2bsport("/"); task_set_bootstrap_port(mach_task_self(), root_bs); mach_port_deallocate(mach_task_self(), bootstrap_port); @@ -1719,11 +1724,13 @@ if (launch_data_array_get_count(lus.pass0) == 0 && launch_data_array_get_count(lus.pass1) == 0 && launch_data_array_get_count(lus.pass2) == 0) { - fprintf(stderr, "nothing found to %s\n", lus.load ? "load" : "unload"); + if (!is_managed) { + fprintf(stderr, "nothing found to %s\n", lus.load ? "load" : "unload"); + } launch_data_free(lus.pass0); launch_data_free(lus.pass1); launch_data_free(lus.pass2); - return 1; + return is_managed ? 0 : 1; } if (lus.load) {

1 0