May 2008 - launchd-changes - lists.macosforge.org

[23619] tags/launchd-274/
by source_changes＠macosforge.org 02 May '08

02 May '08

Revision: 23619 http://trac.macosforge.org/projects/launchd/changeset/23619 Author: zarzycki(a)apple.com Date: 2008-05-02 16:19:42 -0700 (Fri, 02 May 2008) Log Message: ----------- "Tagging launchd-274 from https://svn.macosforge.org/repository/launchd/trunk" Added Paths: ----------- tags/launchd-274/ Copied: tags/launchd-274 (from rev 23618, trunk)

1 0

[23618] trunk/launchd/src/launchd_core_logic.c
by source_changes＠macosforge.org 02 May '08

02 May '08

Revision: 23618 http://trac.macosforge.org/projects/launchd/changeset/23618 Author: zarzycki(a)apple.com Date: 2008-05-02 16:19:24 -0700 (Fri, 02 May 2008) Log Message: ----------- <rdar://problem/5875034> 10A52: Stuck at an empty desktop after changing homedirs <rdar://problem/5871441> Investigation: Accounting for transient processes Modified Paths: -------------- trunk/launchd/src/launchd_core_logic.c Modified: trunk/launchd/src/launchd_core_logic.c =================================================================== --- trunk/launchd/src/launchd_core_logic.c 2008-05-02 22:58:06 UTC (rev 23617) +++ trunk/launchd/src/launchd_core_logic.c 2008-05-02 23:19:24 UTC (rev 23618) @@ -324,8 +324,6 @@ /* static void jobmgr_log_error(jobmgr_t jm, int pri, const char *msg, ...) __attribute__((format(printf, 3, 4))); */ static void jobmgr_log_bug(jobmgr_t jm, unsigned int line); -#define DO_RUSAGE_SUMMATION 0 - #define AUTO_PICK_LEGACY_LABEL (const char *)(~0) struct job_s { @@ -343,9 +341,7 @@ SLIST_HEAD(, machservice) machservices; SLIST_HEAD(, semaphoreitem) semaphores; SLIST_HEAD(, waiting_for_removal) removal_watchers; -#if DO_RUSAGE_SUMMATION struct rusage ru; -#endif cpu_type_t *j_binpref; size_t j_binpref_cnt; mach_port_t j_port; @@ -921,7 +917,6 @@ ipc_close_all_with_job(j); -#if DO_RUSAGE_SUMMATION job_log(j, LOG_INFO, "Total rusage: utime %ld.%06u stime %ld.%06u maxrss %lu ixrss %lu idrss %lu isrss %lu minflt %lu majflt %lu nswap %lu inblock %lu oublock %lu msgsnd %lu msgrcv %lu nsignals %lu nvcsw %lu nivcsw %lu", j->ru.ru_utime.tv_sec, j->ru.ru_utime.tv_usec, j->ru.ru_stime.tv_sec, j->ru.ru_stime.tv_usec, @@ -930,7 +925,6 @@ j->ru.ru_nswap, j->ru.ru_inblock, j->ru.ru_oublock, j->ru.ru_msgsnd, j->ru.ru_msgrcv, j->ru.ru_nsignals, j->ru.ru_nvcsw, j->ru.ru_nivcsw); -#endif if (j->forced_peers_to_demand_mode) { job_set_global_on_demand(j, false); @@ -2393,7 +2387,6 @@ job_log(j, LOG_INFO, "Exited %lld.%06lld seconds after %s was sent", td_sec, td_usec, signal_to_C_name(SIGTERM)); } -#if DO_RUSAGE_SUMMATION timeradd(&ru.ru_utime, &j->ru.ru_utime, &j->ru.ru_utime); timeradd(&ru.ru_stime, &j->ru.ru_stime, &j->ru.ru_stime); j->ru.ru_maxrss += ru.ru_maxrss; @@ -2410,7 +2403,6 @@ j->ru.ru_nsignals += ru.ru_nsignals; j->ru.ru_nvcsw += ru.ru_nvcsw; j->ru.ru_nivcsw += ru.ru_nivcsw; -#endif if (WIFEXITED(status) && WEXITSTATUS(status) != 0) { job_log(j, LOG_WARNING, "Exited with exit code: %d", WEXITSTATUS(status)); @@ -3171,7 +3163,6 @@ { /* This function is all about 5201578 */ - const char *shell_env_var = getenv("SHELL"); const char *home_env_var = getenv("HOME"); const char *user_env_var = getenv("USER"); const char *logname_env_var = getenv("LOGNAME"); @@ -3183,7 +3174,7 @@ struct passwd *pwe; - if (!job_assumes(j, shell_env_var && home_env_var && user_env_var && logname_env_var + if (!job_assumes(j, home_env_var && user_env_var && logname_env_var && strcmp(user_env_var, logname_env_var) == 0)) { goto out_bad; } @@ -3208,10 +3199,6 @@ strlcpy(loginname, pwe->pw_name, sizeof(loginname)); strlcpy(homedir, pwe->pw_dir, sizeof(homedir)); - if (strcmp(shellpath, shell_env_var) != 0) { - job_log(j, LOG_ERR, "The %s environmental variable changed out from under us!", "SHELL"); - goto out_bad; - } if (strcmp(loginname, logname_env_var) != 0) { job_log(j, LOG_ERR, "The %s environmental variable changed out from under us!", "USER"); goto out_bad; @@ -3233,8 +3220,12 @@ return; out_bad: +#if 0 job_assumes(j, runtime_kill(getppid(), SIGTERM) != -1); _exit(EXIT_FAILURE); +#else + job_log(j, LOG_WARNING, "In a future build of the OS, this error will be fatal."); +#endif } void

1 0

[23617] trunk/launchd/src/launchd_runtime_kill.c
by source_changes＠macosforge.org 02 May '08

02 May '08

Revision: 23617 http://trac.macosforge.org/projects/launchd/changeset/23617 Author: zarzycki(a)apple.com Date: 2008-05-02 15:58:06 -0700 (Fri, 02 May 2008) Log Message: ----------- <rdar://problem/5906374> launchd calls __kill() on arm Modified Paths: -------------- trunk/launchd/src/launchd_runtime_kill.c Modified: trunk/launchd/src/launchd_runtime_kill.c =================================================================== --- trunk/launchd/src/launchd_runtime_kill.c 2008-05-02 22:54:41 UTC (rev 23616) +++ trunk/launchd/src/launchd_runtime_kill.c 2008-05-02 22:58:06 UTC (rev 23617) @@ -18,40 +18,27 @@ * @APPLE_APACHE_LICENSE_HEADER_END@ */ -#if defined(__LP64__) -/* ??? No way to get the old behavior */ -#define old_kill(x, y) kill(x, y) -#define old_killpg(x, y) kill(-(x), y) -#elif defined(__arm__) -/* ??? No blessed way to get the old behavior */ -extern int __kill(int, int, int); -#define old_kill(x, y) __kill(x, y, 0) -#define old_killpg(x, y) __kill(-(x), y, 0) -#else -#define _NONSTD_SOURCE 1 -#define old_kill(x, y) kill(x, y) -#define old_killpg(x, y) killpg(x, y) -#endif +#include <sys/syscall.h> +#include <unistd.h> #include <signal.h> #include "launchd_runtime_kill.h" -/* - * POSIX defines consistency over correctness, and consequently kill/killpg now - * returns EPERM instead of ESRCH. - * - * I've filed 5487498 to get a non-portable kill() variant, but for now, - * defining _NONSTD_SOURCE gets us the old behavior. - */ - int runtime_kill(pid_t pid, int sig) { - return old_kill(pid, sig); + /* + * POSIX defines consistency over correctness, and consequently + * kill/killpg now returns EPERM instead of ESRCH. + * + * I've filed 5487498 to get a non-portable kill(). + * We'll regretfully take advantage of implementation details for now. + */ + return syscall(SYS_kill, pid, sig, 0); } int runtime_killpg(pid_t pgrp, int sig) { - return old_killpg(pgrp, sig); + return runtime_kill(-pgrp, sig); }

1 0

[23616] tags/launchd-258.14/
by source_changes＠macosforge.org 02 May '08

02 May '08

Revision: 23616 http://trac.macosforge.org/projects/launchd/changeset/23616 Author: zarzycki(a)apple.com Date: 2008-05-02 15:54:41 -0700 (Fri, 02 May 2008) Log Message: ----------- "Tagging launchd-258.14 from https://svn.macosforge.org/repository/launchd/branches/SULeopard" Added Paths: ----------- tags/launchd-258.14/ Copied: tags/launchd-258.14 (from rev 23615, branches/SULeopard)

1 0

[23615] branches/SULeopard/launchd/src/launchd_runtime_kill.c
by source_changes＠macosforge.org 02 May '08

02 May '08

Revision: 23615 http://trac.macosforge.org/projects/launchd/changeset/23615 Author: zarzycki(a)apple.com Date: 2008-05-02 15:53:47 -0700 (Fri, 02 May 2008) Log Message: ----------- <rdar://problem/5906374> launchd calls __kill() on arm Modified Paths: -------------- branches/SULeopard/launchd/src/launchd_runtime_kill.c Modified: branches/SULeopard/launchd/src/launchd_runtime_kill.c =================================================================== --- branches/SULeopard/launchd/src/launchd_runtime_kill.c 2008-04-30 21:32:53 UTC (rev 23614) +++ branches/SULeopard/launchd/src/launchd_runtime_kill.c 2008-05-02 22:53:47 UTC (rev 23615) @@ -18,36 +18,27 @@ * @APPLE_APACHE_LICENSE_HEADER_END@ */ -#if !defined(__LP64__) && !defined(__arm__) -#define _NONSTD_SOURCE 1 -#define old_kill(x, y) kill(x, y) -#define old_killpg(x, y) killpg(x, y) -#else -/* ??? No blessed way to get the old behavior */ -extern int __kill(int, int, int); -#define old_kill(x, y) __kill(x, y, 0) -#define old_killpg(x, y) __kill(-(x), y, 0) -#endif +#include <sys/syscall.h> +#include <unistd.h> #include <signal.h> #include "launchd_runtime_kill.h" -/* - * POSIX defines consistency over correctness, and consequently kill/killpg now - * returns EPERM instead of ESRCH. - * - * I've filed 5487498 to get a non-portable kill() variant, but for now, - * defining _NONSTD_SOURCE gets us the old behavior. - */ - int runtime_kill(pid_t pid, int sig) { - return old_kill(pid, sig); + /* + * POSIX defines consistency over correctness, and consequently + * kill/killpg now returns EPERM instead of ESRCH. + * + * I've filed 5487498 to get a non-portable kill(). + * We'll regretfully take advantage of implementation details for now. + */ + return syscall(SYS_kill, pid, sig, 0); } int runtime_killpg(pid_t pgrp, int sig) { - return old_killpg(pgrp, sig); + return runtime_kill(-pgrp, sig); }

1 0