November 2009 - libdispatch-dev - lists.macosforge.org

Solaris portability / Pthread workqueue
by Prakash Sangappa 24 Nov '09

24 Nov '09

I am interested in finding out more about the pthread workqueue API that libdispatch uses. Is there any documentation / man pages available? Glad to see a Solaris port of libdispatch coming along, great effort by Joakim. I understand that a full API support, including blocks and the kernel support is desirable. Thanks, -Prakash.

4 3

State of the Linux port (without blocks support)
by Mario Schwalbe 23 Nov '09

23 Nov '09

Hi, Robert Watson schrieb: > Has anyone else noticed that getting libdispatch to run on a new OS is > the easy bit, and that figuring out the auto*/libtool/pkg-config/etc > stuff is the hard bit? :-) I did recognize the irony and I don't want to underestimate your work either, but getting libdispatch to compile is just the first step. The real problems are going to arise thereafter, as we're now able to run the test suite. I also would like to thank all developers who are replying that quickly on the list, and Mark Heily for developing libkqueue. All libraries and programs have been compiled with GCC 4.4.1. Please note that I ran the tests manually, because make -C <build-of-libdispatch>/testing check might report pass, e.g.: Actual: 193 Expected: 192 [FAIL] blocks completed (/home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:82) /home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:82 Actual: 29 Expected: <36 [PASS] high priority precedence PASS: dispatch_priority Here are the results: dispatch_api: pass dispatch_c99: pass dispatch_cascade: pass dispatch_debug: pass dispatch_priority: fail ================================================== [TEST] Dispatch Priority [PID] 3369 ================================================== LOW: 128 ******************************************************************************** DEFAULT: 23 *************** HIGH: 42 *************************** Actual: 193 Expected: 192 [FAIL] blocks completed (/home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:82) /home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:82 Actual: 128 Expected: <42 [FAIL] high priority precedence (/home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:83) /home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:83 dispatch_priority2: fail ================================================== [TEST] Dispatch Priority (Set Target Queue) [PID] 3944 ================================================== Actual: 0x240e010 Expected: 0x240e010 [PASS] q[i] Actual: 0x240e350 Expected: 0x240e350 [PASS] q[i] Actual: 0x240e400 Expected: 0x240e400 [PASS] q[i] LOW: 63 **************************************** DEFAULT: 67 ****************************************** HIGH: 62 *************************************** Actual: 192 Expected: 192 [PASS] blocks completed Actual: 63 Expected: <62 [FAIL] high priority precedence (/home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:83) /home/mario/diplom/src/libdispatch/testing/dispatch_priority.c:83 dispatch_starfish: fail laps 10-1 pass, but the task doesn't return and spins forever (one thread). queue_finalizer: pass ciao, Mario

2 2

[PATCH 2/4] check whether to add -lm for testing to compile
by Mario Schwalbe 20 Nov '09

20 Nov '09

Hi, Linux needs -lm in order to compile the testing directory due to fabs(). ciao, Mario Index: configure.ac =================================================================== --- configure.ac (Revision 171) +++ configure.ac (Arbeitskopie) @@ -138,6 +138,7 @@ # AC_SEARCH_LIBS(clock_gettime, rt) AC_SEARCH_LIBS(pthread_create, pthread) +AC_SEARCH_LIBS(fabs, m) # # Prefer native kqueue(2); otherwise use libkqueue if present.

5 10

[PATCH] arc4random
by Mark Heily 19 Nov '09

19 Nov '09

Here's a patch I sent a couple days ago that may have been overlooked. Thanks, - Mark Index: configure.ac =================================================================== --- configure.ac (revision 166) +++ configure.ac (working copy) @@ -191,7 +191,7 @@ AC_CHECK_DECLS([FD_COPY], [], [], [[#include <sys/select.h>]]) AC_CHECK_DECLS([SIGEMT], [], [], [[#include <signal.h>]]) AC_CHECK_DECLS([VQ_UPDATE, VQ_VERYLOWDISK], [], [], [[#include <sys/mount.h>]]) -AC_CHECK_FUNCS([pthread_key_init_np pthread_main_np mach_absolute_time malloc_create_zone sysconf]) +AC_CHECK_FUNCS([pthread_key_init_np pthread_main_np mach_absolute_time malloc_create_zone sysconf arc4random]) AC_CHECK_DECLS([POSIX_SPAWN_START_SUSPENDED], [have_posix_spawn_start_suspended=true], Index: testing/queue_finalizer.c =================================================================== --- testing/queue_finalizer.c (revision 166) +++ testing/queue_finalizer.c (working copy) @@ -32,6 +32,35 @@ void *ctxt_magic; +/* +* Based on ISC BIND lib/isc/random.c +*/ +#ifndef HAVE_ARC4RANDOM +static uint32_t +arc4random(void) +{ + unsigned int pid; + static int arc4random_init; + + /* + * The low bits of pid generally change faster. + * Xor them with the high bits of time which change slowly. + */ + if (!arc4random_init) { + pid = getpid(); + pid = ((pid << 16) & 0xffff0000) | ((pid >> 16) & 0xffff); + srand(time(NULL) ^ pid); + arc4random_init = 1; + } + + /* + * rand()'s lower bits are not random. + * rand()'s upper bit is zero. + */ + return ((rand() >> 4) & 0xffff) | ((rand() << 12) & 0xffff0000); +} +#endif /* ! HAVE_ARC4RANDOM */ + static void finalizer(void *ctxt) {

7 6

Solaris portability, dispatch.h - PATCH [4/6]
by Joakim Johansson 19 Nov '09

19 Nov '09

Added the checking for cdefs.h that does not exist on all platforms, also added the __BEGIN_DECLS here as they are usually from cdefs.h and are not available on Solaris. Perhaps this should be broken out to a DISPATCH_SHIMS_CDEFS instead? Joakim octo.tbricks.com:gcd/trunk/dispatch> svn diff Index: dispatch.h =================================================================== --- dispatch.h (revision 140) +++ dispatch.h (working copy) @@ -25,7 +25,20 @@ #include <Availability.h> #include <TargetConditionals.h> #endif +#if HAVE_SYS_CDEFS_H #include <sys/cdefs.h> +#endif + +#ifndef __BEGIN_DECLS +# if defined(__cplusplus) +# define __BEGIN_DECLS extern "C" { +# define __END_DECLS }; +# else /* __BEGIN_DECLS */ +# define __BEGIN_DECLS +# define __END_DECLS +# endif /* __BEGIN_DECLS */ +#endif /* __BEGIN_DECLS */ + #include <stddef.h> #include <stdint.h> #include <stdbool.h>

5 11

State of the Linux port (with blocks support)
by Mario Schwalbe 19 Nov '09

19 Nov '09

Hi, this time I compiled with LLVM/GCC 4.2.1. Here are the brief results: dispatch_api: pass dispatch_c99: pass dispatch_cascade: pass dispatch_debug: pass dispatch_priority: fail dispatch_priority2: fail dispatch_starfish: fail, spins forever queue_finalizer: pass dispatch_after: fail, spins forever dispatch_apply: pass dispatch_drift: fail, spins forever dispatch_group: pass dispatch_pingpong: pass dispatch_read: fail, spins forever dispatch_readsync: pass dispatch_sema: pass dispatch_timer_bit31: fail, spins forever dispatch_timer_bit63: fail, spins forever dispatch_plusplus: pass Hopefully, those tasks that don't terminate fail due to the same problem, so I'm going to investigate this issue further. ciao, Mario

2 1

[PATCH] missing kqueue libs in testing/Makefile.am
by Mario Schwalbe 19 Nov '09

19 Nov '09

Hi, added libkqueue library variable to testing/Makefile.am. ciao, Mario Index: testing/Makefile.am =================================================================== --- testing/Makefile.am (Revision 165) +++ testing/Makefile.am (Arbeitskopie) @@ -81,4 +81,5 @@ LDADD=libtest.la ../src/libdispatch.la CFLAGS=-Wall $(MARCH_FLAGS) $(CBLOCKS_FLAGS) CXXFLAGS=-Wall $(MARCH_FLAGS) $(CXXBLOCKS_FLAGS) +LIBS=$(KQUEUE_LIBS)

5 12

[PATCH] use libkqueue if sys/event.h is missing
by Mark Heily 18 Nov '09

18 Nov '09

Here is a patch that enables libdispatch to use libkqueue on platforms that do not support kqueue(2). I have made pretty good progress with libkqueue and the current sources are here: http://mark.heily.com/src/libkqueue/ diff -ru -x .svn ./configure.ac ../trunk.NEW/configure.ac --- ./configure.ac 2009-10-18 20:59:34.000000000 -0400 +++ ../trunk.NEW/configure.ac 2009-10-18 20:55:29.000000000 -0400 @@ -170,6 +170,17 @@ ) # +# Use either libkqueue or the native kqueue(2) system calls +# +AC_CHECK_HEADER([sys/event.h], + [use_libkqueue=false], + [AC_CHECK_HEADER([kqueue/sys/event.h], + use_libkqueue=true, + AC_MSG_ERROR("sys/event.h not found"))] +) +AM_CONDITIONAL(USE_LIBKQUEUE, $use_libkqueue) + +# # Find functions and declarations we care about. # AC_CHECK_DECLS([CLOCK_UPTIME, CLOCK_MONOTONIC], [], [], diff -ru -x .svn ./src/Makefile.am ../trunk.NEW/src/Makefile.am --- ./src/Makefile.am 2009-10-18 20:59:34.000000000 -0400 +++ ../trunk.NEW/src/Makefile.am 2009-10-18 21:03:54.000000000 -0400 @@ -16,6 +16,7 @@ time.c libdispatch_la_CFLAGS=-Wall +libdispatch_la_LIBADD= INCLUDES=-I$(top_builddir) -I$(top_srcdir) \ @APPLE_LIBC_SOURCE_PATH@ @APPLE_XNU_SOURCE_PATH@ @@ -27,7 +28,12 @@ endif if USE_LIBPTHREAD -libdispatch_la_LIBADD=-lpthread +libdispatch_la_LIBADD+= -lpthread +endif + +if USE_LIBKQUEUE +libdispatch_la_LIBADD+= -lkqueue +libdispatch_la_CFLAGS+= -I/usr/include/kqueue endif if USE_MIG

5 22

[PATCH 4/4]
by Mario Schwalbe 18 Nov '09

18 Nov '09

Hi, Standard versions of GCC don't define __unused. And LLVM/GCC doesn't define __block anymore. I don't know whether it is right to put it in testing/dispatch_test.h, but it at least affects all test applications at once. Together with the other patches I sent the last days, this is everything required to compile and use libdispatch on Linux (with the exception of queue_finalizer due to arc4random). ciao, Mario Index: testing/dispatch_test.h =================================================================== --- testing/dispatch_test.h (Revision 171) +++ testing/dispatch_test.h (Arbeitskopie) @@ -1,5 +1,18 @@ #include <errno.h> +/* standard GCC and LLVM/GCC don't define __unused by default */ +#ifndef __unused + #define __unused __attribute__((__unused__)) +#endif + +/* standard LLVM/GCC doesn't define __block by default, because + * used as a parameter name in include/c++/4.2.1/ext/mt_allocator.h as well */ +#if __BLOCKS__ + #ifndef __block + #define __block __attribute__((__blocks__(byref))) + #endif +#endif + __BEGIN_DECLS void test_start(const char* desc);

1 0

[PATCH 3/4] add blocks headers to libshims
by Mario Schwalbe 18 Nov '09

18 Nov '09

Hi, libshims also needs the blocks headers in order to compile. ciao, Mario Index: src/Makefile.am =================================================================== --- src/Makefile.am (Revision 171) +++ src/Makefile.am (Arbeitskopie) @@ -26,6 +26,7 @@ @APPLE_LIBC_SOURCE_PATH@ @APPLE_XNU_SOURCE_PATH@ libdispatch_la_CFLAGS+=$(MARCH_FLAGS) $(CBLOCKS_FLAGS) $(KQUEUE_CFLAGS) +libshims_la_CFLAGS=$(CBLOCKS_FLAGS) if USE_LEGACY_API libdispatch_la_SOURCES+= \

1 0