- libdispatch-dev - lists.macosforge.org

[PATCH 4/4] do not use strlcpy
by Paolo Bonzini 10 Nov '09

10 Nov '09

--- src/source.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/source.c b/src/source.c index 01061a4..95c9b5d 100644 --- a/src/source.c +++ b/src/source.c @@ -391,6 +391,7 @@ dispatch_source_create(dispatch_source_type_t type, dispatch_queue_t q) { dispatch_source_t ds = NULL; + static char source_label[sizeof ds->dq_label] = "source"; // input validation if (type == NULL || (mask & ~type->mask)) { @@ -404,7 +405,7 @@ dispatch_source_create(dispatch_source_type_t type, // Initialize as a queue first, then override some settings below. _dispatch_queue_init((dispatch_queue_t)ds); - strlcpy(ds->dq_label, "source", sizeof(ds->dq_label)); + memcpy(ds->dq_label, source_label, sizeof source_label); // Dispatch Object ds->do_vtable = &_dispatch_source_kevent_vtable; -- 1.6.2.5

1 0

Best practice for building libdispatch for verification on SL?
by Joakim Johansson 09 Nov '09

09 Nov '09

What would be the best practice for building on a "clean" 10.6 system for verification of patches/builds ? Just naively hitting "build" in Xcode for the libdispatch target gives me 969 errors and a failed build, I am probably missing something obvious here... Any pointers? Joakim

1 1

Solaris portability
by Joakim Johansson 07 Nov '09

07 Nov '09

I am working a bit on a Solaris port and will provide a few patches, looking forward to house-style comments etc. One thought I played with, was to build libdispatch without support for event sources (except perhaps for timers), would that be something that would seem useful to others on the list (it would be analogous to disabling the support for blocks on platforms not supporting it). It could help in initial portability to platforms without kqueue support. I'm sure there are some issues with disabling it that I'm not aware of, any pointers are appreciated. Joakim

3 5

Solaris portability, POSIX memalign checking in configure.ac - PATCH [1/6]
by Joakim Johansson 06 Nov '09

06 Nov '09

Need to check whether posix_memalign exists on the target system (there is a patch for a future Solaris version to add it, so I'd rather not check for the Solaris platform, but rather for feature existence). Still a lot of work remains for a working Solaris port due to the kqueue stuff, but here are some initial patches. Joakim ----------------------------------------------- > svn diff configure.ac Index: configure.ac =================================================================== --- configure.ac (revision 140) +++ configure.ac (working copy) @@ -184,7 +198,7 @@ AC_CHECK_DECLS([FD_COPY], [], [], [[#include <sys/select.h>]]) AC_CHECK_DECLS([SIGEMT], [], [], [[#include <signal.h>]]) AC_CHECK_DECLS([VQ_UPDATE, VQ_VERYLOWDISK], [], [], [[#include <sys/ mount.h>]]) -AC_CHECK_FUNCS([pthread_key_init_np pthread_main_np mach_absolute_time malloc_create_zone]) +AC_CHECK_FUNCS([pthread_key_init_np pthread_main_np mach_absolute_time malloc_create_zone sem_init posix_memalign]) AC_CHECK_DECLS([POSIX_SPAWN_START_SUSPENDED], [have_posix_spawn_start_suspended=true],

3 2

Solaris portability, dispatch.h - PATCH [5/6]
by Joakim Johansson 06 Nov '09

06 Nov '09

Checking for sys/cdefs.h again... Joakim > svn diff private.h Index: private.h =================================================================== --- private.h (revision 140) +++ private.h (working copy) @@ -33,7 +33,9 @@ #include <mach/message.h> #endif #include <unistd.h> +#if HAVE_SYS_CDEFS_H #include <sys/cdefs.h> +#endif #include <pthread.h> #ifndef __DISPATCH_BUILDING_DISPATCH__

1 0

Solaris portability, POSIX memalign() missing - PATCH [2/6]
by Joakim Johansson 06 Nov '09

06 Nov '09

Use memalign() instead... Joakim > svn diff malloc_zone.h Index: malloc_zone.h =================================================================== --- malloc_zone.h (revision 140) +++ malloc_zone.h (working copy) @@ -80,14 +80,28 @@ return (realloc(ptr, size)); } +/* posix_memalign is not supported with the current shipping release of Solaris 10, it is + fixed in the latest available Solaris Nevada (next-gen) distribution though, see: + + http://bugs.opensolaris.org/bugdatabase/view_bug.do;jsessionid=3af20a8d00f3… + + Falling back at using memalign() here as is done by Sun in the implementation at: + http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port… + */ + static inline void * malloc_zone_memalign(malloc_zone_t *zone, size_t alignment, size_t size) { +#ifdef HAS_POSIX_MEMALIGN void *ptr; if (posix_memalign(&ptr, alignment, size) < 0) return (NULL); + return (ptr); +#else + return memalign(alignment, size); +#endif } static inline void octo.tbricks.com:trunk/src/shims>

1 0

minor libkqueue fix
by Mario Schwalbe 06 Nov '09

06 Nov '09

Hi Mark, while working with libdispatch and libkqueue on Linux, I discovered some minor issues. Could you please commit the attached patch for those who like to: (a) reconfigure libkqueue sometimes (b) do not have test.o around (c) install to a non-standard prefix thanks & ciao, Mario Schwalbe diff -urp foo/src/libkqueue/configure diplom/src/libkqueue/configure --- foo/src/libkqueue/configure 2009-11-05 13:43:37.695235346 +0100 +++ diplom/src/libkqueue/configure 2009-11-03 18:12:21.581371724 +0100 @@ -65,15 +65,15 @@ finalize mandir "${prefix}/share/man echo "Checking operating system type... $target" rm -f socket.c vnode.c signal.c timer.c user.c if [ $target = "linux" ] ; then - check_header sys/epoll.h && ln -s os/linux/socket.c \ - || ln -s os/posix/socket.c - check_header sys/inotify.h && ln -s os/linux/vnode.c \ - || ln -s os/posix/vnode.c - check_header sys/signalfd.h && ln -s os/linux/signal.c \ - || ln -s os/posix/signal.c - check_header sys/timerfd.h && ln -s os/linux/timer.c \ - || ln -s os/posix/timer.c - ln -s os/posix/user.c + check_header sys/epoll.h && ln -sf os/linux/socket.c \ + || ln -sf os/posix/socket.c + check_header sys/inotify.h && ln -sf os/linux/vnode.c \ + || ln -sf os/posix/vnode.c + check_header sys/signalfd.h && ln -sf os/linux/signal.c \ + || ln -sf os/posix/signal.c + check_header sys/timerfd.h && ln -sf os/linux/timer.c \ + || ln -sf os/posix/timer.c + ln -sf os/posix/user.c fi echo "Creating config.h" diff -urp foo/src/libkqueue/Makefile diplom/src/libkqueue/Makefile --- foo/src/libkqueue/Makefile 2009-11-05 13:43:37.705236408 +0100 +++ diplom/src/libkqueue/Makefile 2009-11-05 13:23:21.312802794 +0100 @@ -24,13 +24,14 @@ include config.mk build: gcc $(CFLAGS) -c *.c - rm test.o + -rm test.o ar rcs libkqueue.a *.o gcc -shared -Wl,-soname,libkqueue.so -o libkqueue.so *.o install: $(INSTALL) -d -m 755 $(INCLUDEDIR)/kqueue $(INSTALL) -d -m 755 $(INCLUDEDIR)/kqueue/sys + $(INSTALL) -d -m 755 $(LIBDIR)/pkgconfig $(INSTALL) -d -m 755 $(MANDIR)/man2 $(INSTALL) -m 644 sys/event.h $(INCLUDEDIR)/kqueue/sys/event.h $(INSTALL) -m 644 libkqueue.so $(LIBDIR)/libkqueue.so

2 2

libkqueue updates
by Mark Heily 06 Nov '09

06 Nov '09

A couple of quick updates about libkqueue: * Version 0.1 has been released. * Most of the problems with EVFILT_VNODE have been solved. * There is now a "stable" Subversion branch that will only contain release-quality code. * There are now two libkqueue mailing lists: one for announcements, and one for general discussion. For more details, see the libkqueue web page at: http://mark.heily.com/libkqueue/ Cheers, - Mark

1 0

testing tree now ported/automaked and committed
by Robert Watson 05 Nov '09

05 Nov '09

Dear all: Yesterday I committed an adaptation of the testing tree to the autoconf/automake build system. Most tests now run on FreeBSD, and often report success. Here's a quick summary: OK: dispatch_api dispatch_apply dispatch_c99 * But that is not the point of this test dispatch_debug dispatch_group dispatch_pingpong dispatch_read dispatch_sema dispatch_timer_bit31 Mixed success: dispatch_after * Occasionally one or two fail dispatch_drift * Jitter fails, drift passes dispatch_starfish * Latency requirements not always met Pass, but no 'leaks' testing on non-Mac OS X: dispatch_cascade dispatch_readsync dispatch_timer_bit63 Failure: dispatch_priority * Blocks complete but fails precedence test Doesn't yet run on FreeBSD: dispatch_cffd * No Core Foundation on FreeBSD dispatch_cpp * No working C++ compiler with blocks off Mac OS X dispatch_timer_set_time * Requires legacy API I've left the original Darwin Makefile as Makefile.darwin, as it contains better runtime packaging and summarization, as well as knowing about lipo on Mac OS X. Some of this packaging should make it into the portable makefiles in the future. I plan to spend time investigating dispatch_priority today. Poor latency/jitter in some tests may be a result of my using a VM for testing, which I'll also investigate, but could also be a property of timer resolution, an off-by-one error in how wakeups are calculated (perhaps by the POSIX semaphore/kqueue code on FreeBSD?) but we'll see. I also ommitted some fixes to the POSIX semaphore code in libdispatch; I had some of the timeout calculation and handling wrong. One important semantic difference between Mach and POSIX semaphores is that their timed wait primitives take different time scales: Mach accepts a relative timeout, and POSIX and absolute timeout. There are arguments for/against both approaches, but I was pondering adding a non-portable POSIX semaphore extension to FreeBSD supporting relative timeouts to avoid additional clock reads to convert between the two bases. Robert N M Watson Computer Laboratory University of Cambridge

3 4

autoconf HAVE macro conventions
by Kevin Van Vechten 02 Nov '09

02 Nov '09

I'm not very familiar with autoconf conventions and was wondering why some config.h values are merely defined and some are explicitly defined to 1. Is there a strong convention to do #ifdef HAVE_FOO instead of #if HAVE_FOO when testing for configure features? For various reasons, the ability to define a macro to 0 or 1 would be useful for the Mac OS X version of config.h — it would let us define certain features in terms of other features without as much conditional logic. Kevin

4 11