Revision
138981
Author
ijackson@macports.org
Date
2015-07-26 03:37:19 -0700 (Sun, 26 Jul 2015)

Log Message

Fix libsolv search: Blame r138807.
Move 'return $pool' outside the if {![info exists pool]} block.
Accidentally moved it inside the if block while setting up
installed repo.
Update Comment headers: Add To-Do tasks. Move completed tasks
to Done list.

Modified Paths

Diff

Modified: branches/gsoc15-dependency/base/src/macports1.0/macports_libsolv.tcl (138980 => 138981)


--- branches/gsoc15-dependency/base/src/macports1.0/macports_libsolv.tcl	2015-07-26 04:35:24 UTC (rev 138980)
+++ branches/gsoc15-dependency/base/src/macports1.0/macports_libsolv.tcl	2015-07-26 10:37:19 UTC (rev 138981)
@@ -62,10 +62,14 @@
     ## Procedure to create the libsolv pool. This is similar to PortIndex. \
     #  Read the PortIndex contents and write into libsolv readable solv's.
     #  To Do:
-    #  Add additional information regarding arch, vendor, dependency, etc to solv.
+    #  Add additional information regarding arch, vendor, etc to solv.
+    #  Add obsoletes information to solv by parsing the replaced_by field in PortIndex. \
+    #  They mean the converse of each other, hence cannot assign them directly.
     #  Done:
     #  Add epoch, version and revision to each solv.
     #  Add more info to solv about its description, long_description, license, category and homepage.
+    #  Add dependency information to each solv.
+    #  Create a repo of installed packages for dependency calculation and Transaction summary.
     proc create_pool {} {
         variable pool
         variable portindexinfo
@@ -129,7 +133,6 @@
                             } else {
                                 set solvable [$repo add_solvable]
                             }
-                            # set solvable [$repo add_solvable]
 
                             $solvable configure -name $name \
                             -evr "$portinfo(epoch)@$portinfo(version)-$portinfo(revision)" \
@@ -192,8 +195,8 @@
             #  This method is necessary before we can run any lookups on provides.
             $pool createwhatprovides
     
-            return $pool
         }
+        return $pool
     }
 
     ## Search using libsolv. Needs some more work.