[148902] trunk/dports/graphics/inkscape/Portfile
Revision: 148902 https://trac.macports.org/changeset/148902 Author: jeremyhu@macports.org Date: 2016-05-22 10:03:16 -0700 (Sun, 22 May 2016) Log Message: ----------- inkscape: Revert hack from #51287 If enchant tickles a bug in one of its variants on Mountain Lion, then a workaround should be added to enchant, not inkscape. Modified Paths: -------------- trunk/dports/graphics/inkscape/Portfile Modified: trunk/dports/graphics/inkscape/Portfile =================================================================== --- trunk/dports/graphics/inkscape/Portfile 2016-05-22 16:09:11 UTC (rev 148901) +++ trunk/dports/graphics/inkscape/Portfile 2016-05-22 17:03:16 UTC (rev 148902) @@ -2,12 +2,11 @@ # $Id$ PortSystem 1.0 -PortGroup active_variants 1.1 name inkscape conflicts inkscape-devel version 0.91 -revision 15 +revision 14 license GPL-2 LGPL-2.1 maintainers devans categories graphics gnome @@ -47,23 +46,10 @@ port:libexif \ port:libvisio-0.1 \ port:libwpg-0.3 \ + port:gtkspell2 \ port:py27-lxml \ port:py27-numpy -# spell checking dependencies -# require enchant +aspell -applespell -# this breaks inkscape default build because -# enchant +aspell is not the default -# https://trac.macports.org/ticket/51287 - -depends_lib-append port:aspell \ - port:enchant \ - port:gtkspell2 - -require_active_variants enchant aspell applespell - -depends_run port:gnome-themes-standard - post-patch { xinstall -m 755 ${filespath}/autogen.sh ${worksrcpath} reinplace "s|\"python-interpreter\", \"python\"|\"python-interpreter\", \"python2.7\"|g" ${worksrcpath}/src/extension/implementation/script.cpp
On 5/22/16 10:03 AM, jeremyhu@macports.org wrote:
Revision 148902 <https://trac.macports.org/changeset/148902> Author jeremyhu@macports.org Date 2016-05-22 10:03:16 -0700 (Sun, 22 May 2016)
Log Message
inkscape: Revert hack from #51287
If enchant tickles a bug in one of its variants on Mountain Lion, then a workaround should be added to enchant, not inkscape.
I believe there is a mis-understanding here. Even though inkscape uses enchant it requires that the enchant backend be aspell to work correctly and in some code bypasses enchat to access aspell directly. Inkscape checks for aspell and will disable the spell checking functionality if it is not present. This applies to all platforms. Thus the need exists to check for enchant +aspell. The problem with 10.8 is that enchant fails on backend initialization (in the applespell code) if +applespell is enabled. This issue does not occur on 10.9+ but if +aspell is asserted then +applespell is moot because aspell has higher priority in enchant. This is where the check for -applespell comes in. The +applespell issue has not been checked on platforms earlier than 10.8 to my knowledge and so I'm not sure whether this is unique to 10.8. I suggested that the default variants for enchant be +aspell only so that the inkscape default build would succeed in all cases but mcalhoun is resistent to this idea. He believes that +applespell is a more natural default for darwin platforms. Because of this, I believe the variant checks on enchant are valid in inkscape. Hope this clarifies the issue. Dave
participants (2)
-
David Evans
-
jeremyhu＠macports.org