Revision: 139459 https://trac.macports.org/changeset/139459 Author: cal@macports.org Date: 2015-08-17 15:34:24 -0700 (Mon, 17 Aug 2015) Log Message: ----------- guide: clarify what to do when taking over maintainership *and* fixing bugs Modified Paths: -------------- trunk/doc-new/guide/xml/project.xml Modified: trunk/doc-new/guide/xml/project.xml =================================================================== --- trunk/doc-new/guide/xml/project.xml 2015-08-17 21:15:11 UTC (rev 139458) +++ trunk/doc-new/guide/xml/project.xml 2015-08-17 22:34:24 UTC (rev 139459) @@ -649,18 +649,30 @@ </listitem> <listitem> - <para>Now, <ulink url="https://trac.macports.org/newticket">file - a new ticket in Trac</ulink>. Set <guilabel>type</guilabel> to - <guilabel>enhancement</guilabel> if you only changed the maintainer - and an appropriate other type if you also fixed a bug or enhanced - or updated the port. Leave the <guilabel>milestone</guilabel> field - empty. If you added yourself as co-maintainer, add the other - maintainers in the <guilabel>Cc</guilabel> field. Finally, fill in - the <guilabel>port</guilabel> field, set - <guilabel>keywords</guilabel> to <userinput>haspatch</userinput> - (because you are attaching a patch), check the box that you want to - attach files to the ticket and submit. After submission, attach the - patch you created in the previous step.</para> + <para>If you are only changing the maintainer, <ulink + url="https://trac.macports.org/newticket">file a new ticket in + Trac</ulink>. Set <guilabel>type</guilabel> to + <guilabel>enhancement</guilabel>. Leave the + <guilabel>milestone</guilabel> field empty. If you added yourself + as co-maintainer, add the other maintainers in the + <guilabel>Cc</guilabel> field. Finally, fill in the + <guilabel>port</guilabel> field, set <guilabel>keywords</guilabel> + to <userinput>haspatch</userinput> (because you are attaching + a patch), check the box that you want to attach files to the ticket + and submit. After submission, attach the patch you created in the + previous step.</para> + + <para>If you are also fixing a bug, attach a separate patch for that + change to the same ticket. If you are fixing a bug that already has + a ticket, attach a patch fixing the bug there and file the + maintainer change in a separate ticket (with a separate patch) as + discussed above. In general, please create a separate patch for + each semantic change. Doing so enables each independent change to + be accepted without worries about conflicts that sometimes arise + when several changes are rolled into one patch and simplifies + reviewing. Do not worry that you cannot change the + <guilabel>keywords</guilabel> to <userinput>haspatch</userinput> on + existing tickets.</para> </listitem> <listitem>