On Dec 7, 2007, at 1:38 PM, Juan Manuel Palacios wrote: (snip)
I believe that anyone savvy enough to change his/her shell to zsh is also savvy enough to manually adapt his/her environment as needed.
(snip) In my r31818 edit to the postflight script in the release_1_6 brach I removed the globs that would match all C based shells and all bourne based shells, limiting our targets to only tcsh and bash specifically (again, we're only aiming to adapt for MacPorts a default OS installation).
Also, it's a bad idea to modify $MANPATH as this may break things in particular if the user usually has an empty $MANPATH (in which case the man path is automatically built from $PATH -- this is much better to get consistent paths).
Adding our setting to MANPATH *only-if-it-already-exists* *and* if we're not already in there was agreed here to be the "lesser evil" for the time being, so that's what we're doing. If MANPATH does not exist at all (different from existing but being empty, or otherwise not containing our path), we don't add anything there and instead let alternative methods to their work (manpath(1), path_helper(8), whatever). If MANPATH exists (thus probably overriding the work of those alternate methods), and does not contain our path, then (and only then) we add it. If I'm not mistaken, having an *existing* MANPATH variable that does not contain our path is precisely the situation that breaks our man pages and what we're trying to remedy.
I haven't received any more feedback for this particular part of the script, so I'm going to (hopefully not wrongfully) assume that what we are doing now is indeed the lesser evil. Please speak up before it is too late if there is indeed something better we could do to fix the manpath situation. As for the rest before I finally release 1.6.0, I'm only concerned about http://trac.macosforge.org/projects/macports/ticket/ 13436#comment:5 Markus, IIRC prebinding does have its benefits on the Panther platform, so why not keep it there through a simple `if` statement? Or do we *also* want to remove all traces of prebinding for panther users? We could use something as simple as Kevin's "set os_major [lindex [split $tcl_platform(osVersion) .] 0]" for the $os.major variable in port1.0 to determine if we're on Darwin 7. Regards,... -jmpp