There is no detriment that I can discern by naming patchfiles "patch- *.diff" as port lint recommends. There is a detriment by not following this convention which has been discussed at length before on the list. This warning has been in port lint for quite some time already. It's just now been made an automated email. On Feb 6, 2008, at 13:45, Landon Fuller wrote:
So I just received the following automated e-mail. While I think automated portlint is great, I'm wondering why we need a new ".diff" Official Policy just to appease certain people's editors.
Begin forwarded message:
From: noreply@macports.org Date: February 6, 2008 05:17:47 PST To: landonf@macports.org Subject: [MacPorts Lint] Portfile Lint Errors for: dpkg
Portfile: dpkg
Errors: Warning: Line 4 should be a newline (after PortSystem) Warning: Line 33 has trailing whitespace before newline Warning: Patchfile patch-config.h.in does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-configure does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-configure.in does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-lib_utils.c does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-lib_tarfn.c does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-main_remove.c does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-utils_Makefile.in does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-main_archives.c does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-archtable does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-include_parsedump.h does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile patch-utils_start-stop-daemon.c does not follow the source patch naming policy "patch-*.diff" Warning: Patchfile bsd/patch-main_help.c does not follow the source patch naming policy "patch-*.diff"
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev