On Jul 16, 2007, at 20:03, Chris Pickel wrote:
Hi all,
12309 [1] - Currently we use sed to do some replacement in port, portindex, and portmirror. I think autoconf is better suited to this.
Using make for this purpose ensures that the scripts are re-built when their source is updated. See: http://www.gnu.org/software/autoconf/manual/autoconf-2.57/html_mono/ autoconf.html#SEC24
12310 [2] - Right now we detect some libraries (curl, readline, etc.) and then we link them all into every dylib we compile. This patch slims it down so that decisions can be made separately for each dylib.
Looks good to me, although CFLAGS should probably be broken out too
12311 [3] - On the same note as my previous post to -dev about macports_fastload.tcl. This is a fix for the version comparison problem.
Paul should comment on this one.
12312 [4] - Several manpages reference paths according to variables, rather than giving the actual path; we can do the latter and that's more helpful to users.
Sweet, although I think this should still be done with Makefile substitution, as per above =) -landonf
[1] http://trac.macports.org/projects/macports/ticket/12309 [2] http://trac.macports.org/projects/macports/ticket/12310 [3] http://trac.macports.org/projects/macports/ticket/12311 [4] http://trac.macports.org/projects/macports/ticket/12312
The only one I have a strong attachment to is 12310, but I feel the others are improvements too.