Le 11 oct. 07 à 22:00, Ryan Schmidt a écrit :
On Oct 11, 2007, at 08:36, source_changes@macosforge.org wrote:
Revision: 29835 http://trac.macosforge.org/projects/macports/changeset/ 29835 Author: nox@macports.org Date: 2007-10-11 06:36:52 -0700 (Thu, 11 Oct 2007)
Log Message: ----------- py25-libxml2: * Changed docdir name into a versioned one. * Changed homepage to something more relevant. * libxslt is now directly disabled in setup.py, no more hazardous file delete calls.
You've replaced what looks like some simple code in the portfile to delete unwanted files.... with a whole bunch of Python code that will have to be maintained going forward. Is that really better? What was so hazardous about the "file delete" calls? Or is this Python code something that has been submitted upstream? That would be better since then we wouldn't have to maintain it.
The patch is awfully simple to maintain, just remove the part that enable xslt support. I've changed the disable method because with "file delete", you end up with /opt/local/lib/python2.5/site-packages/libxml2mod.so linking to libxslt, which should not. You can always say i'm obviously dumb of not having stated it in the commit log ;) Regards, PS: Could you tell me how to use the revprop thing? -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org