On 02.09.2007, at 21:43, Juan Manuel Palacios wrote:
Hey Mark!
Of all of the edits you made in this commit, the ones I left quoted below present somewhat of a puzzle: does the "configure.cppflags" env variable really need the "-L${prefix}/lib" linking argument? It's present in all of them.
honestly I have no idea. But the original author probably had a reason to do so and I did not test if it worked without. I only transformed the 'configure.env' statements to configure.whatever ones. Regards, -Markus
On Sep 2, 2007, at 1:01 PM, source_changes@macosforge.org wrote:
Modified: trunk/dports/x11/Terminal/Portfile (28498 => 28499) --- trunk/dports/x11/Terminal/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/Terminal/Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -16,4 +16,4 @@ depends_lib lib:libexo-0.3:libexo lib:libvte:vte patchfiles patch-terminal- Makefile.in configure.args --mandir=${prefix}/share/man - configure.env CPPFLAGS="-L${prefix}/lib -I${prefix}/include" +configure.cppflags-append "-L${prefix}/lib" Modified: trunk/dports/x11/blt/Portfile (28498 => 28499) --- trunk/ dports/x11/blt/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/blt/Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -21,9 +21,8 @@ port:tcl \ port:tk -configure.env CPPFLAGS="-L$ {prefix}/lib" \ - CFLAGS="-O3 -fno-common" \ - LDFLAGS="-L$ {prefix}/lib" +configure.cppflags "-L${prefix}/lib" +configure.cflags "-O3 -fno-common" configure.args --prefix=$ {prefix} \ --exec_prefix=${prefix} \ Modified: trunk/dports/x11/dlume/Portfile (28498 => 28499) --- trunk/dports/x11/dlume/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/dlume/Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -15,8 +15,8 @@ checksums md5 6b2a3ef0eff622a412395187d1c5d178 depends_lib lib:gtk.2:gtk2 lib:libxml2:libxml2 configure.args --mandir=${prefix}/share/man - configure.env CPPFLAGS="-I${prefix}/include -L${prefix}/lib" \ - CFLAGS="-no-cpp-precomp -flat_namespace -undefined suppress" +configure.cppflags-append "-L${prefix}/lib" +configure.cflags "- no-cpp-precomp -flat_namespace -undefined suppress" post-configure { reinplace "s|-export-dynamic||g" ${worksrcpath}/Makefile Modified: trunk/dports/x11/gtk-smooth-engine/Portfile (28498 => 28499) --- trunk/dports/x11/gtk-smooth-engine/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/gtk-smooth-engine/ Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -13,6 +13,5 @@ checksums md5 a2231118c8187649d1e634fdfe6f36de depends_lib lib:libX11.6:XFree86 lib:libglib.2:glib2 lib:libgtk.2:gtk2 configure.args --mandir=${prefix}/share/man --disable-gtk-1 - configure.env CPPFLAGS="-L${prefix}/lib -I${prefix}/include" \ - CFLAGS="-no-cpp-precomp -flat_namespace -undefined suppress" \ - LDFLAGS="-L${prefix}/lib" +configure.cppflags-append "-L${prefix}/ lib" +configure.cflags "-no-cpp-precomp -flat_namespace -undefined suppress" Modified: trunk/dports/x11/gtk-thinice-engine/Portfile (28498 => 28499) --- trunk/dports/x11/gtk-thinice-engine/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/gtk-thinice-engine/ Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -13,5 +13,5 @@ depends_lib lib:libX11.6:XFree86 lib:libglib.2:glib2 lib:libgtk. 2:gtk2 use_bzip2 yes configure.args --mandir=${prefix}/share/man - configure.env CPPFLAGS="-L${prefix}/lib -I${prefix}/include" \ - CFLAGS="-no-cpp-precomp -flat_namespace -undefined suppress" +configure.cppflags-append "-L${prefix}/lib" +configure.cflags "- no-cpp-precomp -flat_namespace -undefined suppress" Modified: trunk/dports/x11/gtk2-clearlooks/Portfile (28498 => 28499) --- trunk/dports/x11/gtk2-clearlooks/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/gtk2-clearlooks/ Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -14,7 +14,7 @@ distname clearlooks-${version} checksums md5 451ef33d1bffa261c5cbe01182199f97 configure.args --mandir=$ {prefix}/share/man -configure.env CPPFLAGS="-L${prefix}/lib -I$ {prefix}/include" \ - CFLAGS="-no-cpp-precomp -flat_namespace - undefined suppress" -depends_lib lib:libgtk.2:gtk2 +configure.cppflags-append "-L${prefix}/lib" +configure.cflags "- no-cpp-precomp -flat_namespace -undefined suppress" +depends_lib port:gtk2 use_bzip2 yes Modified: trunk/dports/x11/gtkspell2/Portfile (28498 => 28499) --- trunk/dports/x11/gtkspell2/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/gtkspell2/Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -14,11 +14,11 @@ master_sites $homepage/download distname gtkspell-${version} checksums md5 494869f67146a12a3f17a958f51aeb05 -depends_lib lib:libaspell:aspell \ - lib:gtk.2:gtk2 +depends_lib port:aspell \ + port:gtk2 configure.args --disable-debug -configure.env CPPFLAGS="-L$ {prefix}/lib -I${prefix}/include" \ - CFLAGS="-no-cpp-precomp - flat_namespace -undefined suppress" +configure.cppflags-append "-L$ {prefix}/lib" +configure.cflags "-no-cpp-precomp -flat_namespace - undefined suppress" #NOTES Port is named gtkspell2 due to ongoing development of gtkspell3 # Although there are no ports that require this port, there are a Modified: trunk/dports/x11/siag/Portfile (28498 => 28499) --- trunk/dports/x11/siag/Portfile 2007-09-02 16:36:37 UTC (rev 28498) +++ trunk/dports/x11/siag/Portfile 2007-09-02 17:01:00 UTC (rev 28499) @@ -15,8 +15,7 @@ checksums md5 bb7bb66dc9d3659fd11cdbac61ea6e13 depends_lib lib:libneXtaw:neXtaw lib:libMowitz:mowitz lib:libXawM.1:XawM patchfiles patch- oledecod.c patch-fileio_xls.c -configure.env CPPFLAGS="-L${prefix}/ lib -I${prefix}/include" \ - LDFLAGS="-L${prefix}/lib" +configure.cppflags-append "-L${prefix}/lib" pre-configure { reinplace "s|malloc.h|stdlib.h|g" \
--- Markus W. Weissmann http://www.mweissmann.de/