On 27/05/07, Ryan Schmidt <ryandesign@macports.org> wrote:
It looks like you've done at least three things in that diff:
1. you've changed the maintainer 2. you've added checksums 3. you've reformatted the entire portfile 4. maybe something else; hard to tell because of 3.
I don't like patches that do all these things at once. Especially whitespace/reformatting changes should be done by themselves, without any changes to the substance of the portfile, otherwise it's very difficult for others to later determine what substantial changes occurred in any given revision.
Thanks, I'll split up future patches.
I made you the maintainer and added the checksums in r25624:
http://trac.macosforge.org/projects/macports/changeset/25624
If you want to submit another patch that just reformats the port or just makes other substantive changes, I can commit that too.
Attached. Cheers Adam