On Apr 17, 2007, at 2:57 PM, Landon Fuller wrote:
On Apr 17, 2007, at 14:33, Ryan Schmidt wrote:
On Apr 17, 2007, at 16:19, Landon Fuller wrote:
I once said I would work on a pre-commit hook script we could install which would reject any commit that did not conform with these requirements. I haven't gotten around to that yet, but I haven't forgotten either.
If we're going to be nazis, can the pre-commit hook just set this stuff magically? Or can we stop being nazis about it?
The pre-commit hook can only verify the transaction and either accept or reject it; it cannot modify the transaction.
I think these are useful conventions to enforce, so I will work on a pre-commit hook to enforce this.
I'm apathetically opposed -- I don't care about $Id$ tags in my Portfiles, or native line breaks. If there was a way to do this automatically I'd be all in favor, but enforcement rubs me the wrong way.
I agree in general with Landon. But I do agree with Ryan that our committers should set the following in their subversion config:
To ensure that the correct properties automatically get set on your new Portfiles, you can edit your ~/.subversion/config file, turn auto-props on, and add this auto-prop definition:
Portfile = svn:eol-style=native;svn:keywords=Id
James