On Mar 3, 2007, at 1:48 AM, Randall Wood wrote:
Is this +no_startupitem variant really smart?
I recently had a request to add a +without_startupitem variant to a port I maintain and rejected the request; since startupitems simply enable a port to be started at boot time, but do not cause a port to be booted at start time, it simply seems stupid to deliberately cripple a server port such that a user would have to reinstall it if they wanted to start the port at boot time later.
BTW: If the variant is to be retained, can it be named +without_startupitem instead?
Unless I'm missing something, I see no reason whatsoever for the no_startupitem variant, or anything like it. Using the startup item strategy, we have two cases, systemstarter (pre tiger) and launchd (tiger++): SystemStarter: The code generated by port for system starter automatically looks for an enable flag from /etc/hostconfig, and this is -NO- by default. So by default the port won't be run. Launchd: Likewise, the launchd.plist file generated for a port is not enabled by default, so by default the server won't be run. The only reason I see for having a +server variant in some cases is if building the server is way too onerous (like perhaps in the case of mysql where somebody just wants to build the client but not the server). Still this is debatable. Okay, so what possible rationale did I miss? James
On 2 Mar 2007, at 16:51, source_changes@macosforge.org wrote:
Revision 22490 Author blair@macports.org Date 2007-03-02 13:51:15 -0800 (Fri, 02 Mar 2007) Log MessageAdd a +no_startupitem variant that prevents the automatic startup of the Apache web server.Modified Paths trunk/dports/www/apache2/Portfile Diff Modified: trunk/dports/www/apache2/Portfile (22489 => 22490)--- trunk/dports/www/apache2/Portfile 2007-03-02 20:42:45 UTC (rev 22489) +++ trunk/dports/www/apache2/Portfile 2007-03-02 21:51:15 UTC (rev 22490) @@ -105,6 +105,10 @@ configure.args-append --with- mpm=event } +variant no_startupitem { + startupitem.create no +} + startupitem.create yes startupitem.start \ "\[ -x ${prefix}/ apache2/bin/apachectl \] && ${prefix}/apache2/bin/apachectl start
/dev/null" @@ -112,4 +116,3 @@ "\[ -r ${prefix}/apache2/logs/ httpd.pid \] && ${prefix}/apache2/bin/apachectl stop > /dev/null" startupitem.restart \ "\[ -r ${prefix}/apache2/logs/httpd.pid \] && ${prefix}/apache2/bin/apachectl restart > /dev/null" -
macports-changes mailing list macports-changes@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-changes
Randall Wood rhwood@mac.com
"The rules are simple: The ball is round. The game lasts 90 minutes. All the rest is just philosophy."
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev