Re: [28197] trunk/dports/palm/hrsh2csv/Portfile
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 source_changes@macosforge.org wrote:
Revision: 28197 http://trac.macosforge.org/projects/macports/changeset/28197 Author: css@macports.org Date: 2007-08-24 06:18:36 -0700 (Fri, 24 Aug 2007)
Log Message: ----------- Create a powerpc platform variant that removes the endian conversion. This fixes hrsh2csv to function properly on Intel Macs. (#12555)
Modified Paths: -------------- trunk/dports/palm/hrsh2csv/Portfile
Modified: trunk/dports/palm/hrsh2csv/Portfile =================================================================== --- trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:17:34 UTC (rev 28196) +++ trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:18:36 UTC (rev 28197) @@ -3,6 +3,7 @@ PortSystem 1.0 name hrsh2csv version 1.3 +revision 1 description converts Hours pdb files into CSV text files long_description Hours is a time-tracking utility for the PalmOS. \ This utility converts Hours for PalmOS database files into \ @@ -16,8 +17,13 @@
use_configure no post-extract { - reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/Makefile reinplace "s|prefix = /usr/local|prefix = ${destroot}${prefix}|" ${worksrcpath}/Makefile } + +# For PowerPC, remove the endian conversion since PDBs are big endian. +platform powerpc { + reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/Makefile +} + destroot.args mandir=${destroot}${prefix}/share/man/man1
I don't know why, but it looks like macports is trying to execute the "reinplace" even if only something like "port info" is called on this file. So it should be moved to post-configure, but I don't know how this is done. Simon - -- + privacy is necessary + using http://gnupg.org + public key id: 0x6115F804EFB33229 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFG01NxYRX4BO+zMikRCj4+AJ92/BmROTF72bz0Yw51TOIz/F92tgCglGYc jmJ18xuIOgjb/YBGCBanxKQ= =W5uv -----END PGP SIGNATURE-----
Le 28 août 07 à 00:42, Simon Ruderich a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
source_changes@macosforge.org wrote:
Revision: 28197 http://trac.macosforge.org/projects/macports/changeset/ 28197 Author: css@macports.org Date: 2007-08-24 06:18:36 -0700 (Fri, 24 Aug 2007)
Log Message: ----------- Create a powerpc platform variant that removes the endian conversion. This fixes hrsh2csv to function properly on Intel Macs. (#12555)
Modified Paths: -------------- trunk/dports/palm/hrsh2csv/Portfile
Modified: trunk/dports/palm/hrsh2csv/Portfile =================================================================== --- trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:17:34 UTC (rev 28196) +++ trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:18:36 UTC (rev 28197) @@ -3,6 +3,7 @@ PortSystem 1.0 name hrsh2csv version 1.3 +revision 1 description converts Hours pdb files into CSV text files long_description Hours is a time-tracking utility for the PalmOS. \ This utility converts Hours for PalmOS database files into \ @@ -16,8 +17,13 @@
use_configure no post-extract { - reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/ Makefile reinplace "s|prefix = /usr/local|prefix = ${destroot}${prefix}|" ${worksrcpath}/Makefile } + +# For PowerPC, remove the endian conversion since PDBs are big endian. +platform powerpc { + reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/ Makefile +} + destroot.args mandir=${destroot}${prefix}/share/man/man1
I don't know why, but it looks like macports is trying to execute the "reinplace" even if only something like "port info" is called on this file. So it should be moved to post-configure, but I don't know how this is done.
Simon
The reinplace call should be in a post-patch block. -- Anthony Ramine, the infamous MacPorts Trac slave. nox@macports.org
On Aug 27, 2007, at 7:09 PM, N_Ox wrote:
The reinplace call should be in a post-patch block.
No one had any feedback for this for several days already so I just jumped in and moved the reinplace call to a post-extract block, mimicking what the main body of the Portfile does. Sad to say... but breaking stuff is a sure way to get feedback ;-) We'll surely know if my edit breaks anything. -jmpp
On Aug 27, 2007, at 18:09, N_Ox wrote:
Le 28 août 07 à 00:42, Simon Ruderich a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
source_changes@macosforge.org wrote:
Revision: 28197 http://trac.macosforge.org/projects/macports/changeset/ 28197 Author: css@macports.org Date: 2007-08-24 06:18:36 -0700 (Fri, 24 Aug 2007)
Log Message: ----------- Create a powerpc platform variant that removes the endian conversion. This fixes hrsh2csv to function properly on Intel Macs. (#12555)
Modified Paths: -------------- trunk/dports/palm/hrsh2csv/Portfile
Modified: trunk/dports/palm/hrsh2csv/Portfile =================================================================== --- trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:17:34 UTC (rev 28196) +++ trunk/dports/palm/hrsh2csv/Portfile 2007-08-24 13:18:36 UTC (rev 28197) @@ -3,6 +3,7 @@ PortSystem 1.0 name hrsh2csv version 1.3 +revision 1 description converts Hours pdb files into CSV text files long_description Hours is a time-tracking utility for the PalmOS. \ This utility converts Hours for PalmOS database files into \ @@ -16,8 +17,13 @@
use_configure no post-extract { - reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/ Makefile reinplace "s|prefix = /usr/local|prefix = ${destroot}$ {prefix}|" ${worksrcpath}/Makefile } + +# For PowerPC, remove the endian conversion since PDBs are big endian. +platform powerpc { + reinplace "s|-O2 -D__MAC2PC_CONVERSION__|-O2|" ${worksrcpath}/ Makefile +} + destroot.args mandir=${destroot}${prefix}/share/man/man1
I don't know why, but it looks like macports is trying to execute the "reinplace" even if only something like "port info" is called on this file. So it should be moved to post-configure, but I don't know how this is done.
Simon
The reinplace call should be in a post-patch block.
We discussed this a couple days ago on the list and there was info in the bug about it: http://trac.macosforge.org/projects/macports/ticket/12555
participants (4)
-
Juan Manuel Palacios
-
N_Ox
-
Ryan Schmidt
-
Simon Ruderich