It would be better to use "svn cp" to copy the old port. By not doing this, the "svn log" of py25-gnupg gives misleading information: it claims the file just came into existence, created out of thin air, but in fact, it was based on another existing file. It would be better for the Subversion history to reflect that. "svn blame" would also be more useful as a result. On Nov 13, 2007, at 16:28, source_changes@macosforge.org wrote:
Revision: 31016 http://trac.macosforge.org/projects/macports/changeset/31016 Author: ram@macports.org Date: 2007-11-13 14:28:24 -0800 (Tue, 13 Nov 2007)
Log Message: ----------- add py25-gnupg, copied from py-gnupg - closes #13010
Added Paths: ----------- trunk/dports/python/py25-gnupg/ trunk/dports/python/py25-gnupg/Portfile trunk/dports/python/py25-gnupg/files/ trunk/dports/python/py25-gnupg/files/patch-setup.py.diff
Added: trunk/dports/python/py25-gnupg/Portfile =================================================================== --- trunk/dports/python/py25-gnupg/Portfile (rev 0) +++ trunk/dports/python/py25-gnupg/Portfile 2007-11-13 22:28:24 UTC (rev 31016)
We need a Subversion training blog and a quiz for svn users before we give out commit rights. Also, are all committers on the dev mailing list? Are we certain that doing a reply to a commit is seen by the author? Can we have the post-commit mailer use the committer's username as the From field, so that if somebody does a Reply-All, they'll get two emails, assuming they are on the dev mailing list? Blair Ryan Schmidt wrote:
It would be better to use "svn cp" to copy the old port. By not doing this, the "svn log" of py25-gnupg gives misleading information: it claims the file just came into existence, created out of thin air, but in fact, it was based on another existing file. It would be better for the Subversion history to reflect that. "svn blame" would also be more useful as a result.
On Nov 13, 2007, at 16:28, source_changes@macosforge.org wrote:
Revision: 31016 http://trac.macosforge.org/projects/macports/changeset/31016 Author: ram@macports.org Date: 2007-11-13 14:28:24 -0800 (Tue, 13 Nov 2007)
Log Message: ----------- add py25-gnupg, copied from py-gnupg - closes #13010
Added Paths: ----------- trunk/dports/python/py25-gnupg/ trunk/dports/python/py25-gnupg/Portfile trunk/dports/python/py25-gnupg/files/ trunk/dports/python/py25-gnupg/files/patch-setup.py.diff
Added: trunk/dports/python/py25-gnupg/Portfile =================================================================== --- trunk/dports/python/py25-gnupg/Portfile (rev 0) +++ trunk/dports/python/py25-gnupg/Portfile 2007-11-13 22:28:24 UTC (rev 31016)
_______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org http://lists.macosforge.org/mailman/listinfo/macports-dev
On 13/11/2007, Ryan Schmidt <ryandesign@macports.org> wrote:
It would be better to use "svn cp" to copy the old port. By not doing this, the "svn log" of py25-gnupg gives misleading information: it claims the file just came into existence, created out of thin air, but in fact, it was based on another existing file. It would be better for the Subversion history to reflect that. "svn blame" would also be more useful as a result.
I realised I should have done this just after I committed, corrected in r31019 and r31020. Sorry for the noise. Cheers Adam
On Nov 13, 2007, at 7:28 PM, Blair Zajac wrote:
We need a Subversion training blog and a quiz for svn users before we give out commit rights.
An svn tutorial covering things like the issue raised here (which Ryan has been kind enough to remind us of over and over), please! A quiz... eeehhh.... hhhmmm.... I don't think I'm too comfortable with that idea; at this point we're interested in growing our contributor base and potential deterrents like a quiz are not gonna help us achieve that goal. But rest easy, I'm not talking about deliberately lowering the skill level that we require for membership for the sole sake of quantity over quality, but rather advocating that we provide newcomers with the material they need to fill in whatever gaps they might have... like an svn tutorial ;-) (a solid guide with a Portfile writing tutorial and Q&A is another example of what we should provide -- already underway thanks mostly to Mark, Simon and Maun Suang)
Also, are all committers on the dev mailing list? Are we certain that doing a reply to a commit is seen by the author?
We require all our members to subscribe to both the developers and changes list (and users, but that's orthogonal to this point), but unfortunately this thread made me realize I haven't been explicit about that requirement lately when welcoming new members. Thanks for the reminder, I'll re-add it to the list of TODOs I send to approved applicants. In any case, we could easily send out a mail to *all* members asking them to confirm if they're subscribed to these two lists, should we ever need to (http://trac.macports.org/projects/macports/wiki/MacPortsDevelopers -- and I could also get their real addresses, what their macports handles forward to, if really needed).
Can we have the post-commit mailer use the committer's username as the From field, so that if somebody does a Reply-All, they'll get two emails, assuming they are on the dev mailing list?
Having changes posted as $username@macports.org rather than the generic "source_changes@macosforge.org" is a request I already made, but it was dependent on the migration of the svn server to new hardware. That was completed just yesterday, so luckily we'll now be able to move forward with the former and other {pre,post}-commit hooks that I've requested over time (svn props validation, yay!)
Blair
Regards,... -jmpp
participants (4)
-
Adam Mercer
-
Blair Zajac
-
Juan Manuel Palacios
-
Ryan Schmidt